Skip to contentSkip to conversation

drm: dereferencing before checking for null

PATCH New Dan Carpenter 1 participant 1 message May 7, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: dereferencing before checking for null

The original code dereferences "fb_helper_conn" before verifying that it's non-null.

---
It's never null here actually. I could send a patch to remove the check instead if that's prefered.

drivers/gpu/drm/drm_fb_helper.c +2 -1
index b28e563..f5fe3a9 100644
@@ -96,11 +96,12 @@ static bool drm_fb_helper_connector_parse_command_line(struct drm_fb_helper_conn
 	int i;
 	enum drm_connector_force force = DRM_FORCE_UNSPECIFIED;
 	struct drm_fb_helper_cmdline_mode *cmdline_mode;
-	struct drm_connector *connector = fb_helper_conn->connector;
+	struct drm_connector *connector;
 
 	if (!fb_helper_conn)
 		return false;
 
+	connector = fb_helper_conn->connector;
 	cmdline_mode = &fb_helper_conn->cmdline_mode;
 	if (!mode_option)
 		mode_option = fb_mode_option;

------------------------------------------------------------------------------

--