Skip to contentSkip to conversation

x86/mrst: set vRTC's IRQ to level trigger type

PATCH New Alan Cox 1 participant 1 message Nov 11, 2010 x86

lore
Share & tools
lore

Alan Cox

author
#0 lore raw

PATCH 1/1 x86/mrst: set vRTC's IRQ to level trigger type

From: Feng Tang <[email protected]>

When setting up the mpc_intsrc structure for vRTC's IRQ, we need to set its irqflag to level trigger, otherwise it will be taken as edge triggered and the vRTC IRQ will fire only once, as there is never a EOI issued from the IA core for it.

The original code worked in previous kernel. This is because it was configured to level trigger type by luck. It fell into the default PCI trigger category which is level triggered.

---

 arch/x86/platform/mrst/mrst.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/platform/mrst/mrst.c +1 -1
index f2bc945..9ad8f57 100644
@@ -195,7 +195,7 @@ int __init sfi_parse_mrtc(struct sfi_table_header *table)
 			totallen, (u32)pentry->phys_addr, pentry->irq);
 		mp_irq.type = MP_IOAPIC;
 		mp_irq.irqtype = mp_INT;
-		mp_irq.irqflag = 0;
+		mp_irq.irqflag = 0xf;	/* level trigger and active low */
 		mp_irq.srcbus = 0;
 		mp_irq.srcbusirq = pentry->irq;	/* IRQ */
 		mp_irq.dstapic = MP_APIC_ALL;