Skip to contentSkip to conversation

mmc: not clock gate host when host is in runtime suspended state

PATCH In review Chuanxiao Dong 1 participant 1 message Jan 14, 2011 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 mmc: not clock gate host when host is in runtime suspended state

Since mmc clock gating is done in a work queue which is not synchronized with host runtime power management, when driver is doing clock gating, host may has already been power gated.

So before driver clock gate host, check whether host is already suspended.

---
 drivers/mmc/core/core.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)
drivers/mmc/core/core.c +11 -0
index e296c5a..d2121fa 100644
@@ -670,6 +670,17 @@ void mmc_gate_clock(struct mmc_host *host)
 	host->ios.clock = 0;
 	host->clk_gated = true;
 	spin_unlock_irqrestore(&host->clk_lock, flags);
+#ifdef CONFIG_PM_RUNTIME
+	/*
+	 * mmc clock gating is done in a work queue which
+	 * does not synchronized with host controller runtime
+	 * power management. So when mmc gate clock, host may
+	 * have already in runtime suspend state. In that case,
+	 * driver cannot touch host controller registers
+	 */
+	if (host->class_dev.power.runtime_status != RPM_ACTIVE)
+		return;
+#endif
 	mmc_set_ios(host);
 }
 
Signature · 1 line
1.6.6.1