Skip to contentSkip to conversation

Regression: Can't compile x86_64 with 32 Bit userland: arch/x86/purgatory/purgatory.c:1:0: error: code model 'large' not supported in the 32 bit mode

DISCUSSION Thomas Glanzmann 3 participants 8 messages Aug 20, 2014 x86

lore
Share & tools
lore
#0 lore raw

Hello,
I used to compile 64 Bit Kernel on 32 Bit Userland and until v3.16 it worked. But with todays git head from Linus it does not:

(mini) [~/work/linux-2.6] make scripts/kconfig/conf --silentoldconfig Kconfig

  CHK     include/config/kernel.release
  UPD     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
  UPD     include/generated/utsrelease.h
  CC      arch/x86/purgatory/purgatory.o

arch/x86/purgatory/purgatory.c:1:0: error: code model 'large' not supported in the 32 bit mode make[1]: *** [arch/x86/purgatory/purgatory.o] Error 1
make: *** [archprepare] Error 2

I'll do git bisect to identify the offending commit.

I'm using Debian Wheezy 7 32 Bit on x86 with gcc version 4.7.2 (Debian 4.7.2-5).

Cheers,
Thomas

#1 lore raw

REGRESSION: 8fc5b4d: Unable to compile x86_64 kernel with x86_32 userland

Hello Vivek,
commit 8fc5b4d introduces a regression that no longer allows to compile x86_64 kernel under x86_32 userland. TJ on freenode/#kernel did analyze it:

Quoted 11 lines

(mini) [~/work/linux-2.6] make
scripts/kconfig/conf --silentoldconfig Kconfig

  CHK     include/config/kernel.release
  UPD     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
  UPD     include/generated/utsrelease.h
  CC      arch/x86/purgatory/purgatory.o

arch/x86/purgatory/purgatory.c:1:0: error: code model 'large' not supported in the 32 bit mode make[1]: *** [arch/x86/purgatory/purgatory.o] Error 1
make: *** [archprepare] Error 2

08:10 < TJ-> Glanzmann: The purgatory code from kexec is specifying ".code64"
08:11 < TJ-> Glanzmann: so when your local 32-bit linker tries to deal with that ... it errors 08:14 < TJ-> Glanzmann: there's only one introducing the purgatory stuff
08:14 < TJ-> 8fc5b4d Fri Aug 8 15:57:32 2014 -0700 Vivek Goyal purgatory: core purgatory functionality

Cheers,
Thomas

#2 lore raw

Re: REGRESSION: 8fc5b4d: Unable to compile x86_64 kernel with x86_32 userland

Quoted 17 lines · Thomas Glanzmann

Hello Vivek,
commit 8fc5b4d introduces a regression that no longer allows to compile x86_64 kernel under x86_32 userland. TJ on freenode/#kernel did analyze it:

Quoted 11 lines

(mini) [~/work/linux-2.6] make
scripts/kconfig/conf --silentoldconfig Kconfig

  CHK     include/config/kernel.release
  UPD     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
  UPD     include/generated/utsrelease.h
  CC      arch/x86/purgatory/purgatory.o

arch/x86/purgatory/purgatory.c:1:0: error: code model 'large' not supported in the 32 bit mode make[1]: *** [arch/x86/purgatory/purgatory.o] Error 1
make: *** [archprepare] Error 2

Quoted 4 lines

08:10 < TJ-> Glanzmann: The purgatory code from kexec is specifying ".code64"
08:11 < TJ-> Glanzmann: so when your local 32-bit linker tries to deal with that ... it errors 08:14 < TJ-> Glanzmann: there's only one introducing the purgatory stuff
08:14 < TJ-> 8fc5b4d Fri Aug 8 15:57:32 2014 -0700 Vivek Goyal purgatory: core purgatory functionality

Hi Thomas,

Thanks for the report. I think this is also happening because purgatory is right now being compiled with compiler option -mcmodel=large. There was another report where older version of gcc did not support -mcmodel=large.

A patch is sitting in akpm's tree. That patch puts the new code under a new config option CONFIG_KEXEC_FILE. So as long as you don't enable CONFIG_KEXEC_FILE=y, you should be fine. This should not impact any of the existing functionality. Just that you will not get the benefit of new system call.

http://ozlabs.org/~akpm/mmotm/broken-out/kexec-create-a-new-config-option-config_kexec_file-for-new-syscall.patch

I hope this patch gets merged soon.

In the mean time I am trying to figure out how can I move away from using -mcmodel=large for purgatory.

Thanks
Vivek

#3 lore raw

Re: REGRESSION: 8fc5b4d: Unable to compile x86_64 kernel with x86_32 userland

It says "32-bit mode" which means it is another issue: we are dropping -m64 at some point.

Quoted 53 lines · Vivek Goyal
Quoted 2 lines · Thomas Glanzmann

Hello Vivek,
commit 8fc5b4d introduces a regression that no longer allows to

compile

Quoted 1 line

x86_64 kernel under x86_32 userland. TJ on freenode/#kernel did

analyze

Quoted 11 lines

it:

Quoted 9 lines

(mini) [~/work/linux-2.6] make
scripts/kconfig/conf --silentoldconfig Kconfig

  CHK     include/config/kernel.release
  UPD     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
  UPD     include/generated/utsrelease.h
  CC      arch/x86/purgatory/purgatory.o

arch/x86/purgatory/purgatory.c:1:0: error: code model 'large' not

supported in the 32 bit mode

Quoted 4 lines
Quoted 2 lines

make[1]: *** [arch/x86/purgatory/purgatory.o] Error 1
make: *** [archprepare] Error 2

08:10 < TJ-> Glanzmann: The purgatory code from kexec is specifying

".code64"

Quoted 1 line

08:11 < TJ-> Glanzmann: so when your local 32-bit linker tries to

deal with that ... it errors

Quoted 1 line

08:14 < TJ-> Glanzmann: there's only one introducing the purgatory

stuff

Quoted 1 line

08:14 < TJ-> 8fc5b4d Fri Aug 8 15:57:32 2014 -0700 Vivek Goyal

purgatory: core purgatory functionality

Hi Thomas,

Thanks for the report. I think this is also happening because purgatory is
right now being compiled with compiler option -mcmodel=large. There was another report where older version of gcc did not support -mcmodel=large.

A patch is sitting in akpm's tree. That patch puts the new code under a new config option CONFIG_KEXEC_FILE. So as long as you don't enable CONFIG_KEXEC_FILE=y, you should be fine. This should not impact any of the existing functionality. Just that you will not get the benefit of new system call.

http://ozlabs.org/~akpm/mmotm/broken-out/kexec-create-a-new-config-option-config_kexec_file-for-new-syscall.patch

I hope this patch gets merged soon.

In the mean time I am trying to figure out how can I move away from using -mcmodel=large for purgatory.

Thanks
Vivek

Signature · 1 line
Sent from my mobile phone.  Please pardon brevity and lack of formatting.
#4 lore raw

Re: REGRESSION: 8fc5b4d: Unable to compile x86_64 kernel with x86_32 userland

Quoted 1 line · H. Peter Anvin

It says "32-bit mode" which means it is another issue: we are dropping -m64 at some point.

Thanks hpa. I am not adding -m64 to kbuild flags at all. So 32bit tool chain must be assuming -m32 by default, and probably that's the issue.

Thomas,

Can you please try attached single line patch and see if it fixes the issue for you.

Thanks
Vivek

---
 arch/x86/purgatory/Makefile |    1 +
 1 file changed, 1 insertion(+)
arch/x86/purgatory/Makefile +1 -0
Index: linux-2.6/arch/x86/purgatory/Makefile
===================================================================
@@ -11,6 +11,7 @@ targets += purgatory.ro
 # sure how to relocate those. Like kexec-tools, use custom flags.
 
 KBUILD_CFLAGS := -fno-strict-aliasing -Wall -Wstrict-prototypes -fno-zero-initialized-in-bss -fno-builtin -ffreestanding -c -MD -Os -mcmodel=large
+KBUILD_CFLAGS += -m$(BITS)
 
 $(obj)/purgatory.ro: $(PURGATORY_OBJS) FORCE
 		$(call if_changed,ld)
author Tested-by
#5 lore raw

Re: REGRESSION: 8fc5b4d: Unable to compile x86_64 kernel with x86_32 userland

Hello Vivek,

Quoted 11 lines · Vivek Goyal
arch/x86/purgatory/Makefile +1 -0
@@ -11,6 +11,7 @@ targets += purgatory.ro
 # sure how to relocate those. Like kexec-tools, use custom flags.
 
 KBUILD_CFLAGS := -fno-strict-aliasing -Wall -Wstrict-prototypes -fno-zero-initialized-in-bss -fno-builtin -ffreestanding -c -MD -Os -mcmodel=large
+KBUILD_CFLAGS += -m$(BITS)
 
 $(obj)/purgatory.ro: $(PURGATORY_OBJS) FORCE
 		$(call if_changed,ld)
Quoted 2 lines

Can you please try attached single line patch and see if it fixes the issue for you.

I tested the same and it works.

...

  CC      arch/x86/purgatory/purgatory.o
  AS      arch/x86/purgatory/stack.o
  AS      arch/x86/purgatory/setup-x86_64.o
  CC      arch/x86/purgatory/sha256.o
  AS      arch/x86/purgatory/entry64.o
  CC      arch/x86/purgatory/string.o
  LD      arch/x86/purgatory/purgatory.ro
  BIN2C   arch/x86/purgatory/kexec-purgatory.c

...

I also made sure that I backed out the other patch _before_ I tried this one.

Cheers,
Thomas

#6 lore raw

Re: REGRESSION: 8fc5b4d: Unable to compile x86_64 kernel with x86_32 userland

In reply to Vivek Goyal

Yes, that is exactly right. The lack of -m64 is a bug.

Quoted 36 lines · Vivek Goyal
Quoted 1 line · H. Peter Anvin

It says "32-bit mode" which means it is another issue: we are

dropping -m64 at some point.

Thanks hpa. I am not adding -m64 to kbuild flags at all. So 32bit tool chain must be assuming -m32 by default, and probably that's the issue.

Thomas,

Can you please try attached single line patch and see if it fixes the issue for you.

Thanks
Vivek

---
arch/x86/purgatory/Makefile | 1 +

1 file changed, 1 insertion(+)

Index: linux-2.6/arch/x86/purgatory/Makefile
===================================================================
--- linux-2.6.orig/arch/x86/purgatory/Makefile 2014-08-20
11:32:21.723559119 -0400
+++ linux-2.6/arch/x86/purgatory/Makefile 2014-08-20 11:32:23.654570231
-0400

arch/x86/purgatory/Makefile +0 -0
@@ -11,6 +11,7 @@ targets += purgatory.ro
 # sure how to relocate those. Like kexec-tools, use custom flags.
 

KBUILD_CFLAGS := -fno-strict-aliasing -Wall -Wstrict-prototypes

(quoted diff) +1 -2
-fno-zero-initialized-in-bss -fno-builtin -ffreestanding -c -MD -Os
-mcmodel=large
+KBUILD_CFLAGS += -m$(BITS)

$(obj)/purgatory.ro: $(PURGATORY_OBJS) FORCE

		$(call if_changed,ld)
Signature · 1 line
Sent from my mobile phone.  Please pardon brevity and lack of formatting.
#7 lore raw

Re: REGRESSION: 8fc5b4d: Unable to compile x86_64 kernel with x86_32 userland

In reply to Vivek Goyal

Hello Vivek,

Quoted 6 lines · Vivek Goyal

A patch is sitting in akpm's tree. That patch puts the new code under a new config option CONFIG_KEXEC_FILE. So as long as you don't enable CONFIG_KEXEC_FILE=y, you should be fine. This should not impact any of the existing functionality. Just that you will not get the benefit of new system call.

Quoted 6 lines

http://ozlabs.org/~akpm/mmotm/broken-out/kexec-create-a-new-config-option-config_kexec_file-for-new-syscall.patch

I hope this patch gets merged soon.

In the mean time I am trying to figure out how can I move away from using -mcmodel=large for purgatory.

perfect. I tried the patch and with the patch the kernel compiles again.

Cheers,
Thomas