exec: file_ram_alloc(): print error when prealloc fails
PATCH 1/1 exec: file_ram_alloc(): print error when prealloc fails
If memory allocation fails when using the -mem-prealloc command-line option, QEMU exits without printing any error information to the user:
# qemu [...] -m 1G -mem-prealloc -mem-path /dev/hugepages # echo $? 1
This commit adds an error message, so that we print instead:
# qemu [...] -m 1G -mem-prealloc -mem-path /dev/hugepages qemu: unable to map backing store for hugepages: Cannot allocate memory
Signed-off-by Luiz Capitulino <[email protected]>
--- exec.c | 1 + 1 file changed, 1 insertion(+)
exec.c +1 -0
@@ -1130,6 +1130,7 @@ static void *file_ram_alloc(RAMBlock *block, error:if (mem_prealloc) { +error_report ("%s\n" ,error_get_pretty (*errp));exit (1 ); }return NULL ;
Signature · 1 line
1.9.3
Quoted 10 lines · Luiz Capitulino
If memory allocation fails when using the -mem-prealloc command-line option, QEMU exits without printing any error information to the user:
# qemu [...] -m 1G -mem-prealloc -mem-path /dev/hugepages # echo $? 1This commit adds an error message, so that we print instead:
Quoted 8 lines
# qemu [...] -m 1G -mem-prealloc -mem-path /dev/hugepages qemu: unable to map backing store for hugepages: Cannot allocate memorySigned-off-by Luiz Capitulino <[email protected]>--- exec.c | 1 + 1 file changed, 1 insertion(+)
Reviewed-by Eric Blake <[email protected]>
Signature · 2 lines
Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org