usb: gadget: udc: remove bogus NULL check

PATCH New Dan Carpenter 1 participant 1 message Nov 25, 2014

Subsystems (3)

USB Kernel janitors Broadcom bdc driver

lore

Share & tools

lore

Dan Carpenter

author

2014-11-25 15:56 UTC #0 lore raw

PATCH 2/2 usb: gadget: udc: remove bogus NULL check

"ep" isn't NULL here, and static checkers complain because we dereferenced it on the previous line.

Signed-off-by Dan Carpenter <[email protected]>

drivers/usb/gadget/udc/bdc/bdc_ep.c +1 -1

index 2f4ac6e..7e502ef 100644
@@ -718,7 +718,7 @@ static int ep_queue(struct bdc_ep *ep, struct bdc_req *req)
 	int ret = 0;
 
 	bdc = ep->bdc;
-	if (!req || !ep || !ep->usb_ep.desc)
+	if (!req || !ep->usb_ep.desc)
 		return -EINVAL;
 
 	req->usb_req.actual = 0;