staging: fbtft: removed space before ')' and after '(' parenthesis.
Subsystems (2)
PATCH 1/1 staging: fbtft: removed space before ')' and after '(' parenthesis.
This fixes the following checkpatch.pl errors:
ERROR: space prohibited after that open parenthesis '('
ERROR: space prohibited before that close parenthesis ')'
--- drivers/staging/fbtft/fb_bd663474.c | 76 ++++++++++++++++++------------------- 1 file changed, 38 insertions(+), 38 deletions(-)
drivers/staging/fbtft/fb_bd663474.c +38 -38
@@ -47,49 +47,49 @@ static int init_display(struct fbtft_par *par)/* Initialization sequence from Lib_UTFT */ /* oscillator start */ -write_reg (par,0x000 ,0x0001 );/*oscillator 0: stop, 1: operation */ +write_reg (par,0x000 ,0x0001 );/*oscillator 0: stop, 1: operation */ mdelay (10 );/* Power settings */ -write_reg (par,0x100 ,0x0000 );/* power supply setup */ -write_reg (par,0x101 ,0x0000 ); -write_reg (par,0x102 ,0x3110 ); -write_reg (par,0x103 ,0xe200 ); -write_reg (par,0x110 ,0x009d ); -write_reg (par,0x111 ,0x0022 ); -write_reg (par,0x100 ,0x0120 ); -mdelay (20 ); - -write_reg (par,0x100 ,0x3120 ); -mdelay (80 ); +write_reg (par,0x100 ,0x0000 );/* power supply setup */ +write_reg (par,0x101 ,0x0000 ); +write_reg (par,0x102 ,0x3110 ); +write_reg (par,0x103 ,0xe200 ); +write_reg (par,0x110 ,0x009d ); +write_reg (par,0x111 ,0x0022 ); +write_reg (par,0x100 ,0x0120 ); +mdelay (20 ); + +write_reg (par,0x100 ,0x3120 ); +mdelay (80 );/* Display control */ -write_reg (par,0x001 ,0x0100 ); -write_reg (par,0x002 ,0x0000 ); -write_reg (par,0x003 ,0x1230 ); -write_reg (par,0x006 ,0x0000 ); -write_reg (par,0x007 ,0x0101 ); -write_reg (par,0x008 ,0x0808 ); -write_reg (par,0x009 ,0x0000 ); -write_reg (par,0x00b ,0x0000 ); -write_reg (par,0x00c ,0x0000 ); -write_reg (par,0x00d ,0x0018 ); +write_reg (par,0x001 ,0x0100 ); +write_reg (par,0x002 ,0x0000 ); +write_reg (par,0x003 ,0x1230 ); +write_reg (par,0x006 ,0x0000 ); +write_reg (par,0x007 ,0x0101 ); +write_reg (par,0x008 ,0x0808 ); +write_reg (par,0x009 ,0x0000 ); +write_reg (par,0x00b ,0x0000 ); +write_reg (par,0x00c ,0x0000 ); +write_reg (par,0x00d ,0x0018 );/* LTPS control settings */ -write_reg (par,0x012 ,0x0000 ); -write_reg (par,0x013 ,0x0000 ); -write_reg (par,0x018 ,0x0000 ); -write_reg (par,0x019 ,0x0000 ); - -write_reg (par,0x203 ,0x0000 ); -write_reg (par,0x204 ,0x0000 ); - -write_reg (par,0x210 ,0x0000 ); -write_reg (par,0x211 ,0x00ef ); -write_reg (par,0x212 ,0x0000 ); -write_reg (par,0x213 ,0x013f ); -write_reg (par,0x214 ,0x0000 ); -write_reg (par,0x215 ,0x0000 ); -write_reg (par,0x216 ,0x0000 ); -write_reg (par,0x217 ,0x0000 ); +write_reg (par,0x012 ,0x0000 ); +write_reg (par,0x013 ,0x0000 ); +write_reg (par,0x018 ,0x0000 ); +write_reg (par,0x019 ,0x0000 ); + +write_reg (par,0x203 ,0x0000 ); +write_reg (par,0x204 ,0x0000 ); + +write_reg (par,0x210 ,0x0000 ); +write_reg (par,0x211 ,0x00ef ); +write_reg (par,0x212 ,0x0000 ); +write_reg (par,0x213 ,0x013f ); +write_reg (par,0x214 ,0x0000 ); +write_reg (par,0x215 ,0x0000 ); +write_reg (par,0x216 ,0x0000 ); +write_reg (par,0x217 ,0x0000 );/* Gray scale settings */ write_reg (par,0x300 ,0x5343 );
Signature · 1 line
1.9.1
Quoted 15 lines · Navya Sri Nizamkari
This fixes the following checkpatch.pl errors:
ERROR: space prohibited after that open parenthesis '('
ERROR: space prohibited before that close parenthesis ')'Signed-off-by Navya Sri Nizamkari <[email protected]>--- drivers/staging/fbtft/fb_bd663474.c | 76 ++++++++++++++++++------------------- 1 file changed, 38 insertions(+), 38 deletions(-)drivers/staging/fbtft/fb_bd663474.c +0
-0
drivers/staging/fbtft/fb_bd663474.c static int init_display(struct fbtft_par *par) · line 50
Quoted 5 lines
drivers/staging/fbtft/fb_bd663474.c +1
-1@@ -47,49 +47,49 @@ static int init_display(struct fbtft_par *par)/* Initialization sequence from Lib_UTFT */ /* oscillator start */ -write_reg (par,0x000 ,0x0001 );/*oscillator 0: stop, 1: operation */ +write_reg (par,0x000 ,0x0001 );/*oscillator 0: stop, 1: operation */
This change doesn't match your commit message. Is it left over from a previous patch?
julia
Quoted 92 lines
drivers/staging/fbtft/fb_bd663474.c +37
-37mdelay (10 );/* Power settings */ -write_reg (par,0x100 ,0x0000 );/* power supply setup */ -write_reg (par,0x101 ,0x0000 ); -write_reg (par,0x102 ,0x3110 ); -write_reg (par,0x103 ,0xe200 ); -write_reg (par,0x110 ,0x009d ); -write_reg (par,0x111 ,0x0022 ); -write_reg (par,0x100 ,0x0120 ); -mdelay (20 ); - -write_reg (par,0x100 ,0x3120 ); -mdelay (80 ); +write_reg (par,0x100 ,0x0000 );/* power supply setup */ +write_reg (par,0x101 ,0x0000 ); +write_reg (par,0x102 ,0x3110 ); +write_reg (par,0x103 ,0xe200 ); +write_reg (par,0x110 ,0x009d ); +write_reg (par,0x111 ,0x0022 ); +write_reg (par,0x100 ,0x0120 ); +mdelay (20 ); + +write_reg (par,0x100 ,0x3120 ); +mdelay (80 );/* Display control */ -write_reg (par,0x001 ,0x0100 ); -write_reg (par,0x002 ,0x0000 ); -write_reg (par,0x003 ,0x1230 ); -write_reg (par,0x006 ,0x0000 ); -write_reg (par,0x007 ,0x0101 ); -write_reg (par,0x008 ,0x0808 ); -write_reg (par,0x009 ,0x0000 ); -write_reg (par,0x00b ,0x0000 ); -write_reg (par,0x00c ,0x0000 ); -write_reg (par,0x00d ,0x0018 ); +write_reg (par,0x001 ,0x0100 ); +write_reg (par,0x002 ,0x0000 ); +write_reg (par,0x003 ,0x1230 ); +write_reg (par,0x006 ,0x0000 ); +write_reg (par,0x007 ,0x0101 ); +write_reg (par,0x008 ,0x0808 ); +write_reg (par,0x009 ,0x0000 ); +write_reg (par,0x00b ,0x0000 ); +write_reg (par,0x00c ,0x0000 ); +write_reg (par,0x00d ,0x0018 );/* LTPS control settings */ -write_reg (par,0x012 ,0x0000 ); -write_reg (par,0x013 ,0x0000 ); -write_reg (par,0x018 ,0x0000 ); -write_reg (par,0x019 ,0x0000 ); - -write_reg (par,0x203 ,0x0000 ); -write_reg (par,0x204 ,0x0000 ); - -write_reg (par,0x210 ,0x0000 ); -write_reg (par,0x211 ,0x00ef ); -write_reg (par,0x212 ,0x0000 ); -write_reg (par,0x213 ,0x013f ); -write_reg (par,0x214 ,0x0000 ); -write_reg (par,0x215 ,0x0000 ); -write_reg (par,0x216 ,0x0000 ); -write_reg (par,0x217 ,0x0000 ); +write_reg (par,0x012 ,0x0000 ); +write_reg (par,0x013 ,0x0000 ); +write_reg (par,0x018 ,0x0000 ); +write_reg (par,0x019 ,0x0000 ); + +write_reg (par,0x203 ,0x0000 ); +write_reg (par,0x204 ,0x0000 ); + +write_reg (par,0x210 ,0x0000 ); +write_reg (par,0x211 ,0x00ef ); +write_reg (par,0x212 ,0x0000 ); +write_reg (par,0x213 ,0x013f ); +write_reg (par,0x214 ,0x0000 ); +write_reg (par,0x215 ,0x0000 ); +write_reg (par,0x216 ,0x0000 ); +write_reg (par,0x217 ,0x0000 );/* Gray scale settings */ write_reg (par,0x300 ,0x5343 );Signature · 8 lines
1.9.1 -- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150218221315.GA14737%40localhost. For more options, visit https://groups.google.com/d/optout.
The open parenthesis error is with respect to the mdelay() function.
Quoted 1 line · navya sri nizamkari
The open parenthesis error is with respect to the
mdelay()function.ᅵ
Hi,
I think this is in response to my mail. When you respond, you should keep a bit of text from the other person, and your patch if it is appropriate, so that one can get the context.
I think that you need to redo your patch (send a v2) so that it only includes the space and parenthesis change, and not the space and comma change that you submitted previously. Probably you did not commit your file after the first change? You can use git add -p to add just part of a change, and then commit that. More information is available here, at the bottom of the page:
http://git-scm.com/book/en/v2/Git-Tools-Interactive-Staging
julia
Quoted 12 lines
--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/6ffbe89f-e71b-4eec-93b4- b881d5aab211%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Hi,
I'll make sure to reply inline from now.I'll send a new version of the patch for the ')' and space patch and an other patch for the ',' and space one.
Navya
Quoted 39 lines · Julia Lawall
Quoted 1 line · navya sri nizamkari
The open parenthesis error is with respect to the
mdelay()function.Hi,
I think this is in response to my mail. When you respond, you should keep a bit of text from the other person, and your patch if it is appropriate, so that one can get the context.
I think that you need to redo your patch (send a v2) so that it only includes the space and parenthesis change, and not the space and comma change that you submitted previously. Probably you did not commit your file after the first change? You can use git add -p to add just part of a change, and then commit that. More information is available here, at the bottom of the page:
http://git-scm.com/book/en/v2/Git-Tools-Interactive-Staging
julia
Quoted 3 lines
Signature · 2 lines
-- You received this message because you are subscribed to the GoogleGroups
Quoted 2 lines
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, sendan
Quoted 2 lines
email to [email protected] <javascript:>. To post to this group, send email to [email protected]
<javascript:>.
Quoted 1 line
To view this discussion on the web visithttps://
groups.google.com/d/msgid/outreachy-kernel/6ffbe89f-e71b-4eec-93b4-
Quoted 4 lines
b881d5aab211%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.