Remove braces from single statement block
PATCH 1/1 Remove braces from single statement block
This patch is to remove braces from single statement if condition to follow kernel coding convention.
--- drivers/staging/rtl8188eu/hal/fw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8188eu/hal/fw.c +1 -2
@@ -154,9 +154,8 @@ static int _rtl88e_fw_free_to_go(struct adapter *adapt)break ; }while (counter++ <POLLING_READY_TIMEOUT_COUNT ); -if (counter >=POLLING_READY_TIMEOUT_COUNT ) { +if (counter >=POLLING_READY_TIMEOUT_COUNT ) goto exit; - } value32 =usb_read32 (adapt,REG_MCUFWDL ); value32 |=MCUFWDL_RDY ;
Signature · 1 line
1.9.1
Quoted 2 lines · Vatika Harlalka
This patch is to remove braces from single statement if condition to follow kernel coding convention.
OK toleave this one as is, but you don't need the "This patch is to" part. It is a little bit obvious from the context.
julia
Quoted 30 lines
Signed-off-by Vatika Harlalka <[email protected]>--- drivers/staging/rtl8188eu/hal/fw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/staging/rtl8188eu/hal/fw.c +1
-3@@ -154,9 +154,8 @@ static int _rtl88e_fw_free_to_go(struct adapter *adapt)break ; }while (counter++ <POLLING_READY_TIMEOUT_COUNT ); -if (counter >=POLLING_READY_TIMEOUT_COUNT ) { +if (counter >=POLLING_READY_TIMEOUT_COUNT ) goto exit; - } value32 =usb_read32 (adapt,REG_MCUFWDL ); value32 |=MCUFWDL_RDY ; --1.9.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150222104213.GA1215%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
Greg KH
maintainerQuoted 7 lines · Vatika Harlalka
This patch is to remove braces from single statement if condition to follow kernel coding convention.
Signed-off-by Vatika Harlalka <[email protected]>--- drivers/staging/rtl8188eu/hal/fw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Please resend and change the Subject: to show that you are working in the staging directory on the rtl8188eu driver.
thanks,
greg k-h