Skip to contentSkip to conversation

Remove braces from single statement block

PATCH Superseded Vatika Harlalka 3 participants 3 messages Feb 22, 2015 – Feb 26, 2015 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove braces from single statement block

This patch is to remove braces from single statement if condition to follow kernel coding convention.

---
 drivers/staging/rtl8188eu/hal/fw.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8188eu/hal/fw.c +1 -2
index 3b28754..a71c542 100644
@@ -154,9 +154,8 @@ static int _rtl88e_fw_free_to_go(struct adapter *adapt)
 			break;
 	} while (counter++ < POLLING_READY_TIMEOUT_COUNT);
 
-	if (counter >= POLLING_READY_TIMEOUT_COUNT) {
+	if (counter >= POLLING_READY_TIMEOUT_COUNT)
 		goto exit;
-	}
 
 	value32 = usb_read32(adapt, REG_MCUFWDL);
 	value32 |= MCUFWDL_RDY;
Signature · 1 line
1.9.1
#1 lore raw
Quoted 2 lines · Vatika Harlalka

This patch is to remove braces from single statement if condition to follow kernel coding convention.

OK toleave this one as is, but you don't need the "This patch is to" part. It is a little bit obvious from the context.

julia

Quoted 30 lines
---
 drivers/staging/rtl8188eu/hal/fw.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8188eu/hal/fw.c +1 -3
index 3b28754..a71c542 100644
@@ -154,9 +154,8 @@ static int _rtl88e_fw_free_to_go(struct adapter *adapt)
 			break;
 	} while (counter++ < POLLING_READY_TIMEOUT_COUNT);
 
-	if (counter >= POLLING_READY_TIMEOUT_COUNT) {
+	if (counter >= POLLING_READY_TIMEOUT_COUNT)
 		goto exit;
-	}
 
 	value32 = usb_read32(adapt, REG_MCUFWDL);
 	value32 |= MCUFWDL_RDY;
--

1.9.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150222104213.GA1215%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

maintainer
#2 lore raw
In reply to Vatika Harlalka
Quoted 7 lines · Vatika Harlalka

This patch is to remove braces from single statement if condition to follow kernel coding convention.

---
 drivers/staging/rtl8188eu/hal/fw.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Please resend and change the Subject: to show that you are working in the staging directory on the rtl8188eu driver.

thanks,

greg k-h