Skip to contentSkip to conversation

Staging: fbtbt: Move variable declarations

PATCH In review Vatika Harlalka 2 participants 2 messages Mar 12, 2015 – Mar 15, 2015

Subsystems (2)
Staging Fbtft Framebuffer drivers
lore
Share & tools
lore

Vatika Harlalka

author
#0 lore raw

PATCH 1/1 Staging: fbtbt: Move variable declarations

Move variable declarations so as to follow kernel coding conventions.

Signed-off-by Vatika Harlalka <[email protected]>
---
 drivers/staging/fbtft/fb_agm1264k-fl.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/fbtft/fb_agm1264k-fl.c +2 -3
index 2ec607d..acf5acb 100644
@@ -410,15 +410,14 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
 
 static int write(struct fbtft_par *par, void *buf, size_t len)
 {
+	u8 i, data;
+
 	fbtft_par_dbg_hex(DEBUG_WRITE, par, par->info->device, u8, buf, len,
 		"%s(len=%d): ", __func__, len);
 
 	gpio_set_value(par->RW, 0); /* set write mode */
 
-
 	while (len--) {
-		u8 i, data;
-
 		data = *(u8 *) buf++;
 
 		/* set data bus */
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 17 lines · Vatika Harlalka

Move variable declarations so as to follow kernel coding conventions.

Signed-off-by Vatika Harlalka <[email protected]>
---
 drivers/staging/fbtft/fb_agm1264k-fl.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/fbtft/fb_agm1264k-fl.c +1 -0
index 2ec607d..acf5acb 100644
@@ -410,15 +410,14 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
 
 static int write(struct fbtft_par *par, void *buf, size_t len)
 {
+	u8 i, data;

drivers/staging/fbtft/fb_agm1264k-fl.c static int write_vmem(struct fbtft_par *par, size_t offset, size_t len) · line 421

Quoted 10 lines
drivers/staging/fbtft/fb_agm1264k-fl.c +1 -3
+
 	fbtft_par_dbg_hex(DEBUG_WRITE, par, par->info->device, u8, buf, len,
 		"%s(len=%d): ", __func__, len);
 
 	gpio_set_value(par->RW, 0); /* set write mode */
 
-
 	while (len--) {
-		u8 i, data;
-

Why? There is nothing wrong with this code at all, please leave it as-is, unless there is a good reason to move it.

thanks,

greg k-h