PROBLEM: Intel HDMI output busticated on 4.4 (regression)
Subsystems (2)
Hi,
Upgrading from 4.3 to 4.4 breaks my HDMI output on my G45 machine.
As soon as the intel driver is loaded, the monitor shuts off (standby mode). Inspecting /sys/class/drm/card0-HDMI-A-1/status reports "disconnected". When it is working, this attribute says "connected".
There is nothing unusual printed to dmesg.
Bisection pinpoints the following:
237ed86c693d8a8e4db476976aeb30df4deac74b is the first bad commit commit 237ed86c693d8a8e4db476976aeb30df4deac74b
Author: Sonika Jindal <[email protected]>
Date: Tue Sep 15 09:44:20 2015 +0530
drm/i915: Check live status before reading edid
The commit does not revert cleanly, but this patch resolves the issue:
drivers/gpu/drm/i915/intel_hdmi.c +1 -1
@@ -1393,7 +1393,7 @@ intel_hdmi_detect(struct drm_connector *connector, bool force)intel_hdmi_unset_edid (connector); -if (intel_hdmi_set_edid (connector, live_status)) { +if (intel_hdmi_set_edid (connector, true)) {struct intel_hdmi *intel_hdmi =intel_attached_hdmi (connector);hdmi_to_dig_port (intel_hdmi)->base.type =INTEL_OUTPUT_HDMI ;
Let me know if you need any more info.
Thanks,
Nick
Can you please check if you have following patch:
"commit 3d8acd1f667b45c531401c8f0c2033072e32a05d
Author: Gary Wang <[email protected]> Date: Wed Dec 23 16:11:35 2015 +0800
drm/i915: increase the tries for HDMI hotplug live status checking"
For some monitors, 30ms delay is not good enough to report the live status correctly.
Does the same system works with any other monitor?
Daniel,
Can this be related to the live status bits on g45? "commit 0ce99f749b3834edeb500e17d6ad17e86b60ff83
Author: Daniel Vetter <[email protected]> Date: Fri Jul 26 11:27:49 2013 +0200
drm/i915: fix gen4 digital port hotplug definitions"
Regards,
Sonika
Quoted 41 lines · Nick Bowler
Hi,
Upgrading from 4.3 to 4.4 breaks my HDMI output on my G45 machine.
As soon as the intel driver is loaded, the monitor shuts off (standby mode). Inspecting
/sys/class/drm/card0-HDMI-A-1/statusreports "disconnected". When it is working, this attribute says "connected".There is nothing unusual printed to dmesg.
Bisection pinpoints the following:
237ed86c693d8a8e4db476976aeb30df4deac74bis the first bad commit commit237ed86c693d8a8e4db476976aeb30df4deac74b
Author: Sonika Jindal <[email protected]>
Date: Tue Sep 15 09:44:20 2015 +0530drm/i915: Check live status before reading edid
[...]Signed-off-by Shashank Sharma <[email protected]>Signed-off-by Sonika Jindal <[email protected]>Reviewed-by Rodrigo Vivi <[email protected]>Signed-off-by Daniel Vetter <[email protected]>The commit does not revert cleanly, but this patch resolves the issue:
drivers/gpu/drm/i915/intel_hdmi.c +1
-1@@ -1393,7 +1393,7 @@ intel_hdmi_detect(struct drm_connector *connector, bool force)intel_hdmi_unset_edid (connector); -if (intel_hdmi_set_edid (connector, live_status)) { +if (intel_hdmi_set_edid (connector, true)) {struct intel_hdmi *intel_hdmi =intel_attached_hdmi (connector);hdmi_to_dig_port (intel_hdmi)->base.type =INTEL_OUTPUT_HDMI ;
Quoted 4 lines
Let me know if you need any more info.
Thanks,
Nick
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi,
Quoted 6 lines · Sonika
Can you please check if you have following patch:
"commit3d8acd1f667b45c531401c8f0c2033072e32a05dAuthor: Gary Wang <[email protected]> Date: Wed Dec 23 16:11:35 2015 +0800drm/i915: increase the tries for HDMI hotplug live status checking"
Yes, that patch seems to be present in 4.4.
Quoted 1 line
Does the same system works with any other monitor?
I'll see if I can find another to try.
Thanks,
Nick
Quoted 8 lines · Nick Bowler
Hi,
Quoted 5 lines · Sonika
Can you please check if you have following patch:
"commit3d8acd1f667b45c531401c8f0c2033072e32a05dAuthor: Gary Wang <[email protected]> Date: Wed Dec 23 16:11:35 2015 +0800
Quoted 7 lines
Quoted 1 line
drm/i915: increase the tries for HDMI hotplug live status checking"
Yes, that patch seems to be present in 4.4.
Quoted 1 line
Does the same system works with any other monitor?
I'll see if I can find another to try.
I tried another monitor, and the same problem occurs.
Quoted 9 lines · Nick Bowler
Quoted 8 lines · Nick Bowler
Hi,
Quoted 5 lines · Sonika
Can you please check if you have following patch:
"commit3d8acd1f667b45c531401c8f0c2033072e32a05dAuthor: Gary Wang <[email protected]> Date: Wed Dec 23 16:11:35 2015 +0800
Quoted 6 lines
Quoted 5 lines
Quoted 1 line
drm/i915: increase the tries for HDMI hotplug live status checking"
Yes, that patch seems to be present in 4.4.
Quoted 1 line
Does the same system works with any other monitor?
I'll see if I can find another to try.
I tried another monitor, and the same problem occurs.
Which make are these monitors?
Do you have any other system other than G45?
Shashank,
Do you suggest anything else which Nick can try?
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 3 lines · Sonika
Quoted 2 lines · Nick Bowler
Quoted 1 line · Nick Bowler
On 2016-01-20, Jindal, Sonika <[email protected]> wrote:
[...]
Quoted 4 lines
Quoted 3 lines
Quoted 2 lines
Quoted 1 line
Does the same system works with any other monitor?
I'll see if I can find another to try.
I tried another monitor, and the same problem occurs.
Which make are these monitors?
- LG Flatron W2253V
- Dell E228WFPc
Quoted 1 line
Do you have any other system other than G45?
Nothing else with Linux 4.4, unfortunately.
Thanks,
Nick
Quoted 8 lines · Nick Bowler
Quoted 3 lines · Sonika
Quoted 2 lines · Nick Bowler
Quoted 1 line · Nick Bowler
On 2016-01-20, Jindal, Sonika <[email protected]> wrote:
[...]
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines
Quoted 1 line
Does the same system works with any other monitor?
I'll see if I can find another to try.
I tried another monitor, and the same problem occurs.
Quoted 8 lines
Quoted 1 line
Which make are these monitors?
- LG Flatron W2253V
- Dell E228WFPcQuoted 1 line
Do you have any other system other than G45?
Nothing else with Linux 4.4, unfortunately.
Anything else you want me to try?
This issue is still present in 4.5-rc1.
Cheers,
Nick
Quoted 14 lines · Nick Bowler
Quoted 13 lines · Nick Bowler
Quoted 3 lines · Sonika
Quoted 2 lines · Nick Bowler
Quoted 1 line · Nick Bowler
On 2016-01-20, Jindal, Sonika <[email protected]> wrote:
[...]
Quoted 4 lines
Quoted 3 lines
Quoted 2 lines
Quoted 1 line
Does the same system works with any other monitor?
I'll see if I can find another to try.
I tried another monitor, and the same problem occurs.
Which make are these monitors?
- LG Flatron W2253V
- Dell E228WFPc
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Do you have any other system other than G45?
Nothing else with Linux 4.4, unfortunately.
Anything else you want me to try?
This issue is still present in 4.5-rc1.
Ping?
HDMI is still broken on my system in 4.5-rc3.
Cheers,
Nick
Hi Nick,
Sonika is OOO for this week.
AFAIK about this issue, looks like the live status is not getting set for your system, on HPD.
As per the Bspec, we must check live status before trying to read EDID. Is it possible for you to check with an HDMI analyzer and probe live status register ?
Regards
Shashank
-----Original Message-----
From: Nick Bowler [mailto:[email protected]]
Sent: Tuesday, February 09, 2016 10:03 PM
To: Jindal, Sonika
Cc: [email protected]; [email protected]; Daniel Vetter; Sharma, Shashank
Subject: Re: PROBLEM: Intel HDMI output busticated on 4.4 (regression)
Quoted 14 lines · Nick Bowler
Quoted 13 lines · Nick Bowler
Quoted 3 lines · Sonika
Quoted 2 lines · Nick Bowler
Quoted 1 line · Nick Bowler
On 2016-01-20, Jindal, Sonika <[email protected]> wrote:
[...]
Quoted 4 lines
Quoted 3 lines
Quoted 2 lines
Quoted 1 line
Does the same system works with any other monitor?
I'll see if I can find another to try.
I tried another monitor, and the same problem occurs.
Which make are these monitors?
- LG Flatron W2253V
- Dell E228WFPc
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Do you have any other system other than G45?
Nothing else with Linux 4.4, unfortunately.
Anything else you want me to try?
This issue is still present in 4.5-rc1.
Ping?
HDMI is still broken on my system in 4.5-rc3.
Cheers,
Nick
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 7 lines · Shashank
Hi Nick,
Sonika is OOO for this week.
AFAIK about this issue, looks like the live status is not getting set for your system, on HPD.As per the Bspec, we must check live status before trying to read EDID. Is it possible for you to check with an HDMI analyzer and probe live status register ?
BTW I'm not at all convinced about the current live status bit defines we have for g4x. Supposedly someone tested them and found that they don't match the spec, but IIRC when I tried them on one g4x machine here, they did match the spec (well, at least for the ports present on that particular board).
So something like this may or may not help:
drivers/gpu/drm/i915/i915_reg.h +2 -2
@@ -3302,9 +3302,9 @@ enum skl_disp_power_wells {* Please check the detailed lore in the commit message for for experimental * evidence. */ -#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 29) +#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 27)#define PORTC_HOTPLUG_LIVE_STATUS_G4X (1 << 28) -#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 27) +#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 29)/* VLV DP/HDMI bits again match Bspec */ #define PORTD_HOTPLUG_LIVE_STATUS_VLV (1 << 27)#define PORTC_HOTPLUG_LIVE_STATUS_VLV (1 << 28)
Signature · 1 line
2.4.10
Quoted 43 lines
Regards
Shashank
-----Original Message-----
From: Nick Bowler [mailto:[email protected]]
Sent: Tuesday, February 09, 2016 10:03 PM
To: Jindal, Sonika
Cc: [email protected]; [email protected]; Daniel Vetter; Sharma, Shashank
Subject: Re: PROBLEM: Intel HDMI output busticated on 4.4 (regression)Quoted 14 lines · Nick Bowler
Quoted 13 lines · Nick Bowler
Quoted 3 lines · Sonika
Quoted 2 lines · Nick Bowler
Quoted 1 line · Nick Bowler
On 2016-01-20, Jindal, Sonika <[email protected]> wrote:
[...]
Quoted 4 lines
Quoted 3 lines
Quoted 2 lines
Quoted 1 line
Does the same system works with any other monitor?
I'll see if I can find another to try.
I tried another monitor, and the same problem occurs.
Which make are these monitors?
- LG Flatron W2253V
- Dell E228WFPcQuoted 7 lines
Quoted 3 lines
Quoted 1 line
Do you have any other system other than G45?
Nothing else with Linux 4.4, unfortunately.
Anything else you want me to try?
This issue is still present in 4.5-rc1.
Ping?
HDMI is still broken on my system in 4.5-rc3.
Cheers,
Nick
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 2 lines
Ville Syrjälä Intel OTC
Quoted 23 lines · Ville Syrjälä
Quoted 7 lines · Shashank
Hi Nick,
Sonika is OOO for this week.
AFAIK about this issue, looks like the live status is not getting set for your system, on HPD.As per the Bspec, we must check live status before trying to read EDID. Is it possible for you to check with an HDMI analyzer and probe live status register ?
BTW I'm not at all convinced about the current live status bit defines we have for g4x. Supposedly someone tested them and found that they don't match the spec, but IIRC when I tried them on one g4x machine here, they did match the spec (well, at least for the ports present on that particular board).
So something like this may or may not help:
drivers/gpu/drm/i915/i915_reg.h +0
-0@@ -3302,9 +3302,9 @@ enum skl_disp_power_wells {* Please check the detailed lore in the commit message for for experimental
drivers/gpu/drm/i915/i915_reg.h enum skl_disp_power_wells { · line 3310
Quoted 10 lines
drivers/gpu/drm/i915/i915_reg.h +2
-2* evidence. */ -#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 29) +#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 27)#define PORTC_HOTPLUG_LIVE_STATUS_G4X (1 << 28) -#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 27) +#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 29)/* VLV DP/HDMI bits again match Bspec */ #define PORTD_HOTPLUG_LIVE_STATUS_VLV (1 << 27)#define PORTC_HOTPLUG_LIVE_STATUS_VLV (1 << 28)
Just retested the g4x machine here, and port B is definitely on bit 29, port C on bit 28. No port D on ELK, so can't check that. So either someone made a fumble when they tested this originally, or some boards are just wired incorrectly, or CTG is where it was tested and that actually disagrees with the spec for some reason.
Quoted 55 lines
Signature · 1 line
2.4.10Quoted 43 lines
Regards
Shashank
-----Original Message-----
From: Nick Bowler [mailto:[email protected]]
Sent: Tuesday, February 09, 2016 10:03 PM
To: Jindal, Sonika
Cc: [email protected]; [email protected]; Daniel Vetter; Sharma, Shashank
Subject: Re: PROBLEM: Intel HDMI output busticated on 4.4 (regression)Quoted 14 lines · Nick Bowler
Quoted 13 lines · Nick Bowler
Quoted 3 lines · Sonika
Quoted 2 lines · Nick Bowler
Quoted 1 line · Nick Bowler
On 2016-01-20, Jindal, Sonika <[email protected]> wrote:
[...]
Quoted 4 lines
Quoted 3 lines
Quoted 2 lines
Quoted 1 line
Does the same system works with any other monitor?
I'll see if I can find another to try.
I tried another monitor, and the same problem occurs.
Which make are these monitors?
- LG Flatron W2253V
- Dell E228WFPcQuoted 7 lines
Quoted 3 lines
Quoted 1 line
Do you have any other system other than G45?
Nothing else with Linux 4.4, unfortunately.
Anything else you want me to try?
This issue is still present in 4.5-rc1.
Ping?
HDMI is still broken on my system in 4.5-rc3.
Cheers,
Nick
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-develSignature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 2 lines
Ville Syrjälä Intel OTC
Quoted 32 lines · Ville Syrjälä
Quoted 31 lines · Ville Syrjälä
Quoted 7 lines · Shashank
Hi Nick,
Sonika is OOO for this week.
AFAIK about this issue, looks like the live status is not getting set for your system, on HPD.As per the Bspec, we must check live status before trying to read EDID. Is it possible for you to check with an HDMI analyzer and probe live status register ?
BTW I'm not at all convinced about the current live status bit defines we have for g4x. Supposedly someone tested them and found that they don't match the spec, but IIRC when I tried them on one g4x machine here, they did match the spec (well, at least for the ports present on that particular board).
So something like this may or may not help:
drivers/gpu/drm/i915/i915_reg.h +2
-2@@ -3302,9 +3302,9 @@ enum skl_disp_power_wells {* Please check the detailed lore in the commit message for for experimental * evidence. */ -#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 29) +#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 27)#define PORTC_HOTPLUG_LIVE_STATUS_G4X (1 << 28) -#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 27) +#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 29)/* VLV DP/HDMI bits again match Bspec */
Quoted 8 lines
drivers/gpu/drm/i915/i915_reg.h enum skl_disp_power_wells { · line 3310
Quoted 2 lines
drivers/gpu/drm/i915/i915_reg.h +0
-0#define PORTD_HOTPLUG_LIVE_STATUS_VLV (1 << 27)#define PORTC_HOTPLUG_LIVE_STATUS_VLV (1 << 28)Just retested the g4x machine here, and port B is definitely on bit 29, port C on bit 28. No port D on ELK, so can't check that. So either someone made a fumble when they tested this originally, or some boards are just wired incorrectly, or CTG is where it was tested and that actually disagrees with the spec for some reason.
I just tried to trawl the w/a database for anything interesting, and the only thing I ran across was WaDPHDMISupriousHpd (without any description of course) for both elk and ctg. Nothing else really relevant looking.
So I think we should get someone to double check this on ctg, and then we can decide whether we change the bits just for elk or for ctg as well.
Quoted 64 lines
Quoted 56 lines
Signature · 2 lines
-- 2.4.10Quoted 43 lines
Regards
Shashank
-----Original Message-----
From: Nick Bowler [mailto:[email protected]]
Sent: Tuesday, February 09, 2016 10:03 PM
To: Jindal, Sonika
Cc: [email protected]; [email protected]; Daniel Vetter; Sharma, Shashank
Subject: Re: PROBLEM: Intel HDMI output busticated on 4.4 (regression)Quoted 14 lines · Nick Bowler
Quoted 13 lines · Nick Bowler
Quoted 3 lines · Sonika
Quoted 2 lines · Nick Bowler
Quoted 1 line · Nick Bowler
On 2016-01-20, Jindal, Sonika <[email protected]> wrote:
[...]
Quoted 4 lines
Quoted 3 lines
Quoted 2 lines
Quoted 1 line
Does the same system works with any other monitor?
I'll see if I can find another to try.
I tried another monitor, and the same problem occurs.
Which make are these monitors?
- LG Flatron W2253V
- Dell E228WFPcQuoted 7 lines
Quoted 3 lines
Quoted 1 line
Do you have any other system other than G45?
Nothing else with Linux 4.4, unfortunately.
Anything else you want me to try?
This issue is still present in 4.5-rc1.
Ping?
HDMI is still broken on my system in 4.5-rc3.
Cheers,
Nick
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-develSignature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-develSignature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
I checked locally in BDC,
Seems we don't have these boards available with us (in working state).
Regards
Shashank
-----Original Message-----
From: Ville Syrjälä [mailto:[email protected]]
Sent: Tuesday, February 09, 2016 11:53 PM
To: Sharma, Shashank
Cc: Nick Bowler; Daniel Vetter; [email protected]; [email protected]
Subject: Re: PROBLEM: Intel HDMI output busticated on 4.4 (regression)
Quoted 33 lines · Ville Syrjälä
Quoted 32 lines · Ville Syrjälä
Quoted 7 lines · Shashank
Hi Nick,
Sonika is OOO for this week.
AFAIK about this issue, looks like the live status is not getting set for your system, on HPD.As per the Bspec, we must check live status before trying to read EDID. Is it possible for you to check with an HDMI analyzer and probe live status register ?
BTW I'm not at all convinced about the current live status bit defines we have for g4x. Supposedly someone tested them and found that they don't match the spec, but IIRC when I tried them on one g4x machine here, they did match the spec (well, at least for the ports present on that particular board).
So something like this may or may not help:
(quoted diff) +0
-0
b/drivers/gpu/drm/i915/i915_reg.hindex188ad5de020f..80c08016e522100644drivers/gpu/drm/i915/i915_reg.h +2
-2@@ -3302,9 +3302,9 @@ enum skl_disp_power_wells {* Please check the detailed lore in the commit message for for experimental * evidence. */ -#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 29) +#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 27)#define PORTC_HOTPLUG_LIVE_STATUS_G4X (1 << 28) -#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 27) +#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 29)/* VLV DP/HDMI bits again match Bspec */
Quoted 8 lines
drivers/gpu/drm/i915/i915_reg.h enum skl_disp_power_wells { · line 3310
Quoted 2 lines
drivers/gpu/drm/i915/i915_reg.h +0
-0#define PORTD_HOTPLUG_LIVE_STATUS_VLV (1 << 27)#define PORTC_HOTPLUG_LIVE_STATUS_VLV (1 << 28)Just retested the g4x machine here, and port B is definitely on bit 29, port C on bit 28. No port D on ELK, so can't check that. So either someone made a fumble when they tested this originally, or some boards are just wired incorrectly, or CTG is where it was tested and that actually disagrees with the spec for some reason.
I just tried to trawl the w/a database for anything interesting, and the only thing I ran across was WaDPHDMISupriousHpd (without any description of course) for both elk and ctg. Nothing else really relevant looking.
So I think we should get someone to double check this on ctg, and then we can decide whether we change the bits just for elk or for ctg as well.
Quoted 59 lines
Quoted 51 lines
--
2.4.10Quoted 37 lines
Regards
Shashank
-----Original Message-----
From: Nick Bowler [mailto:[email protected]]
Sent: Tuesday, February 09, 2016 10:03 PM
To: Jindal, Sonika
Cc: [email protected]; [email protected]; Daniel Vetter; Sharma, Shashank
Subject: Re: PROBLEM: Intel HDMI output busticated on 4.4 (regression)Quoted 14 lines · Nick Bowler
Quoted 13 lines · Nick Bowler
Quoted 3 lines · Sonika
Quoted 2 lines · Nick Bowler
Quoted 1 line · Nick Bowler
On 2016-01-20, Jindal, Sonika <[email protected]> wrote:
[...]
Quoted 4 lines
Quoted 3 lines
Quoted 2 lines
Quoted 1 line
Does the same system works with any other monitor?
I'll see if I can find another to try.
I tried another monitor, and the same problem occurs.
Which make are these monitors?
- LG Flatron W2253V
- Dell E228WFPcQuoted 7 lines
Quoted 3 lines
Quoted 1 line
Do you have any other system other than G45?
Nothing else with Linux 4.4, unfortunately.
Anything else you want me to try?
This issue is still present in 4.5-rc1.
Ping?
Quoted 8 lines
HDMI is still broken on my system in 4.5-rc3.
Cheers,
Nick
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-develQuoted 7 lines
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 7 lines
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 18 lines · Ville Syrjälä
BTW I'm not at all convinced about the current live status bit defines we have for g4x. Supposedly someone tested them and found that they don't match the spec, but IIRC when I tried them on one g4x machine here, they did match the spec (well, at least for the ports present on that particular board).
So something like this may or may not help:
drivers/gpu/drm/i915/i915_reg.h +0
-0@@ -3302,9 +3302,9 @@ enum skl_disp_power_wells {* Please check the detailed lore in the commit message for for experimental
* evidence.
*/
drivers/gpu/drm/i915/i915_reg.h enum skl_disp_power_wells { · line 3310
Quoted 8 lines
drivers/gpu/drm/i915/i915_reg.h +2
-2-#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 29) +#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 27)#define PORTC_HOTPLUG_LIVE_STATUS_G4X (1 << 28) -#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 27) +#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 29)/* VLV DP/HDMI bits again match Bspec */ #define PORTD_HOTPLUG_LIVE_STATUS_VLV (1 << 27)#define PORTC_HOTPLUG_LIVE_STATUS_VLV (1 << 28)
Well, I applied this on 4.5-rc3 and it seems to fix things.
Thanks,
Nick
Jani Nikula
maintainerQuoted 21 lines · Nick Bowler
Quoted 20 lines · Ville Syrjälä
BTW I'm not at all convinced about the current live status bit defines we have for g4x. Supposedly someone tested them and found that they don't match the spec, but IIRC when I tried them on one g4x machine here, they did match the spec (well, at least for the ports present on that particular board).
So something like this may or may not help:
drivers/gpu/drm/i915/i915_reg.h +0
-0@@ -3302,9 +3302,9 @@ enum skl_disp_power_wells {* Please check the detailed lore in the commit message for for experimental
* evidence.
*/drivers/gpu/drm/i915/i915_reg.h +1
-1-#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 29) +#define PORTD_HOTPLUG_LIVE_STATUS_G4X (1 << 27)
Quoted 8 lines
drivers/gpu/drm/i915/i915_reg.h enum skl_disp_power_wells { · line 3310
Quoted 6 lines
#define
PORTC_HOTPLUG_LIVE_STATUS_G4X(1 << 28)drivers/gpu/drm/i915/i915_reg.h +1
-1-#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 27) +#define PORTB_HOTPLUG_LIVE_STATUS_G4X (1 << 29)/* VLV DP/HDMI bits again match Bspec */ #define PORTD_HOTPLUG_LIVE_STATUS_VLV (1 << 27)#define PORTC_HOTPLUG_LIVE_STATUS_VLV (1 << 28)Well, I applied this on 4.5-rc3 and it seems to fix things.
Ville, please do a proper patch, using your best judgement on elk vs. ctg difference.
BR,
Jani.
Quoted 7 lines
Thanks,
Nick
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel