staging: rtl8192e: prefer using eth_broadcast_addr()

PATCH Superseded Gujulan Elango, Hari Prasath (H.) 2 participants 2 messages Jan 20, 2016 – Feb 8, 2016 Staging

lore

Share & tools

lore

Gujulan Elango, Hari Prasath (H.)

author

2016-01-20 13:22 UTC #0 lore raw

PATCH 1/1 staging: rtl8192e: prefer using eth_broadcast_addr()

From: Hari Prasath Gujulan Elango

Prefer using the eth_broadcast_addr() instead of memset to broadcast address 0xFF to the array.

Signed-off-by Hari Prasath Gujulan Elango <[email protected]>

---
 drivers/staging/rtl8192e/rtllib_softmac.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/staging/rtl8192e/rtllib_softmac.c +2 -2

index d0fedb0..2a57640 100644
@@ -355,9 +355,9 @@ static inline struct sk_buff *rtllib_probe_req(struct rtllib_device *ieee)
 	req->header.frame_ctl = cpu_to_le16(RTLLIB_STYPE_PROBE_REQ);
 	req->header.duration_id = 0;
 
-	memset(req->header.addr1, 0xff, ETH_ALEN);
+	eth_broadcast_addr(req->header.addr1);
 	ether_addr_copy(req->header.addr2, ieee->dev->dev_addr);
-	memset(req->header.addr3, 0xff, ETH_ALEN);
+	eth_broadcast_addr(req->header.addr3);
 
 	tag = (u8 *) skb_put(skb, len + 2 + rate_len);

Signature · 1 line

1.9.1

[email protected]

maintainer

2016-02-08 04:01 UTC #1 lore raw

Quoted 1 line · Hari Prasath (H.)

From: Hari Prasath Gujulan Elango

When you do this, you need an email address after the name, otherwise git complains and refuses to apply the patch.

Please fix up and resend.

thanks,

greg k-h