Skip to contentSkip to conversation

staging: rtl8192e: prefer using eth_broadcast_addr()

PATCH New Gujulan Elango, Hari Prasath (H.) 1 participant 1 message Feb 8, 2016 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: rtl8192e: prefer using eth_broadcast_addr()

From: Hari Prasath Gujulan Elango <[email protected]>

Prefer using the eth_broadcast_addr() instead of memset to broadcast address 0xFF to the array.

---
v2: From email address was missing as pointed by Greg.

---
 drivers/staging/rtl8192e/rtllib_softmac.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8192e/rtllib_softmac.c +2 -2
index d0fedb0..2a57640 100644
@@ -355,9 +355,9 @@ static inline struct sk_buff *rtllib_probe_req(struct rtllib_device *ieee)
 	req->header.frame_ctl = cpu_to_le16(RTLLIB_STYPE_PROBE_REQ);
 	req->header.duration_id = 0;
 
-	memset(req->header.addr1, 0xff, ETH_ALEN);
+	eth_broadcast_addr(req->header.addr1);
 	ether_addr_copy(req->header.addr2, ieee->dev->dev_addr);
-	memset(req->header.addr3, 0xff, ETH_ALEN);
+	eth_broadcast_addr(req->header.addr3);
 
 	tag = (u8 *) skb_put(skb, len + 2 + rate_len);
 
Signature · 1 line
1.9.1