staging: rtl8192e: Replaced comparison to NULL statements
PATCH 1/6 staging: rtl8192e: Replaced comparison to NULL statements
This patch corrects check generated by checkpatch.pl by replacing comparison to null statements with equivalent statements in the form of "!x".
--- drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8192e/rtl819x_BAProc.c +3 -3
@@ -83,12 +83,12 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_device *ieee, u8 *Dst,netdev_dbg (ieee->dev,"%s(): frame(%d) sentd to: %pM, ieee->dev:%p\n" , __func__, type, Dst, ieee->dev); -if (pBA ==NULL ) { +if (!pBA) {netdev_warn (ieee->dev,"pBA is NULL\n" );return NULL ; } skb =dev_alloc_skb (len +sizeof (struct rtllib_hdr_3addr )); -if (skb ==NULL ) +if (!skb)return NULL ;memset (skb->data,0 ,sizeof (struct rtllib_hdr_3addr ));
@@ -154,7 +154,7 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_device *ieee, u8 *dst, DelbaParamSet.field.TID = pBA->BaParamSet.field.TID; skb =dev_alloc_skb (len +sizeof (struct rtllib_hdr_3addr )); -if (skb ==NULL ) +if (!skb)return NULL ;skb_reserve (skb, ieee->tx_headroom);
Signature · 1 line
2.7.4
Quoted 1 line · simran singhal
This patch corrects check generated by checkpatch.pl by
There is not much information in the first line. Use the imperative:
Replace comparisons to NULL by ...
Quoted 2 lines
replacing comparison to null statements with equivalent statements in the form of "!x".
Actually, they are expressions. An expression returns a value. A statement is performed for its side effects only.
julia
Quoted 43 lines
Signed-off-by simran singhal <[email protected]>--- drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/staging/rtl8192e/rtl819x_BAProc.c +3
-4@@ -83,12 +83,12 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_device *ieee, u8 *Dst,netdev_dbg (ieee->dev,"%s(): frame(%d) sentd to: %pM, ieee->dev:%p\n" , __func__, type, Dst, ieee->dev); -if (pBA ==NULL ) { +if (!pBA) {netdev_warn (ieee->dev,"pBA is NULL\n" );return NULL ; } skb =dev_alloc_skb (len +sizeof (struct rtllib_hdr_3addr )); -if (skb ==NULL ) +if (!skb)return NULL ;memset (skb->data,0 ,sizeof (struct rtllib_hdr_3addr ));@@ -154,7 +154,7 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_device *ieee, u8 *dst, DelbaParamSet.field.TID = pBA->BaParamSet.field.TID; skb =dev_alloc_skb (len +sizeof (struct rtllib_hdr_3addr )); -if (skb ==NULL ) +if (!skb)return NULL ;skb_reserve (skb, ieee->tx_headroom); --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218071115.GA10540%40singhal-Inspiron-5558.
For more options, visit https://groups.google.com/d/optout.