drm/vc4: Enable selection in Kconfig on any BCM platform.
Subsystems (3)
PATCH 1/1 drm/vc4: Enable selection in Kconfig on any BCM platform.
With the Cygnus port, we needed to add at least "|| ARCH_BCM_CYGNUS" to let the module get built on a cygnus-only kernel. However, I anticipate having a port for Kona soon, so just present the module on all of BCM.
---
I would be sending this through drm-misc-next, assuming BCM maintainers like it.
drivers/gpu/drm/vc4/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/vc4/Kconfig +1 -1
@@ -1,6 +1,6 @@ config DRM_VC4 tristate "Broadcom VC4 Graphics" - depends on ARCH_BCM2835 || COMPILE_TEST + depends on ARCH_BCM || COMPILE_TEST depends on DRM depends on SND && SND_SOC depends on COMMON_CLK
Signature · 6 lines
2.11.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 4 lines · Eric Anholt
With the Cygnus port, we needed to add at least "||
ARCH_BCM_CYGNUS" to let the module get built on a cygnus-only kernel. However, I anticipate having a port for Kona soon, so just present the module on all of BCM.
This seems reasonable, but by replacing ARCH_BCM2835 which is common to ARM/Linux and ARM64/Linux, you are no longer allowing an ARM64 systems to benefit from this driver unless COMPILE_TEST is also selected, right?
This could be:
depends on COMPILE_TEST
depends on ARCH_BCM # 32-bit ARM
depends on ARCH_BCM2835 || ARCH_BCM_IPROC # 64-bit ARM
or maybe down to just:
depends on COMPILE_TEST
and let DRM, COMMON_CLK and SND drive the bulk of the dependencies?
Quoted 23 lines
Signed-off-by Eric Anholt <[email protected]>---
I would be sending this through drm-misc-next, assuming BCM maintainers like it.
drivers/gpu/drm/vc4/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/vc4/Kconfig +1
-1@@ -1,6 +1,6 @@ config DRM_VC4 tristate "Broadcom VC4 Graphics" - depends on ARCH_BCM2835 || COMPILE_TEST + depends on ARCH_BCM || COMPILE_TEST depends on DRM depends on SND && SND_SOC depends on COMMON_CLK
Signature · 1 line
Florian
Quoted 10 lines · Florian Fainelli
Quoted 4 lines · Eric Anholt
With the Cygnus port, we needed to add at least "||
ARCH_BCM_CYGNUS" to let the module get built on a cygnus-only kernel. However, I anticipate having a port for Kona soon, so just present the module on all of BCM.This seems reasonable, but by replacing
ARCH_BCM2835which is common to ARM/Linux and ARM64/Linux, you are no longer allowing an ARM64 systems to benefit from this driver unlessCOMPILE_TESTis also selected, right?
Quoted 5 lines
This could be:
depends on
COMPILE_TEST
depends onARCH_BCM# 32-bit ARM
depends onARCH_BCM2835||ARCH_BCM_IPROC# 64-bit ARM
There are no 64-bit IPROC variants that use this.
Quoted 32 lines
or maybe down to just:
depends on
COMPILE_TESTand let DRM,
COMMON_CLKand SND drive the bulk of the dependencies?Quoted 23 lines
Signed-off-by Eric Anholt <[email protected]>---
I would be sending this through drm-misc-next, assuming BCM maintainers like it.
drivers/gpu/drm/vc4/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/vc4/Kconfig +1
-1@@ -1,6 +1,6 @@ config DRM_VC4 tristate "Broadcom VC4 Graphics" - depends on ARCH_BCM2835 || COMPILE_TEST + depends on ARCH_BCM || COMPILE_TEST depends on DRM depends on SND && SND_SOC depends on COMMON_CLK
Quoted 16 lines · Florian Fainelli
Quoted 4 lines · Eric Anholt
With the Cygnus port, we needed to add at least "||
ARCH_BCM_CYGNUS" to let the module get built on a cygnus-only kernel. However, I anticipate having a port for Kona soon, so just present the module on all of BCM.This seems reasonable, but by replacing
ARCH_BCM2835which is common to ARM/Linux and ARM64/Linux, you are no longer allowing an ARM64 systems to benefit from this driver unlessCOMPILE_TESTis also selected, right?This could be:
depends on
COMPILE_TEST
depends onARCH_BCM# 32-bit ARM
depends onARCH_BCM2835||ARCH_BCM_IPROC# 64-bit ARM
Quoted 5 lines
or maybe down to just:
depends on
COMPILE_TESTand let DRM,
COMMON_CLKand SND drive the bulk of the dependencies?
That would disable it on ARCH_BCM2835 && !COMPILE_TEST, right? COMPILE_TEST is typically disabled.
I think I should use ARCH_BCM2835 || ARCH_BCM || COMPILE_TEST. Does that sound good?
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel