Skip to contentSkip to conversation

drm/vc4: Enable selection in Kconfig on any 32-bit BCM platform.

PATCH In review Eric Anholt 3 participants 5 messages May 9, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/vc4: Enable selection in Kconfig on any 32-bit BCM platform.

With the Cygnus port, we needed to add at least "|| ARCH_BCM_CYGNUS" to let the module get built on a cygnus-only kernel. However, I anticipate having a port for Kona soon, so just present the module on all of BCM.

v2: Keep allowing selection with ARCH_BCM2835, since ARCH_BCM doesn't
exist on arm64.

---
 drivers/gpu/drm/vc4/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/vc4/Kconfig +1 -1
index 973b4203c0b2..b16aefe4a8d3 100644
@@ -1,6 +1,6 @@
 config DRM_VC4
 	tristate "Broadcom VC4 Graphics"
-	depends on ARCH_BCM2835 || COMPILE_TEST
+	depends on ARCH_BCM || ARCH_BCM2835 || COMPILE_TEST
 	depends on DRM
 	depends on SND && SND_SOC
 	depends on COMMON_CLK
Signature · 1 line
2.11.0
Acked-by on v2 1/1
#1 lore raw

Looks good for Cygnus.

Quoted 10 lines · Eric Anholt

With the Cygnus port, we needed to add at least "|| ARCH_BCM_CYGNUS" to let the module get built on a cygnus-only kernel. However, I anticipate having a port for Kona soon, so just present the module on all of BCM.

v2: Keep allowing selection with ARCH_BCM2835, since ARCH_BCM doesn't
exist on arm64.

Quoted 17 lines
---
 drivers/gpu/drm/vc4/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/vc4/Kconfig +1 -1
index 973b4203c0b2..b16aefe4a8d3 100644
@@ -1,6 +1,6 @@
 config DRM_VC4
 	tristate "Broadcom VC4 Graphics"
-	depends on ARCH_BCM2835 || COMPILE_TEST
+	depends on ARCH_BCM || ARCH_BCM2835 || COMPILE_TEST
 	depends on DRM
 	depends on SND && SND_SOC
 	depends on COMMON_CLK
Acked-by on v2 1/1
#2 lore raw
In reply to Eric Anholt
Quoted 7 lines · Eric Anholt

With the Cygnus port, we needed to add at least "|| ARCH_BCM_CYGNUS" to let the module get built on a cygnus-only kernel. However, I anticipate having a port for Kona soon, so just present the module on all of BCM.

v2: Keep allowing selection with ARCH_BCM2835, since ARCH_BCM doesn't
exist on arm64.

Nit: the patch changelog usually goes after the "---" line so it gets stripped with git am. Not necessary to resubmit just because of that.

Quoted 3 lines
Quoted 17 lines
---
 drivers/gpu/drm/vc4/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/vc4/Kconfig +1 -1
index 973b4203c0b2..b16aefe4a8d3 100644
@@ -1,6 +1,6 @@
 config DRM_VC4
 	tristate "Broadcom VC4 Graphics"
-	depends on ARCH_BCM2835 || COMPILE_TEST
+	depends on ARCH_BCM || ARCH_BCM2835 || COMPILE_TEST
 	depends on DRM
 	depends on SND && SND_SOC
 	depends on COMMON_CLK
Signature · 1 line
Florian
#3 lore raw
Quoted 11 lines · Florian Fainelli
Quoted 7 lines · Eric Anholt

With the Cygnus port, we needed to add at least "|| ARCH_BCM_CYGNUS" to let the module get built on a cygnus-only kernel. However, I anticipate having a port for Kona soon, so just present the module on all of BCM.

v2: Keep allowing selection with ARCH_BCM2835, since ARCH_BCM doesn't
exist on arm64.

Nit: the patch changelog usually goes after the "---" line so it gets stripped with git am. Not necessary to resubmit just because of that.

Behavior on that front differs between subsystems. DRM is one where the changelog is generally retained.

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw
Quoted 8 lines · Eric Anholt
Quoted 6 lines · Florian Fainelli
Quoted 5 lines · Eric Anholt

With the Cygnus port, we needed to add at least "|| ARCH_BCM_CYGNUS" to let the module get built on a cygnus-only kernel. However, I anticipate having a port for Kona soon, so just present the module on all of BCM.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

v2: Keep allowing selection with ARCH_BCM2835, since ARCH_BCM doesn't
exist on arm64.

Nit: the patch changelog usually goes after the "---" line so it gets stripped with git am. Not necessary to resubmit just because of that.

Behavior on that front differs between subsystems. DRM is one where the changelog is generally retained.

Once the patch lands in git, it's sort of interesting to know its history and the context surrounding this acceptance, but there is already so much context being lost already (like where are all other patches from the same patch series for instance?) that I wonder if we should not add more to it (like links to past iterations and so on).

Thanks for explaining how DRM works in that regard, though.

Signature · 1 line
Florian