drm/pl111: Fix return value check in pl111_amba_probe()
Subsystems (3)
PATCH 1/1 drm/pl111: Fix return value check in pl111_amba_probe()
From: Wei Yongjun <[email protected]>
In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR().
Fixes bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111")
Signed-off-by Wei Yongjun <[email protected]>
--- drivers/gpu/drm/pl111/pl111_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/pl111/pl111_drv.c +2 -2
@@ -203,9 +203,9 @@ static int pl111_amba_probe(struct amba_device *amba_dev, } priv->regs =devm_ioremap_resource (dev, &amba_dev->res); -if (!priv->regs) { +if (IS_ERR (priv->regs)) {dev_err (dev,"%s failed mmio\n" , __func__); -return -EINVAL ; +return PTR_ERR (priv->regs); }/* turn off interrupts before requesting the irq */
Quoted 8 lines · Wei Yongjun
From: Wei Yongjun <[email protected]>
In case of error, the function
devm_ioremap_resource()returnsERR_PTR()and never returns NULL. The NULL test in the return value check should be replaced withIS_ERR().Fixes bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111")Signed-off-by Wei Yongjun <[email protected]>
Reviewed and applied. Thanks!
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel