Skip to contentSkip to conversation

armv8: ls1088a: Enable sata on ls1088a

PATCH New andy.tang at nxp.com 2 participants 3 messages Oct 26, 2017 – Oct 30, 2017

lore
Share & tools
lore

andy.tang at nxp.com

author
#0 lore raw

PATCH 1/2 armv8: ls1088a: Enable sata on ls1088a

From: Yuantian Tang <[email protected]>

Enable sata feature on ls1088a platforms

Signed-off-by Tang Yuantian <[email protected]>
---
 include/configs/ls1088aqds.h | 12 ++++++++++++
 include/configs/ls1088ardb.h | 13 +++++++++++++
 2 files changed, 25 insertions(+)
include/configs/ls1088aqds.h +12 -0
index 71d0e4e7d1..c1087edb38 100644
@@ -293,6 +293,18 @@ unsigned long get_board_ddr_clk(void);
 #define CONFIG_SYS_EEPROM_PAGE_WRITE_BITS	3
 #define CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS	5
 
+/* SATA */
+#define CONFIG_LIBATA
+#define CONFIG_SCSI
+#define CONFIG_SCSI_AHCI
+#define CONFIG_SCSI_AHCI_PLAT
+
+#define CONFIG_SYS_SATA1                       AHCI_BASE_ADDR1
+
+#define CONFIG_SYS_SCSI_MAX_SCSI_ID            1
+#define CONFIG_SYS_SCSI_MAX_LUN                        1
+#define CONFIG_SYS_SCSI_MAX_DEVICE             (CONFIG_SYS_SCSI_MAX_SCSI_ID * \
+						CONFIG_SYS_SCSI_MAX_LUN)
 /* QSPI device */
 #if defined(CONFIG_QSPI_BOOT)
 #define CONFIG_FSL_QSPI
include/configs/ls1088ardb.h +13 -0
index 39f1345f97..8587234dcd 100644
@@ -232,6 +232,19 @@
 #define CONFIG_SYS_EEPROM_PAGE_WRITE_BITS	3
 #define CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS	5
 
+/* SATA */
+#define CONFIG_LIBATA
+#define CONFIG_SCSI
+#define CONFIG_SCSI_AHCI
+#define CONFIG_SCSI_AHCI_PLAT
+
+#define CONFIG_SYS_SATA1			AHCI_BASE_ADDR1
+
+#define CONFIG_SYS_SCSI_MAX_SCSI_ID		1
+#define CONFIG_SYS_SCSI_MAX_LUN			1
+#define CONFIG_SYS_SCSI_MAX_DEVICE		(CONFIG_SYS_SCSI_MAX_SCSI_ID * \
+						CONFIG_SYS_SCSI_MAX_LUN)
+
 /* QSPI device */
 #if defined(CONFIG_QSPI_BOOT)
 #define CONFIG_FSL_QSPI
Signature · 1 line
2.14.1
author
#1 lore raw

PATCH 2/2 armv8: ls1088a: Add SCSI command support

From: Yuantian Tang <[email protected]>

SATA feature was supported on ls1088a, so add SCSI command to operate sata.

Signed-off-by Tang Yuantian <[email protected]>
---
 configs/ls1088aqds_qspi_defconfig | 1 +
 configs/ls1088ardb_qspi_defconfig | 1 +
 2 files changed, 2 insertions(+)
configs/ls1088aqds_qspi_defconfig +1 -0
index 6a542ed5f8..6a4ae491c7 100644
@@ -15,6 +15,7 @@ CONFIG_CMD_SF=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_DHCP=y
 CONFIG_CMD_PING=y
+CONFIG_CMD_SCSI=y
 CONFIG_OF_CONTROL=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DM=y
configs/ls1088ardb_qspi_defconfig +1 -0
index 52b10af96a..4ed221ea68 100644
@@ -15,6 +15,7 @@ CONFIG_CMD_SF=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_DHCP=y
 CONFIG_CMD_PING=y
+CONFIG_CMD_SCSI=y
 CONFIG_OF_CONTROL=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DM=y
Signature · 1 line
2.14.1
#2 lore raw

PATCH 1/2 armv8: ls1088a: Enable sata on ls1088a

In reply to andy.tang at nxp.com
Quoted 15 lines · andy.tang at nxp.com

From: Yuantian Tang <[email protected]>

Enable sata feature on ls1088a platforms

Signed-off-by Tang Yuantian <[email protected]>
---
 include/configs/ls1088aqds.h | 12 ++++++++++++
 include/configs/ls1088ardb.h | 13 +++++++++++++
 2 files changed, 25 insertions(+)
include/configs/ls1088aqds.h +0 -0
index 71d0e4e7d1..c1087edb38 100644

include/configs/ls1088aqds.h unsigned long get_board_ddr_clk(void); · line 296

Quoted 4 lines
include/configs/ls1088aqds.h +1 -0
@@ -293,6 +293,18 @@ unsigned long get_board_ddr_clk(void);
 #define CONFIG_SYS_EEPROM_PAGE_WRITE_BITS	3
 #define CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS	5
 
+/* SATA */

How about check CONFIG_SCSI here, and use Kconfig to select SCSI?

Quoted 25 lines
include/configs/ls1088aqds.h +11 -0
+#define CONFIG_LIBATA
+#define CONFIG_SCSI
+#define CONFIG_SCSI_AHCI
+#define CONFIG_SCSI_AHCI_PLAT
+
+#define CONFIG_SYS_SATA1                       AHCI_BASE_ADDR1
+
+#define CONFIG_SYS_SCSI_MAX_SCSI_ID            1
+#define CONFIG_SYS_SCSI_MAX_LUN                        1
+#define CONFIG_SYS_SCSI_MAX_DEVICE             (CONFIG_SYS_SCSI_MAX_SCSI_ID * \
+						CONFIG_SYS_SCSI_MAX_LUN)
 /* QSPI device */
 #if defined(CONFIG_QSPI_BOOT)
 #define CONFIG_FSL_QSPI
include/configs/ls1088ardb.h +3 -0
index 39f1345f97..8587234dcd 100644
@@ -232,6 +232,19 @@
 #define CONFIG_SYS_EEPROM_PAGE_WRITE_BITS	3
 #define CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS	5
 
+/* SATA */
+#define CONFIG_LIBATA
+#define CONFIG_SCSI

include/configs/ls1088ardb.h line 247

Quoted 10 lines
include/configs/ls1088ardb.h +10 -0
+#define CONFIG_SCSI_AHCI
+#define CONFIG_SCSI_AHCI_PLAT
+
+#define CONFIG_SYS_SATA1			AHCI_BASE_ADDR1
+
+#define CONFIG_SYS_SCSI_MAX_SCSI_ID		1
+#define CONFIG_SYS_SCSI_MAX_LUN			1
+#define CONFIG_SYS_SCSI_MAX_DEVICE		(CONFIG_SYS_SCSI_MAX_SCSI_ID * \
+						CONFIG_SYS_SCSI_MAX_LUN)
+

Aren't the above two sections are identical? Do they fit well in the common header file?

York