Skip to contentSkip to conversation

v4.15-rc2 on thinkpad x60: ethernet stopped working

DISCUSSION Pavel Machek 8 participants 17 messages Dec 10, 2017 – Dec 21, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi!

In v4.15-rc2+, network manager can not see my ethernet card, and manual attempts to ifconfig it up did not really help, either.

Card is:

02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet Controller

Dmesg says:

dmesg | grep eth

[    0.648931] e1000e 0000:02:00.0 eth0: (PCI Express:2.5GT/s:Width
x1) 00:16:d3:25:19:04
[    0.648934] e1000e 0000:02:00.0 eth0: Intel(R) PRO/1000 Network
Connection
[    0.649012] e1000e 0000:02:00.0 eth0: MAC: 2, PHY: 2, PBA No:
005302-003
[    0.706510] usbcore: registered new interface driver cdc_ether
[    6.557022] e1000e 0000:02:00.0 eth1: renamed from eth0
[    6.577554] systemd-udevd[2363]: renamed network interface eth0 to

eth1

Any ideas?
Pavel

Signature · 9 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20171210/d9e8d378/attachment.asc>
#1 lore raw
Quoted 1 line · Pavel Machek

Hi!

Hi,

Quoted 20 lines

In v4.15-rc2+, network manager can not see my ethernet card, and manual attempts to ifconfig it up did not really help, either.

Card is:

02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet Controller

Dmesg says:

dmesg | grep eth

[    0.648931] e1000e 0000:02:00.0 eth0: (PCI Express:2.5GT/s:Width
x1) 00:16:d3:25:19:04
[    0.648934] e1000e 0000:02:00.0 eth0: Intel(R) PRO/1000 Network
Connection
[    0.649012] e1000e 0000:02:00.0 eth0: MAC: 2, PHY: 2, PBA No:
005302-003
[    0.706510] usbcore: registered new interface driver cdc_ether
[    6.557022] e1000e 0000:02:00.0 eth1: renamed from eth0
[    6.577554] systemd-udevd[2363]: renamed network interface eth0 to
Quoted 3 lines

eth1

Any ideas ?

Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.

See:
https://bugzilla.kernel.org/show_bug.cgi?id=198047

Fix there :
https://marc.info/?l=linux-kernel&m=151272209903675&w=2

Regards,

Gabriel C

#2 lore raw

Hi!

Quoted 7 lines
Quoted 7 lines

In v4.15-rc2+, network manager can not see my ethernet card, and manual attempts to ifconfig it up did not really help, either.

Card is:

02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet Controller

....

Quoted 9 lines
Quoted 1 line

Any ideas ?

Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.

See:
https://bugzilla.kernel.org/show_bug.cgi?id=198047

Fix there :
https://marc.info/?l=linux-kernel&m=151272209903675&w=2

I don't see the patch in latest mainline. Not having ethernet is... somehow annoying. What is going on there?
Pavel

Signature · 9 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20171215/daac13ea/attachment.asc>
maintainer
#3 lore raw

From: Pavel Machek <[email protected]>
Date: Fri, 15 Dec 2017 10:28:49 +0100

Quoted 14 lines

Hi!

Quoted 7 lines
Quoted 7 lines

In v4.15-rc2+, network manager can not see my ethernet card, and manual attempts to ifconfig it up did not really help, either.

Card is:

02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet Controller

....

Quoted 4 lines
Quoted 1 line

Any ideas ?

Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.

Quoted 8 lines
Quoted 5 lines

See:
https://bugzilla.kernel.org/show_bug.cgi?id=198047

Fix there :
https://marc.info/?l=linux-kernel&m=151272209903675&w=2

I don't see the patch in latest mainline. Not having ethernet is... somehow annoying. What is going on there?

Generally speaking, e1000 maintainence has been handled very poorly over the past few years, I have to say.

Fixes take forever to propagate even when someone other than the maintainer provides a working and tested fix, just like this case.

Jeff, please take e1000 maintainence seriously and get these critical bug fixes propagated.

Thank you.

#4 lore raw

Hi!

Quoted 21 lines
Quoted 12 lines
Quoted 7 lines
Quoted 7 lines

In v4.15-rc2+, network manager can not see my ethernet card, and manual attempts to ifconfig it up did not really help, either.

Card is:

02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet Controller

....

Quoted 4 lines
Quoted 1 line

Any ideas ?

Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.

Quoted 8 lines
Quoted 5 lines

See:
https://bugzilla.kernel.org/show_bug.cgi?id=198047

Fix there :
https://marc.info/?l=linux-kernel&m=151272209903675&w=2

I don't see the patch in latest mainline. Not having ethernet is... somehow annoying. What is going on there?

Quoted 8 lines

Generally speaking, e1000 maintainence has been handled very poorly over the past few years, I have to say.

Fixes take forever to propagate even when someone other than the maintainer provides a working and tested fix, just like this case.

Jeff, please take e1000 maintainence seriously and get these critical bug fixes propagated.

No response AFAICT. I guess I should test reverting 19110cfbb34d4af0cdfe14cd243f3b09dc95b013, then ask you for revert?

Pavel

Signature · 9 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20171218/d4ab524e/attachment.asc>
#5 lore raw
Quoted 31 lines · Pavel Machek

Hi!

Quoted 18 lines
Quoted 11 lines
Quoted 7 lines
Quoted 7 lines

In v4.15-rc2+, network manager can not see my ethernet card, and manual attempts to ifconfig it up did not really help, either.

Card is:

02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet Controller

....

Quoted 3 lines
Quoted 1 line

Any ideas ?

Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.

Quoted 7 lines
Quoted 5 lines

See:
https://bugzilla.kernel.org/show_bug.cgi?id=198047

Fix there :
https://marc.info/?l=linux-kernel&m=151272209903675&w=2

I don't see the patch in latest mainline. Not having ethernet is... somehow annoying. What is going on there?

Quoted 8 lines

Generally speaking, e1000 maintainence has been handled very poorly over the past few years, I have to say.

Fixes take forever to propagate even when someone other than the maintainer provides a working and tested fix, just like this case.

Jeff, please take e1000 maintainence seriously and get these critical bug fixes propagated.

No response AFAICT. I guess I should test reverting 19110cfbb34d4af0cdfe14cd243f3b09dc95b013, then ask you for revert?

Quoted 7 lines

Pavel

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan at osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Hello Pavel,

Before ask for reverting 19110cfbb..., please, check if follow patch of Benjamin work for you http://patchwork.ozlabs.org/patch/846825/

Thanks,

Sasha

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20171218/9c3eb9f7/attachment.html>

#6 lore raw
Quoted 29 lines · Sasha
Quoted 28 lines · Pavel Machek

Hi!

Quoted 26 lines
Quoted 11 lines
Quoted 7 lines
Quoted 7 lines

In v4.15-rc2+, network manager can not see my ethernet card, and manual attempts to ifconfig it up did not really help, either.

Card is:

02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet Controller

....

Quoted 3 lines
Quoted 1 line

Any ideas ?

Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.

Quoted 7 lines
Quoted 5 lines

See:
https://bugzilla.kernel.org/show_bug.cgi?id=198047

Fix there :
https://marc.info/?l=linux-kernel&m=151272209903675&w=2

I don't see the patch in latest mainline. Not having ethernet is... somehow annoying. What is going on there?

Generally speaking, e1000 maintainence has been handled very poorly over the past few years, I have to say.

Fixes take forever to propagate even when someone other than the maintainer provides a working and tested fix, just like this case.

Jeff, please take e1000 maintainence seriously and get these critical bug fixes propagated.

Quoted 7 lines
Quoted 2 lines

No response AFAICT. I guess I should test reverting 19110cfbb34d4af0cdfe14cd243f3b09dc95b013, then ask you for revert?

Hello Pavel,

Before ask for reverting 19110cfbb..., please, check if follow patch of Benjamin work for you http://patchwork.ozlabs.org/patch/846825/

Jacob said, in another email:

# Digging into this, the problem is complicated. The original bug

# assumed behavior of the .check_for_link call, which is universally not
# implemented.
# 
# I think the correct fix is to revert 19110cfbb34d ("e1000e: Separate
# signaling for link check/link up", 2017-10-10) and find a more proper solution.

...which makes me think that revert is preffered?

Pavel

Signature · 9 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20171218/fbeb0aaa/attachment.asc>
#7 lore raw
Quoted 45 lines · Pavel Machek
Quoted 27 lines · Sasha
Quoted 26 lines · Pavel Machek

Hi!

Quoted 24 lines
Quoted 11 lines
Quoted 7 lines
Quoted 7 lines

In v4.15-rc2+, network manager can not see my ethernet card, and manual attempts to ifconfig it up did not really help, either.

Card is:

02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet Controller

....

Quoted 3 lines
Quoted 1 line

Any ideas ?

Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.

Quoted 7 lines
Quoted 5 lines

See:
https://bugzilla.kernel.org/show_bug.cgi?id=198047

Fix there :
https://marc.info/?l=linux-kernel&m=151272209903675&w=2

I don't see the patch in latest mainline. Not having ethernet is... somehow annoying. What is going on there?

Generally speaking, e1000 maintainence has been handled very poorly over the past few years, I have to say.

Fixes take forever to propagate even when someone other than the maintainer provides a working and tested fix, just like this case.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Jeff, please take e1000 maintainence seriously and get these critical bug fixes propagated.

No response AFAICT. I guess I should test reverting 19110cfbb34d4af0cdfe14cd243f3b09dc95b013, then ask you for revert?

Hello Pavel,

Before ask for reverting 19110cfbb..., please, check if follow patch of Benjamin work for you http://patchwork.ozlabs.org/patch/846825/

Jacob said, in another email:

# Digging into this, the problem is complicated. The original bug

# assumed behavior of the .check_for_link call, which is universally not
# implemented.
#
# I think the correct fix is to revert 19110cfbb34d ("e1000e: Separate
# signaling for link check/link up", 2017-10-10) and find a more proper solution.
Quoted 4 lines

...which makes me think that revert is preffered?

Pavel

Pavel, before ask for revert - let's check Benjamin's patch following to his previous patch. Previous patch was not competed and latest one come to complete changes.

#8 lore raw

Jeff was out sick last week. It might take him a bit to catch up.

I'll remind him when I see him next (which I hope is soon).

Todd Fujinaka
Software Application Engineer
Datacenter Engineering Group
Intel Corporation
todd.fujinaka at intel.com

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Neftin, Sasha
Sent: Monday, December 18, 2017 7:50 AM
To: Pavel Machek <[email protected]>; Keller, Jacob E <[email protected]>
Cc: bpoirier at suse.com; nix.or.die at gmail.com; netdev at vger.kernel.org; linux-kernel at vger.kernel.org; intel-wired-lan at lists.osuosl.org; lsorense at csclub.uwaterloo.ca; David Miller <[email protected]>
Subject: Re: [Intel-wired-lan] v4.15-rc2 on thinkpad x60: ethernet stopped working

Quoted 40 lines · Pavel Machek
Quoted 27 lines · Sasha
Quoted 26 lines · Pavel Machek

Hi!

Quoted 24 lines
Quoted 11 lines
Quoted 7 lines
Quoted 7 lines

In v4.15-rc2+, network manager can not see my ethernet card, and manual attempts to ifconfig it up did not really help, either.

Card is:

02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet Controller

....

Quoted 3 lines
Quoted 1 line

Any ideas ?

Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.

Quoted 7 lines
Quoted 5 lines

See:
https://bugzilla.kernel.org/show_bug.cgi?id=198047

Fix there :
https://marc.info/?l=linux-kernel&m=151272209903675&w=2

I don't see the patch in latest mainline. Not having ethernet is... somehow annoying. What is going on there?

Generally speaking, e1000 maintainence has been handled very poorly over the past few years, I have to say.

Fixes take forever to propagate even when someone other than the maintainer provides a working and tested fix, just like this case.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Jeff, please take e1000 maintainence seriously and get these critical bug fixes propagated.

No response AFAICT. I guess I should test reverting 19110cfbb34d4af0cdfe14cd243f3b09dc95b013, then ask you for revert?

Hello Pavel,

Before ask for reverting 19110cfbb..., please, check if follow patch of Benjamin work for you http://patchwork.ozlabs.org/patch/846825/

Jacob said, in another email:

# Digging into this, the problem is complicated. The original bug # assumed behavior of the .check_for_link call, which is universally not

Quoted 9 lines
# implemented.
#
# I think the correct fix is to revert 19110cfbb34d ("e1000e: Separate 
# signaling for link check/link up", 2017-10-10) and find a more proper solution.

...which makes me think that revert is preffered?

Pavel

Pavel, before ask for revert - let's check Benjamin's patch following to his previous patch. Previous patch was not competed and latest one come to complete changes.

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan at osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

#9 lore raw

Hi!

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

Before ask for reverting 19110cfbb..., please, check if follow patch of Benjamin work for you http://patchwork.ozlabs.org/patch/846825/

Pavel, before ask for revert - let's check Benjamin's patch following to his previous patch. Previous patch was not competed and latest one come to complete changes.

v4.15-rc4+:

Ethernet works with 19110cfbb reverted.

Ethernet works With patchwork.ozlabs.org/patch/846825/ applied.

Pavel

Signature · 9 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20171220/eccc321a/attachment.asc>
#10 lore raw
Quoted 6 lines · Pavel Machek

Hi!

Quoted 4 lines
Quoted 4 lines
Quoted 2 lines

Before ask for reverting 19110cfbb..., please, check if follow patch of Benjamin work for you http://patchwork.ozlabs.org/patch/846825/

Quoted 8 lines
Quoted 2 lines

Pavel, before ask for revert - let's check Benjamin's patch following to his previous patch. Previous patch was not competed and latest one come to complete changes.

v4.15-rc4+:

Ethernet works with 19110cfbb reverted.

Ethernet works With patchwork.ozlabs.org/patch/846825/ applied.

Hmm. So... ethernet originally did not work with patch/846825/ applied or 19110cfbb reverted, so I re-plugged ethernet cables. Now it works even with plain v4.15-rc4+.

So it looks like the bug was fixed in the mainline in the meantime...?

Sorry for the noise,
Pavel

Signature · 9 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20171220/4cd6c7ff/attachment.asc>
#11 lore raw
Quoted 12 lines · Pavel Machek
Quoted 11 lines · Pavel Machek

Hi!

Quoted 4 lines
Quoted 2 lines
Quoted 2 lines

Before ask for reverting 19110cfbb..., please, check if follow patch of Benjamin work for you http://patchwork.ozlabs.org/patch/846825/

Pavel, before ask for revert - let's check Benjamin's patch following to his previous patch. Previous patch was not competed and latest one come to complete changes.

v4.15-rc4+:

Ethernet works with 19110cfbb reverted.

Ethernet works With patchwork.ozlabs.org/patch/846825/ applied.

Quoted 8 lines

Hmm. So... ethernet originally did not work with patch/846825/ applied or 19110cfbb reverted, so I re-plugged ethernet cables. Now it works even with plain v4.15-rc4+.

So it looks like the bug was fixed in the mainline in the meantime...?

Sorry for the noise,
Pavel

Good Pavel, thanks for update us, let's keep both patch applied and see ethernet adapter behavior.

#12 lore raw
In reply to Neftin, Sasha
Quoted 53 lines · Sasha
Quoted 48 lines · Pavel Machek
Quoted 29 lines · Sasha
Quoted 28 lines · Pavel Machek

Hi!

Quoted 26 lines
Quoted 12 lines
Quoted 8 lines
Quoted 8 lines

In v4.15-rc2+, network manager can not see my ethernet card, and manual attempts to ifconfig it up did not really help, either.

Card is:

02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet
Controller

....

Quoted 3 lines
Quoted 1 line

Any ideas ?

Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.

Quoted 7 lines
Quoted 5 lines

See:
https://bugzilla.kernel.org/show_bug.cgi?id=198047

Fix there :
https://marc.info/?l=linux-kernel&m=151272209903675&w=2

I don't see the patch in latest mainline. Not having ethernet is... somehow annoying. What is going on there?

Generally speaking, e1000 maintainence has been handled very poorly over
the past few years, I have to say.

Fixes take forever to propagate even when someone other than the maintainer provides a working and tested fix, just like this case.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Jeff, please take e1000 maintainence seriously and get these critical bug fixes propagated.

No response AFAICT. I guess I should test reverting 19110cfbb34d4af0cdfe14cd243f3b09dc95b013, then ask you for revert?

Hello Pavel,

Before ask for reverting 19110cfbb..., please, check if follow patch of Benjamin work for you http://patchwork.ozlabs.org/patch/846825/

Jacob said, in another email:

# Digging into this, the problem is complicated. The original bug

# assumed behavior of the .check_for_link call, which is universally not
# implemented.
#
# I think the correct fix is to revert 19110cfbb34d ("e1000e: Separate
# signaling for link check/link up", 2017-10-10) and find a more 
proper solution.
Quoted 4 lines

...which makes me think that revert is preffered?

??????????????????????????????????? Pavel

Quoted 8 lines

Pavel, before ask for revert - let's check Benjamin's patch following to his previous patch. Previous patch was not competed and latest one come to complete changes.

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan at osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Pavel, any update? Is Benjamin's last patch solved your network problem?

#13 lore raw
In reply to Gabriel C
Quoted 43 lines

-----Original Message-----
From: netdev-owner at vger.kernel.org [mailto:netdev-owner at vger.kernel.org] On Behalf Of Gabriel C
Sent: Sunday, December 10, 2017 4:44 AM
To: Pavel Machek <[email protected]>; kernel list <[email protected]>
Cc: Kirsher, Jeffrey T <[email protected]>; intel-wired- lan at lists.osuosl.org; netdev at vger.kernel.org
Subject: Re: v4.15-rc2 on thinkpad x60: ethernet stopped working

Quoted 1 line · Pavel Machek

Hi!

Hi,

Quoted 20 lines

In v4.15-rc2+, network manager can not see my ethernet card, and manual attempts to ifconfig it up did not really help, either.

Card is:

02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet Controller

Dmesg says:

dmesg | grep eth

[    0.648931] e1000e 0000:02:00.0 eth0: (PCI Express:2.5GT/s:Width
x1) 00:16:d3:25:19:04
[    0.648934] e1000e 0000:02:00.0 eth0: Intel(R) PRO/1000 Network
Connection
[    0.649012] e1000e 0000:02:00.0 eth0: MAC: 2, PHY: 2, PBA No:
005302-003
[    0.706510] usbcore: registered new interface driver cdc_ether
[    6.557022] e1000e 0000:02:00.0 eth1: renamed from eth0
[    6.577554] systemd-udevd[2363]: renamed network interface eth0 to
Quoted 3 lines

eth1

Any ideas ?

Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.

See:
https://bugzilla.kernel.org/show_bug.cgi?id=198047

Quoted 6 lines

Fix there :
https://marc.info/?l=linux-kernel&m=151272209903675&w=2

Regards,

Gabriel C

Hi,

Digging into this, the problem is complicated. The original bug assumed behavior of the .check_for_link call, which is universally not implemented.

I think the correct fix is to revert 19110cfbb34d ("e1000e: Separate signaling for link check/link up", 2017-10-10) and find a more proper solution.

I don't think any other code which uses check_for_link expects the interface to return in the way this patch attempted.

Thanks,
Jake

#14 lore raw
Quoted 66 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Keller, Jacob E
Sent: Friday, December 15, 2017 9:29 AM
To: Gabriel C <[email protected]>; Pavel Machek <[email protected]>; kernel list <[email protected]>
Cc: netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org
Subject: Re: [Intel-wired-lan] v4.15-rc2 on thinkpad x60: ethernet stopped working

Quoted 2 lines

-----Original Message-----
From: netdev-owner at vger.kernel.org [mailto:netdev-

owner at vger.kernel.org]

Quoted 41 lines

On Behalf Of Gabriel C
Sent: Sunday, December 10, 2017 4:44 AM
To: Pavel Machek <[email protected]>; kernel list <[email protected]>
Cc: Kirsher, Jeffrey T <[email protected]>; intel-wired- lan at lists.osuosl.org; netdev at vger.kernel.org
Subject: Re: v4.15-rc2 on thinkpad x60: ethernet stopped working

Quoted 1 line · Pavel Machek

Hi!

Hi,

Quoted 20 lines

In v4.15-rc2+, network manager can not see my ethernet card, and manual attempts to ifconfig it up did not really help, either.

Card is:

02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet Controller

Dmesg says:

dmesg | grep eth

[    0.648931] e1000e 0000:02:00.0 eth0: (PCI Express:2.5GT/s:Width
x1) 00:16:d3:25:19:04
[    0.648934] e1000e 0000:02:00.0 eth0: Intel(R) PRO/1000 Network
Connection
[    0.649012] e1000e 0000:02:00.0 eth0: MAC: 2, PHY: 2, PBA No:
005302-003
[    0.706510] usbcore: registered new interface driver cdc_ether
[    6.557022] e1000e 0000:02:00.0 eth1: renamed from eth0
[    6.577554] systemd-udevd[2363]: renamed network interface eth0 to
Quoted 3 lines

eth1

Any ideas ?

Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.

See:
https://bugzilla.kernel.org/show_bug.cgi?id=198047

Quoted 6 lines

Fix there :
https://marc.info/?l=linux-kernel&m=151272209903675&w=2

Regards,

Gabriel C

Hi,

Digging into this, the problem is complicated. The original bug assumed behavior of the .check_for_link call, which is universally not implemented.

Quoted 9 lines

I think the correct fix is to revert 19110cfbb34d ("e1000e: Separate signaling for link check/link up", 2017-10-10) and find a more proper solution.

I don't think any other code which uses check_for_link expects the interface to return in the way this patch attempted.

Thanks,
Jake

Alternatively, we can go a step farther and make sure every implementation of .check_for_link follows the modified interface.

Thanks,
Jake

#15 lore raw

Hi!

Quoted 19 lines
Quoted 19 lines
Quoted 7 lines
Quoted 1 line

Any ideas ?

Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.

See:
https://bugzilla.kernel.org/show_bug.cgi?id=198047

Quoted 6 lines

Fix there :
https://marc.info/?l=linux-kernel&m=151272209903675&w=2

Regards,

Gabriel C

Hi,

Digging into this, the problem is complicated. The original bug assumed behavior of the .check_for_link call, which is universally not implemented.

Quoted 8 lines
Quoted 5 lines

I think the correct fix is to revert 19110cfbb34d ("e1000e: Separate signaling for link check/link up", 2017-10-10) and find a more proper solution.

I don't think any other code which uses check_for_link expects the interface to return in the way this patch attempted.

Alternatively, we can go a step farther and make sure every implementation of .check_for_link follows the modified interface.

We are at -rc3 now. Reverting 19110cfbb34d seems like good solution at the moment.
Pavel

Signature · 9 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20171215/19cf7295/attachment.asc>
#16 lore raw
In reply to Pavel Machek

Dear Pavel,

Quoted 11 lines · Pavel Machek

In v4.15-rc2+, network manager can not see my ethernet card, and manual attempts to ifconfig it up did not really help, either.

Card is:

02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet Controller

Dmesg says:

dmesg | grep eth

Quoted 8 lines
[    0.648931] e1000e 0000:02:00.0 eth0: (PCI Express:2.5GT/s:Width x1) 00:16:d3:25:19:04
[    0.648934] e1000e 0000:02:00.0 eth0: Intel(R) PRO/1000 Network Connection
[    0.649012] e1000e 0000:02:00.0 eth0: MAC: 2, PHY: 2, PBA No: 005302-003
[    0.706510] usbcore: registered new interface driver cdc_ether
[    6.557022] e1000e 0000:02:00.0 eth1: renamed from eth0
[    6.577554] systemd-udevd[2363]: renamed network interface eth0 to eth1

Any ideas?

I am sorry for jumping in on this so late.

Since using a Lenovo X60t more ofter since a year or so, I experience the issue, that the link doesn?t come up during that period occasionally [1]. I haven?t tried the latest patches yet, but it might be unrelated.

Did you test, that removing and loading the e1000e module fixes the issue?

Additionally, I was asked privately to test the out of tree driver, but haven?t had time yet.

Quoted 3 lines

You might give the out-of-tree driver a try, you can download it here
https://downloadcenter.intel.com/download/26549/Intel-Network-Adapter-Driver-for-PCIe-Intel-Gigabit-Ethernet-Network-Connections-Under-Linux-?product=19297
It's version is 3.3.5, dated 8/2016

Kind regards,

Paul

[1]
https://lists.osuosl.org/pipermail/intel-wired-lan/Week-of-Mon-20170410/008590.html
-------------- next part --------------
An embedded message was scrubbed...
From: Paul Menzel <[email protected]>
Subject: [Intel-wired-lan] e1000e: Link down after startup on Lenovo X60
Date: Wed, 12 Apr 2017 16:31:45 +0200
Size: 6867
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20171221/0804f19a/attachment-0001.mht>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5174 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20171221/0804f19a/attachment-0001.p7s>