i40e: program fragmented IPv4 filter input set
Subsystems (2)
PATCH 11/13 i40e: program fragmented IPv4 filter input set
From: Jacob Keller <[email protected]>
When implementing support for IP_USER_FLOW filters, we correctly programmed a filter for both the non fragmented IPv4/Other filter, as well as the fragmented IPv4 filters. However, we did not properly program the input set for fragmented IPv4 PCTYPE. This meant that the filters would almost certainly not match, unless the user specified all of the flow types.
Add support to program the fragmented IPv4 filter input set. Since we always program these filters together, we'll assume that the two input sets must match, and will thus always program the input sets to the same value.
--- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 10 ++++++++++ drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +++ 2 files changed, 13 insertions(+)
drivers/net/ethernet/intel/i40e/i40e_ethtool.c +10 -0
@@ -3809,6 +3809,16 @@ static int i40e_check_fdir_input_set(struct i40e_vsi *vsi,i40e_write_fd_input_set (pf, index, new_mask); +/* IP_USER_FLOW filters match both IPv4/Other and IPv4/Fragmented +* frames. If we're programming the input set for IPv4/Other, we also +* need to program the IPv4/Fragmented input set. Since we don't have +* separate support, we'll always assume and enforce that the two flow +* types must have matching input sets. +*/ +if (index ==I40E_FILTER_PCTYPE_NONF_IPV4_OTHER ) +i40e_write_fd_input_set (pf,I40E_FILTER_PCTYPE_FRAG_IPV4 , + new_mask); +/* Add the new offset and update table, if necessary */ if (new_flex_offset) { err = i40e_add_flex_offset(&pf->l4_flex_pit_list, src_offset,
drivers/net/ethernet/intel/i40e/i40e_main.c +3 -0
@@ -7736,6 +7736,9 @@ static void i40e_fdir_filter_exit(struct i40e_pf *pf)/* Reprogram the default input set for Other/IPv4 */ i40e_write_fd_input_set (pf,I40E_FILTER_PCTYPE_NONF_IPV4_OTHER ,I40E_L3_SRC_MASK |I40E_L3_DST_MASK ); + +i40e_write_fd_input_set (pf,I40E_FILTER_PCTYPE_FRAG_IPV4 , +I40E_L3_SRC_MASK |I40E_L3_DST_MASK ); }/**
Signature · 1 line
2.9.5
Bowers
PATCH 11/13 i40e: program fragmented IPv4 filter input set
Quoted 21 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Alice Michael
Sent: Wednesday, December 27, 2017 5:24 AM
To: Michael, Alice <[email protected]>; intel-wired- lan at lists.osuosl.org
Subject: [Intel-wired-lan] [next PATCH S84-V2 11/13] i40e: program fragmented IPv4 filter input setFrom: Jacob Keller <[email protected]>
When implementing support for
IP_USER_FLOWfilters, we correctly programmed a filter for both the non fragmented IPv4/Other filter, as well as the fragmented IPv4 filters. However, we did not properly program the input set for fragmented IPv4 PCTYPE. This meant that the filters would almost certainly not match, unless the user specified all of the flow types.Add support to program the fragmented IPv4 filter input set. Since we always program these filters together, we'll assume that the two input sets must match, and will thus always program the input sets to the same value.
Quoted 5 lines
Signed-off-by Jacob Keller <[email protected]>--- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 10 ++++++++++ drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +++ 2 files changed, 13 insertions(+)