replay additions
v4 cover replay additions
Accidentally sent draft version of patches to the mailing list. Please consider this one as the correct one.
This set of patches includex fixes from Alex Bennée for fixing BQL and replay locks after inventing the MTTCG. It also includes some additional replay patches that makes this set of fixes working. It is also fixes some vmstate creation (and loading) issues in record/replay modes:
- VM start/stop fixes in replay mode
- overlay creation for blkreplay filter
- fixes for vmstate save/load in record/replay mode
- fixes for host clock vmstate
There is also a set of helper scripts written by Alex Bennée for debugging the record/replay code.
v4 changes:
- removed upstreamed patches
- added patch for saving async queue state in replay
- minor fixes
v3 changes:
- removed upstreamed patches
- fixed bug with recursive checkpoints
- fixed bug with icount warp checkpoint
v2 changes:
- updated lock/unlock logic (as suggested by Paolo Bonzini)
- updated cpu execution loop to avoid races in setting/resetting exit request (as suggested by Paolo Bonzini)
- minor changes
---
Alex Bennée (8):
target/arm/arm-powertctl: drop BQL assertions
cpus: push BQL lock to qemu_*_wait_io_event
cpus: only take BQL for sleeping threads replay/replay.c: bump REPLAY_VERSION again replay/replay-internal.c: track holding of replay_lock
replay: make locking visible outside replay code
replay: push replay_mutex_lock up the call tree scripts/replay-dump.py: replay log dumper
Pavel Dovgalyuk (15):
This patch adds a condition before overwriting exception_index fields.
block: implement bdrv_snapshot_goto for blkreplay
blkreplay: create temporary overlay for underlaying devices
replay: disable default snapshot for record/replay
replay: fix processing async events
replay: fixed replay_enable_events
replay: fix save/load vm for non-empty queue
replay: added replay log format description
replay: make safe vmstop at record/replay
replay: save prior value of the host clock
replay: don't destroy mutex at exit
replay: check return values of fwrite
replay: avoid recursive call of checkpoints
replay: don't process async events when warping the clock
replay: save vmstate of the asynchronous events
accel/kvm/kvm-all.c | 4 - accel/tcg/cpu-exec.c | 5 + block/blkreplay.c | 73 +++++++++++ cpus-common.c | 13 +- cpus.c | 46 +++++-- docs/replay.txt | 91 +++++++++++++ dtc | 2 include/qemu/timer.h | 14 ++ include/sysemu/replay.h | 19 +++ migration/savevm.c | 13 ++ replay/replay-char.c | 21 +-- replay/replay-events.c | 73 +++++------ replay/replay-internal.c | 48 ++++++- replay/replay-internal.h | 15 ++ replay/replay-snapshot.c | 12 ++ replay/replay-time.c | 10 + replay/replay.c | 62 ++++++--- scripts/replay-dump.py | 308 +++++++++++++++++++++++++++++++++++++++++++++ stubs/replay.c | 16 ++ target/arm/arm-powerctl.c | 8 - target/i386/hax-all.c | 2 util/main-loop.c | 17 ++ util/qemu-timer.c | 12 ++ vl.c | 12 +- 24 files changed, 764 insertions(+), 132 deletions(-) create mode 100755 scripts/replay-dump.py
Signature · 1 line
Pavel Dovgalyuk
RFC PATCH v4 1/23 This patch adds a condition before overwriting exception_index fields.
It is needed when exception_index is already set to some meaningful value.
--- accel/tcg/cpu-exec.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
accel/tcg/cpu-exec.c +4 -1
@@ -585,6 +585,7 @@ static inline bool cpu_handle_interrupt(CPUState *cpu,else {if (cc->cpu_exec_interrupt (cpu, interrupt_request)) {replay_interrupt (); + cpu->exception_index =-1 ; *last_tb =NULL ; }/* The target hook may have updated the 'cpu->interrupt_request';
@@ -606,7 +607,9 @@ static inline bool cpu_handle_interrupt(CPUState *cpu,if (unlikely (atomic_read (&cpu->exit_request) || (use_icount && cpu->icount_decr.u16.low + cpu->icount_extra ==0 ))) {atomic_set (&cpu->exit_request,0 ); - cpu->exception_index =EXCP_INTERRUPT ; +if (cpu->exception_index ==-1 ) { + cpu->exception_index =EXCP_INTERRUPT ; + }return true; }
RFC PATCH v4 2/23 block: implement bdrv_snapshot_goto for blkreplay
In reply to Pavel DovgalyukFrom: Pavel Dovgalyuk <[email protected]>
This patch enables making snapshots with blkreplay used in block devices.
This function is required to make bdrv_snapshot_goto without calling .bdrv_open which is not implemented.
--- block/blkreplay.c | 8 ++++++++ 1 file changed, 8 insertions(+)
block/blkreplay.c +8 -0
@@ -127,6 +127,12 @@ static int coroutine_fn blkreplay_co_flush(BlockDriverState *bs)return ret; } +static int blkreplay_snapshot_goto (BlockDriverState *bs, +const char *snapshot_id) +{ +return bdrv_snapshot_goto (bs->file->bs, snapshot_id,NULL ); +} +static BlockDriver bdrv_blkreplay = { .format_name ="blkreplay" , .protocol_name ="blkreplay" ,
@@ -143,6 +149,8 @@ static BlockDriver bdrv_blkreplay = { .bdrv_co_pwrite_zeroes = blkreplay_co_pwrite_zeroes, .bdrv_co_pdiscard = blkreplay_co_pdiscard, .bdrv_co_flush = blkreplay_co_flush, + + .bdrv_snapshot_goto = blkreplay_snapshot_goto, };static void bdrv_blkreplay_init (void )
RFC PATCH v4 3/23 blkreplay: create temporary overlay for underlaying devices
In reply to Pavel DovgalyukFrom: Pavel Dovgalyuk <[email protected]>
This patch allows using '-snapshot' behavior in record/replay mode. blkreplay layer creates temporary overlays on top of underlaying disk images. It is needed, because creating an overlay over blkreplay breaks the determinism.
This patch creates similar temporary overlay (when it is needed) under the blkreplay driver. Therefore all block operations are controlled by blkreplay.
--- block/blkreplay.c | 65 +++++++++++++++++++++++++++++++++++++++++++++++++++++ stubs/replay.c | 1 + vl.c | 2 +- 3 files changed, 67 insertions(+), 1 deletion(-)
block/blkreplay.c +65 -0
@@ -14,12 +14,69 @@#include "block/block_int.h" #include "sysemu/replay.h" #include "qapi/error.h" +#include "qapi/qmp/qstring.h" typedef struct Request {Coroutine *co;QEMUBH *bh; }Request ; +static BlockDriverState *blkreplay_append_snapshot (BlockDriverState *bs, +Error **errp) +{ +int ret; +BlockDriverState *bs_snapshot; +int64_t total_size; +QemuOpts *opts =NULL ; +char tmp_filename[PATH_MAX +1 ]; +QDict *snapshot_options =qdict_new (); + +/* Prepare options QDict for the overlay file */ +qdict_put (snapshot_options,"file.driver" ,qstring_from_str ("file" )); +qdict_put (snapshot_options,"driver" ,qstring_from_str ("qcow2" )); + +/* Create temporary file */ + ret =get_tmp_filename (tmp_filename,PATH_MAX +1 ); +if (ret <0 ) { +error_setg_errno (errp, -ret,"Could not get temporary filename" ); + goto out; + } +qdict_put (snapshot_options,"file.filename" , +qstring_from_str (tmp_filename)); + +/* Get the required size from the image */ + total_size =bdrv_getlength (bs); +if (total_size <0 ) { +error_setg_errno (errp, -total_size,"Could not get image size" ); + goto out; + } + + opts =qemu_opts_create (bdrv_qcow2.create_opts,NULL ,0 , &error_abort); +qemu_opt_set_number (opts,BLOCK_OPT_SIZE , total_size, &error_abort); + ret =bdrv_create (&bdrv_qcow2, tmp_filename, opts, errp); +qemu_opts_del (opts); +if (ret <0 ) { +error_prepend (errp,"Could not create temporary overlay '%s': " , + tmp_filename); + goto out; + } + + bs_snapshot =bdrv_open (NULL ,NULL , snapshot_options, +BDRV_O_RDWR |BDRV_O_TEMPORARY , errp); + snapshot_options =NULL ; +if (!bs_snapshot) { + goto out; + } + +bdrv_append (bs_snapshot, bs, errp); + +return bs_snapshot; + +out: +QDECREF (snapshot_options); +return NULL ; +} +static int blkreplay_open (BlockDriverState *bs,QDict *options,int flags,Error **errp) {
@@ -35,6 +92,14 @@ static int blkreplay_open(BlockDriverState *bs, QDict *options, int flags, goto fail; } +/* Add temporary snapshot to preserve the image */ +if (!replay_snapshot + && !blkreplay_append_snapshot (bs->file->bs, &local_err)) { + ret = -EINVAL ; +error_propagate (errp, local_err); + goto fail; + } + ret =0 ; fail:return ret;
stubs/replay.c +1 -0
@@ -3,6 +3,7 @@#include "sysemu/sysemu.h" ReplayMode replay_mode; +char *replay_snapshot;int64_t replay_save_clock (unsigned int kind,int64_t clock) {
vl.c +1 -1
@@ -4548,7 +4548,7 @@ int main(int argc, char **argv, char **envp)qapi_free_BlockdevOptions (bdo->bdo);g_free (bdo); } -if (snapshot || replay_mode !=REPLAY_MODE_NONE ) { +if (snapshot) {qemu_opts_foreach (qemu_find_opts ("drive" ), drive_enable_snapshot,NULL ,NULL ); }
RFC PATCH v4 4/23 replay: disable default snapshot for record/replay
In reply to Pavel DovgalyukFrom: Pavel Dovgalyuk <[email protected]>
This patch disables setting '-snapshot' option on by default in record/replay mode. This is needed for creating vmstates in record and replay modes.
--- vl.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
vl.c +7 -1
@@ -3251,7 +3251,13 @@ int main(int argc, char **argv, char **envp)drive_add (IF_PFLASH ,-1 , optarg,PFLASH_OPTS );break ;case QEMU_OPTION_snapshot: - snapshot =1 ; + { +Error *blocker =NULL ; + snapshot =1 ; +error_setg (&blocker,QERR_REPLAY_NOT_SUPPORTED , +"-snapshot" ); +replay_add_blocker (blocker); + }break ;case QEMU_OPTION_numa: opts = qemu_opts_parse_noisily(qemu_find_opts("numa"),
RFC PATCH v4 5/23 replay: fix processing async events
In reply to Pavel DovgalyukAsynchronous events saved at checkpoints may invoke callbacks when processed. These callbacks may also generate/read new events (e.g. clock reads). Therefore event processing flag must be reset before callback invocation.
--- replay/replay-events.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
replay/replay-events.c +2 -2
@@ -295,13 +295,13 @@ void replay_read_events(int checkpoint)if (!event) {break ; } +replay_finish_event (); + read_event_kind =-1 ;replay_mutex_unlock ();replay_run_event (event);replay_mutex_lock ();g_free (event); -replay_finish_event (); - read_event_kind =-1 ; } }
RFC PATCH v4 6/23 replay: fixed replay_enable_events
In reply to Pavel DovgalyukThis patch fixes assignment to internal events_enabled variable. Now it is set only in record/replay mode. This affects the behavior of the external functions that check this flag.
--- replay/replay-events.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
replay/replay-events.c +5 -3
@@ -67,7 +67,9 @@ static void replay_run_event(Event *event)void replay_enable_events (void ) { - events_enabled = true; +if (replay_mode !=REPLAY_MODE_NONE ) { + events_enabled = true; + } }bool replay_has_events (void )
@@ -141,7 +143,7 @@ void replay_add_event(ReplayAsyncEventKind event_kind,void replay_bh_schedule_event (QEMUBH *bh) { -if (replay_mode !=REPLAY_MODE_NONE && events_enabled) { +if (events_enabled) {uint64_t id =replay_get_current_step ();replay_add_event (REPLAY_ASYNC_EVENT_BH , bh,NULL , id); }else {
@@ -161,7 +163,7 @@ void replay_add_input_sync_event(void)void replay_block_event (QEMUBH *bh,uint64_t id) { -if (replay_mode !=REPLAY_MODE_NONE && events_enabled) { +if (events_enabled) {replay_add_event (REPLAY_ASYNC_EVENT_BLOCK , bh,NULL , id); }else {qemu_bh_schedule (bh);
RFC PATCH v4 7/23 replay: fix save/load vm for non-empty queue
In reply to Pavel DovgalyukThis patch does not allows saving/loading vmstate when replay events queue is not empty. There is no reliable way to save events queue, because it describes internal coroutine state. Therefore saving and loading operations should be deferred to another record/replay step.
--
v2: fixed error_report calls
--- include/sysemu/replay.h | 3 +++ migration/savevm.c | 13 +++++++++++++ replay/replay-snapshot.c | 6 ++++++ 3 files changed, 22 insertions(+)
include/sysemu/replay.h +3 -0
@@ -165,5 +165,8 @@ void replay_audio_in(int *recorded, void *samples, int *wpos, int size);/*! Called at the start of execution. Loads or saves initial vmstate depending on execution mode. */ void replay_vmstate_init (void ); +/*! Called to ensure that replay state is consistent and VM snapshot +can be created */ +bool replay_can_snapshot (void );#endif
migration/savevm.c +13 -0
@@ -52,6 +52,7 @@#include "qemu/cutils.h" #include "io/channel-buffer.h" #include "io/channel-file.h" +#include "sysemu/replay.h" #ifndef ETH_P_RARP #define ETH_P_RARP 0x8035
@@ -2141,6 +2142,12 @@ int save_snapshot(const char *name, Error **errp)struct tm tm;AioContext *aio_context; +if (!replay_can_snapshot ()) { +error_report ("Record/replay does not allow making snapshot " +"right now. Try once more later." ); +return ret; + } +if (!bdrv_all_can_snapshot (&bs)) {error_setg (errp,"Device '%s' is writable but does not support " "snapshots" ,bdrv_get_device_name (bs));
@@ -2331,6 +2338,12 @@ int load_snapshot(const char *name, Error **errp)AioContext *aio_context;MigrationIncomingState *mis =migration_incoming_get_current (); +if (!replay_can_snapshot ()) { +error_report ("Record/replay does not allow loading snapshot " +"right now. Try once more later." ); +return -EINVAL ; + } +if (!bdrv_all_can_snapshot (&bs)) { error_setg(errp, "Device '%s' is writable but does not support snapshots",
replay/replay-snapshot.c +6 -0
@@ -83,3 +83,9 @@ void replay_vmstate_init(void) } } } + +bool replay_can_snapshot (void ) +{ +return replay_mode ==REPLAY_MODE_NONE + || !replay_has_events (); +}
RFC PATCH v4 8/23 replay: added replay log format description
In reply to Pavel DovgalyukFrom: Pavel Dovgalyuk <[email protected]>
This patch adds description of the replay log file format into the docs/replay.txt.
--- docs/replay.txt | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 69 insertions(+)
docs/replay.txt +69 -0
@@ -232,3 +232,72 @@ Audio devices Audio data is recorded and replay automatically. The command line for recording and replaying must contain identical specifications of audio hardware, e.g.: -soundhw ac97 + +Replay log format +----------------- + +Record/replay log consits of the header and the sequence of execution +events. The header includes 4-byte replay version id and 8-byte reserved +field. Version is updated every time replay log format changes to prevent +using replay log created by another build of qemu. + +The sequence of the events describes virtual machine state changes. +It includes all non-deterministic inputs of VM, synchronization marks and +instruction counts used to correctly inject inputs at replay. + +Synchronization marks (checkpoints) are used for synchronizing qemu threads +that perform operations with virtual hardware. These operations may change +system's state (e.g., change some register or generate interrupt) and +therefore should execute synchronously with CPU thread. + +Every event in the log includes 1-byte event id and optional arguments. +When argument is an array, it is stored as 4-byte array length +and corresponding number of bytes with data. +Here is the list of events that are written into the log: + + - EVENT_INSTRUCTION. Instructions executed since last event. + Argument: 4-byte number of executed instructions. + - EVENT_INTERRUPT. Used to synchronize interrupt processing. + - EVENT_EXCEPTION. Used to synchronize exception handling. + - EVENT_ASYNC. This is a group of events. They are always processed + together with checkpoints. When such an event is generated, it is + stored in the queue and processed only when checkpoint occurs. + Every such event is followed by 1-byte checkpoint id and 1-byte + async event id from the following list: + - REPLAY_ASYNC_EVENT_BH. Bottom-half callback. This event synchronizes + callbacks that affect virtual machine state, but normally called + asyncronously. + Argument: 8-byte operation id. + - REPLAY_ASYNC_EVENT_INPUT. Input device event. Contains + parameters of keyboard and mouse input operations + (key press/release, mouse pointer movement). + Arguments: 9-16 bytes depending of input event. + - REPLAY_ASYNC_EVENT_INPUT_SYNC. Internal input synchronization event. + - REPLAY_ASYNC_EVENT_CHAR_READ. Character (e.g., serial port) device input + initiated by the sender. + Arguments: 1-byte character device id. + Array with bytes were read. + - REPLAY_ASYNC_EVENT_BLOCK. Block device operation. Used to synchronize + operations with disk and flash drives with CPU. + Argument: 8-byte operation id. + - REPLAY_ASYNC_EVENT_NET. Incoming network packet. + Arguments: 1-byte network adapter id. + 4-byte packet flags. + Array with packet bytes. + - EVENT_SHUTDOWN. Occurs when user sends shutdown event to qemu, + e.g., by closing the window. + - EVENT_CHAR_WRITE. Used to synchronize character output operations. + Arguments: 4-byte output function return value. + 4-byte offset in the output array. + - EVENT_CHAR_READ_ALL. Used to synchronize character input operations, + initiated by qemu. + Argument: Array with bytes that were read. + - EVENT_CHAR_READ_ALL_ERROR. Unsuccessful character input operation, + initiated by qemu. + Argument: 4-byte error code. + - EVENT_CLOCK + clock_id. Group of events for host clock read operations. + Argument: 8-byte clock value. + - EVENT_CHECKPOINT + checkpoint_id. Checkpoint for synchronization of + CPU, internal threads, and asynchronous input events. May be followed + by one or more EVENT_ASYNC events. + - EVENT_END. Last event in the log.
RFC PATCH v4 9/23 replay: make safe vmstop at record/replay
In reply to Pavel DovgalyukFrom: Pavel Dovgalyuk <[email protected]>
This patch disables bdrv flush/drain in record/replay mode. When block request is in the replay queue it cannot be processed with drain/flush until it is found in the log. Therefore vm should just stop leaving unfinished operations in the queue.
--- cpus.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
cpus.c +4 -3
@@ -1004,9 +1004,10 @@ static int do_vm_stop(RunState state)qapi_event_send_stop (&error_abort); } -bdrv_drain_all (); -replay_disable_events (); - ret =bdrv_flush_all (); +if (!replay_events_enabled ()) { +bdrv_drain_all (); + ret =bdrv_flush_all (); + }return ret; }
RFC PATCH v4 10/23 replay: save prior value of the host clock
In reply to Pavel DovgalyukThis patch adds saving/restoring of the host clock field 'last'. It is used in host clock calculation and therefore clock may become incorrect when using restored vmstate.
--- include/qemu/timer.h | 14 ++++++++++++++ replay/replay-internal.h | 2 ++ replay/replay-snapshot.c | 3 +++ util/qemu-timer.c | 12 ++++++++++++ 4 files changed, 31 insertions(+)
include/qemu/timer.h +14 -0
@@ -251,6 +251,20 @@ bool qemu_clock_run_timers(QEMUClockType type);*/ bool qemu_clock_run_all_timers (void ); +/** +* qemu_clock_get_last: +* +* Returns last clock query time. +*/ +uint64_t qemu_clock_get_last (QEMUClockType type); +/** +* qemu_clock_set_last: +* +* Sets last clock query time. +*/ +void qemu_clock_set_last (QEMUClockType type,uint64_t last); + +/* * QEMUTimerList */
replay/replay-internal.h +2 -0
@@ -78,6 +78,8 @@ typedef struct ReplayState {This counter is global, because requests from different block devices should not get overlapping ids. */ uint64_t block_request_id; +/*! Prior value of the host clock */ +uint64_t host_clock_last; } ReplayState;extern ReplayState replay_state;
replay/replay-snapshot.c +3 -0
@@ -25,6 +25,7 @@ static int replay_pre_save(void *opaque) {ReplayState *state = opaque; state->file_offset =ftell (replay_file); + state->host_clock_last =qemu_clock_get_last (QEMU_CLOCK_HOST );return 0 ; }
@@ -33,6 +34,7 @@ static int replay_post_load(void *opaque, int version_id) {ReplayState *state = opaque;fseek (replay_file, state->file_offset,SEEK_SET ); +qemu_clock_set_last (QEMU_CLOCK_HOST , state->host_clock_last);/* If this was a vmstate, saved in recording mode, we need to initialize replay data fields. */ replay_fetch_data_kind ();
@@ -54,6 +56,7 @@ static const VMStateDescription vmstate_replay = { VMSTATE_UINT32(has_unread_data, ReplayState), VMSTATE_UINT64(file_offset, ReplayState), VMSTATE_UINT64(block_request_id, ReplayState), + VMSTATE_UINT64(host_clock_last, ReplayState),VMSTATE_END_OF_LIST () }, };
util/qemu-timer.c +12 -0
@@ -622,6 +622,18 @@ int64_t qemu_clock_get_ns(QEMUClockType type) } } +uint64_t qemu_clock_get_last (QEMUClockType type) +{ +QEMUClock *clock =qemu_clock_ptr (type); +return clock->last; +} + +void qemu_clock_set_last (QEMUClockType type,uint64_t last) +{ +QEMUClock *clock =qemu_clock_ptr (type); + clock->last = last; +} +void qemu_clock_register_reset_notifier (QEMUClockType type,Notifier *notifier) {
RFC PATCH v4 11/23 target/arm/arm-powertctl: drop BQL assertions
In reply to Pavel DovgalyukFrom: Alex Bennée <[email protected]>
The powerctl code is run in the context of the vCPU changing power state. It does not need the BQL to protect its changes.
--- target/arm/arm-powerctl.c | 8 -------- 1 file changed, 8 deletions(-)
target/arm/arm-powerctl.c +0 -8
@@ -124,7 +124,6 @@ static void arm_set_cpu_on_async_work(CPUState *target_cpu_state,g_free (info);/* Finally set the power status */ -assert (qemu_mutex_iothread_locked ()); target_cpu->power_state =PSCI_ON ; }
@@ -135,8 +134,6 @@ int arm_set_cpu_on(uint64_t cpuid, uint64_t entry, uint64_t context_id,ARMCPU *target_cpu;struct CpuOnInfo *info; -assert (qemu_mutex_iothread_locked ()); -DPRINTF ("cpu %" PRId64" (EL %d, %s) @ 0x%" PRIx64" with R0 = 0x%" PRIx64"\n" , cpuid, target_el, target_aa64 ?"aarch64" :"aarch32" , entry, context_id);
@@ -227,7 +224,6 @@ static void arm_set_cpu_off_async_work(CPUState *target_cpu_state, {ARMCPU *target_cpu =ARM_CPU (target_cpu_state); -assert (qemu_mutex_iothread_locked ()); target_cpu->power_state =PSCI_OFF ; target_cpu_state->halted =1 ; target_cpu_state->exception_index =EXCP_HLT ;
@@ -238,8 +234,6 @@ int arm_set_cpu_off(uint64_t cpuid)CPUState *target_cpu_state;ARMCPU *target_cpu; -assert (qemu_mutex_iothread_locked ()); -DPRINTF ("cpu %" PRId64"\n" , cpuid);/* change to the cpu we are powering up */
@@ -274,8 +268,6 @@ int arm_reset_cpu(uint64_t cpuid)CPUState *target_cpu_state;ARMCPU *target_cpu; -assert (qemu_mutex_iothread_locked ()); -DPRINTF ("cpu %" PRId64"\n" , cpuid);/* change to the cpu we are resetting */
RFC PATCH v4 12/23 cpus: push BQL lock to qemu_*_wait_io_event
In reply to Pavel DovgalyukFrom: Alex Bennée <[email protected]>
We only really need to grab the lock for initial setup (so we don't race with the thread-spawning thread). After that we can drop the lock for the whole main loop and only grab it for waiting for IO events.
There is a slight wrinkle for the round-robin TCG thread as we also expire timers which needs to be done under BQL as they are in the main-loop.
This is stage one of reducing the lock impact as we can drop the requirement of implicit BQL for async work and only grab the lock when we need to sleep on the cpu->halt_cond.
--- accel/kvm/kvm-all.c | 4 ---- cpus.c | 22 +++++++++++++++------- dtc | 2 +- target/i386/hax-all.c | 2 -- 4 files changed, 16 insertions(+), 14 deletions(-)
accel/kvm/kvm-all.c +0 -4
@@ -1857,9 +1857,7 @@ int kvm_cpu_exec(CPUState *cpu)return EXCP_HLT ; } -qemu_mutex_unlock_iothread ();cpu_exec_start (cpu); - do { MemTxAttrs attrs;
@@ -1989,8 +1987,6 @@ int kvm_cpu_exec(CPUState *cpu) }while (ret ==0 );cpu_exec_end (cpu); -qemu_mutex_lock_iothread (); -if (ret <0 ) {cpu_dump_state (cpu, stderr, fprintf,CPU_DUMP_CODE );vm_stop (RUN_STATE_INTERNAL_ERROR );
cpus.c +15 -7
@@ -1150,10 +1150,14 @@ static void qemu_tcg_rr_wait_io_event(CPUState *cpu)start_tcg_kick_timer ();qemu_wait_io_event_common (cpu); + +qemu_mutex_unlock_iothread (); }static void qemu_wait_io_event (CPUState *cpu) { +qemu_mutex_lock_iothread (); +while (cpu_thread_is_idle (cpu)) {qemu_cond_wait (cpu->halt_cond, &qemu_global_mutex); }
@@ -1190,6 +1194,8 @@ static void *qemu_kvm_cpu_thread_fn(void *arg)/* signal CPU creation */ cpu->created = true; +qemu_mutex_unlock_iothread (); +qemu_cond_signal (&qemu_cpu_cond); do {
@@ -1232,10 +1238,10 @@ static void *qemu_dummy_cpu_thread_fn(void *arg)/* signal CPU creation */ cpu->created = true; +qemu_mutex_unlock_iothread ();qemu_cond_signal (&qemu_cpu_cond);while (1 ) { -qemu_mutex_unlock_iothread (); do { int sig; r = sigwait(&waitset, &sig);
@@ -1246,6 +1252,7 @@ static void *qemu_dummy_cpu_thread_fn(void *arg) }qemu_mutex_lock_iothread ();qemu_wait_io_event (cpu); +qemu_mutex_unlock_iothread (); }return NULL ;
@@ -1334,11 +1341,9 @@ static int tcg_cpu_exec(CPUState *cpu)#ifdef CONFIG_PROFILER ti =profile_getclock ();#endif -qemu_mutex_unlock_iothread ();cpu_exec_start (cpu); ret =cpu_exec (cpu);cpu_exec_end (cpu); -qemu_mutex_lock_iothread ();#ifdef CONFIG_PROFILER tcg_time +=profile_getclock () - ti;#endif
@@ -1398,6 +1403,7 @@ static void *qemu_tcg_rr_cpu_thread_fn(void *arg)qemu_wait_io_event_common (cpu); } } +qemu_mutex_unlock_iothread ();start_tcg_kick_timer ();
@@ -1407,6 +1413,8 @@ static void *qemu_tcg_rr_cpu_thread_fn(void *arg) cpu->exit_request =1 ;while (1 ) { +qemu_mutex_lock_iothread (); +/* Account partial waits to QEMU_CLOCK_VIRTUAL. */ qemu_account_warp_timer ();
@@ -1415,6 +1423,8 @@ static void *qemu_tcg_rr_cpu_thread_fn(void *arg)*/ handle_icount_deadline (); +qemu_mutex_unlock_iothread (); +if (!cpu) { cpu = first_cpu; }
@@ -1440,9 +1450,7 @@ static void *qemu_tcg_rr_cpu_thread_fn(void *arg)cpu_handle_guest_debug (cpu);break ; }else if (r ==EXCP_ATOMIC ) { -qemu_mutex_unlock_iothread ();cpu_exec_step_atomic (cpu); -qemu_mutex_lock_iothread ();break ; } }else if (cpu->stop) {
@@ -1483,6 +1491,7 @@ static void *qemu_hax_cpu_thread_fn(void *arg) current_cpu = cpu;hax_init_vcpu (cpu); +qemu_mutex_unlock_iothread ();qemu_cond_signal (&qemu_cpu_cond);while (1 ) {
@@ -1569,6 +1578,7 @@ static void *qemu_tcg_cpu_thread_fn(void *arg) cpu->created = true; cpu->can_do_io =1 ; current_cpu = cpu; +qemu_mutex_unlock_iothread ();qemu_cond_signal (&qemu_cpu_cond);/* process any pending work */
@@ -1593,9 +1603,7 @@ static void *qemu_tcg_cpu_thread_fn(void *arg)g_assert (cpu->halted);break ;case EXCP_ATOMIC : -qemu_mutex_unlock_iothread ();cpu_exec_step_atomic (cpu); -qemu_mutex_lock_iothread ();default :/* Ignore everything else? */ break ;
dtc +1 -1
@@ -1 +1 @@ -Subproject commit e54388015af1fb4bf04d0bca99caba1074d9cc42 +Subproject commit 558cd81bdd432769b59bff01240c44f82cfb1a9d
target/i386/hax-all.c +0 -2
@@ -513,11 +513,9 @@ static int hax_vcpu_hax_exec(CPUArchState *env)hax_vcpu_interrupt (env); -qemu_mutex_unlock_iothread ();cpu_exec_start (cpu); hax_ret =hax_vcpu_run (vcpu);cpu_exec_end (cpu); -qemu_mutex_lock_iothread ();/* Simply continue the vcpu_run if system call interrupted */ if (hax_ret == -EINTR || hax_ret == -EAGAIN ) {
RFC PATCH v4 13/23 cpus: only take BQL for sleeping threads
In reply to Pavel DovgalyukFrom: Alex Bennée <[email protected]>
Now the only real need to hold the BQL is for when we sleep on the cpu->halt conditional. The lock is actually dropped while the thread sleeps so the actual window for contention is pretty small. This also means we can remove the special case hack for exclusive work and simply declare that work no longer has an implicit BQL held. This isn't a major problem async work is generally only changing things in the context of its own vCPU. If it needs to work across vCPUs it should be using the exclusive mechanism or possibly taking the lock itself.
--- cpus-common.c | 13 +++++-------- cpus.c | 7 ++++--- 2 files changed, 9 insertions(+), 11 deletions(-)
cpus-common.c +5 -8
@@ -310,6 +310,11 @@ void async_safe_run_on_cpu(CPUState *cpu, run_on_cpu_func func,queue_work_on_cpu (cpu, wi); } +/* Work items run outside of the BQL. This is essential for avoiding a +* deadlock for exclusive work but also applies to non-exclusive work. +* If the work requires cross-vCPU changes then it should use the +* exclusive mechanism. +*/ void process_queued_cpu_work (CPUState *cpu) {struct qemu_work_item *wi;
@@ -327,17 +332,9 @@ void process_queued_cpu_work(CPUState *cpu) }qemu_mutex_unlock (&cpu->work_mutex);if (wi->exclusive) { -/* Running work items outside the BQL avoids the following deadlock: -* 1) start_exclusive() is called with the BQL taken while another -* CPU is running; 2) cpu_exec in the other CPU tries to takes the -* BQL, so it goes to sleep; start_exclusive() is sleeping too, so -* neither CPU can proceed. -*/ -qemu_mutex_unlock_iothread ();start_exclusive (); wi->func (cpu, wi->data);end_exclusive (); -qemu_mutex_lock_iothread (); }else { wi->func (cpu, wi->data); }
cpus.c +4 -3
@@ -1143,23 +1143,24 @@ static void qemu_wait_io_event_common(CPUState *cpu)static void qemu_tcg_rr_wait_io_event (CPUState *cpu) {while (all_cpu_threads_idle ()) { +qemu_mutex_lock_iothread ();stop_tcg_kick_timer ();qemu_cond_wait (cpu->halt_cond, &qemu_global_mutex); +qemu_mutex_unlock_iothread (); }start_tcg_kick_timer ();qemu_wait_io_event_common (cpu); - -qemu_mutex_unlock_iothread (); }static void qemu_wait_io_event (CPUState *cpu) { -qemu_mutex_lock_iothread ();while (cpu_thread_is_idle (cpu)) { +qemu_mutex_lock_iothread ();qemu_cond_wait (cpu->halt_cond, &qemu_global_mutex); +qemu_mutex_unlock_iothread (); }#ifdef _WIN32
RFC PATCH v4 14/23 replay/replay.c: bump REPLAY_VERSION again
In reply to Pavel DovgalyukFrom: Alex Bennée <[email protected]>
This time commit 802f045a5f61b781df55e4492d896b4d20503ba7 broke the replay file format. Also add a comment about this to replay-internal.h.
--- replay/replay-internal.h | 2 +- replay/replay.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
replay/replay-internal.h +1 -1
@@ -12,7 +12,7 @@* */ - +/* Any changes to order/number of events will need to bump REPLAY_VERSION */ enum ReplayEvents {/* for instruction event */ EVENT_INSTRUCTION ,
replay/replay.c +1 -1
@@ -22,7 +22,7 @@/* Current version of the replay mechanism. Increase it when file format changes. */ -#define REPLAY_VERSION 0xe02006 +#define REPLAY_VERSION 0xe02007/* Size of replay log header */ #define HEADER_SIZE (sizeof(uint32_t) + sizeof(uint64_t))
RFC PATCH v4 15/23 replay/replay-internal.c: track holding of replay_lock
In reply to Pavel DovgalyukFrom: Alex Bennée <[email protected]>
This is modelled after the iothread mutex lock. We keep a TLS flag to indicate when that thread has acquired the lock and assert we don't double-lock or release when we shouldn't have.
--- replay/replay-internal.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
replay/replay-internal.c +11 -0
@@ -179,13 +179,24 @@ void replay_mutex_destroy(void)qemu_mutex_destroy (&lock); } +static __threadbool replay_locked; + +static bool replay_mutex_locked (void ) +{ +return replay_locked; +} +void replay_mutex_lock (void ) { +g_assert (!replay_mutex_locked ());qemu_mutex_lock (&lock); + replay_locked = true; }void replay_mutex_unlock (void ) { +g_assert (replay_mutex_locked ()); + replay_locked = false;qemu_mutex_unlock (&lock); }
RFC PATCH v4 16/23 replay: make locking visible outside replay code
In reply to Pavel DovgalyukFrom: Alex Bennée <[email protected]>
The replay_mutex_lock/unlock/locked functions are now going to be used for ensuring lock-step behaviour between the two threads. Make them public API functions and also provide stubs for non-QEMU builds on common paths.
--- include/sysemu/replay.h | 14 ++++++++++++++ replay/replay-internal.c | 9 ++++----- replay/replay-internal.h | 5 ++--- stubs/replay.c | 15 +++++++++++++++ 4 files changed, 35 insertions(+), 8 deletions(-)
include/sysemu/replay.h +14 -0
@@ -47,6 +47,20 @@ extern ReplayMode replay_mode;/* Name of the initial VM snapshot */ extern char *replay_snapshot; +/* Replay locking +* +* The locks are needed to protect the shared structures and log file +* when doing record/replay. They also are the main sync-point between +* the main-loop thread and the vCPU thread. This was a role +* previously filled by the BQL which has been busy trying to reduce +* its impact across the code. This ensures blocks of events stay +* sequential and reproducible. +*/ + +void replay_mutex_lock (void ); +void replay_mutex_unlock (void ); +bool replay_mutex_locked (void ); +/* Replay process control functions */ /*! Enables recording or saving event log with specified parameters */
replay/replay-internal.c +4 -5
@@ -169,6 +169,8 @@ void replay_finish_event(void)replay_fetch_data_kind (); } +static __threadbool replay_locked; +void replay_mutex_init (void ) {qemu_mutex_init (&lock);
@@ -179,9 +181,7 @@ void replay_mutex_destroy(void)qemu_mutex_destroy (&lock); } -static __threadbool replay_locked; - -static bool replay_mutex_locked (void ) +bool replay_mutex_locked (void ) {return replay_locked; }
@@ -204,7 +204,7 @@ void replay_mutex_unlock(void)void replay_save_instructions (void ) {if (replay_file && replay_mode ==REPLAY_MODE_RECORD ) { -replay_mutex_lock (); +g_assert (replay_mutex_locked ());int diff = (int )(replay_get_current_step () - replay_state.current_step);/* Time can only go forward */
@@ -215,6 +215,5 @@ void replay_save_instructions(void)replay_put_dword (diff); replay_state.current_step += diff; } -replay_mutex_unlock (); } }
replay/replay-internal.h +2 -3
@@ -100,12 +100,11 @@ int64_t replay_get_qword(void);void replay_get_array (uint8_t *buf,size_t *size);void replay_get_array_alloc (uint8_t **buf,size_t *size); -/* Mutex functions for protecting replay log file */ +/* Mutex functions for protecting replay log file and ensuring +* synchronisation between vCPU and main-loop threads. */ void replay_mutex_init (void );void replay_mutex_destroy (void ); -void replay_mutex_lock (void ); -void replay_mutex_unlock (void );/*! Checks error status of the file. */ void replay_check_error (void );
stubs/replay.c +15 -0
@@ -73,3 +73,18 @@ uint64_t blkreplay_next_id(void) {return 0 ; } + +void replay_mutex_lock (void ) +{ +abort (); +} + +void replay_mutex_unlock (void ) +{ +abort (); +} + +bool replay_mutex_locked (void ) +{ +return false; +}
RFC PATCH v4 17/23 replay: push replay_mutex_lock up the call tree
In reply to Pavel DovgalyukFrom: Alex Bennée <[email protected]>
Now instead of using the replay_lock to guard the output of the log we now use it to protect the whole execution section. This replaces what the BQL used to do when it was held during TCG execution.
We also introduce some rules for locking order - mainly that you cannot take the replay_mutex while holding the BQL. This leads to some slight sophistry during start-up and extending the replay_mutex_destroy function to unlock the mutex without checking for the BQL condition so it can be cleanly dropped in the non-replay case.
--
v2: updated replay_mutex_lock/unlock functions as suggested by Paolo Bonzini
updated docs
--- cpus.c | 16 ++++++++++++++++ docs/replay.txt | 22 ++++++++++++++++++++++ include/sysemu/replay.h | 2 ++ replay/replay-char.c | 21 ++++++++------------- replay/replay-events.c | 18 +++++------------- replay/replay-internal.c | 33 +++++++++++++++++++++++---------- replay/replay-time.c | 10 +++++----- replay/replay.c | 38 ++++++++++++++++++-------------------- util/main-loop.c | 17 +++++++++++++---- vl.c | 2 ++ 10 files changed, 114 insertions(+), 65 deletions(-)
cpus.c +16 -0
@@ -1313,6 +1313,8 @@ static void prepare_icount_for_run(CPUState *cpu) insns_left =MIN (0xffff , cpu->icount_budget); cpu->icount_decr.u16.low = insns_left; cpu->icount_extra = cpu->icount_budget - insns_left; + +replay_mutex_lock (); } }
@@ -1328,6 +1330,8 @@ static void process_icount_data(CPUState *cpu) cpu->icount_budget =0 ;replay_account_executed_instructions (); + +replay_mutex_unlock (); } }
@@ -1414,6 +1418,7 @@ static void *qemu_tcg_rr_cpu_thread_fn(void *arg) cpu->exit_request =1 ;while (1 ) { +replay_mutex_lock ();qemu_mutex_lock_iothread ();/* Account partial waits to QEMU_CLOCK_VIRTUAL. */
@@ -1426,6 +1431,8 @@ static void *qemu_tcg_rr_cpu_thread_fn(void *arg)qemu_mutex_unlock_iothread (); +replay_mutex_unlock (); +if (!cpu) { cpu = first_cpu; }
@@ -1732,12 +1739,21 @@ void pause_all_vcpus(void) } } +/* We need to drop the replay_lock so any vCPU threads woken up +* can finish their replay tasks +*/ +replay_mutex_unlock (); +while (!all_vcpus_paused ()) {qemu_cond_wait (&qemu_pause_cond, &qemu_global_mutex);CPU_FOREACH (cpu) {qemu_cpu_kick (cpu); } } + +qemu_mutex_unlock_iothread (); +replay_mutex_lock (); +qemu_mutex_lock_iothread (); }void cpu_resume (CPUState *cpu)
docs/replay.txt +22 -0
@@ -49,6 +49,28 @@ Modifications of qemu include: * recording/replaying user input (mouse and keyboard) * adding internal checkpoints for cpu and io synchronization +Locking and thread synchronisation +---------------------------------- + +Previously the synchronisation of the main thread and the vCPU thread +was ensured by the holding of the BQL. However the trend has been to +reduce the time the BQL was held across the system including under TCG +system emulation. As it is important that batches of events are kept +in sequence (e.g. expiring timers and checkpoints in the main thread +while instruction checkpoints are written by the vCPU thread) we need +another lock to keep things in lock-step. This role is now handled by +the replay_mutex_lock. It used to be held only for each event being +written but now it is held for a whole execution period. This results +in a deterministic ping-pong between the two main threads. + +As the BQL is now a finer grained lock than the replay_lock it is almost +certainly a bug, and a source of deadlocks, to take the +replay_mutex_lock while the BQL is held. This is enforced by an assert. +While the unlocks are usually in the reverse order, this is not +necessary; you can drop the replay_lock while holding the BQL, without +doing a more complicated unlock_iothread/replay_unlock/lock_iothread +sequence. + Non-deterministic events ------------------------
include/sysemu/replay.h +2 -0
@@ -63,6 +63,8 @@ bool replay_mutex_locked(void);/* Replay process control functions */ +/*! Enables and take replay locks (even if we don't use it) */ +void replay_init_locks (void );/*! Enables recording or saving event log with specified parameters */ void replay_configure (struct QemuOpts *opts);/*! Initializes timers used for snapshotting and enables events recording */
replay/replay-char.c +8 -13
@@ -96,25 +96,24 @@ void *replay_event_char_read_load(void)void replay_char_write_event_save (int res,int offset) { +g_assert (replay_mutex_locked ()); +replay_save_instructions (); -replay_mutex_lock ();replay_put_event (EVENT_CHAR_WRITE );replay_put_dword (res);replay_put_dword (offset); -replay_mutex_unlock (); }void replay_char_write_event_load (int *res,int *offset) { +g_assert (replay_mutex_locked ()); +replay_account_executed_instructions (); -replay_mutex_lock ();if (replay_next_event_is (EVENT_CHAR_WRITE )) { *res =replay_get_dword (); *offset =replay_get_dword ();replay_finish_event (); -replay_mutex_unlock (); }else { -replay_mutex_unlock ();error_report ("Missing character write event in the replay log" );exit (1 ); }
@@ -122,23 +121,21 @@ void replay_char_write_event_load(int *res, int *offset)int replay_char_read_all_load (uint8_t *buf) { -replay_mutex_lock (); +g_assert (replay_mutex_locked ()); +if (replay_next_event_is (EVENT_CHAR_READ_ALL )) {size_t size;int res;replay_get_array (buf, &size);replay_finish_event (); -replay_mutex_unlock (); res = (int )size;assert (res >=0 );return res; }else if (replay_next_event_is (EVENT_CHAR_READ_ALL_ERROR )) {int res =replay_get_dword ();replay_finish_event (); -replay_mutex_unlock ();return res; }else { -replay_mutex_unlock ();error_report ("Missing character read all event in the replay log" );exit (1 ); }
@@ -146,19 +143,17 @@ int replay_char_read_all_load(uint8_t *buf)void replay_char_read_all_save_error (int res) { +g_assert (replay_mutex_locked ());assert (res <0 );replay_save_instructions (); -replay_mutex_lock ();replay_put_event (EVENT_CHAR_READ_ALL_ERROR );replay_put_dword (res); -replay_mutex_unlock (); }void replay_char_read_all_save_buf (uint8_t *buf,int offset) { +g_assert (replay_mutex_locked ());replay_save_instructions (); -replay_mutex_lock ();replay_put_event (EVENT_CHAR_READ_ALL );replay_put_array (buf, offset); -replay_mutex_unlock (); }
replay/replay-events.c +5 -13
@@ -79,16 +79,14 @@ bool replay_has_events(void)void replay_flush_events (void ) { -replay_mutex_lock (); +g_assert (replay_mutex_locked ()); +while (!QTAILQ_EMPTY (&events_list)) {Event *event =QTAILQ_FIRST (&events_list); -replay_mutex_unlock ();replay_run_event (event); -replay_mutex_lock ();QTAILQ_REMOVE (&events_list, event, events);g_free (event); } -replay_mutex_unlock (); }void replay_disable_events (void )
@@ -102,14 +100,14 @@ void replay_disable_events(void)void replay_clear_events (void ) { -replay_mutex_lock (); +g_assert (replay_mutex_locked ()); +while (!QTAILQ_EMPTY (&events_list)) {Event *event =QTAILQ_FIRST (&events_list);QTAILQ_REMOVE (&events_list, event, events);g_free (event); } -replay_mutex_unlock (); }/*! Adds specified async event to the queue */
@@ -136,9 +134,8 @@ void replay_add_event(ReplayAsyncEventKind event_kind, event->opaque2 = opaque2; event->id = id; -replay_mutex_lock (); +g_assert (replay_mutex_locked ());QTAILQ_INSERT_TAIL (&events_list, event, events); -replay_mutex_unlock (); }void replay_bh_schedule_event (QEMUBH *bh)
@@ -210,10 +207,7 @@ void replay_save_events(int checkpoint)while (!QTAILQ_EMPTY (&events_list)) {Event *event =QTAILQ_FIRST (&events_list);replay_save_event (event, checkpoint); - -replay_mutex_unlock ();replay_run_event (event); -replay_mutex_lock ();QTAILQ_REMOVE (&events_list, event, events);g_free (event); }
@@ -299,9 +293,7 @@ void replay_read_events(int checkpoint) }replay_finish_event (); read_event_kind =-1 ; -replay_mutex_unlock ();replay_run_event (event); -replay_mutex_lock ();g_free (event); }
replay/replay-internal.c +23 -10
@@ -174,30 +174,43 @@ static __thread bool replay_locked;void replay_mutex_init (void ) {qemu_mutex_init (&lock); +/* Hold the mutex while we start-up */ +qemu_mutex_lock (&lock); + replay_locked = true; } -void replay_mutex_destroy (void ) +bool replay_mutex_locked (void ) { -qemu_mutex_destroy (&lock); +return replay_locked; } -bool replay_mutex_locked (void ) +void replay_mutex_destroy (void ) { -return replay_locked; +if (replay_mutex_locked ()) { +qemu_mutex_unlock (&lock); + } +qemu_mutex_destroy (&lock); } +/* Ordering constraints, replay_lock must be taken before BQL */ void replay_mutex_lock (void ) { -g_assert (!replay_mutex_locked ()); -qemu_mutex_lock (&lock); - replay_locked = true; +if (replay_mode !=REPLAY_MODE_NONE ) { +g_assert (!qemu_mutex_iothread_locked ()); +g_assert (!replay_mutex_locked ()); +qemu_mutex_lock (&lock); + replay_locked = true; + } } +/* BQL can't be held when releasing the replay_lock */ void replay_mutex_unlock (void ) { -g_assert (replay_mutex_locked ()); - replay_locked = false; -qemu_mutex_unlock (&lock); +if (replay_mode !=REPLAY_MODE_NONE ) { +g_assert (replay_mutex_locked ()); + replay_locked = false; +qemu_mutex_unlock (&lock); + } }/*! Saves cached instructions. */
replay/replay-time.c +5 -5
@@ -17,13 +17,13 @@int64_t replay_save_clock (ReplayClockKind kind,int64_t clock) { -replay_save_instructions ();if (replay_file) { -replay_mutex_lock (); +g_assert (replay_mutex_locked ()); + +replay_save_instructions ();replay_put_event (EVENT_CLOCK + kind);replay_put_qword (clock); -replay_mutex_unlock (); }return clock;
@@ -46,16 +46,16 @@ void replay_read_next_clock(ReplayClockKind kind)/*! Reads next clock event from the input. */ int64_t replay_read_clock (ReplayClockKind kind) { +g_assert (replay_file &&replay_mutex_locked ()); +replay_account_executed_instructions ();if (replay_file) {int64_t ret; -replay_mutex_lock ();if (replay_next_event_is (EVENT_CLOCK + kind)) {replay_read_next_clock (kind); } ret = replay_state.cached_clock[kind]; -replay_mutex_unlock ();return ret; }
replay/replay.c +18 -20
@@ -81,7 +81,7 @@ int replay_get_instructions(void)void replay_account_executed_instructions (void ) {if (replay_mode ==REPLAY_MODE_PLAY ) { -replay_mutex_lock (); +g_assert (replay_mutex_locked ());if (replay_state.instructions_count >0 ) {int count = (int )(replay_get_current_step () - replay_state.current_step);
@@ -100,24 +100,22 @@ void replay_account_executed_instructions(void)qemu_notify_event (); } } -replay_mutex_unlock (); } }bool replay_exception (void ) { +if (replay_mode ==REPLAY_MODE_RECORD ) { +g_assert (replay_mutex_locked ());replay_save_instructions (); -replay_mutex_lock ();replay_put_event (EVENT_EXCEPTION ); -replay_mutex_unlock ();return true; }else if (replay_mode ==REPLAY_MODE_PLAY ) { +g_assert (replay_mutex_locked ());bool res =replay_has_exception ();if (res) { -replay_mutex_lock ();replay_finish_event (); -replay_mutex_unlock (); }return res; }
@@ -129,10 +127,9 @@ bool replay_has_exception(void) {bool res = false;if (replay_mode ==REPLAY_MODE_PLAY ) { +g_assert (replay_mutex_locked ());replay_account_executed_instructions (); -replay_mutex_lock (); res =replay_next_event_is (EVENT_EXCEPTION ); -replay_mutex_unlock (); }return res;
@@ -141,17 +138,15 @@ bool replay_has_exception(void)bool replay_interrupt (void ) {if (replay_mode ==REPLAY_MODE_RECORD ) { +g_assert (replay_mutex_locked ());replay_save_instructions (); -replay_mutex_lock ();replay_put_event (EVENT_INTERRUPT ); -replay_mutex_unlock ();return true; }else if (replay_mode ==REPLAY_MODE_PLAY ) { +g_assert (replay_mutex_locked ());bool res =replay_has_interrupt ();if (res) { -replay_mutex_lock ();replay_finish_event (); -replay_mutex_unlock (); }return res; }
@@ -163,10 +158,9 @@ bool replay_has_interrupt(void) {bool res = false;if (replay_mode ==REPLAY_MODE_PLAY ) { +g_assert (replay_mutex_locked ());replay_account_executed_instructions (); -replay_mutex_lock (); res =replay_next_event_is (EVENT_INTERRUPT ); -replay_mutex_unlock (); }return res; }
@@ -174,9 +168,8 @@ bool replay_has_interrupt(void)void replay_shutdown_request (ShutdownCause cause) {if (replay_mode ==REPLAY_MODE_RECORD ) { -replay_mutex_lock (); +g_assert (replay_mutex_locked ());replay_put_event (EVENT_SHUTDOWN + cause); -replay_mutex_unlock (); } }
@@ -190,9 +183,9 @@ bool replay_checkpoint(ReplayCheckpoint checkpoint)return true; } -replay_mutex_lock ();if (replay_mode ==REPLAY_MODE_PLAY ) { +g_assert (replay_mutex_locked ());if (replay_next_event_is (EVENT_CHECKPOINT + checkpoint)) {replay_finish_event (); }else if (replay_state.data_kind !=EVENT_ASYNC ) {
@@ -205,15 +198,20 @@ bool replay_checkpoint(ReplayCheckpoint checkpoint)checkpoint were processed */ res = replay_state.data_kind !=EVENT_ASYNC ; }else if (replay_mode ==REPLAY_MODE_RECORD ) { +g_assert (replay_mutex_locked ());replay_put_event (EVENT_CHECKPOINT + checkpoint);replay_save_events (checkpoint); res = true; } out: -replay_mutex_unlock ();return res; } +void replay_init_locks (void ) +{ +replay_mutex_init (); +} +static void replay_enable (const char *fname,int mode) {const char *fmode =NULL ;
@@ -233,8 +231,6 @@ static void replay_enable(const char *fname, int mode)atexit (replay_finish); -replay_mutex_init (); - replay_file =fopen (fname, fmode);if (replay_file ==NULL ) {fprintf (stderr,"Replay: open %s: %s\n" , fname,strerror (errno));
@@ -274,6 +270,8 @@ void replay_configure(QemuOpts *opts)Location loc;if (!opts) { +/* we no longer need this lock */ +replay_mutex_destroy ();return ; }
util/main-loop.c +13 -4
@@ -29,6 +29,7 @@#include "qemu/sockets.h" // struct in_addr needed for libslirp.h #include "sysemu/qtest.h" #include "sysemu/cpus.h" +#include "sysemu/replay.h" #include "slirp/libslirp.h" #include "qemu/main-loop.h" #include "block/aio.h"
@@ -245,18 +246,21 @@ static int os_host_main_loop_wait(int64_t timeout) timeout =SCALE_MS ; } +if (timeout) { spin_counter =0 ; -qemu_mutex_unlock_iothread (); }else { spin_counter++; } +qemu_mutex_unlock_iothread (); + +replay_mutex_unlock (); ret =qemu_poll_ns ((GPollFD *)gpollfds->data, gpollfds->len, timeout); -if (timeout) { -qemu_mutex_lock_iothread (); - } +replay_mutex_lock (); + +qemu_mutex_lock_iothread ();glib_pollfds_poll ();
@@ -463,8 +467,13 @@ static int os_host_main_loop_wait(int64_t timeout) poll_timeout_ns =qemu_soonest_timeout (poll_timeout_ns, timeout);qemu_mutex_unlock_iothread (); + +replay_mutex_unlock (); + g_poll_ret =qemu_poll_ns (poll_fds, n_poll_fds + w->num, poll_timeout_ns); +replay_mutex_lock (); +qemu_mutex_lock_iothread ();if (g_poll_ret >0 ) {for (i =0 ; i < w->num; i++) {
vl.c +2 -0
@@ -3091,6 +3091,8 @@ int main(int argc, char **argv, char **envp)qemu_init_cpu_list ();qemu_init_cpu_loop (); + +replay_init_locks ();qemu_mutex_lock_iothread ();atexit (qemu_run_exit_notifiers);
RFC PATCH v4 18/23 replay: don't destroy mutex at exit
In reply to Pavel DovgalyukReplay mutex is held by vCPU thread and destroy function is called from atexit of the main thread. Therefore we cannot destroy it safely.
--- replay/replay.c | 1 - 1 file changed, 1 deletion(-)
replay/replay.c +0 -1
@@ -356,7 +356,6 @@ void replay_finish(void) replay_snapshot =NULL ;replay_finish_events (); -replay_mutex_destroy (); }void replay_add_blocker (Error *reason)
RFC PATCH v4 20/23 replay: avoid recursive call of checkpoints
In reply to Pavel DovgalyukThis patch adds a flag which denies recursive call of replay_checkpoint function. Checkpoints may be accompanied by the hardware events. When event is processed, virtual device may invoke timer modification functions that also invoke the checkpoint function. This leads to infinite loop.
--- replay/replay.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
replay/replay.c +13 -1
@@ -176,13 +176,24 @@ void replay_shutdown_request(ShutdownCause cause)bool replay_checkpoint (ReplayCheckpoint checkpoint) {bool res = false; +static bool in_checkpoint;assert (EVENT_CHECKPOINT + checkpoint <=EVENT_CHECKPOINT_LAST ); -replay_save_instructions ();if (!replay_file) {return true; } +if (in_checkpoint) { +/* If we are already in checkpoint, then there is no need +for additional synchronization. +Recursion occurs when HW event modifies timers. +Timer modification may invoke the checkpoint and +proceed to recursion. */ +return true; + } + in_checkpoint = true; + +replay_save_instructions ();if (replay_mode ==REPLAY_MODE_PLAY ) {g_assert (replay_mutex_locked ());
@@ -204,6 +215,7 @@ bool replay_checkpoint(ReplayCheckpoint checkpoint) res = true; } out: + in_checkpoint = false;return res; }
RFC PATCH v4 19/23 replay: check return values of fwrite
In reply to Pavel DovgalyukThis patch adds error reporting when fwrite cannot completely save the buffer to the file.
--
v3: also check putc() return value
--- replay/replay-internal.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-)
replay/replay-internal.c +15 -2
@@ -24,12 +24,23 @@static QemuMutex lock;/* File for replay writing */ +static bool write_error;FILE *replay_file; +static void replay_write_error (void ) +{ +if (!write_error) { +error_report ("replay write error" ); + write_error = true; + } +} +void replay_put_byte (uint8_t byte) {if (replay_file) { -putc (byte, replay_file); +if (putc (byte, replay_file) ==EOF ) { +replay_write_error (); + } } }
@@ -62,7 +73,9 @@ void replay_put_array(const uint8_t *buf, size_t size) {if (replay_file) {replay_put_dword (size); -fwrite (buf,1 , size, replay_file); +if (fwrite (buf,1 , size, replay_file) != size) { +replay_write_error (); + } } }
RFC PATCH v4 21/23 scripts/replay-dump.py: replay log dumper
In reply to Pavel DovgalyukFrom: Alex Bennée <[email protected]>
This script is a debugging tool for looking through the contents of a replay log file. It is incomplete but should fail gracefully at events it doesn't understand.
It currently understands two different log formats as the audio record/replay support was merged during since MTTCG. It was written to help debug what has caused the BQL changes to break replay support.
---
v2
- yet another update to the log format
--- scripts/replay-dump.py | 308 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 308 insertions(+) create mode 100755 scripts/replay-dump.py
scripts/replay-dump.py new file +308 -0
@@ -0,0 +1,308 @@ +#!/usr/bin/env python +# -*- coding: utf-8 -*- +# +# Dump the contents of a recorded execution stream +# +# Copyright (c) 2017 Alex Bennée <[email protected]> +# +# This library is free software; you can redistribute it and/or +# modify it under the terms of the GNU Lesser General Public +# License as published by the Free Software Foundation; either +# version 2 of the License, or (at your option) any later version. +# +# This library is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +# Lesser General Public License for more details. +# +# You should have received a copy of the GNU Lesser General Public +# License along with this library; if not, see <http://www.gnu.org/licenses/>. + +import argparse +import struct +from collections import namedtuple + +# This mirrors some of the global replay state which some of the +# stream loading refers to. Some decoders may read the next event so +# we need handle that case. Calling reuse_event will ensure the next +# event is read from the cache rather than advancing the file. + +class ReplayState(object): + def __init__(self): + self.event = -1 + self.event_count = 0 + self.already_read = False + self.current_checkpoint = 0 + self.checkpoint = 0 + + def set_event(self, ev): + self.event = ev + self.event_count += 1 + + def get_event(self): + self.already_read = False + return self.event + + def reuse_event(self, ev): + self.event = ev + self.already_read = True + + def set_checkpoint(self): + self.checkpoint = self.event - self.checkpoint_start + + def get_checkpoint(self): + return self.checkpoint + +replay_state = ReplayState() + +# Simple read functions that mirror replay-internal.c +# The file-stream is big-endian and manually written out a byte at a time. + +def read_byte(fin): + "Read a single byte" + return struct.unpack('>B', fin.read(1))[0] + +def read_event(fin): + "Read a single byte event, but save some state" + if replay_state.already_read: + return replay_state.get_event() + else: + replay_state.set_event(read_byte(fin)) + return replay_state.event + +def read_word(fin): + "Read a 16 bit word" + return struct.unpack('>H', fin.read(2))[0] + +def read_dword(fin): + "Read a 32 bit word" + return struct.unpack('>I', fin.read(4))[0] + +def read_qword(fin): + "Read a 64 bit word" + return struct.unpack('>Q', fin.read(8))[0] + +# Generic decoder structure +Decoder = namedtuple("Decoder", "eid name fn") + +def call_decode(table, index, dumpfile): + "Search decode table for next step" + decoder = next((d for d in table if d.eid == index), None) + if not decoder: + print "Could not decode index: %d" % (index) + print "Entry is: %s" % (decoder) + print "Decode Table is:\n%s" % (table) + return False + else: + return decoder.fn(decoder.eid, decoder.name, dumpfile) + +# Print event +def print_event(eid, name, string=None, event_count=None): + "Print event with count" + if not event_count: + event_count = replay_state.event_count + + if string: + print "%d:%s(%d) %s" % (event_count, name, eid, string) + else: + print "%d:%s(%d)" % (event_count, name, eid) + + +# Decoders for each event type + +def decode_unimp(eid, name, _unused_dumpfile): + "Unimplimented decoder, will trigger exit" + print "%s not handled - will now stop" % (name) + return False + +# Checkpoint decoder +def swallow_async_qword(eid, name, dumpfile): + "Swallow a qword of data without looking at it" + step_id = read_qword(dumpfile) + print " %s(%d) @ %d" % (name, eid, step_id) + return True + +async_decode_table = [ Decoder(0, "REPLAY_ASYNC_EVENT_BH", swallow_async_qword), + Decoder(1, "REPLAY_ASYNC_INPUT", decode_unimp), + Decoder(2, "REPLAY_ASYNC_INPUT_SYNC", decode_unimp), + Decoder(3, "REPLAY_ASYNC_CHAR_READ", decode_unimp), + Decoder(4, "REPLAY_ASYNC_EVENT_BLOCK", decode_unimp), + Decoder(5, "REPLAY_ASYNC_EVENT_NET", decode_unimp), +] +# See replay_read_events/replay_read_event +def decode_async(eid, name, dumpfile): + """Decode an ASYNC event""" + + print_event(eid, name) + + async_event_kind = read_byte(dumpfile) + async_event_checkpoint = read_byte(dumpfile) + + if async_event_checkpoint != replay_state.current_checkpoint: + print " mismatch between checkpoint %d and async data %d" % ( + replay_state.current_checkpoint, async_event_checkpoint) + return True + + return call_decode(async_decode_table, async_event_kind, dumpfile) + + +def decode_instruction(eid, name, dumpfile): + ins_diff = read_dword(dumpfile) + print_event(eid, name, "0x%x" % (ins_diff)) + return True + +def decode_audio_out(eid, name, dumpfile): + audio_data = read_dword(dumpfile) + print_event(eid, name, "%d" % (audio_data)) + return True + +def decode_checkpoint(eid, name, dumpfile): + """Decode a checkpoint. + + Checkpoints contain a series of async events with their own specific data. + """ + replay_state.set_checkpoint() + # save event count as we peek ahead + event_number = replay_state.event_count + next_event = read_event(dumpfile) + + # if the next event is EVENT_ASYNC there are a bunch of + # async events to read, otherwise we are done + if next_event != 3: + print_event(eid, name, "no additional data", event_number) + else: + print_event(eid, name, "more data follows", event_number) + + replay_state.reuse_event(next_event) + return True + +def decode_checkpoint_init(eid, name, dumpfile): + print_event(eid, name) + return True + +def decode_interrupt(eid, name, dumpfile): + print_event(eid, name) + return True + +def decode_clock(eid, name, dumpfile): + clock_data = read_qword(dumpfile) + print_event(eid, name, "0x%x" % (clock_data)) + return True + + +# pre-MTTCG merge +v5_event_table = [Decoder(0, "EVENT_INSTRUCTION", decode_instruction), + Decoder(1, "EVENT_INTERRUPT", decode_interrupt), + Decoder(2, "EVENT_EXCEPTION", decode_unimp), + Decoder(3, "EVENT_ASYNC", decode_async), + Decoder(4, "EVENT_SHUTDOWN", decode_unimp), + Decoder(5, "EVENT_CHAR_WRITE", decode_unimp), + Decoder(6, "EVENT_CHAR_READ_ALL", decode_unimp), + Decoder(7, "EVENT_CHAR_READ_ALL_ERROR", decode_unimp), + Decoder(8, "EVENT_CLOCK_HOST", decode_clock), + Decoder(9, "EVENT_CLOCK_VIRTUAL_RT", decode_clock), + Decoder(10, "EVENT_CP_CLOCK_WARP_START", decode_checkpoint), + Decoder(11, "EVENT_CP_CLOCK_WARP_ACCOUNT", decode_checkpoint), + Decoder(12, "EVENT_CP_RESET_REQUESTED", decode_checkpoint), + Decoder(13, "EVENT_CP_SUSPEND_REQUESTED", decode_checkpoint), + Decoder(14, "EVENT_CP_CLOCK_VIRTUAL", decode_checkpoint), + Decoder(15, "EVENT_CP_CLOCK_HOST", decode_checkpoint), + Decoder(16, "EVENT_CP_CLOCK_VIRTUAL_RT", decode_checkpoint), + Decoder(17, "EVENT_CP_INIT", decode_checkpoint_init), + Decoder(18, "EVENT_CP_RESET", decode_checkpoint), +] + +# post-MTTCG merge, AUDIO support added +v6_event_table = [Decoder(0, "EVENT_INSTRUCTION", decode_instruction), + Decoder(1, "EVENT_INTERRUPT", decode_interrupt), + Decoder(2, "EVENT_EXCEPTION", decode_unimp), + Decoder(3, "EVENT_ASYNC", decode_async), + Decoder(4, "EVENT_SHUTDOWN", decode_unimp), + Decoder(5, "EVENT_CHAR_WRITE", decode_unimp), + Decoder(6, "EVENT_CHAR_READ_ALL", decode_unimp), + Decoder(7, "EVENT_CHAR_READ_ALL_ERROR", decode_unimp), + Decoder(8, "EVENT_AUDIO_OUT", decode_audio_out), + Decoder(9, "EVENT_AUDIO_IN", decode_unimp), + Decoder(10, "EVENT_CLOCK_HOST", decode_clock), + Decoder(11, "EVENT_CLOCK_VIRTUAL_RT", decode_clock), + Decoder(12, "EVENT_CP_CLOCK_WARP_START", decode_checkpoint), + Decoder(13, "EVENT_CP_CLOCK_WARP_ACCOUNT", decode_checkpoint), + Decoder(14, "EVENT_CP_RESET_REQUESTED", decode_checkpoint), + Decoder(15, "EVENT_CP_SUSPEND_REQUESTED", decode_checkpoint), + Decoder(16, "EVENT_CP_CLOCK_VIRTUAL", decode_checkpoint), + Decoder(17, "EVENT_CP_CLOCK_HOST", decode_checkpoint), + Decoder(18, "EVENT_CP_CLOCK_VIRTUAL_RT", decode_checkpoint), + Decoder(19, "EVENT_CP_INIT", decode_checkpoint_init), + Decoder(20, "EVENT_CP_RESET", decode_checkpoint), +] + +# Shutdown cause added +v7_event_table = [Decoder(0, "EVENT_INSTRUCTION", decode_instruction), + Decoder(1, "EVENT_INTERRUPT", decode_interrupt), + Decoder(2, "EVENT_EXCEPTION", decode_unimp), + Decoder(3, "EVENT_ASYNC", decode_async), + Decoder(4, "EVENT_SHUTDOWN", decode_unimp), + Decoder(5, "EVENT_SHUTDOWN_HOST_ERR", decode_unimp), + Decoder(6, "EVENT_SHUTDOWN_HOST_QMP", decode_unimp), + Decoder(7, "EVENT_SHUTDOWN_HOST_SIGNAL", decode_unimp), + Decoder(8, "EVENT_SHUTDOWN_HOST_UI", decode_unimp), + Decoder(9, "EVENT_SHUTDOWN_GUEST_SHUTDOWN", decode_unimp), + Decoder(10, "EVENT_SHUTDOWN_GUEST_RESET", decode_unimp), + Decoder(11, "EVENT_SHUTDOWN_GUEST_PANIC", decode_unimp), + Decoder(12, "EVENT_SHUTDOWN___MAX", decode_unimp), + Decoder(13, "EVENT_CHAR_WRITE", decode_unimp), + Decoder(14, "EVENT_CHAR_READ_ALL", decode_unimp), + Decoder(15, "EVENT_CHAR_READ_ALL_ERROR", decode_unimp), + Decoder(16, "EVENT_AUDIO_OUT", decode_audio_out), + Decoder(17, "EVENT_AUDIO_IN", decode_unimp), + Decoder(18, "EVENT_CLOCK_HOST", decode_clock), + Decoder(19, "EVENT_CLOCK_VIRTUAL_RT", decode_clock), + Decoder(20, "EVENT_CP_CLOCK_WARP_START", decode_checkpoint), + Decoder(21, "EVENT_CP_CLOCK_WARP_ACCOUNT", decode_checkpoint), + Decoder(22, "EVENT_CP_RESET_REQUESTED", decode_checkpoint), + Decoder(23, "EVENT_CP_SUSPEND_REQUESTED", decode_checkpoint), + Decoder(24, "EVENT_CP_CLOCK_VIRTUAL", decode_checkpoint), + Decoder(25, "EVENT_CP_CLOCK_HOST", decode_checkpoint), + Decoder(26, "EVENT_CP_CLOCK_VIRTUAL_RT", decode_checkpoint), + Decoder(27, "EVENT_CP_INIT", decode_checkpoint_init), + Decoder(28, "EVENT_CP_RESET", decode_checkpoint), +] + +def parse_arguments(): + "Grab arguments for script" + parser = argparse.ArgumentParser() + parser.add_argument("-f", "--file", help='record/replay dump to read from', + required=True) + return parser.parse_args() + +def decode_file(filename): + "Decode a record/replay dump" + dumpfile = open(filename, "rb") + + # read and throwaway the header + version = read_dword(dumpfile) + junk = read_qword(dumpfile) + + print "HEADER: version 0x%x" % (version) + + if version == 0xe02007: + event_decode_table = v7_event_table + replay_state.checkpoint_start = 12 + elif version == 0xe02006: + event_decode_table = v6_event_table + replay_state.checkpoint_start = 12 + else: + event_decode_table = v5_event_table + replay_state.checkpoint_start = 10 + + try: + decode_ok = True + while decode_ok: + event = read_event(dumpfile) + decode_ok = call_decode(event_decode_table, event, dumpfile) + finally: + dumpfile.close() + +if __name__ == "__main__": + args = parse_arguments() + decode_file(args.file)
RFC PATCH v4 22/23 replay: don't process async events when warping the clock
In reply to Pavel DovgalyukVirtual clock is wapred from iothread and vcpu thread. When the hardware events associated with warp checkpoint, then interrupt delivering may be non-deterministic if checkpoint is processed in different threads in record and replay.
This patch disables event processing for clock warp checkpoint and leaves all hardware events to other checkpoints (e.g., virtual clock).
--
v4: added assert for replay_save_events function
--- replay/replay-events.c | 1 + replay/replay.c | 7 ++++++- 2 files changed, 7 insertions(+), 1 deletion(-)
replay/replay-events.c +1 -0
@@ -204,6 +204,7 @@ static void replay_save_event(Event *event, int checkpoint)/* Called with replay mutex locked */ void replay_save_events (int checkpoint) { +assert (checkpoint !=CHECKPOINT_CLOCK_WARP_START );while (!QTAILQ_EMPTY (&events_list)) {Event *event =QTAILQ_FIRST (&events_list);replay_save_event (event, checkpoint);
replay/replay.c +6 -1
@@ -211,7 +211,12 @@ bool replay_checkpoint(ReplayCheckpoint checkpoint) }else if (replay_mode ==REPLAY_MODE_RECORD ) {g_assert (replay_mutex_locked ());replay_put_event (EVENT_CHECKPOINT + checkpoint); -replay_save_events (checkpoint); +/* This checkpoint belongs to several threads. +Processing events from different threads is +non-deterministic */ +if (checkpoint !=CHECKPOINT_CLOCK_WARP_START ) { +replay_save_events (checkpoint); + } res = true; } out:
RFC PATCH v4 23/23 replay: save vmstate of the asynchronous events
In reply to Pavel DovgalyukThis patch fixes saving and loading the snapshots in the replay mode. It is required for the snapshots created in the moment when the header of the asynchronous event is read. This information was not saved in the snapshot. After loading the vmstate replay continued with the file offset passed the event header. The event header is lost in this case and replay hangs.
--- replay/replay-events.c | 44 +++++++++++++++++++++----------------------- replay/replay-internal.h | 6 ++++++ replay/replay-snapshot.c | 3 +++ 3 files changed, 30 insertions(+), 23 deletions(-)
replay/replay-events.c +21 -23
@@ -27,10 +27,6 @@ typedef struct Event { } Event; static QTAILQ_HEAD(, Event) events_list = QTAILQ_HEAD_INITIALIZER(events_list); -static unsigned int read_event_kind =-1 ; -static uint64_t read_id =-1 ; -static int read_checkpoint =-1 ; -static bool events_enabled;/* Functions */
@@ -217,58 +213,60 @@ void replay_save_events(int checkpoint)static Event *replay_read_event (int checkpoint) {Event *event; -if (read_event_kind ==-1 ) { - read_checkpoint =replay_get_byte (); - read_event_kind =replay_get_byte (); - read_id =-1 ; +if (replay_state.read_event_kind ==-1 ) { + replay_state.read_event_checkpoint =replay_get_byte (); + replay_state.read_event_kind =replay_get_byte (); + replay_state.read_event_id =-1 ;replay_check_error (); } -if (checkpoint != read_checkpoint) { +if (checkpoint != replay_state.read_event_checkpoint) {return NULL ; }/* Events that has not to be in the queue */ -switch (read_event_kind) { +switch (replay_state.read_event_kind) {case REPLAY_ASYNC_EVENT_BH : -if (read_id ==-1 ) { - read_id =replay_get_qword (); +if (replay_state.read_event_id ==-1 ) { + replay_state.read_event_id =replay_get_qword (); }break ;case REPLAY_ASYNC_EVENT_INPUT : event =g_malloc0 (sizeof (Event)); - event->event_kind = read_event_kind; + event->event_kind = replay_state.read_event_kind; event->opaque =replay_read_input_event ();return event;case REPLAY_ASYNC_EVENT_INPUT_SYNC : event =g_malloc0 (sizeof (Event)); - event->event_kind = read_event_kind; + event->event_kind = replay_state.read_event_kind; event->opaque =0 ;return event;case REPLAY_ASYNC_EVENT_CHAR_READ : event =g_malloc0 (sizeof (Event)); - event->event_kind = read_event_kind; + event->event_kind = replay_state.read_event_kind; event->opaque =replay_event_char_read_load ();return event;case REPLAY_ASYNC_EVENT_BLOCK : -if (read_id ==-1 ) { - read_id =replay_get_qword (); +if (replay_state.read_event_id ==-1 ) { + replay_state.read_event_id =replay_get_qword (); }break ;case REPLAY_ASYNC_EVENT_NET : event =g_malloc0 (sizeof (Event)); - event->event_kind = read_event_kind; + event->event_kind = replay_state.read_event_kind; event->opaque =replay_event_net_load ();return event;default : -error_report ("Unknown ID %d of replay event" , read_event_kind); +error_report ("Unknown ID %d of replay event" , + replay_state.read_event_kind);exit (1 );break ; } QTAILQ_FOREACH(event, &events_list, events) { -if (event->event_kind == read_event_kind - && (read_id ==-1 || read_id == event->id)) { +if (event->event_kind == replay_state.read_event_kind + && (replay_state.read_event_id ==-1 + || replay_state.read_event_id == event->id)) {break ; } }
@@ -293,7 +291,7 @@ void replay_read_events(int checkpoint)break ; }replay_finish_event (); - read_event_kind =-1 ; + replay_state.read_event_kind =-1 ;replay_run_event (event);g_free (event);
@@ -302,7 +300,7 @@ void replay_read_events(int checkpoint)void replay_init_events (void ) { - read_event_kind =-1 ; + replay_state.read_event_kind =-1 ; }void replay_finish_events (void )
replay/replay-internal.h +6 -0
@@ -80,6 +80,12 @@ typedef struct ReplayState {uint64_t block_request_id;/*! Prior value of the host clock */ uint64_t host_clock_last; +/*! Asynchronous event type read from the log */ +int32_t read_event_kind; +/*! Asynchronous event id read from the log */ +uint64_t read_event_id; +/*! Asynchronous event checkpoint id read from the log */ +int32_t read_event_checkpoint; } ReplayState;extern ReplayState replay_state;
replay/replay-snapshot.c +3 -0
@@ -57,6 +57,9 @@ static const VMStateDescription vmstate_replay = { VMSTATE_UINT64(file_offset, ReplayState), VMSTATE_UINT64(block_request_id, ReplayState), VMSTATE_UINT64(host_clock_last, ReplayState), + VMSTATE_INT32(read_event_kind, ReplayState), + VMSTATE_UINT64(read_event_id, ReplayState), + VMSTATE_INT32(read_event_checkpoint, ReplayState),VMSTATE_END_OF_LIST () }, };
Re: [Qemu-devel] [RFC PATCH v4 01/23] This patch adds a condition before overwriting exception_index fields.
In reply to Pavel DovgalyukQuoted 2 lines · Pavel Dovgalyuk
It is needed when
exception_indexis already set to some meaningful value.
Pavel, very frankly, this commit message is awful, and for two reasons.
First, it should include the high level overview of the bug ("XYZ does not work") and the description of why XYZ does not work (what is the meaningful value? who set it?)
Second, it also resets cpu->exception_index to -1 in after calling cc->cpu_exec_interrupt. Why is this correct? Who was clearing it before? Is that clearing still needed? What does cc->cpu_exec_interrupt even have to do with cpu->exception_index, since exceptions are handled by cc->do_interrupt?
And so on.
Paolo
Quoted 29 lines
Signed-off-by Paolo Bonzini <[email protected]>--- accel/tcg/cpu-exec.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)accel/tcg/cpu-exec.c +4
-1@@ -585,6 +585,7 @@ static inline bool cpu_handle_interrupt(CPUState *cpu,else {if (cc->cpu_exec_interrupt (cpu, interrupt_request)) {replay_interrupt (); + cpu->exception_index =-1 ; *last_tb =NULL ; }/* The target hook may have updated the 'cpu->interrupt_request'; @@ -606,7 +607,9 @@ static inline bool cpu_handle_interrupt(CPUState *cpu,if (unlikely (atomic_read (&cpu->exit_request) || (use_icount && cpu->icount_decr.u16.low + cpu->icount_extra ==0 ))) {atomic_set (&cpu->exit_request,0 ); - cpu->exception_index =EXCP_INTERRUPT ; +if (cpu->exception_index ==-1 ) { + cpu->exception_index =EXCP_INTERRUPT ; + }return true; }
Re: [Qemu-devel] [RFC PATCH v4 12/23] cpus: push BQL lock to qemu_*_wait_io_event
In reply to Pavel Dovgalyukcpus.c static void qemu_tcg_rr_wait_io_event(CPUState *cpu) · line 1163
Quoted 7 lines · Pavel Dovgalyuk
static void
qemu_wait_io_event(CPUState *cpu)
{cpus.c +2
-0+qemu_mutex_lock_iothread (); +while (cpu_thread_is_idle (cpu)) {qemu_cond_wait (cpu->halt_cond, &qemu_global_mutex); }
This function locks the iothread and never unlocks it. Please test your patches better.
cpus.c static void *qemu_kvm_cpu_thread_fn(void *arg) · line 1201
Quoted 9 lines
cpus.c +2
-0@@ -1190,6 +1194,8 @@ static void *qemu_kvm_cpu_thread_fn(void *arg)/* signal CPU creation */ cpu->created = true; +qemu_mutex_unlock_iothread (); +qemu_cond_signal (&qemu_cpu_cond); do {
This function calls qemu_wait_io_event with BQL not taken.
Quoted 13 lines
cpus.c +1
-1@@ -1232,10 +1238,10 @@ static void *qemu_dummy_cpu_thread_fn(void *arg)/* signal CPU creation */ cpu->created = true; +qemu_mutex_unlock_iothread ();qemu_cond_signal (&qemu_cpu_cond);while (1 ) { -qemu_mutex_unlock_iothread (); do { int sig; r = sigwait(&waitset, &sig);
cpus.c static void *qemu_dummy_cpu_thread_fn(void *arg) · line 1255
Quoted 4 lines
cpus.c +1
-0@@ -1246,6 +1252,7 @@ static void *qemu_dummy_cpu_thread_fn(void *arg) }qemu_mutex_lock_iothread ();qemu_wait_io_event (cpu); +qemu_mutex_unlock_iothread ();
This function calls it with BQL taken.
Even without the mistakes, these changes are hard to follow. If possible, please separate the hax_vcpu_hax_exec and kvm_cpu_exec changes to a separate patch.
Paolo
Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads
In reply to Pavel Dovgalyukcpus.c static void qemu_wait_io_event_common(CPUState *cpu) · line 1150
Quoted 6 lines · Pavel Dovgalyuk
while (all_cpu_threads_idle()) {cpus.c +2
-0+qemu_mutex_lock_iothread ();stop_tcg_kick_timer ();qemu_cond_wait (cpu->halt_cond, &qemu_global_mutex); +qemu_mutex_unlock_iothread (); }
cpu_has_work cannot be called outside BQL yet. You first need to access cpu->interrupt_request with atomics.
In general, testing the condition outside the mutex is a very dangerous pattern (and I'm usually the one who enjoys dangerous patterns).
But also, taking a slightly wider look:
Quoted 6 lines
static void
qemu_tcg_rr_wait_io_event(CPUState *cpu){ while (all_cpu_threads_idle()) {cpus.c +1
-0+qemu_mutex_lock_iothread ();stop_tcg_kick_timer ();
cpus.c static void qemu_wait_io_event_common(CPUState *cpu) · line 1155
Quoted 10 lines
cpus.c +1
-2qemu_cond_wait (cpu->halt_cond, &qemu_global_mutex); +qemu_mutex_unlock_iothread (); }start_tcg_kick_timer ();qemu_wait_io_event_common (cpu); - -qemu_mutex_unlock_iothread (); }
You are adding a qemu_mutex_lock_iothread to a function that wasn't there before. Either it was broken before, or it is now.
Paolo
This series failed docker-quick@centos6 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally.
Hi,
This series failed docker-quick@centos6 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally.
Type: series
Message-id: 20180119084235.7100.98318.stgit@pasha-VirtualBox
Subject: [Qemu-devel] [RFC PATCH v4 00/23] replay additions
=== TEST SCRIPT BEGIN ===
#!/bin/bash
set -e
git submodule update --init dtc
# Let docker tests dump environment info
export SHOW_ENV=1
export J=8
time make docker-test-quick@centos6
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'7e4754f78a replay: save vmstate of the asynchronous events f2737d0e8b replay: don't process async events when warping the clock 316399fbab scripts/replay-dump.py: replay log dumperc6f1de36a1 replay: avoid recursive call of checkpoints64a7a46f79 replay: check return values of fwrite0faa4ab3c2 replay: don't destroy mutex at exit490d134534 replay: push replay_mutex_lock up the call tree 545871aa54 replay: make locking visible outside replay code b7572a44ac replay/replay-internal.c: track holding of replay_lock bb9d744e90 replay/replay.c: bump REPLAY_VERSION again9094c03794 cpus: only take BQL for sleeping threadsb2ddb5feaa cpus: push BQL lock to qemu_*_wait_io_eventdbcbab41bf target/arm/arm-powertctl: drop BQL assertions235c9a3a1e replay: save prior value of the host clockbe2ce2f9b4 replay: make safe vmstop at record/replayafc1507141 replay: added replay log format description715e0a803a replay: fix save/load vm for non-empty queued49d47c97a replay: fixed replay_enable_eventsc203e45276 replay: fix processing async eventsb7d4c1578e replay: disable default snapshot for record/replay ba0302d5a2 blkreplay: create temporary overlay for underlaying devices bd3e4d9037 block: implement bdrv_snapshot_goto for blkreplay 357d17d78c This patch adds a condition before overwriting exception_index fields.
=== OUTPUT BEGIN ===
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into '/var/tmp/patchew-tester-tmp-o2p83o2g/src/dtc'...
Submodule path 'dtc': checked out '558cd81bdd432769b59bff01240c44f82cfb1a9d'
BUILD centos6
GEN /var/tmp/patchew-tester-tmp-o2p83o2g/src/docker-src.2018-01-19-04.22.43.21265/qemu.tar
Cloning into '/var/tmp/patchew-tester-tmp-o2p83o2g/src/docker-src.2018-01-19-04.22.43.21265/qemu.tar.vroot'... done.
Your branch is up-to-date with 'origin/test'.
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into '/var/tmp/patchew-tester-tmp-o2p83o2g/src/docker-src.2018-01-19-04.22.43.21265/qemu.tar.vroot/dtc'... Submodule path 'dtc': checked out '558cd81bdd432769b59bff01240c44f82cfb1a9d'
Submodule 'ui/keycodemapdb' (git://git.qemu.org/keycodemapdb.git) registered for path 'ui/keycodemapdb' Cloning into '/var/tmp/patchew-tester-tmp-o2p83o2g/src/docker-src.2018-01-19-04.22.43.21265/qemu.tar.vroot/ui/keycodemapdb'... Submodule path 'ui/keycodemapdb': checked out '10739aa26051a5d49d88132604539d3ed085e72e'
COPY RUNNER
RUN test-quick in qemu:centos6
Packages installed:
SDL-devel-1.2.14-7.el6_7.1.x86_64
bison-2.4.1-5.el6.x86_64
bzip2-devel-1.0.5-7.el6_0.x86_64
ccache-3.1.6-2.el6.x86_64
csnappy-devel-0-6.20150729gitd7bc683.el6.x86_64
flex-2.5.35-9.el6.x86_64
gcc-4.4.7-18.el6.x86_64
gettext-0.17-18.el6.x86_64
git-1.7.1-9.el6_9.x86_64
glib2-devel-2.28.8-9.el6.x86_64
libepoxy-devel-1.2-3.el6.x86_64
libfdt-devel-1.4.0-1.el6.x86_64
librdmacm-devel-1.0.21-0.el6.x86_64
lzo-devel-2.03-3.1.el6_5.1.x86_64
make-3.81-23.el6.x86_64
mesa-libEGL-devel-11.0.7-4.el6.x86_64
mesa-libgbm-devel-11.0.7-4.el6.x86_64
package g++ is not installed
pixman-devel-0.32.8-1.el6.x86_64
spice-glib-devel-0.26-8.el6.x86_64
spice-server-devel-0.12.4-16.el6.x86_64
tar-1.23-15.el6_8.x86_64
vte-devel-0.25.1-9.el6.x86_64
xen-devel-4.6.6-2.el6.x86_64
zlib-devel-1.2.3-29.el6.x86_64
Environment variables:
PACKAGES=bison bzip2-devel ccache csnappy-devel flex g++ gcc gettext git glib2-devel libepoxy-devel libfdt-devel librdmacm-devel lzo-devel make mesa-libEGL-devel mesa-libgbm-devel pixman-devel SDL-devel spice-glib-devel spice-server-devel tar vte-devel xen-devel zlib-devel
HOSTNAME=a4d04a14ecd0
MAKEFLAGS= -j8
J=8
CCACHE_DIR=/var/tmp/ccache
EXTRA_CONFIGURE_OPTS=
V=
SHOW_ENV=1 PATH=/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD=/
TARGET_LIST=
SHLVL=1
HOME=/root
TEST_DIR=/tmp/qemu-test
FEATURES= dtc
DEBUG=
_=/usr/bin/env
Configure options:
--enable-werror --target-list=x86_64-softmmu,aarch64-softmmu --prefix=/tmp/qemu-test/install No C++ compiler available; disabling C++ specific optional code
Install prefix /tmp/qemu-test/install BIOS directory /tmp/qemu-test/install/share/qemu firmware path /tmp/qemu-test/install/share/qemu-firmware binary directory /tmp/qemu-test/install/bin
library directory /tmp/qemu-test/install/lib module directory /tmp/qemu-test/install/lib/qemu libexec directory /tmp/qemu-test/install/libexec include directory /tmp/qemu-test/install/include config directory /tmp/qemu-test/install/etc
local state directory /tmp/qemu-test/install/var
Manual directory /tmp/qemu-test/install/share/man ELF interp prefix /usr/gnemul/qemu-%M
Source path /tmp/qemu-test/src
GIT binary git
GIT submodules
C compiler cc
Host C compiler cc
C++ compiler
Objective-C compiler cc
ARFLAGS rv CFLAGS -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -g QEMU_CFLAGS -I/usr/include/pixman-1 -I$(SRC_PATH)/dtc/libfdt -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DNCURSES_WIDECHAR -fPIE -DPIE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-all -Wno-missing-braces -I/usr/include/libpng12 -I/usr/include/libdrm -I/usr/include/spice-server -I/usr/include/cacard -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/nss3 -I/usr/include/nspr4 -I/usr/include/spice-1 LDFLAGS -Wl,--warn-common -Wl,-z,relro -Wl,-z,now -pie -m64 -g make make install install python python -B smbd /usr/sbin/smbd module support no host CPU x86_64 host big endian no target list x86_64-softmmu aarch64-softmmu gprof enabled no sparse enabled no strip binaries yes profiler no static build no SDL support yes (1.2.14) GTK support yes (2.24.23) GTK GL support no VTE support yes (0.25.1) TLS priority NORMAL GNUTLS support no GNUTLS rnd no libgcrypt no libgcrypt kdf no nettle no nettle kdf no libtasn1 no curses support yes virgl support no curl support no mingw32 support no Audio drivers oss
Block whitelist (rw)
Block whitelist (ro)
VirtFS support no
Multipath support no
VNC support yes VNC SASL support no VNC JPEG support yes VNC PNG support yes xen support yes xen ctrl version 40600 pv dom build no brlapi support no bluez support no Documentation no PIE yes vde support no netmap support no Linux AIO support no ATTR/XATTR support yes Install blobs yes KVM support yes HAX support no HVF support no TCG support yes TCG debug enabled no TCG interpreter no malloc trim support yes RDMA support yes fdt support yes preadv support yes fdatasync yes madvise yes posix_madvise yes
libcap-ng support no
vhost-net support yes
vhost-scsi support yes
vhost-vsock support yes
vhost-user support yes
Trace backends log spice support yes (0.12.6/0.12.4) rbd support no xfsctl support no smartcard support yes libusb no usb net redir no OpenGL support yes OpenGL dmabufs no libiscsi support no libnfs support no
build guest agent yes
QGA VSS support no
QGA w32 disk info no
QGA MSI support no
seccomp support no
coroutine backend ucontext
coroutine pool yes
debug stack usage no
crypto afalg no
GlusterFS support no
gcov gcov gcov enabled no TPM support yes libssh2 support no TPM passthrough yes TPM emulator yes QOM debugging yes Live block migration yes lzo support yes snappy support no bzip2 support yes
NUMA host support no
tcmalloc support no
jemalloc support no
avx2 optimization no
replication support yes
VxHS block device no
capstone no
WARNING: Use of GTK 2.0 is deprecated and will be removed in
WARNING: future releases. Please switch to using GTK 3.0
GEN x86_64-softmmu/config-devices.mak.tmp GEN aarch64-softmmu/config-devices.mak.tmp GEN config-host.h GEN qemu-options.def GEN qmp-commands.h GEN qapi-types.h GEN qapi-visit.h GEN qapi-event.h GEN x86_64-softmmu/config-devices.mak GEN qmp-marshal.c GEN qapi-types.c GEN aarch64-softmmu/config-devices.mak GEN qapi-visit.c GEN qapi-event.c GEN qmp-introspect.h GEN qmp-introspect.c GEN trace/generated-tcg-tracers.h GEN trace/generated-helpers-wrappers.h GEN trace/generated-helpers.h GEN trace/generated-helpers.c GEN module_block.h GEN ui/input-keymap-linux-to-qcode.c GEN ui/input-keymap-qnum-to-qcode.c GEN ui/input-keymap-qcode-to-qnum.c GEN ui/input-keymap-qcode-to-linux.c GEN tests/test-qapi-types.h GEN tests/test-qapi-visit.h GEN tests/test-qmp-commands.h GEN tests/test-qapi-event.h GEN tests/test-qmp-introspect.h GEN trace-root.h GEN util/trace.h GEN crypto/trace.h GEN io/trace.h GEN migration/trace.h GEN block/trace.h GEN chardev/trace.h GEN hw/block/trace.h GEN hw/block/dataplane/trace.h GEN hw/char/trace.h GEN hw/intc/trace.h GEN hw/net/trace.h GEN hw/virtio/trace.h GEN hw/audio/trace.h GEN hw/misc/trace.h GEN hw/usb/trace.h GEN hw/scsi/trace.h GEN hw/nvram/trace.h GEN hw/display/trace.h GEN hw/input/trace.h GEN hw/timer/trace.h GEN hw/dma/trace.h GEN hw/sparc/trace.h GEN hw/sparc64/trace.h GEN hw/sd/trace.h GEN hw/isa/trace.h GEN hw/mem/trace.h GEN hw/i386/trace.h GEN hw/i386/xen/trace.h GEN hw/9pfs/trace.h GEN hw/ppc/trace.h GEN hw/pci/trace.h GEN hw/s390x/trace.h GEN hw/vfio/trace.h GEN hw/acpi/trace.h GEN hw/arm/trace.h GEN hw/alpha/trace.h GEN hw/xen/trace.h GEN hw/ide/trace.h GEN ui/trace.h GEN audio/trace.h GEN net/trace.h GEN target/arm/trace.h GEN target/i386/trace.h GEN target/mips/trace.h GEN target/sparc/trace.h GEN target/s390x/trace.h GEN target/ppc/trace.h GEN qom/trace.h GEN linux-user/trace.h GEN qapi/trace.h GEN accel/tcg/trace.h GEN accel/kvm/trace.h GEN nbd/trace.h GEN scsi/trace.h GEN trace-root.c GEN util/trace.c GEN crypto/trace.c GEN io/trace.c GEN migration/trace.c GEN block/trace.c GEN chardev/trace.c GEN hw/block/trace.c GEN hw/block/dataplane/trace.c GEN hw/char/trace.c GEN hw/intc/trace.c GEN hw/net/trace.c GEN hw/virtio/trace.c GEN hw/audio/trace.c GEN hw/misc/trace.c GEN hw/usb/trace.c GEN hw/scsi/trace.c GEN hw/nvram/trace.c GEN hw/display/trace.c GEN hw/input/trace.c GEN hw/timer/trace.c GEN hw/dma/trace.c GEN hw/sparc/trace.c GEN hw/sparc64/trace.c GEN hw/sd/trace.c GEN hw/isa/trace.c GEN hw/mem/trace.c GEN hw/i386/trace.c GEN hw/i386/xen/trace.c GEN hw/9pfs/trace.c GEN hw/ppc/trace.c GEN hw/pci/trace.c GEN hw/s390x/trace.c GEN hw/vfio/trace.c GEN hw/acpi/trace.c GEN hw/arm/trace.c GEN hw/alpha/trace.c GEN hw/xen/trace.c GEN hw/ide/trace.c GEN ui/trace.c GEN audio/trace.c GEN net/trace.c GEN target/arm/trace.c GEN target/i386/trace.c GEN target/mips/trace.c GEN target/sparc/trace.c GEN target/s390x/trace.c GEN target/ppc/trace.c GEN qom/trace.c GEN linux-user/trace.c GEN qapi/trace.c GEN accel/tcg/trace.c GEN accel/kvm/trace.c GEN nbd/trace.c GEN scsi/trace.c GEN config-all-devices.mak
DEP /tmp/qemu-test/src/dtc/tests/dumptrees.c
DEP /tmp/qemu-test/src/dtc/tests/trees.S
DEP /tmp/qemu-test/src/dtc/tests/testutils.c
DEP /tmp/qemu-test/src/dtc/tests/value-labels.c DEP /tmp/qemu-test/src/dtc/tests/asm_tree_dump.c DEP /tmp/qemu-test/src/dtc/tests/truncated_property.c DEP /tmp/qemu-test/src/dtc/tests/check_path.c
DEP /tmp/qemu-test/src/dtc/tests/overlay_bad_fixup.c DEP /tmp/qemu-test/src/dtc/tests/overlay.c
DEP /tmp/qemu-test/src/dtc/tests/subnode_iterate.c DEP /tmp/qemu-test/src/dtc/tests/property_iterate.c DEP /tmp/qemu-test/src/dtc/tests/integer-expressions.c DEP /tmp/qemu-test/src/dtc/tests/utilfdt_test.c DEP /tmp/qemu-test/src/dtc/tests/path_offset_aliases.c DEP /tmp/qemu-test/src/dtc/tests/add_subnode_with_nops.c DEP /tmp/qemu-test/src/dtc/tests/dtbs_equal_unordered.c DEP /tmp/qemu-test/src/dtc/tests/dtb_reverse.c DEP /tmp/qemu-test/src/dtc/tests/dtbs_equal_ordered.c DEP /tmp/qemu-test/src/dtc/tests/extra-terminating-null.c DEP /tmp/qemu-test/src/dtc/tests/incbin.c
DEP /tmp/qemu-test/src/dtc/tests/boot-cpuid.c
DEP /tmp/qemu-test/src/dtc/tests/phandle_format.c DEP /tmp/qemu-test/src/dtc/tests/path-references.c DEP /tmp/qemu-test/src/dtc/tests/references.c
DEP /tmp/qemu-test/src/dtc/tests/string_escapes.c DEP /tmp/qemu-test/src/dtc/tests/propname_escapes.c DEP /tmp/qemu-test/src/dtc/tests/appendprop2.c DEP /tmp/qemu-test/src/dtc/tests/appendprop1.c DEP /tmp/qemu-test/src/dtc/tests/del_node.c
DEP /tmp/qemu-test/src/dtc/tests/del_property.c DEP /tmp/qemu-test/src/dtc/tests/setprop.c
DEP /tmp/qemu-test/src/dtc/tests/set_name.c
DEP /tmp/qemu-test/src/dtc/tests/rw_tree1.c
DEP /tmp/qemu-test/src/dtc/tests/open_pack.c
DEP /tmp/qemu-test/src/dtc/tests/nopulate.c
DEP /tmp/qemu-test/src/dtc/tests/mangle-layout.c DEP /tmp/qemu-test/src/dtc/tests/move_and_save.c DEP /tmp/qemu-test/src/dtc/tests/sw_tree1.c
DEP /tmp/qemu-test/src/dtc/tests/nop_node.c
DEP /tmp/qemu-test/src/dtc/tests/nop_property.c DEP /tmp/qemu-test/src/dtc/tests/setprop_inplace.c DEP /tmp/qemu-test/src/dtc/tests/stringlist.c
DEP /tmp/qemu-test/src/dtc/tests/addr_size_cells.c DEP /tmp/qemu-test/src/dtc/tests/notfound.c
DEP /tmp/qemu-test/src/dtc/tests/sized_cells.c DEP /tmp/qemu-test/src/dtc/tests/char_literal.c DEP /tmp/qemu-test/src/dtc/tests/get_alias.c
DEP /tmp/qemu-test/src/dtc/tests/node_offset_by_compatible.c DEP /tmp/qemu-test/src/dtc/tests/node_check_compatible.c DEP /tmp/qemu-test/src/dtc/tests/node_offset_by_phandle.c DEP /tmp/qemu-test/src/dtc/tests/node_offset_by_prop_value.c DEP /tmp/qemu-test/src/dtc/tests/parent_offset.c DEP /tmp/qemu-test/src/dtc/tests/supernode_atdepth_offset.c DEP /tmp/qemu-test/src/dtc/tests/get_path.c
DEP /tmp/qemu-test/src/dtc/tests/get_phandle.c DEP /tmp/qemu-test/src/dtc/tests/getprop.c
DEP /tmp/qemu-test/src/dtc/tests/get_name.c
DEP /tmp/qemu-test/src/dtc/tests/path_offset.c DEP /tmp/qemu-test/src/dtc/tests/subnode_offset.c DEP /tmp/qemu-test/src/dtc/tests/find_property.c DEP /tmp/qemu-test/src/dtc/tests/root_node.c
DEP /tmp/qemu-test/src/dtc/tests/get_mem_rsv.c DEP /tmp/qemu-test/src/dtc/libfdt/fdt_overlay.c DEP /tmp/qemu-test/src/dtc/libfdt/fdt_addresses.c DEP /tmp/qemu-test/src/dtc/libfdt/fdt_empty_tree.c DEP /tmp/qemu-test/src/dtc/libfdt/fdt_strerror.c DEP /tmp/qemu-test/src/dtc/libfdt/fdt_rw.c
DEP /tmp/qemu-test/src/dtc/libfdt/fdt_sw.c
DEP /tmp/qemu-test/src/dtc/libfdt/fdt_wip.c
DEP /tmp/qemu-test/src/dtc/libfdt/fdt_ro.c
DEP /tmp/qemu-test/src/dtc/libfdt/fdt.c
DEP /tmp/qemu-test/src/dtc/util.c
DEP /tmp/qemu-test/src/dtc/fdtput.c
DEP /tmp/qemu-test/src/dtc/fdtget.c
DEP /tmp/qemu-test/src/dtc/fdtdump.c
LEX convert-dtsv0-lexer.lex.c
DEP /tmp/qemu-test/src/dtc/srcpos.c
BISON dtc-parser.tab.c
LEX dtc-lexer.lex.c
DEP /tmp/qemu-test/src/dtc/treesource.c
DEP /tmp/qemu-test/src/dtc/livetree.c
DEP /tmp/qemu-test/src/dtc/fstree.c
DEP /tmp/qemu-test/src/dtc/flattree.c
DEP /tmp/qemu-test/src/dtc/dtc.c
DEP /tmp/qemu-test/src/dtc/data.c
DEP /tmp/qemu-test/src/dtc/checks.c
DEP convert-dtsv0-lexer.lex.c
DEP dtc-parser.tab.c
DEP dtc-lexer.lex.c
CHK version_gen.h
UPD version_gen.h
DEP /tmp/qemu-test/src/dtc/util.c
CC libfdt/fdt.o
CC libfdt/fdt_ro.o
CC libfdt/fdt_wip.o
CC libfdt/fdt_rw.o
CC libfdt/fdt_strerror.o
CC libfdt/fdt_sw.o
CC libfdt/fdt_empty_tree.o
CC libfdt/fdt_addresses.o
CC libfdt/fdt_overlay.o
AR libfdt/libfdt.a
ar: creating libfdt/libfdt.a
a - libfdt/fdt.o
a - libfdt/fdt_ro.o
a - libfdt/fdt_wip.o
a - libfdt/fdt_sw.o
a - libfdt/fdt_rw.o
a - libfdt/fdt_strerror.o
a - libfdt/fdt_empty_tree.o
a - libfdt/fdt_addresses.o
a - libfdt/fdt_overlay.o
CC tests/qemu-iotests/socket_scm_helper.o GEN qga/qapi-generated/qga-qapi-types.h GEN qga/qapi-generated/qga-qapi-visit.h GEN qga/qapi-generated/qga-qmp-commands.h GEN qga/qapi-generated/qga-qapi-types.c GEN qga/qapi-generated/qga-qmp-marshal.c CC qmp-introspect.o GEN qga/qapi-generated/qga-qapi-visit.c CC qapi-types.o CC qapi-visit.o CC qapi-event.o CC qapi/qapi-visit-core.o CC qapi/qapi-dealloc-visitor.o CC qapi/qobject-input-visitor.o CC qapi/qobject-output-visitor.o CC qapi/qmp-registry.o CC qapi/qmp-dispatch.o CC qapi/string-output-visitor.o CC qapi/string-input-visitor.o CC qapi/opts-visitor.o CC qapi/qapi-clone-visitor.o CC qapi/qmp-event.o CC qobject/qnull.o CC qobject/qnum.o CC qapi/qapi-util.o CC qobject/qstring.o CC qobject/qdict.o CC qobject/qlist.o CC qobject/qbool.o CC qobject/qlit.o CC qobject/qjson.o CC qobject/qobject.o CC qobject/json-lexer.o CC qobject/json-streamer.o CC qobject/json-parser.o CC trace/control.o CC trace/qmp.o CC util/osdep.o CC util/cutils.o CC util/unicode.o CC util/qemu-timer-common.o CC util/bufferiszero.o CC util/lockcnt.o CC util/aiocb.o CC util/async.o CC util/thread-pool.o CC util/qemu-timer.o CC util/main-loop.o CC util/iohandler.o CC util/aio-posix.o CC util/compatfd.o CC util/event_notifier-posix.o CC util/mmap-alloc.o CC util/oslib-posix.o CC util/qemu-openpty.o CC util/qemu-thread-posix.o CC util/memfd.o CC util/envlist.o CC util/path.o CC util/module.o CC util/host-utils.o CC util/bitmap.o CC util/bitops.o CC util/hbitmap.o CC util/fifo8.o CC util/acl.o CC util/cacheinfo.o CC util/error.o CC util/qemu-error.o CC util/id.o CC util/iov.o CC util/qemu-config.o CC util/qemu-sockets.o CC util/uri.o CC util/notify.o CC util/qemu-progress.o CC util/qemu-option.o CC util/keyval.o CC util/hexdump.o CC util/crc32c.o CC util/uuid.o CC util/throttle.o CC util/getauxval.o CC util/readline.o CC util/rcu.o CC util/qemu-coroutine.o CC util/qemu-coroutine-lock.o CC util/qemu-coroutine-io.o CC util/qemu-coroutine-sleep.o CC util/coroutine-ucontext.o CC util/buffer.o CC util/timed-average.o CC util/base64.o CC util/log.o CC util/pagesize.o CC util/qdist.o CC util/qht.o CC util/range.o CC util/stats64.o CC util/systemd.o CC trace-root.o CC util/trace.o CC crypto/trace.o CC io/trace.o CC migration/trace.o CC block/trace.o CC chardev/trace.o CC hw/block/trace.o CC hw/block/dataplane/trace.o CC hw/char/trace.o CC hw/intc/trace.o CC hw/net/trace.o CC hw/virtio/trace.o CC hw/audio/trace.o CC hw/misc/trace.o CC hw/usb/trace.o CC hw/scsi/trace.o CC hw/nvram/trace.o CC hw/display/trace.o CC hw/input/trace.o CC hw/timer/trace.o CC hw/dma/trace.o CC hw/sparc/trace.o CC hw/sparc64/trace.o CC hw/sd/trace.o CC hw/isa/trace.o CC hw/mem/trace.o CC hw/i386/trace.o CC hw/i386/xen/trace.o CC hw/9pfs/trace.o CC hw/ppc/trace.o CC hw/pci/trace.o CC hw/s390x/trace.o CC hw/vfio/trace.o CC hw/acpi/trace.o CC hw/arm/trace.o CC hw/alpha/trace.o CC hw/xen/trace.o CC hw/ide/trace.o CC ui/trace.o CC audio/trace.o CC net/trace.o CC target/arm/trace.o CC target/i386/trace.o CC target/mips/trace.o CC target/sparc/trace.o CC target/s390x/trace.o CC target/ppc/trace.o CC qom/trace.o CC linux-user/trace.o CC qapi/trace.o CC accel/tcg/trace.o CC accel/kvm/trace.o CC nbd/trace.o CC scsi/trace.o CC crypto/pbkdf-stub.o CC stubs/arch-query-cpu-def.o CC stubs/arch-query-cpu-model-expansion.o CC stubs/arch-query-cpu-model-comparison.o CC stubs/arch-query-cpu-model-baseline.o CC stubs/bdrv-next-monitor-owned.o CC stubs/blk-commit-all.o CC stubs/blockdev-close-all-bdrv-states.o CC stubs/clock-warp.o CC stubs/cpu-get-clock.o CC stubs/cpu-get-icount.o CC stubs/dump.o CC stubs/error-printf.o CC stubs/fdset.o CC stubs/gdbstub.o CC stubs/get-vm-name.o CC stubs/iothread.o CC stubs/iothread-lock.o CC stubs/is-daemonized.o CC stubs/machine-init-done.o CC stubs/migr-blocker.o CC stubs/change-state-handler.o CC stubs/monitor.o CC stubs/notify-event.o CC stubs/qtest.o CC stubs/replay.o CC stubs/runstate-check.o CC stubs/set-fd-handler.o CC stubs/slirp.o CC stubs/sysbus.o CC stubs/tpm.o CC stubs/trace-control.o CC stubs/uuid.o CC stubs/vm-stop.o CC stubs/vmstate.o CC stubs/qmp_pc_dimm.o CC stubs/target-monitor-defs.o CC stubs/target-get-monitor-def.o CC stubs/pc_madt_cpu_entry.o CC stubs/vmgenid.o CC stubs/xen-common.o CC stubs/xen-hvm.o CC stubs/pci-host-piix.o CC contrib/ivshmem-client/ivshmem-client.o CC contrib/ivshmem-client/main.o CC contrib/ivshmem-server/ivshmem-server.o CC qemu-nbd.o CC contrib/ivshmem-server/main.o CC block.o CC blockjob.o CC qemu-io-cmds.o CC replication.o CC block/raw-format.o CC block/qcow.o CC block/vdi.o CC block/vmdk.o CC block/cloop.o CC block/bochs.o CC block/vpc.o CC block/vvfat.o CC block/dmg.o CC block/qcow2.o CC block/qcow2-refcount.o CC block/qcow2-cluster.o CC block/qcow2-snapshot.o CC block/qcow2-cache.o CC block/qcow2-bitmap.o CC block/qed.o CC block/qed-l2-cache.o CC block/qed-table.o CC block/qed-cluster.o CC block/qed-check.o CC block/vhdx.o CC block/vhdx-endian.o CC block/vhdx-log.o CC block/quorum.o CC block/parallels.o CC block/blkdebug.o CC block/blkverify.o CC block/blkreplay.o CC block/block-backend.o CC block/snapshot.o CC block/qapi.o CC block/file-posix.o CC block/null.o CC block/mirror.o CC block/commit.o CC block/io.o CC block/throttle-groups.o CC block/nbd.o CC block/nbd-client.o CC block/sheepdog.o CC block/accounting.o CC block/dirty-bitmap.o CC block/write-threshold.o CC block/backup.o CC block/replication.o CC block/throttle.o CC block/crypto.o CC nbd/server.o CC nbd/client.o CC nbd/common.o CC scsi/utils.o CC scsi/pr-manager.o CC scsi/pr-manager-helper.o CC block/dmg-bz2.o CC crypto/init.o CC crypto/hash.o CC crypto/hash-glib.o CC crypto/hmac.o CC crypto/hmac-glib.o CC crypto/aes.o CC crypto/desrfb.o CC crypto/cipher.o CC crypto/tlscreds.o CC crypto/tlscredsanon.o CC crypto/tlscredsx509.o CC crypto/tlssession.o CC crypto/secret.o CC crypto/random-platform.o CC crypto/pbkdf.o CC crypto/ivgen-essiv.o CC crypto/ivgen.o CC crypto/ivgen-plain.o CC crypto/ivgen-plain64.o CC crypto/afsplit.o CC crypto/xts.o CC crypto/block.o CC crypto/block-qcow.o CC crypto/block-luks.o CC io/channel.o CC io/channel-buffer.o CC io/channel-command.o CC io/channel-file.o CC io/channel-socket.o CC io/channel-tls.o CC io/channel-watch.o CC io/channel-websock.o CC io/channel-util.o CC io/dns-resolver.o CC io/net-listener.o CC io/task.o CC qom/object.o CC qom/container.o CC qom/qom-qobject.o CC qom/object_interfaces.o GEN qemu-img-cmds.h CC qemu-io.o CC scsi/qemu-pr-helper.o CC qemu-bridge-helper.o CC blockdev.o CC blockdev-nbd.o CC bootdevice.o CC iothread.o CC qdev-monitor.o CC device-hotplug.o CC os-posix.o CC bt-host.o CC bt-vhci.o CC dma-helpers.o CC vl.o CC tpm.o CC device_tree.o CC qmp-marshal.o CC qmp.o CC hmp.o CC cpus-common.o CC audio/audio.o CC audio/noaudio.o CC audio/wavaudio.o CC audio/mixeng.o CC audio/sdlaudio.o CC audio/ossaudio.o CC audio/spiceaudio.o CC audio/wavcapture.o CC backends/rng.o CC backends/rng-egd.o CC backends/rng-random.o CC backends/tpm.o CC backends/hostmem.o CC backends/hostmem-ram.o CC backends/hostmem-file.o CC backends/cryptodev.o CC backends/cryptodev-builtin.o CC block/stream.o CC chardev/msmouse.o CC chardev/wctablet.o CC chardev/testdev.o CC chardev/spice.o CC disas/arm.o CC disas/i386.o CC fsdev/qemu-fsdev-dummy.o CC fsdev/qemu-fsdev-opts.o CC fsdev/qemu-fsdev-throttle.o CC hw/acpi/core.o CC hw/acpi/piix4.o CC hw/acpi/pcihp.o CC hw/acpi/ich9.o CC hw/acpi/tco.o CC hw/acpi/cpu_hotplug.o CC hw/acpi/memory_hotplug.o CC hw/acpi/cpu.o CC hw/acpi/nvdimm.o CC hw/acpi/vmgenid.o CC hw/acpi/acpi_interface.o CC hw/acpi/bios-linker-loader.o CC hw/acpi/aml-build.o CC hw/acpi/ipmi.o CC hw/acpi/acpi-stub.o CC hw/acpi/ipmi-stub.o CC hw/audio/sb16.o CC hw/audio/es1370.o CC hw/audio/ac97.o CC hw/audio/fmopl.o CC hw/audio/adlib.o CC hw/audio/gus.o CC hw/audio/gusemu_hal.o CC hw/audio/gusemu_mixer.o CC hw/audio/cs4231a.o CC hw/audio/intel-hda.o CC hw/audio/hda-codec.o CC hw/audio/pcspk.o CC hw/audio/wm8750.o CC hw/audio/pl041.o CC hw/audio/lm4549.o CC hw/audio/marvell_88w8618.o CC hw/audio/soundhw.o CC hw/block/block.o CC hw/block/cdrom.o CC hw/block/hd-geometry.o CC hw/block/fdc.o CC hw/block/m25p80.o CC hw/block/nand.o CC hw/block/pflash_cfi01.o CC hw/block/pflash_cfi02.o CC hw/block/xen_disk.o CC hw/block/ecc.o CC hw/block/onenand.o CC hw/block/nvme.o CC hw/bt/core.o CC hw/bt/l2cap.o CC hw/bt/hci.o CC hw/bt/sdp.o CC hw/bt/hid.o CC hw/bt/hci-csr.o CC hw/char/ipoctal232.o CC hw/char/parallel.o CC hw/char/pl011.o CC hw/char/serial.o CC hw/char/serial-isa.o CC hw/char/serial-pci.o CC hw/char/virtio-console.o CC hw/char/xen_console.o CC hw/char/cadence_uart.o CC hw/char/cmsdk-apb-uart.o CC hw/char/debugcon.o CC hw/char/imx_serial.o CC hw/core/qdev.o CC hw/core/qdev-properties.o CC hw/core/bus.o CC hw/core/reset.o CC hw/core/fw-path-provider.o CC hw/core/irq.o CC hw/core/hotplug.o CC hw/core/nmi.o CC hw/core/stream.o CC hw/core/ptimer.o CC hw/core/sysbus.o CC hw/core/machine.o CC hw/core/loader.o CC hw/core/qdev-properties-system.o CC hw/core/register.o CC hw/core/or-irq.o CC hw/core/platform-bus.o CC hw/cpu/core.o CC hw/display/ads7846.o CC hw/display/cirrus_vga.o CC hw/display/pl110.o CC hw/display/ssd0303.o CC hw/display/ssd0323.o CC hw/display/xenfb.o CC hw/display/vga-pci.o CC hw/display/vga-isa.o CC hw/display/vmware_vga.o CC hw/display/blizzard.o CC hw/display/exynos4210_fimd.o CC hw/display/framebuffer.o CC hw/display/tc6393xb.o CC hw/display/qxl.o CC hw/display/qxl-logger.o CC hw/display/qxl-render.o CC hw/dma/pl080.o CC hw/dma/pl330.o CC hw/dma/i8257.o CC hw/dma/xilinx_axidma.o CC hw/dma/xlnx-zynq-devcfg.o CC hw/gpio/max7310.o CC hw/gpio/pl061.o CC hw/gpio/zaurus.o CC hw/gpio/gpio_key.o CC hw/i2c/core.o CC hw/i2c/smbus.o CC hw/i2c/smbus_eeprom.o CC hw/i2c/i2c-ddc.o CC hw/i2c/versatile_i2c.o CC hw/i2c/smbus_ich9.o CC hw/i2c/pm_smbus.o CC hw/i2c/bitbang_i2c.o CC hw/i2c/exynos4210_i2c.o CC hw/i2c/imx_i2c.o CC hw/i2c/aspeed_i2c.o CC hw/ide/core.o CC hw/ide/atapi.o CC hw/ide/qdev.o CC hw/ide/pci.o CC hw/ide/isa.o CC hw/ide/piix.o CC hw/ide/microdrive.o CC hw/ide/ahci.o CC hw/ide/ich.o CC hw/ide/ahci-allwinner.o CC hw/input/hid.o CC hw/input/lm832x.o CC hw/input/pckbd.o CC hw/input/pl050.o CC hw/input/ps2.o CC hw/input/stellaris_input.o CC hw/input/tsc2005.o CC hw/input/virtio-input.o CC hw/input/virtio-input-hid.o CC hw/input/virtio-input-host.o CC hw/intc/i8259_common.o CC hw/intc/i8259.o CC hw/intc/pl190.o CC hw/intc/imx_avic.o CC hw/intc/realview_gic.o CC hw/intc/ioapic_common.o CC hw/intc/arm_gic_common.o CC hw/intc/arm_gic.o CC hw/intc/arm_gicv2m.o CC hw/intc/arm_gicv3_common.o CC hw/intc/arm_gicv3.o CC hw/intc/arm_gicv3_dist.o CC hw/intc/arm_gicv3_redist.o CC hw/intc/arm_gicv3_its_common.o CC hw/intc/intc.o CC hw/ipack/ipack.o CC hw/ipack/tpci200.o CC hw/ipmi/ipmi.o CC hw/ipmi/ipmi_bmc_sim.o CC hw/ipmi/ipmi_bmc_extern.o CC hw/ipmi/isa_ipmi_kcs.o CC hw/ipmi/isa_ipmi_bt.o CC hw/isa/isa-bus.o CC hw/isa/apm.o CC hw/mem/pc-dimm.o CC hw/mem/nvdimm.o CC hw/misc/applesmc.o CC hw/misc/max111x.o CC hw/misc/tmp105.o CC hw/misc/tmp421.o CC hw/misc/debugexit.o CC hw/misc/sga.o CC hw/misc/pc-testdev.o CC hw/misc/pci-testdev.o CC hw/misc/edu.o CC hw/misc/unimp.o CC hw/misc/vmcoreinfo.o CC hw/misc/arm_l2x0.o CC hw/misc/arm_integrator_debug.o CC hw/misc/a9scu.o CC hw/misc/arm11scu.o CC hw/net/xen_nic.o CC hw/net/ne2000.o CC hw/net/eepro100.o CC hw/net/pcnet-pci.o CC hw/net/pcnet.o CC hw/net/e1000.o CC hw/net/e1000x_common.o CC hw/net/net_tx_pkt.o CC hw/net/net_rx_pkt.o CC hw/net/e1000e.o CC hw/net/e1000e_core.o CC hw/net/rtl8139.o CC hw/net/vmxnet3.o CC hw/net/smc91c111.o CC hw/net/lan9118.o CC hw/net/ne2000-isa.o CC hw/net/xgmac.o CC hw/net/xilinx_axienet.o CC hw/net/allwinner_emac.o CC hw/net/imx_fec.o CC hw/net/cadence_gem.o CC hw/net/stellaris_enet.o CC hw/net/ftgmac100.o CC hw/net/rocker/rocker.o CC hw/net/rocker/rocker_fp.o CC hw/net/rocker/rocker_desc.o CC hw/net/rocker/rocker_world.o CC hw/net/rocker/rocker_of_dpa.o CC hw/nvram/eeprom93xx.o CC hw/nvram/eeprom_at24c.o CC hw/nvram/fw_cfg.o CC hw/nvram/chrp_nvram.o CC hw/pci-bridge/pci_bridge_dev.o CC hw/pci-bridge/pcie_root_port.o CC hw/pci-bridge/gen_pcie_root_port.o CC hw/pci-bridge/pcie_pci_bridge.o CC hw/pci-bridge/pci_expander_bridge.o CC hw/pci-bridge/xio3130_upstream.o CC hw/pci-bridge/xio3130_downstream.o CC hw/pci-bridge/ioh3420.o CC hw/pci-bridge/i82801b11.o CC hw/pci-host/pam.o CC hw/pci-host/versatile.o CC hw/pci-host/piix.o CC hw/pci-host/gpex.o CC hw/pci-host/q35.o CC hw/pci/pci.o CC hw/pci/pci_bridge.o CC hw/pci/msix.o CC hw/pci/msi.o CC hw/pci/shpc.o CC hw/pci/slotid_cap.o CC hw/pci/pci_host.o CC hw/pci/pcie_host.o CC hw/pci/pcie.o CC hw/pci/pcie_aer.o CC hw/pci/pcie_port.o CC hw/pci/pci-stub.o CC hw/pcmcia/pcmcia.o CC hw/scsi/scsi-disk.o CC hw/scsi/scsi-generic.o CC hw/scsi/scsi-bus.o CC hw/scsi/lsi53c895a.o CC hw/scsi/mptsas.o CC hw/scsi/mptconfig.o CC hw/scsi/mptendian.o CC hw/scsi/megasas.o CC hw/scsi/vmw_pvscsi.o CC hw/scsi/esp.o CC hw/scsi/esp-pci.o CC hw/sd/pl181.o CC hw/sd/ssi-sd.o CC hw/sd/sd.o CC hw/sd/core.o CC hw/sd/sdhci.o CC hw/smbios/smbios.o CC hw/smbios/smbios_type_38.o CC hw/smbios/smbios-stub.o CC hw/smbios/smbios_type_38-stub.o CC hw/ssi/pl022.o CC hw/ssi/ssi.o CC hw/ssi/xilinx_spips.o CC hw/ssi/aspeed_smc.o CC hw/ssi/stm32f2xx_spi.o CC hw/ssi/mss-spi.o CC hw/timer/arm_timer.o CC hw/timer/arm_mptimer.o CC hw/timer/armv7m_systick.o CC hw/timer/a9gtimer.o CC hw/timer/cadence_ttc.o CC hw/timer/ds1338.o CC hw/timer/hpet.o CC hw/timer/i8254_common.o CC hw/timer/i8254.o CC hw/timer/pl031.o CC hw/timer/twl92230.o CC hw/timer/imx_epit.o CC hw/timer/imx_gpt.o CC hw/timer/stm32f2xx_timer.o CC hw/timer/aspeed_timer.o CC hw/timer/cmsdk-apb-timer.o CC hw/timer/mss-timer.o CC hw/tpm/tpm_util.o CC hw/tpm/tpm_tis.o CC hw/tpm/tpm_passthrough.o CC hw/tpm/tpm_emulator.o CC hw/usb/core.o CC hw/usb/combined-packet.o CC hw/usb/bus.o CC hw/usb/libhw.o CC hw/usb/desc.o CC hw/usb/desc-msos.o CC hw/usb/hcd-uhci.o CC hw/usb/hcd-ohci.o CC hw/usb/hcd-ehci.o CC hw/usb/hcd-ehci-pci.o CC hw/usb/hcd-ehci-sysbus.o CC hw/usb/hcd-xhci.o CC hw/usb/hcd-xhci-nec.o CC hw/usb/hcd-musb.o CC hw/usb/dev-hub.o CC hw/usb/dev-hid.o CC hw/usb/dev-wacom.o CC hw/usb/dev-storage.o CC hw/usb/dev-uas.o CC hw/usb/dev-audio.o CC hw/usb/dev-serial.o CC hw/usb/dev-network.o CC hw/usb/dev-bluetooth.o CC hw/usb/dev-smartcard-reader.o CC hw/usb/ccid-card-passthru.o CC hw/usb/ccid-card-emulated.o CC hw/usb/dev-mtp.o CC hw/usb/host-stub.o CC hw/virtio/virtio-rng.o CC hw/virtio/virtio-pci.o CC hw/virtio/virtio-bus.o CC hw/virtio/virtio-mmio.o CC hw/virtio/vhost-stub.o CC hw/watchdog/watchdog.o CC hw/watchdog/wdt_i6300esb.o CC hw/watchdog/wdt_ib700.o CC hw/watchdog/wdt_aspeed.o CC hw/xen/xen_backend.o CC hw/xen/xen_devconfig.o CC hw/xen/xen_pvdev.o CC hw/xen/xen-common.o CC migration/migration.o CC migration/socket.o CC migration/fd.o CC migration/exec.o CC migration/tls.o CC migration/channel.o CC migration/savevm.o CC migration/colo-comm.o CC migration/colo.o CC migration/colo-failover.o CC migration/vmstate.o CC migration/vmstate-types.o CC migration/page_cache.o CC migration/qemu-file.o CC migration/global_state.o CC migration/qemu-file-channel.o CC migration/xbzrle.o CC migration/postcopy-ram.o CC migration/qjson.o CC migration/rdma.o CC migration/block.o CC net/net.o CC net/queue.o CC net/checksum.o CC net/util.o CC net/hub.o CC net/socket.o CC net/dump.o CC net/eth.o CC net/l2tpv3.o CC net/vhost-user.o CC net/slirp.o CC net/filter.o CC net/filter-buffer.o CC net/filter-mirror.o CC net/colo-compare.o CC net/colo.o CC net/filter-rewriter.o CC net/filter-replay.o CC net/tap.o CC net/tap-linux.o CC qom/cpu.o CC replay/replay.o CC replay/replay-internal.o CC replay/replay-events.o CC replay/replay-time.o CC replay/replay-input.o CC replay/replay-char.o CC replay/replay-snapshot.o CC replay/replay-net.o CC replay/replay-audio.o CC slirp/cksum.o CC slirp/if.o CC slirp/ip_icmp.o CC slirp/ip6_icmp.o CC slirp/ip6_input.o CC slirp/ip6_output.o CC slirp/ip_input.o CC slirp/ip_output.o CC slirp/dnssearch.o CC slirp/slirp.o CC slirp/mbuf.o CC slirp/dhcpv6.o CC slirp/misc.o CC slirp/sbuf.o CC slirp/socket.o CC slirp/tcp_input.o CC slirp/tcp_output.o CC slirp/tcp_subr.o CC slirp/tcp_timer.o
/tmp/qemu-test/src/slirp/tcp_input.c: In function 'tcp_input':/tmp/qemu-test/src/slirp/tcp_input.c:219: warning: 'save_ip.ip_p' may be used uninitialized in this function /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: 'save_ip.ip_len' may be used uninitialized in this function /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: 'save_ip.ip_tos' may be used uninitialized in this function /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: 'save_ip.ip_id' may be used uninitialized in this function /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: 'save_ip.ip_off' may be used uninitialized in this function /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: 'save_ip.ip_ttl' may be used uninitialized in this function /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: 'save_ip.ip_sum' may be used uninitialized in this function /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: 'save_ip.ip_src.s_addr' may be used uninitialized in this function /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: 'save_ip.ip_dst.s_addr' may be used uninitialized in this function /tmp/qemu-test/src/slirp/tcp_input.c:220: warning: 'save_ip6.ip_nh' may be used uninitialized in this function
CC slirp/udp.o
CC slirp/udp6.o
CC slirp/bootp.o
CC slirp/tftp.o
CC slirp/arp_table.o
CC slirp/ndp_table.o
CC slirp/ncsi.o
CC ui/keymaps.o
CC ui/console.o
CC ui/cursor.o
CC ui/qemu-pixman.o
CC ui/input.o
CC ui/input-keymap.o
CC ui/input-legacy.o
CC ui/input-linux.o
CC ui/spice-core.o
CC ui/spice-input.o
CC ui/spice-display.o
CC ui/sdl.o
CC ui/sdl_zoom.o
CC ui/x_keymap.o
CC ui/curses.o
CC ui/vnc.o
CC ui/vnc-enc-zlib.o
CC ui/vnc-enc-hextile.o
CC ui/vnc-enc-tight.o
CC ui/vnc-palette.o
CC ui/vnc-enc-zrle.o
CC ui/vnc-auth-vencrypt.o
CC ui/vnc-ws.o
CC ui/vnc-jobs.o
CC ui/gtk.o
VERT ui/shader/texture-blit-vert.h
VERT ui/shader/texture-blit-flip-vert.h
FRAG ui/shader/texture-blit-frag.h
CC ui/console-gl.o
CC ui/egl-helpers.o
CC ui/egl-context.o
CC ui/gtk-egl.o
CC chardev/char.o
CC chardev/char-fd.o
CC chardev/char-fe.o
CC chardev/char-file.o
CC chardev/char-io.o
CC chardev/char-mux.o
CC chardev/char-null.o
CC chardev/char-parallel.o
CC chardev/char-pipe.o
CC chardev/char-pty.o
In file included from /usr/include/gtk-2.0/gtk/gtk.h:235,
from /tmp/qemu-test/src/include/ui/gtk.h:10,
from /tmp/qemu-test/src/ui/gtk-egl.c:21:
/usr/include/gtk-2.0/gtk/gtkitemfactory.h:47: warning: function declaration isn't a prototype
CC chardev/char-ringbuf.o
CC chardev/char-serial.o
CC chardev/char-socket.o
CC chardev/char-stdio.o
CC chardev/char-udp.o
In file included from /usr/include/gtk-2.0/gtk/gtk.h:235,
from /tmp/qemu-test/src/include/ui/gtk.h:10,
from /tmp/qemu-test/src/ui/gtk.c:43:
/usr/include/gtk-2.0/gtk/gtkitemfactory.h:47: warning: function declaration isn't a prototype
LINK tests/qemu-iotests/socket_scm_helper
CC qga/commands.o
CC qga/guest-agent-command-state.o
CC qga/main.o
AS optionrom/multiboot.o
AS optionrom/linuxboot.o
CC optionrom/linuxboot_dma.oAS optionrom/kvmvapic.o CC qga/commands-posix.o CC qga/channel-posix.o BUILD optionrom/multiboot.img BUILD optionrom/linuxboot.img BUILD optionrom/linuxboot_dma.img BUILD optionrom/kvmvapic.img BUILD optionrom/multiboot.raw BUILD optionrom/linuxboot.raw BUILD optionrom/linuxboot_dma.raw BUILD optionrom/kvmvapic.raw CC qga/qapi-generated/qga-qapi-types.o SIGN optionrom/multiboot.bin SIGN optionrom/linuxboot.bin SIGN optionrom/linuxboot_dma.bin CC qga/qapi-generated/qga-qapi-visit.o CC qga/qapi-generated/qga-qmp-marshal.o SIGN optionrom/kvmvapic.bin AR libqemuutil.a CC qemu-img.o CC ui/shader.o LINK ivshmem-client LINK ivshmem-server LINK qemu-nbd LINK qemu-io LINK scsi/qemu-pr-helper LINK qemu-bridge-helper LINK qemu-ga GEN x86_64-softmmu/hmp-commands.h GEN x86_64-softmmu/hmp-commands-info.h GEN x86_64-softmmu/config-target.h GEN aarch64-softmmu/hmp-commands-info.h GEN aarch64-softmmu/hmp-commands.h GEN aarch64-softmmu/config-target.h CC x86_64-softmmu/exec.o CC x86_64-softmmu/tcg/optimize.o CC x86_64-softmmu/fpu/softfloat.o CC x86_64-softmmu/tcg/tcg.o CC x86_64-softmmu/tcg/tcg-common.o CC x86_64-softmmu/tcg/tcg-op.o CC aarch64-softmmu/exec.o CC x86_64-softmmu/disas.o GEN x86_64-softmmu/gdbstub-xml.c CC aarch64-softmmu/tcg/tcg.o CC aarch64-softmmu/tcg/tcg-op.o CC x86_64-softmmu/arch_init.o CC x86_64-softmmu/cpus.o CC x86_64-softmmu/monitor.o CC x86_64-softmmu/gdbstub.o CC x86_64-softmmu/balloon.o CC x86_64-softmmu/ioport.o CC x86_64-softmmu/numa.o CC aarch64-softmmu/tcg/optimize.o CC x86_64-softmmu/qtest.o CC x86_64-softmmu/memory.o CC aarch64-softmmu/tcg/tcg-common.o LINK qemu-img CC aarch64-softmmu/fpu/softfloat.o CC aarch64-softmmu/disas.o CC x86_64-softmmu/memory_mapping.o CC x86_64-softmmu/dump.o GEN aarch64-softmmu/gdbstub-xml.c CC x86_64-softmmu/migration/ram.o CC x86_64-softmmu/accel/accel.o CC x86_64-softmmu/accel/kvm/kvm-all.o CC aarch64-softmmu/arch_init.o CC x86_64-softmmu/accel/stubs/hax-stub.o CC aarch64-softmmu/cpus.o CC x86_64-softmmu/accel/stubs/hvf-stub.o CC x86_64-softmmu/accel/tcg/tcg-all.o CC aarch64-softmmu/monitor.o CC x86_64-softmmu/accel/tcg/cputlb.o CC x86_64-softmmu/accel/tcg/tcg-runtime.o CC x86_64-softmmu/accel/tcg/cpu-exec.o CC aarch64-softmmu/gdbstub.o CC aarch64-softmmu/balloon.o CC aarch64-softmmu/ioport.o CC aarch64-softmmu/numa.o CC aarch64-softmmu/qtest.o CC x86_64-softmmu/accel/tcg/cpu-exec-common.o CC x86_64-softmmu/accel/tcg/translate-all.o CC aarch64-softmmu/memory.o CC aarch64-softmmu/memory_mapping.o CC aarch64-softmmu/dump.o CC aarch64-softmmu/migration/ram.o CC aarch64-softmmu/accel/accel.o CC x86_64-softmmu/accel/tcg/translator.o CC x86_64-softmmu/hw/block/virtio-blk.o CC x86_64-softmmu/hw/block/dataplane/virtio-blk.o CC aarch64-softmmu/accel/stubs/hax-stub.o CC x86_64-softmmu/hw/char/virtio-serial-bus.o CC aarch64-softmmu/accel/stubs/hvf-stub.o CC x86_64-softmmu/hw/core/generic-loader.o CC x86_64-softmmu/hw/core/null-machine.o CC x86_64-softmmu/hw/display/vga.o CC aarch64-softmmu/accel/stubs/kvm-stub.o CC x86_64-softmmu/hw/display/virtio-gpu.o CC x86_64-softmmu/hw/display/virtio-gpu-3d.o CC x86_64-softmmu/hw/display/virtio-gpu-pci.o CC aarch64-softmmu/accel/tcg/tcg-all.o CC aarch64-softmmu/accel/tcg/cputlb.o CC x86_64-softmmu/hw/display/virtio-vga.o CC aarch64-softmmu/accel/tcg/tcg-runtime.o CC x86_64-softmmu/hw/intc/apic.o CC aarch64-softmmu/accel/tcg/cpu-exec.o CC x86_64-softmmu/hw/intc/apic_common.o CC x86_64-softmmu/hw/intc/ioapic.o CC aarch64-softmmu/accel/tcg/cpu-exec-common.o CC x86_64-softmmu/hw/isa/lpc_ich9.o CC x86_64-softmmu/hw/misc/ivshmem.o CC x86_64-softmmu/hw/misc/pvpanic.o CC aarch64-softmmu/accel/tcg/translate-all.o CC x86_64-softmmu/hw/misc/hyperv_testdev.o CC aarch64-softmmu/accel/tcg/translator.o CC x86_64-softmmu/hw/misc/mmio_interface.o CC aarch64-softmmu/hw/adc/stm32f2xx_adc.o CC aarch64-softmmu/hw/block/virtio-blk.o CC x86_64-softmmu/hw/net/virtio-net.o CC x86_64-softmmu/hw/net/vhost_net.o CC x86_64-softmmu/hw/scsi/virtio-scsi.o CC x86_64-softmmu/hw/scsi/virtio-scsi-dataplane.o CC x86_64-softmmu/hw/scsi/vhost-scsi-common.o CC aarch64-softmmu/hw/block/dataplane/virtio-blk.o CC aarch64-softmmu/hw/char/exynos4210_uart.o CC x86_64-softmmu/hw/scsi/vhost-scsi.o CC x86_64-softmmu/hw/scsi/vhost-user-scsi.o CC x86_64-softmmu/hw/timer/mc146818rtc.o CC aarch64-softmmu/hw/char/omap_uart.o CC x86_64-softmmu/hw/vfio/common.o CC aarch64-softmmu/hw/char/digic-uart.o CC aarch64-softmmu/hw/char/stm32f2xx_usart.o CC x86_64-softmmu/hw/vfio/pci.o CC aarch64-softmmu/hw/char/bcm2835_aux.o CC x86_64-softmmu/hw/vfio/pci-quirks.o CC aarch64-softmmu/hw/char/virtio-serial-bus.o CC aarch64-softmmu/hw/core/generic-loader.o CC x86_64-softmmu/hw/vfio/platform.o CC x86_64-softmmu/hw/vfio/spapr.o CC aarch64-softmmu/hw/core/null-machine.o CC x86_64-softmmu/hw/virtio/virtio.o CC x86_64-softmmu/hw/virtio/virtio-balloon.o CC x86_64-softmmu/hw/virtio/vhost.o CC x86_64-softmmu/hw/virtio/vhost-backend.o CC x86_64-softmmu/hw/virtio/vhost-user.o CC aarch64-softmmu/hw/cpu/arm11mpcore.o CC aarch64-softmmu/hw/cpu/realview_mpcore.o CC aarch64-softmmu/hw/cpu/a9mpcore.o CC aarch64-softmmu/hw/cpu/a15mpcore.o CC aarch64-softmmu/hw/display/omap_dss.o CC x86_64-softmmu/hw/virtio/vhost-vsock.o CC x86_64-softmmu/hw/virtio/virtio-crypto.o CC aarch64-softmmu/hw/display/omap_lcdc.o CC aarch64-softmmu/hw/display/pxa2xx_lcd.o CC x86_64-softmmu/hw/virtio/virtio-crypto-pci.o CC aarch64-softmmu/hw/display/bcm2835_fb.o CC x86_64-softmmu/hw/xen/xen-host-pci-device.o CC aarch64-softmmu/hw/display/vga.o CC x86_64-softmmu/hw/xen/xen_pt.o CC x86_64-softmmu/hw/xen/xen_pt_config_init.o CC x86_64-softmmu/hw/xen/xen_pt_graphics.o CC x86_64-softmmu/hw/xen/xen_pt_msi.o CC x86_64-softmmu/hw/xen/xen_pt_load_rom.o CC aarch64-softmmu/hw/display/virtio-gpu.o CC x86_64-softmmu/hw/i386/multiboot.o CC aarch64-softmmu/hw/display/virtio-gpu-3d.o CC aarch64-softmmu/hw/display/virtio-gpu-pci.o CC aarch64-softmmu/hw/display/dpcd.o CC aarch64-softmmu/hw/display/xlnx_dp.o CC aarch64-softmmu/hw/dma/xlnx_dpdma.o CC aarch64-softmmu/hw/dma/omap_dma.o CC aarch64-softmmu/hw/dma/soc_dma.o CC x86_64-softmmu/hw/i386/pc.o CC aarch64-softmmu/hw/dma/pxa2xx_dma.o CC x86_64-softmmu/hw/i386/pc_piix.o CC x86_64-softmmu/hw/i386/pc_q35.o CC aarch64-softmmu/hw/dma/bcm2835_dma.o CC x86_64-softmmu/hw/i386/pc_sysfw.o CC x86_64-softmmu/hw/i386/x86-iommu.o CC x86_64-softmmu/hw/i386/intel_iommu.o CC aarch64-softmmu/hw/gpio/omap_gpio.o CC x86_64-softmmu/hw/i386/amd_iommu.o CC aarch64-softmmu/hw/gpio/imx_gpio.o CC aarch64-softmmu/hw/gpio/bcm2835_gpio.o CC x86_64-softmmu/hw/i386/vmport.o CC x86_64-softmmu/hw/i386/vmmouse.o CC x86_64-softmmu/hw/i386/kvmvapic.o CC aarch64-softmmu/hw/i2c/omap_i2c.o CC x86_64-softmmu/hw/i386/acpi-build.o CC aarch64-softmmu/hw/input/pxa2xx_keypad.o /tmp/qemu-test/src/hw/i386/pc_piix.c: In function 'igd_passthrough_isa_bridge_create': /tmp/qemu-test/src/hw/i386/pc_piix.c:1078: warning: 'pch_rev_id' may be used uninitialized in this function CC aarch64-softmmu/hw/input/tsc210x.o CC x86_64-softmmu/hw/i386/../xenpv/xen_machine_pv.o CC x86_64-softmmu/hw/i386/kvm/clock.o CC x86_64-softmmu/hw/i386/kvm/apic.o CC aarch64-softmmu/hw/intc/armv7m_nvic.o CC x86_64-softmmu/hw/i386/kvm/i8259.o CC x86_64-softmmu/hw/i386/kvm/ioapic.o CC x86_64-softmmu/hw/i386/kvm/i8254.o CC x86_64-softmmu/hw/i386/xen/xen_platform.o CC x86_64-softmmu/hw/i386/xen/xen_apic.o CC x86_64-softmmu/hw/i386/xen/xen_pvdevice.o CC aarch64-softmmu/hw/intc/exynos4210_gic.o CC aarch64-softmmu/hw/intc/exynos4210_combiner.o CC x86_64-softmmu/hw/i386/xen/xen-hvm.o CC x86_64-softmmu/hw/i386/xen/xen-mapcache.o CC aarch64-softmmu/hw/intc/omap_intc.o CC x86_64-softmmu/target/i386/helper.o CC aarch64-softmmu/hw/intc/bcm2835_ic.o CC aarch64-softmmu/hw/intc/bcm2836_control.o /tmp/qemu-test/src/hw/i386/acpi-build.c: In function 'build_append_pci_bus_devices': /tmp/qemu-test/src/hw/i386/acpi-build.c:509: warning: 'notify_method' may be used uninitialized in this function CC x86_64-softmmu/target/i386/cpu.o CC x86_64-softmmu/target/i386/gdbstub.o CC aarch64-softmmu/hw/intc/allwinner-a10-pic.o CC x86_64-softmmu/target/i386/xsave_helper.o CC aarch64-softmmu/hw/intc/aspeed_vic.o CC x86_64-softmmu/target/i386/translate.o CC aarch64-softmmu/hw/intc/arm_gicv3_cpuif.o CC aarch64-softmmu/hw/misc/ivshmem.o CC aarch64-softmmu/hw/misc/arm_sysctl.o CC x86_64-softmmu/target/i386/bpt_helper.o CC x86_64-softmmu/target/i386/cc_helper.o CC aarch64-softmmu/hw/misc/cbus.o CC x86_64-softmmu/target/i386/excp_helper.o CC aarch64-softmmu/hw/misc/exynos4210_pmu.o CC aarch64-softmmu/hw/misc/exynos4210_clk.o CC aarch64-softmmu/hw/misc/exynos4210_rng.o CC aarch64-softmmu/hw/misc/imx_ccm.o CC x86_64-softmmu/target/i386/fpu_helper.o CC aarch64-softmmu/hw/misc/imx31_ccm.o CC aarch64-softmmu/hw/misc/imx25_ccm.o CC x86_64-softmmu/target/i386/int_helper.o CC aarch64-softmmu/hw/misc/imx6_ccm.o CC aarch64-softmmu/hw/misc/imx6_src.o CC aarch64-softmmu/hw/misc/mst_fpga.o CC x86_64-softmmu/target/i386/mem_helper.o CC aarch64-softmmu/hw/misc/omap_clk.o CC aarch64-softmmu/hw/misc/omap_gpmc.o CC aarch64-softmmu/hw/misc/omap_l4.o CC aarch64-softmmu/hw/misc/omap_sdrc.o CC aarch64-softmmu/hw/misc/omap_tap.o CC aarch64-softmmu/hw/misc/bcm2835_mbox.o CC aarch64-softmmu/hw/misc/bcm2835_property.o CC aarch64-softmmu/hw/misc/bcm2835_rng.o CC aarch64-softmmu/hw/misc/zynq_slcr.o CC aarch64-softmmu/hw/misc/zynq-xadc.o CC x86_64-softmmu/target/i386/misc_helper.o CC x86_64-softmmu/target/i386/mpx_helper.o CC aarch64-softmmu/hw/misc/stm32f2xx_syscfg.o CC aarch64-softmmu/hw/misc/mps2-scc.o CC aarch64-softmmu/hw/misc/auxbus.o CC x86_64-softmmu/target/i386/seg_helper.o CC x86_64-softmmu/target/i386/smm_helper.o CC aarch64-softmmu/hw/misc/aspeed_scu.o CC aarch64-softmmu/hw/misc/aspeed_sdmc.o CC aarch64-softmmu/hw/misc/mmio_interface.o CC aarch64-softmmu/hw/misc/msf2-sysreg.o CC x86_64-softmmu/target/i386/svm_helper.o CC x86_64-softmmu/target/i386/machine.o CC aarch64-softmmu/hw/net/virtio-net.o CC x86_64-softmmu/target/i386/arch_memory_mapping.o CC aarch64-softmmu/hw/net/vhost_net.o CC x86_64-softmmu/target/i386/arch_dump.o CC x86_64-softmmu/target/i386/monitor.o CC x86_64-softmmu/target/i386/kvm.o CC x86_64-softmmu/target/i386/hyperv.o CC aarch64-softmmu/hw/pcmcia/pxa2xx.o GEN trace/generated-helpers.c CC x86_64-softmmu/trace/control-target.o CC aarch64-softmmu/hw/scsi/virtio-scsi.o CC x86_64-softmmu/gdbstub-xml.o CC aarch64-softmmu/hw/scsi/virtio-scsi-dataplane.o CC aarch64-softmmu/hw/scsi/vhost-scsi-common.o CC x86_64-softmmu/trace/generated-helpers.o CC aarch64-softmmu/hw/scsi/vhost-scsi.o CC aarch64-softmmu/hw/scsi/vhost-user-scsi.o CC aarch64-softmmu/hw/sd/omap_mmc.o CC aarch64-softmmu/hw/sd/pxa2xx_mmci.o CC aarch64-softmmu/hw/sd/bcm2835_sdhost.o CC aarch64-softmmu/hw/ssi/omap_spi.o CC aarch64-softmmu/hw/ssi/imx_spi.o CC aarch64-softmmu/hw/timer/exynos4210_mct.o CC aarch64-softmmu/hw/timer/exynos4210_pwm.o CC aarch64-softmmu/hw/timer/exynos4210_rtc.o CC aarch64-softmmu/hw/timer/omap_gptimer.o CC aarch64-softmmu/hw/timer/omap_synctimer.o CC aarch64-softmmu/hw/timer/pxa2xx_timer.o CC aarch64-softmmu/hw/timer/digic-timer.o CC aarch64-softmmu/hw/timer/allwinner-a10-pit.o CC aarch64-softmmu/hw/usb/tusb6010.o CC aarch64-softmmu/hw/vfio/common.o CC aarch64-softmmu/hw/vfio/pci.o CC aarch64-softmmu/hw/vfio/pci-quirks.o CC aarch64-softmmu/hw/vfio/platform.o CC aarch64-softmmu/hw/vfio/calxeda-xgmac.o CC aarch64-softmmu/hw/vfio/amd-xgbe.o CC aarch64-softmmu/hw/vfio/spapr.o CC aarch64-softmmu/hw/virtio/virtio.o CC aarch64-softmmu/hw/virtio/virtio-balloon.o CC aarch64-softmmu/hw/virtio/vhost.o CC aarch64-softmmu/hw/virtio/vhost-backend.o CC aarch64-softmmu/hw/virtio/vhost-user.o CC aarch64-softmmu/hw/virtio/vhost-vsock.o CC aarch64-softmmu/hw/virtio/virtio-crypto.o CC aarch64-softmmu/hw/virtio/virtio-crypto-pci.o CC aarch64-softmmu/hw/arm/boot.o CC aarch64-softmmu/hw/arm/collie.o CC aarch64-softmmu/hw/arm/exynos4_boards.o LINK x86_64-softmmu/qemu-system-x86_64 CC aarch64-softmmu/hw/arm/gumstix.o CC aarch64-softmmu/hw/arm/highbank.o CC aarch64-softmmu/hw/arm/digic_boards.o CC aarch64-softmmu/hw/arm/integratorcp.o CC aarch64-softmmu/hw/arm/mainstone.o CC aarch64-softmmu/hw/arm/musicpal.o CC aarch64-softmmu/hw/arm/nseries.o CC aarch64-softmmu/hw/arm/omap_sx1.o CC aarch64-softmmu/hw/arm/palm.o CC aarch64-softmmu/hw/arm/realview.o CC aarch64-softmmu/hw/arm/spitz.o CC aarch64-softmmu/hw/arm/stellaris.o CC aarch64-softmmu/hw/arm/tosa.o CC aarch64-softmmu/hw/arm/versatilepb.o CC aarch64-softmmu/hw/arm/vexpress.o CC aarch64-softmmu/hw/arm/virt.o CC aarch64-softmmu/hw/arm/xilinx_zynq.o CC aarch64-softmmu/hw/arm/z2.o CC aarch64-softmmu/hw/arm/virt-acpi-build.o CC aarch64-softmmu/hw/arm/netduino2.o CC aarch64-softmmu/hw/arm/sysbus-fdt.o CC aarch64-softmmu/hw/arm/armv7m.o CC aarch64-softmmu/hw/arm/exynos4210.o CC aarch64-softmmu/hw/arm/pxa2xx.o CC aarch64-softmmu/hw/arm/pxa2xx_gpio.o CC aarch64-softmmu/hw/arm/pxa2xx_pic.o CC aarch64-softmmu/hw/arm/digic.o CC aarch64-softmmu/hw/arm/omap1.o CC aarch64-softmmu/hw/arm/omap2.o CC aarch64-softmmu/hw/arm/strongarm.o CC aarch64-softmmu/hw/arm/allwinner-a10.o CC aarch64-softmmu/hw/arm/cubieboard.o CC aarch64-softmmu/hw/arm/bcm2835_peripherals.o CC aarch64-softmmu/hw/arm/bcm2836.o CC aarch64-softmmu/hw/arm/raspi.o CC aarch64-softmmu/hw/arm/stm32f205_soc.o CC aarch64-softmmu/hw/arm/xlnx-zynqmp.o CC aarch64-softmmu/hw/arm/xlnx-zcu102.o CC aarch64-softmmu/hw/arm/fsl-imx25.o CC aarch64-softmmu/hw/arm/imx25_pdk.o CC aarch64-softmmu/hw/arm/fsl-imx31.o CC aarch64-softmmu/hw/arm/kzm.o CC aarch64-softmmu/hw/arm/fsl-imx6.o CC aarch64-softmmu/hw/arm/sabrelite.o CC aarch64-softmmu/hw/arm/aspeed_soc.o CC aarch64-softmmu/hw/arm/aspeed.o CC aarch64-softmmu/hw/arm/mps2.o CC aarch64-softmmu/hw/arm/msf2-soc.o CC aarch64-softmmu/hw/arm/msf2-som.o CC aarch64-softmmu/target/arm/arm-semi.o CC aarch64-softmmu/target/arm/machine.o CC aarch64-softmmu/target/arm/psci.o CC aarch64-softmmu/target/arm/arch_dump.o CC aarch64-softmmu/target/arm/monitor.o CC aarch64-softmmu/target/arm/kvm-stub.o CC aarch64-softmmu/target/arm/translate.o CC aarch64-softmmu/target/arm/op_helper.o CC aarch64-softmmu/target/arm/helper.o CC aarch64-softmmu/target/arm/cpu.o CC aarch64-softmmu/target/arm/neon_helper.o CC aarch64-softmmu/target/arm/iwmmxt_helper.o CC aarch64-softmmu/target/arm/gdbstub.o CC aarch64-softmmu/target/arm/cpu64.o CC aarch64-softmmu/target/arm/translate-a64.o CC aarch64-softmmu/target/arm/helper-a64.o CC aarch64-softmmu/target/arm/gdbstub64.o CC aarch64-softmmu/target/arm/crypto_helper.o CC aarch64-softmmu/target/arm/arm-powerctl.o GEN trace/generated-helpers.c CC aarch64-softmmu/trace/control-target.o CC aarch64-softmmu/gdbstub-xml.o CC aarch64-softmmu/trace/generated-helpers.o
/tmp/qemu-test/src/target/arm/translate-a64.c: In function 'handle_shri_with_rndacc':/tmp/qemu-test/src/target/arm/translate-a64.c:6406: warning: 'tcg_src_hi' may be used uninitialized in this function /tmp/qemu-test/src/target/arm/translate-a64.c: In function 'disas_simd_scalar_two_reg_misc':/tmp/qemu-test/src/target/arm/translate-a64.c:8133: warning: 'rmode' may be used uninitialized in this function
LINK aarch64-softmmu/qemu-system-aarch64 TEST tests/qapi-schema/alternate-any.out TEST tests/qapi-schema/alternate-array.out TEST tests/qapi-schema/alternate-clash.out TEST tests/qapi-schema/alternate-base.out TEST tests/qapi-schema/alternate-conflict-enum-bool.out TEST tests/qapi-schema/alternate-conflict-enum-int.out TEST tests/qapi-schema/alternate-conflict-dict.out TEST tests/qapi-schema/alternate-conflict-string.out TEST tests/qapi-schema/alternate-conflict-bool-string.out TEST tests/qapi-schema/alternate-conflict-num-string.out TEST tests/qapi-schema/alternate-empty.out TEST tests/qapi-schema/alternate-nested.out TEST tests/qapi-schema/alternate-unknown.out TEST tests/qapi-schema/args-alternate.out TEST tests/qapi-schema/args-any.out TEST tests/qapi-schema/args-array-empty.out TEST tests/qapi-schema/args-array-unknown.out TEST tests/qapi-schema/args-bad-boxed.out TEST tests/qapi-schema/args-boxed-anon.out TEST tests/qapi-schema/args-boxed-empty.out TEST tests/qapi-schema/args-boxed-string.out TEST tests/qapi-schema/args-int.out TEST tests/qapi-schema/args-invalid.out TEST tests/qapi-schema/args-member-array-bad.out TEST tests/qapi-schema/args-member-case.out TEST tests/qapi-schema/args-member-unknown.out TEST tests/qapi-schema/args-name-clash.out TEST tests/qapi-schema/args-union.out TEST tests/qapi-schema/args-unknown.out TEST tests/qapi-schema/bad-base.out TEST tests/qapi-schema/bad-data.out TEST tests/qapi-schema/bad-ident.out TEST tests/qapi-schema/bad-type-bool.out TEST tests/qapi-schema/bad-type-dict.out TEST tests/qapi-schema/bad-type-int.out TEST tests/qapi-schema/base-cycle-direct.out TEST tests/qapi-schema/base-cycle-indirect.out TEST tests/qapi-schema/command-int.out TEST tests/qapi-schema/comments.out TEST tests/qapi-schema/doc-bad-alternate-member.out TEST tests/qapi-schema/doc-bad-command-arg.out TEST tests/qapi-schema/doc-bad-section.out TEST tests/qapi-schema/doc-bad-symbol.out TEST tests/qapi-schema/doc-bad-union-member.out TEST tests/qapi-schema/doc-before-include.out TEST tests/qapi-schema/doc-before-pragma.out TEST tests/qapi-schema/doc-duplicated-arg.out TEST tests/qapi-schema/doc-duplicated-return.out TEST tests/qapi-schema/doc-duplicated-since.out TEST tests/qapi-schema/doc-empty-arg.out TEST tests/qapi-schema/doc-empty-section.out TEST tests/qapi-schema/doc-empty-symbol.out TEST tests/qapi-schema/doc-good.out TEST tests/qapi-schema/doc-interleaved-section.out TEST tests/qapi-schema/doc-invalid-end.out TEST tests/qapi-schema/doc-invalid-end2.out TEST tests/qapi-schema/doc-invalid-return.out TEST tests/qapi-schema/doc-invalid-section.out TEST tests/qapi-schema/doc-invalid-start.out TEST tests/qapi-schema/doc-missing-colon.out TEST tests/qapi-schema/doc-missing-expr.out TEST tests/qapi-schema/doc-missing-space.out TEST tests/qapi-schema/doc-missing.out TEST tests/qapi-schema/doc-no-symbol.out TEST tests/qapi-schema/double-data.out TEST tests/qapi-schema/double-type.out TEST tests/qapi-schema/duplicate-key.out TEST tests/qapi-schema/empty.out TEST tests/qapi-schema/enum-bad-name.out TEST tests/qapi-schema/enum-bad-prefix.out TEST tests/qapi-schema/enum-clash-member.out TEST tests/qapi-schema/enum-dict-member.out TEST tests/qapi-schema/enum-int-member.out TEST tests/qapi-schema/enum-member-case.out TEST tests/qapi-schema/enum-missing-data.out TEST tests/qapi-schema/enum-wrong-data.out TEST tests/qapi-schema/escape-outside-string.out TEST tests/qapi-schema/escape-too-big.out TEST tests/qapi-schema/escape-too-short.out TEST tests/qapi-schema/event-boxed-empty.out TEST tests/qapi-schema/event-case.out TEST tests/qapi-schema/event-nest-struct.out TEST tests/qapi-schema/flat-union-array-branch.out TEST tests/qapi-schema/flat-union-bad-base.out TEST tests/qapi-schema/flat-union-bad-discriminator.out TEST tests/qapi-schema/flat-union-base-any.out TEST tests/qapi-schema/flat-union-base-union.out TEST tests/qapi-schema/flat-union-clash-member.out TEST tests/qapi-schema/flat-union-empty.out TEST tests/qapi-schema/flat-union-incomplete-branch.out TEST tests/qapi-schema/flat-union-inline.out TEST tests/qapi-schema/flat-union-int-branch.out TEST tests/qapi-schema/flat-union-invalid-branch-key.out TEST tests/qapi-schema/flat-union-invalid-discriminator.out TEST tests/qapi-schema/flat-union-no-base.out TEST tests/qapi-schema/flat-union-optional-discriminator.out TEST tests/qapi-schema/flat-union-string-discriminator.out TEST tests/qapi-schema/funny-char.out TEST tests/qapi-schema/ident-with-escape.out TEST tests/qapi-schema/include-before-err.out TEST tests/qapi-schema/include-cycle.out TEST tests/qapi-schema/include-extra-junk.out TEST tests/qapi-schema/include-nested-err.out TEST tests/qapi-schema/include-format-err.out TEST tests/qapi-schema/include-no-file.out TEST tests/qapi-schema/include-non-file.out TEST tests/qapi-schema/include-relpath.out TEST tests/qapi-schema/include-repetition.out TEST tests/qapi-schema/include-self-cycle.out TEST tests/qapi-schema/include-simple.out TEST tests/qapi-schema/leading-comma-list.out TEST tests/qapi-schema/indented-expr.out TEST tests/qapi-schema/leading-comma-object.out TEST tests/qapi-schema/missing-colon.out TEST tests/qapi-schema/missing-comma-list.out TEST tests/qapi-schema/missing-comma-object.out TEST tests/qapi-schema/missing-type.out TEST tests/qapi-schema/nested-struct-data.out TEST tests/qapi-schema/non-objects.out TEST tests/qapi-schema/pragma-doc-required-crap.out TEST tests/qapi-schema/pragma-extra-junk.out TEST tests/qapi-schema/pragma-name-case-whitelist-crap.out TEST tests/qapi-schema/pragma-non-dict.out TEST tests/qapi-schema/pragma-returns-whitelist-crap.out TEST tests/qapi-schema/qapi-schema-test.out TEST tests/qapi-schema/quoted-structural-chars.out TEST tests/qapi-schema/redefined-builtin.out TEST tests/qapi-schema/redefined-command.out TEST tests/qapi-schema/redefined-event.out TEST tests/qapi-schema/redefined-type.out TEST tests/qapi-schema/reserved-command-q.out TEST tests/qapi-schema/reserved-enum-q.out TEST tests/qapi-schema/reserved-member-has.out TEST tests/qapi-schema/reserved-member-q.out TEST tests/qapi-schema/reserved-member-u.out TEST tests/qapi-schema/reserved-member-underscore.out TEST tests/qapi-schema/reserved-type-kind.out TEST tests/qapi-schema/reserved-type-list.out TEST tests/qapi-schema/returns-alternate.out TEST tests/qapi-schema/returns-array-bad.out TEST tests/qapi-schema/returns-dict.out TEST tests/qapi-schema/returns-unknown.out TEST tests/qapi-schema/returns-whitelist.out TEST tests/qapi-schema/struct-base-clash-deep.out TEST tests/qapi-schema/struct-base-clash.out TEST tests/qapi-schema/struct-member-invalid.out TEST tests/qapi-schema/struct-data-invalid.out TEST tests/qapi-schema/trailing-comma-list.out TEST tests/qapi-schema/trailing-comma-object.out TEST tests/qapi-schema/type-bypass-bad-gen.out TEST tests/qapi-schema/unclosed-list.out TEST tests/qapi-schema/unclosed-string.out TEST tests/qapi-schema/unclosed-object.out TEST tests/qapi-schema/unicode-str.out TEST tests/qapi-schema/union-base-empty.out TEST tests/qapi-schema/union-base-no-discriminator.out TEST tests/qapi-schema/union-branch-case.out TEST tests/qapi-schema/union-clash-branches.out TEST tests/qapi-schema/union-empty.out TEST tests/qapi-schema/union-invalid-base.out TEST tests/qapi-schema/union-optional-branch.out TEST tests/qapi-schema/union-unknown.out TEST tests/qapi-schema/unknown-expr-key.out TEST tests/qapi-schema/unknown-escape.out GEN tests/qapi-schema/doc-good.test.texi CC tests/check-qdict.o CC tests/test-char.o CC tests/check-qnum.o CC tests/check-qstring.o CC tests/check-qlist.o CC tests/check-qnull.o CC tests/check-qobject.o CC tests/check-qjson.o CC tests/check-qlit.o CC tests/test-qobject-output-visitor.o GEN tests/test-qapi-visit.c GEN tests/test-qapi-types.c GEN tests/test-qapi-event.c GEN tests/test-qmp-introspect.c CC tests/test-qobject-input-visitor.o CC tests/test-clone-visitor.o CC tests/test-qmp-commands.o GEN tests/test-qmp-marshal.c CC tests/test-string-output-visitor.o CC tests/test-string-input-visitor.o CC tests/test-qmp-event.o CC tests/test-opts-visitor.o CC tests/test-coroutine.o CC tests/iothread.o CC tests/test-visitor-serialization.o CC tests/test-iov.o CC tests/test-aio.o CC tests/test-aio-multithread.o CC tests/test-throttle.o CC tests/test-thread-pool.o CC tests/test-hbitmap.o CC tests/test-bdrv-drain.o CC tests/test-blockjob.o CC tests/test-blockjob-txn.o CC tests/test-x86-cpuid.o CC tests/test-xbzrle.o CC tests/test-vmstate.o CC tests/test-cutils.o CC tests/test-shift128.o CC tests/test-mul64.o CC tests/test-int128.o CC tests/rcutorture.o CC tests/test-rcu-list.o /tmp/qemu-test/src/tests/test-int128.c:180: warning: '__noclone__' attribute directive ignored CC tests/test-qdist.o CC tests/test-qht.o CC tests/test-qht-par.o CC tests/qht-bench.o CC tests/test-bitops.o CC tests/check-qom-interface.o CC tests/test-bitcnt.o CC tests/check-qom-proplist.o CC tests/test-qemu-opts.o CC tests/test-keyval.o CC tests/test-write-threshold.o CC tests/test-crypto-hash.o CC tests/test-crypto-hmac.o CC tests/test-crypto-cipher.o CC tests/test-crypto-secret.o CC tests/test-qga.o CC tests/libqtest.o CC tests/test-timed-average.o CC tests/test-io-task.o CC tests/test-io-channel-socket.o CC tests/io-channel-helpers.o CC tests/test-io-channel-file.o CC tests/test-io-channel-command.o CC tests/test-io-channel-buffer.o CC tests/test-base64.o CC tests/test-crypto-ivgen.o CC tests/test-crypto-afsplit.o CC tests/test-crypto-xts.o CC tests/test-crypto-block.o CC tests/test-logging.o CC tests/test-replication.o CC tests/test-bufferiszero.o CC tests/test-uuid.o CC tests/ptimer-test.o CC tests/ptimer-test-stubs.o CC tests/test-qapi-util.o CC tests/vhost-user-test.o CC tests/libqos/pci.o CC tests/libqos/fw_cfg.o CC tests/libqos/malloc.o CC tests/libqos/i2c.o CC tests/libqos/libqos.o CC tests/libqos/malloc-spapr.o CC tests/libqos/libqos-spapr.o CC tests/libqos/rtas.o CC tests/libqos/pci-spapr.o CC tests/libqos/pci-pc.o CC tests/libqos/malloc-pc.o CC tests/libqos/libqos-pc.o CC tests/libqos/ahci.o CC tests/libqos/virtio.o CC tests/libqos/virtio-pci.o CC tests/libqos/virtio-mmio.o CC tests/libqos/malloc-generic.o CC tests/endianness-test.o CC tests/fdc-test.o CC tests/ide-test.o CC tests/ahci-test.o CC tests/hd-geo-test.o CC tests/bios-tables-test.o CC tests/boot-order-test.o CC tests/boot-sector.o CC tests/acpi-utils.o CC tests/boot-serial-test.o CC tests/pxe-test.o CC tests/rtc-test.o CC tests/ipmi-kcs-test.o CC tests/ipmi-bt-test.o CC tests/i440fx-test.o CC tests/fw_cfg-test.o CC tests/drive_del-test.o CC tests/wdt_ib700-test.o CC tests/tco-test.o CC tests/e1000-test.o CC tests/e1000e-test.o CC tests/rtl8139-test.o CC tests/pcnet-test.o CC tests/eepro100-test.o CC tests/ne2000-test.o CC tests/nvme-test.o CC tests/ac97-test.o CC tests/es1370-test.o CC tests/virtio-net-test.o CC tests/virtio-balloon-test.o CC tests/virtio-blk-test.o CC tests/virtio-rng-test.o CC tests/virtio-scsi-test.o CC tests/virtio-serial-test.o CC tests/virtio-console-test.o CC tests/tpci200-test.o CC tests/ipoctal232-test.o CC tests/display-vga-test.o CC tests/intel-hda-test.o CC tests/ivshmem-test.o CC tests/megasas-test.o CC tests/vmxnet3-test.o CC tests/pvpanic-test.o CC tests/i82801b11-test.o CC tests/ioh3420-test.o CC tests/usb-hcd-ohci-test.o CC tests/libqos/usb.o CC tests/usb-hcd-uhci-test.o CC tests/usb-hcd-ehci-test.o CC tests/usb-hcd-xhci-test.o CC tests/pc-cpu-test.o CC tests/q35-test.o CC tests/vmgenid-test.o CC tests/test-netfilter.o CC tests/test-filter-mirror.o CC tests/test-filter-redirector.o CC tests/migration-test.o CC tests/test-x86-cpuid-compat.o CC tests/numa-test.o CC tests/qmp-test.o CC tests/device-introspect-test.o CC tests/qom-test.o CC tests/test-hmp.o LINK tests/check-qdict LINK tests/test-char LINK tests/check-qnum LINK tests/check-qstring LINK tests/check-qlist LINK tests/check-qnull LINK tests/check-qobject LINK tests/check-qjson LINK tests/check-qlit CC tests/test-qmp-introspect.o CC tests/test-qapi-types.o CC tests/test-qapi-event.o CC tests/test-qapi-visit.o CC tests/test-qmp-marshal.o LINK tests/test-coroutine LINK tests/test-iov LINK tests/test-aio LINK tests/test-aio-multithread LINK tests/test-throttle LINK tests/test-thread-pool LINK tests/test-hbitmap LINK tests/test-bdrv-drain LINK tests/test-blockjob LINK tests/test-blockjob-txn LINK tests/test-x86-cpuid LINK tests/test-xbzrle LINK tests/test-vmstate LINK tests/test-cutils LINK tests/test-shift128 LINK tests/test-mul64 LINK tests/test-int128 LINK tests/rcutorture LINK tests/test-rcu-list LINK tests/test-qdist LINK tests/test-qht LINK tests/qht-bench LINK tests/test-bitops LINK tests/test-bitcnt LINK tests/check-qom-interface LINK tests/check-qom-proplist LINK tests/test-qemu-opts LINK tests/test-keyval LINK tests/test-write-threshold LINK tests/test-crypto-hash LINK tests/test-crypto-hmac LINK tests/test-crypto-cipher LINK tests/test-crypto-secret LINK tests/test-qga LINK tests/test-timed-average LINK tests/test-io-task LINK tests/test-io-channel-socket LINK tests/test-io-channel-file LINK tests/test-io-channel-command LINK tests/test-io-channel-buffer LINK tests/test-base64 LINK tests/test-crypto-ivgen LINK tests/test-crypto-afsplit LINK tests/test-crypto-xts LINK tests/test-crypto-block LINK tests/test-logging LINK tests/test-replication LINK tests/test-bufferiszero LINK tests/test-uuid LINK tests/ptimer-test LINK tests/test-qapi-util LINK tests/vhost-user-test LINK tests/endianness-test LINK tests/fdc-test LINK tests/ide-test LINK tests/ahci-test LINK tests/hd-geo-test LINK tests/boot-order-test LINK tests/bios-tables-test LINK tests/boot-serial-test LINK tests/pxe-test LINK tests/rtc-test LINK tests/ipmi-kcs-test LINK tests/ipmi-bt-test LINK tests/i440fx-test LINK tests/fw_cfg-test LINK tests/drive_del-test LINK tests/wdt_ib700-test LINK tests/tco-test LINK tests/e1000-test LINK tests/e1000e-test LINK tests/rtl8139-test LINK tests/pcnet-test LINK tests/eepro100-test LINK tests/ne2000-test LINK tests/nvme-test LINK tests/ac97-test LINK tests/es1370-test LINK tests/virtio-net-test LINK tests/virtio-balloon-test LINK tests/virtio-blk-test LINK tests/virtio-rng-test LINK tests/virtio-scsi-test LINK tests/virtio-serial-test LINK tests/virtio-console-test LINK tests/tpci200-test LINK tests/ipoctal232-test LINK tests/display-vga-test LINK tests/intel-hda-test LINK tests/ivshmem-test LINK tests/megasas-test LINK tests/vmxnet3-test LINK tests/pvpanic-test LINK tests/i82801b11-test LINK tests/ioh3420-test LINK tests/usb-hcd-ohci-test LINK tests/usb-hcd-uhci-test LINK tests/usb-hcd-ehci-test LINK tests/usb-hcd-xhci-test LINK tests/pc-cpu-test LINK tests/q35-test LINK tests/vmgenid-test LINK tests/test-netfilter LINK tests/test-filter-mirror LINK tests/test-filter-redirector LINK tests/migration-test LINK tests/test-x86-cpuid-compat LINK tests/numa-test LINK tests/qmp-test LINK tests/device-introspect-test LINK tests/qom-test LINK tests/test-hmp GTESTER tests/check-qnum GTESTER tests/test-char GTESTER tests/check-qdict GTESTER tests/check-qstring GTESTER tests/check-qlist GTESTER tests/check-qnull GTESTER tests/check-qobject GTESTER tests/check-qjson GTESTER tests/check-qlit LINK tests/test-qobject-output-visitor LINK tests/test-clone-visitor LINK tests/test-qobject-input-visitor LINK tests/test-qmp-commands GTester: last random seed: R02Sf5382dc2dd103fd2a6ba5289f1e65ba4 LINK tests/test-string-input-visitor LINK tests/test-string-output-visitor LINK tests/test-qmp-event LINK tests/test-opts-visitor
GTESTER tests/test-coroutine
GTester: last random seed: R02S3eed7b921e024c71eab178ed06aabc7d
GTester: last random seed: R02S43a2c6b081504d25d208b34c2c6629fe
LINK tests/test-visitor-serialization
GTESTER tests/test-iov
GTESTER tests/test-aio
GTESTER tests/test-throttle
GTESTER tests/test-aio-multithread
GTESTER tests/test-thread-pool
GTESTER tests/test-hbitmap
GTESTER tests/test-bdrv-drain
GTESTER tests/test-blockjob
GTESTER tests/test-blockjob-txn
GTESTER tests/test-x86-cpuid
GTESTER tests/test-xbzrle
GTESTER tests/test-vmstate
Failed to load simple/primitive:b_1
Failed to load simple/primitive:i64_2
Failed to load simple/primitive:i32_1
Failed to load simple/primitive:i32_1
Failed to load test/with_tmp:a
Failed to load test/tmp_child_parent:f
Failed to load test/tmp_child:parent
Failed to load test/with_tmp:tmp
Failed to load test/tmp_child:diff
Failed to load test/with_tmp:tmp
Failed to load test/tmp_child:diff
Failed to load test/with_tmp:tmp
GTester: last random seed: R02Sda41beee7780f80ca50520c480253d02
GTESTER tests/test-cutils
GTESTER tests/test-shift128
GTESTER tests/test-mul64
GTESTER tests/test-int128
GTESTER tests/rcutorture
GTESTER tests/test-rcu-list
GTESTER tests/test-qdist
GTESTER tests/test-qht
GTester: last random seed: R02S1d8ae476122d5550b2150de38835d437
make: *** [check-tests/test-char] Error 1
make: *** Waiting for unfinished jobs....
make: *** wait: No child processes. Stop.
Traceback (most recent call last):
File "./tests/docker/docker.py", line 407, in <module>
sys.exit(main())
File "./tests/docker/docker.py", line 404, in main
return args.cmdobj.run(args, argv)
File "./tests/docker/docker.py", line 261, in run
return Docker().run(argv, args.keep, quiet=args.quiet)
File "./tests/docker/docker.py", line 229, in run
quiet=quiet)
File "./tests/docker/docker.py", line 147, in _do_check
return subprocess.check_call(self._command + cmd, **kwargs)
File "/usr/lib64/python2.7/subprocess.py", line 186, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['docker', 'run', '--label', 'com.qemu.instance.uuid=551b702afcfa11e7840152540069c830', '-u', '0', '--security-opt', 'seccomp=unconfined', '--rm', '--net=none', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=8', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/root/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-o2p83o2g/src/docker-src.2018-01-19-04.22.43.21265:/var/tmp/qemu:z,ro', 'qemu:centos6', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2 make[1]: *** [tests/docker/Makefile.include:129: docker-run] Error 1
make: *** [tests/docker/Makefile.include:163: docker-run-test-quick@centos6] Error 2
real 3m10.071s
user 0m3.918s
sys 0m3.069s
=== OUTPUT END ===
Test command exited with code: 2
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to [email protected]
Re: [Qemu-devel] [RFC PATCH v4 12/23] cpus: push BQL lock to qemu_*_wait_io_event
In reply to Paolo BonziniQuoted 10 lines
From: Paolo Bonzini [mailto:[email protected]]
cpus.c static void qemu_tcg_rr_wait_io_event(CPUState *cpu) · line 1163
Quoted 7 lines · Pavel Dovgalyuk
static void
qemu_wait_io_event(CPUState *cpu)
{cpus.c +2
-0+qemu_mutex_lock_iothread (); +while (cpu_thread_is_idle (cpu)) {qemu_cond_wait (cpu->halt_cond, &qemu_global_mutex); }
Quoted 2 lines
This function locks the iothread and never unlocks it. Please test your patches better.
Yes, there was kind of mess. Lock was inside the function and unlock outside, that's why it worked for me.
Pavel Dovgalyuk
Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads
In reply to Paolo BonziniQuoted 9 lines
From: Paolo Bonzini [mailto:[email protected]]
cpus.c static void qemu_wait_io_event_common(CPUState *cpu) · line 1150
Quoted 6 lines · Pavel Dovgalyuk
while (all_cpu_threads_idle()) {cpus.c +2
-0+qemu_mutex_lock_iothread ();stop_tcg_kick_timer ();qemu_cond_wait (cpu->halt_cond, &qemu_global_mutex); +qemu_mutex_unlock_iothread (); }
Quoted 5 lines
cpu_has_workcannot be called outside BQL yet. You first need to accesscpu->interrupt_requestwith atomics.In general, testing the condition outside the mutex is a very dangerous pattern (and I'm usually the one who enjoys dangerous patterns).
It means, that I'll have to fix all the has_work function to avoid races, because x86_cpu_has_work may have them?
static bool x86_cpu_has_work(CPUState *cs)
{
X86CPU *cpu = X86_CPU(cs);
CPUX86State *env = &cpu->env;
return ((cs->interrupt_request & (CPU_INTERRUPT_HARD |
CPU_INTERRUPT_POLL)) &&
(env->eflags & IF_MASK)) ||
(cs->interrupt_request & (CPU_INTERRUPT_NMI |
CPU_INTERRUPT_INIT |
CPU_INTERRUPT_SIPI |
CPU_INTERRUPT_MCE)) ||
((cs->interrupt_request & CPU_INTERRUPT_SMI) &&
!(env->hflags & HF_SMM_MASK));
}Pavel Dovgalyuk
Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads
Quoted 9 lines · Pavel Dovgalyuk
Quoted 9 lines
From: Paolo Bonzini [mailto:[email protected]]
Quoted 6 lines · Pavel Dovgalyuk
while (all_cpu_threads_idle()) {cpus.c +2
-0+qemu_mutex_lock_iothread ();stop_tcg_kick_timer ();qemu_cond_wait (cpu->halt_cond, &qemu_global_mutex); +qemu_mutex_unlock_iothread (); }
Quoted 8 lines
Quoted 5 lines
cpu_has_workcannot be called outside BQL yet. You first need to accesscpu->interrupt_requestwith atomics.In general, testing the condition outside the mutex is a very dangerous pattern (and I'm usually the one who enjoys dangerous patterns).
It means, that I'll have to fix all the
has_workfunction to avoid races, becausex86_cpu_has_workmay have them?
Why only x86_cpu_has_work?
Even reading cs->interrupt_request outside the mutex is unsafe.
Paolo
Quoted 18 lines
static bool
x86_cpu_has_work(CPUState *cs){ X86CPU *cpu = X86_CPU(cs); CPUX86State *env = &cpu->env; return ((cs->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_POLL)) && (env->eflags & IF_MASK)) || (cs->interrupt_request & (CPU_INTERRUPT_NMI | CPU_INTERRUPT_INIT | CPU_INTERRUPT_SIPI | CPU_INTERRUPT_MCE)) || ((cs->interrupt_request & CPU_INTERRUPT_SMI) && !(env->hflags & HF_SMM_MASK)); }Pavel Dovgalyuk
Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads
Quoted 27 lines
-----Original Message-----
From: Paolo Bonzini [mailto:[email protected]]
Sent: Friday, January 19, 2018 3:20 PM
To: Pavel Dovgalyuk; 'Pavel Dovgalyuk'; [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threadsQuoted 15 lines · Pavel Dovgalyuk
Quoted 14 lines
From: Paolo Bonzini [mailto:[email protected]]
cpus.c static void qemu_wait_io_event_common(CPUState *cpu) · line 1150
Quoted 6 lines · Pavel Dovgalyuk
while (all_cpu_threads_idle()) {cpus.c +2
-0+qemu_mutex_lock_iothread ();stop_tcg_kick_timer ();qemu_cond_wait (cpu->halt_cond, &qemu_global_mutex); +qemu_mutex_unlock_iothread (); }
cpu_has_workcannot be called outside BQL yet. You first need to accesscpu->interrupt_requestwith atomics.In general, testing the condition outside the mutex is a very dangerous pattern (and I'm usually the one who enjoys dangerous patterns).
Quoted 6 lines
Quoted 2 lines
It means, that I'll have to fix all the
has_workfunction to avoid races, becausex86_cpu_has_workmay have them?Why only
x86_cpu_has_work?Even reading
cs->interrupt_requestoutside the mutex is unsafe.
All the vcpu function that access interrupt controller or peripheral state may be unsafe? How can it work safely then?
Pavel Dovgalyuk
Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads
Quoted 7 lines · Pavel Dovgalyuk
Quoted 5 lines
Quoted 2 lines
It means, that I'll have to fix all the
has_workfunction to avoid races, becausex86_cpu_has_workmay have them?Why only
x86_cpu_has_work?Even reading
cs->interrupt_requestoutside the mutex is unsafe.All the vcpu function that access interrupt controller or peripheral state may be unsafe? How can it work safely then?
They do it inside the big QEMU lock. But here you're calling cpu_has_work (via all_cpu_threads_idle) outside the lock.
Paolo
Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads
Quoted 11 lines
From: Paolo Bonzini [mailto:[email protected]]
Sent: Friday, January 19, 2018 3:26 PM
To: Pavel Dovgalyuk; 'Pavel Dovgalyuk'; [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threadsQuoted 2 lines · Pavel Dovgalyuk
Quoted 2 lines
Quoted 2 lines
It means, that I'll have to fix all the
has_workfunction to avoid races, becausex86_cpu_has_workmay have them?
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Why only
x86_cpu_has_work?Even reading
cs->interrupt_requestoutside the mutex is unsafe.All the vcpu function that access interrupt controller or peripheral state may be unsafe? How can it work safely then?
They do it inside the big QEMU lock.
Right. Without these patches.
They are within the replay lock. And BQL is not covering vcpu execution with these patches. Therefore RR will be ok and regular execution may encounter races?
It means that I missed something in Alex ideas, because he prepared the initial patches.
Quoted 1 line
But here you're calling
cpu_has_work(viaall_cpu_threads_idle) outside the lock.
Yes, I see, but what we have to do?
Pavel Dovgalyuk
Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads
Pavel Dovgalyuk
Quoted 22 lines
-----Original Message-----
From: Pavel Dovgalyuk [mailto:[email protected]]
Sent: Friday, January 19, 2018 3:37 PM
To: 'Paolo Bonzini'; 'Pavel Dovgalyuk'; [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: RE: [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threadsQuoted 13 lines
From: Paolo Bonzini [mailto:[email protected]]
Sent: Friday, January 19, 2018 3:26 PM
To: Pavel Dovgalyuk; 'Pavel Dovgalyuk'; [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threadsQuoted 4 lines · Pavel Dovgalyuk
Quoted 4 lines
Quoted 2 lines
It means, that I'll have to fix all the
has_workfunction to avoid races, becausex86_cpu_has_workmay have them?Why only
x86_cpu_has_work?
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Even reading
cs->interrupt_requestoutside the mutex is unsafe.All the vcpu function that access interrupt controller or peripheral state may be unsafe? How can it work safely then?
They do it inside the big QEMU lock.
Right. Without these patches.
Ah, I forgot about unlocking in tcg_cpu_exec.
Now I see, that vcpu is taking the lock when trying to access the peripherals.
Therefore, I have to fix all *_cpu_has_work, right?
Quoted 7 lines
They are within the replay lock. And BQL is not covering vcpu execution with these patches. Therefore RR will be ok and regular execution may encounter races?
It means that I missed something in Alex ideas, because he prepared the initial patches.Quoted 1 line
But here you're calling
cpu_has_work(viaall_cpu_threads_idle) outside the lock.Yes, I see, but what we have to do?
Pavel Dovgalyuk
Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads
In reply to Pavel DovgalyukQuoted 17 lines · Pavel Dovgalyuk
Quoted 17 lines
From: Paolo Bonzini [mailto:[email protected]]
Sent: Friday, January 19, 2018 3:26 PM
To: Pavel Dovgalyuk; 'Pavel Dovgalyuk'; [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threadsQuoted 7 lines · Pavel Dovgalyuk
Quoted 5 lines
Quoted 2 lines
It means, that I'll have to fix all the
has_workfunction to avoid races, becausex86_cpu_has_workmay have them?Why only
x86_cpu_has_work?Even reading
cs->interrupt_requestoutside the mutex is unsafe.All the vcpu function that access interrupt controller or peripheral state may be unsafe? How can it work safely then?
Quoted 6 lines
Quoted 1 line
They do it inside the big QEMU lock.
Right. Without these patches.
They are within the replay lock. And BQL is not covering vcpu execution with these patches. Therefore RR will be ok and regular execution may encounter races?
It means that I missed something in Alex ideas, because he prepared the initial patches.
Yes.
Quoted 3 lines
Quoted 1 line
But here you're calling
cpu_has_work(viaall_cpu_threads_idle) outside the lock.Yes, I see, but what we have to do?
I don't know. But the idiom in these patches,
while(...) {
lock()
cond_wait()
unlock()
}is unsafe as well, so the issue is more than just cpu_has_work.
Paolo
Re: [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads
Quoted 27 lines
From: Paolo Bonzini [mailto:[email protected]]
Quoted 10 lines · Pavel Dovgalyuk
Quoted 10 lines
From: Paolo Bonzini [mailto:[email protected]]
Quoted 7 lines · Pavel Dovgalyuk
Quoted 5 lines
Quoted 2 lines
It means, that I'll have to fix all the
has_workfunction to avoid races, becausex86_cpu_has_workmay have them?Why only
x86_cpu_has_work?Even reading
cs->interrupt_requestoutside the mutex is unsafe.All the vcpu function that access interrupt controller or peripheral state may be unsafe? How can it work safely then?
Quoted 6 lines
Quoted 1 line
They do it inside the big QEMU lock.
Right. Without these patches.
They are within the replay lock. And BQL is not covering vcpu execution with these patches. Therefore RR will be ok and regular execution may encounter races?
It means that I missed something in Alex ideas, because he prepared the initial patches.Yes.
Quoted 3 lines
Quoted 1 line
But here you're calling
cpu_has_work(viaall_cpu_threads_idle) outside the lock.Yes, I see, but what we have to do?
I don't know. But the idiom in these patches,
Quoted 7 lines
while(...) { lock() cond_wait() unlock() }is unsafe as well, so the issue is more than just
cpu_has_work.
Maybe it's better to omit this patch?
It seems that replay and regular execution are ok without it.
Pavel Dovgalyuk