drm/i915/icl: Ringbuffer interrupt handling
Subsystems (2)
PATCH 1/6 drm/i915/icl: Ringbuffer interrupt handling
From: Tvrtko Ursulin <[email protected]>
On Gen11 interrupt masks need to be clear to allow C6 entry. We keep them all enabled knowing that we generate extra interrupts.
v2: Rebase.
v3: Remove gen 11 extra check in logical_render_ring_init.
v4: Rebase fixes.
v5: Rebase/refactor.
v6: Rebase.
v7: Rebase.
v8: Update comment and commit message (Daniele)
--- drivers/gpu/drm/i915/intel_breadcrumbs.c | 16 ++++++++++------ drivers/gpu/drm/i915/intel_lrc.c | 13 +++++++++++-- 2 files changed, 21 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/intel_breadcrumbs.c +10 -6
@@ -168,17 +168,21 @@ static void irq_enable(struct intel_engine_cs *engine)set_bit (ENGINE_IRQ_BREADCRUMB , &engine->irq_posted);/* Caller disables interrupts */ -spin_lock (&engine->i915->irq_lock); - engine->irq_enable (engine); -spin_unlock (&engine->i915->irq_lock); +if (engine->irq_enable) { +spin_lock (&engine->i915->irq_lock); + engine->irq_enable (engine); +spin_unlock (&engine->i915->irq_lock); + } }static void irq_disable (struct intel_engine_cs *engine) {/* Caller disables interrupts */ -spin_lock (&engine->i915->irq_lock); - engine->irq_disable (engine); -spin_unlock (&engine->i915->irq_lock); +if (engine->irq_disable) { +spin_lock (&engine->i915->irq_lock); + engine->irq_disable (engine); +spin_unlock (&engine->i915->irq_lock); + } }void __intel_engine_disarm_breadcrumbs (struct intel_engine_cs *engine)
drivers/gpu/drm/i915/intel_lrc.c +11 -2
@@ -2009,8 +2009,17 @@ logical_ring_default_vfuncs(struct intel_engine_cs *engine) engine->set_default_submission = execlists_set_default_submission; - engine->irq_enable = gen8_logical_ring_enable_irq; - engine->irq_disable = gen8_logical_ring_disable_irq; +if (INTEL_GEN (engine->i915) <11 ) { + engine->irq_enable = gen8_logical_ring_enable_irq; + engine->irq_disable = gen8_logical_ring_disable_irq; + }else { +/* +* TODO: On Gen11 interrupt masks need to be clear +* to allow C6 entry. Keep interrupts enabled at +* and take the hit of generating extra interrupts +* until a more refined solution exists. +*/ + } engine->emit_bb_start = gen8_emit_bb_start; }
Signature · 6 lines
2.14.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/6 drm/i915/icl: Correctly initialize the Gen11 engines
From: Oscar Mateo <[email protected]>
Gen11 has up to 4 VCS and up to 2 VECS engines, this patch adds mmio base definitions for all of them.
Bspec: 20944
Bspec: 7021
v2: Set the correct mmio_base in intel_engines_init_mmio; updating the base mmio values any later would cause incorrect reads in i915_gem_sanitize (Michel).
--- drivers/gpu/drm/i915/i915_reg.h | 6 +++++ drivers/gpu/drm/i915/intel_engine_cs.c | 44 +++++++++++++++++++++++++++++++++- 2 files changed, 49 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_reg.h +6 -0
@@ -2345,7 +2345,13 @@ enum i915_power_well_id {#define BSD_RING_BASE 0x04000#define GEN6_BSD_RING_BASE 0x12000#define GEN8_BSD2_RING_BASE 0x1c000 +#define GEN11_BSD_RING_BASE 0x1c0000 +#define GEN11_BSD2_RING_BASE 0x1c4000 +#define GEN11_BSD3_RING_BASE 0x1d0000 +#define GEN11_BSD4_RING_BASE 0x1d4000#define VEBOX_RING_BASE 0x1a000 +#define GEN11_VEBOX_RING_BASE 0x1c8000 +#define GEN11_VEBOX2_RING_BASE 0x1d8000#define BLT_RING_BASE 0x22000#define RING_TAIL (base) _MMIO((base)+0x30)#define RING_HEAD (base) _MMIO((base)+0x34)
drivers/gpu/drm/i915/intel_engine_cs.c +43 -1
62 lines not on this page · raw message
Signature · 6 lines
2.14.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 2/6] drm/i915/icl: Correctly initialize the Gen11 engines
Quoted 92 lines · Mika Kuoppala
From: Oscar Mateo <[email protected]>
Gen11 has up to 4 VCS and up to 2 VECS engines, this patch adds mmio base definitions for all of them.
Bspec: 20944
Bspec: 7021v2: Set the correct
mmio_baseinintel_engines_init_mmio; updating the base mmio values any later would cause incorrect reads ini915_gem_sanitize(Michel).Cc Tvrtko Ursulin <[email protected]>Cc Ceraolo Spurio, Daniele <[email protected]>Signed-off-by Oscar Mateo <[email protected]>Signed-off-by Michel Thierry <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 6 +++++ drivers/gpu/drm/i915/intel_engine_cs.c | 44 +++++++++++++++++++++++++++++++++- 2 files changed, 49 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_reg.h +6
-0@@ -2345,7 +2345,13 @@ enum i915_power_well_id {#define BSD_RING_BASE 0x04000#define GEN6_BSD_RING_BASE 0x12000#define GEN8_BSD2_RING_BASE 0x1c000 +#define GEN11_BSD_RING_BASE 0x1c0000 +#define GEN11_BSD2_RING_BASE 0x1c4000 +#define GEN11_BSD3_RING_BASE 0x1d0000 +#define GEN11_BSD4_RING_BASE 0x1d4000#define VEBOX_RING_BASE 0x1a000 +#define GEN11_VEBOX_RING_BASE 0x1c8000 +#define GEN11_VEBOX2_RING_BASE 0x1d8000#define BLT_RING_BASE 0x22000#define RING_TAIL (base) _MMIO((base)+0x30)#define RING_HEAD (base) _MMIO((base)+0x34)drivers/gpu/drm/i915/intel_engine_cs.c +30
-1@@ -123,6 +123,22 @@ static const struct engine_info intel_engines[] = { .mmio_base = GEN8_BSD2_RING_BASE, .irq_shift = GEN8_VCS2_IRQ_SHIFT, }, + [VCS3] = { + .hw_id = VCS3_HW, + .uabi_id = I915_EXEC_BSD, + .class = VIDEO_DECODE_CLASS, + .instance = 2, + .mmio_base = GEN11_BSD3_RING_BASE, + .irq_shift = 0, /* not used */ + }, + [VCS4] = { + .hw_id = VCS4_HW, + .uabi_id = I915_EXEC_BSD, + .class = VIDEO_DECODE_CLASS, + .instance = 3, + .mmio_base = GEN11_BSD4_RING_BASE, + .irq_shift = 0, /* not used */ + }, [VECS] = { .hw_id = VECS_HW, .uabi_id = I915_EXEC_VEBOX,@@ -131,6 +147,14 @@ static const struct engine_info intel_engines[] = { .mmio_base = VEBOX_RING_BASE, .irq_shift = GEN8_VECS_IRQ_SHIFT, }, + [VECS2] = { + .hw_id = VECS2_HW, + .uabi_id = I915_EXEC_VEBOX, + .class = VIDEO_ENHANCEMENT_CLASS, + .instance = 1, + .mmio_base = GEN11_VEBOX2_RING_BASE, + .irq_shift = 0, /* not used */ + }, };/** @@ -230,7 +254,25 @@ intel_engine_setup(struct drm_i915_private *dev_priv, class_info->name, info->instance) >= sizeof(engine->name)); engine->hw_id = engine->guc_id = info->hw_id; - engine->mmio_base = info->mmio_base; +if (INTEL_GEN (dev_priv) >=11 ) { +switch (engine->id) { +case VCS : + engine->mmio_base =GEN11_BSD_RING_BASE ; +break ; +case VCS2 :
drivers/gpu/drm/i915/intel_engine_cs.c intel_engine_setup(struct drm_i915_private *dev_priv, · line 272
Quoted 10 lines
drivers/gpu/drm/i915/intel_engine_cs.c +10
-0+ engine->mmio_base =GEN11_BSD2_RING_BASE ; +break ; +case VECS : + engine->mmio_base =GEN11_VEBOX_RING_BASE ; +break ; +default : +/* take the original value for all other engines */ + engine->mmio_base = info->mmio_base; +break ; + }
I'm slightly unconvinced by the fact that we have a static table with some values and then we use other values here. Maybe we could instead use and array of [starting_gen, mmio_base] pairs in the table and derive the correct value here? Anyway, since this is not the only place where we don't use the mmio_base value from the table (same happens for pre-gen6 BSD in intel_init_bsd_ring_buffer) I don't consider this a blocking issue. All the values match the specs, so:
I'll probably check how using the table I mentioned above looks like after this is merged and I'll send an RFC if it seems nice.
Thanks,
Daniele
drivers/gpu/drm/i915/intel_engine_cs.c intel_engine_setup(struct drm_i915_private *dev_priv, · line 278
Quoted 7 lines
drivers/gpu/drm/i915/intel_engine_cs.c +3
-0+ }else { + engine->mmio_base = info->mmio_base; + } engine->irq_shift = info->irq_shift; engine->class = info->class; engine->instance = info->instance;
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 2/6] drm/i915/icl: Correctly initialize the Gen11 engines
Quoted 107 lines · Daniele Ceraolo Spurio
Quoted 95 lines · Mika Kuoppala
From: Oscar Mateo <[email protected]>
Gen11 has up to 4 VCS and up to 2 VECS engines, this patch adds mmio base definitions for all of them.
Bspec: 20944
Bspec: 7021v2: Set the correct
mmio_baseinintel_engines_init_mmio; updating the base mmio values any later would cause incorrect reads ini915_gem_sanitize(Michel).Cc Tvrtko Ursulin <[email protected]>Cc Ceraolo Spurio, Daniele <[email protected]>Signed-off-by Oscar Mateo <[email protected]>Signed-off-by Michel Thierry <[email protected]>---
drivers/gpu/drm/i915/i915_reg.h | 6 +++++drivers/gpu/drm/i915/intel_engine_cs.c| 44
+++++++++++++++++++++++++++++++++-2 files changed, 49 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_reg.h +6
-0@@ -2345,7 +2345,13 @@ enum i915_power_well_id { #define BSD_RING_BASE 0x04000 #define GEN6_BSD_RING_BASE 0x12000 #define GEN8_BSD2_RING_BASE 0x1c000 +#define GEN11_BSD_RING_BASE 0x1c0000 +#define GEN11_BSD2_RING_BASE 0x1c4000 +#define GEN11_BSD3_RING_BASE 0x1d0000 +#define GEN11_BSD4_RING_BASE 0x1d4000 #define VEBOX_RING_BASE 0x1a000 +#define GEN11_VEBOX_RING_BASE 0x1c8000 +#define GEN11_VEBOX2_RING_BASE 0x1d8000 #define BLT_RING_BASE 0x22000 #define RING_TAIL(base) _MMIO((base)+0x30) #define RING_HEAD(base) _MMIO((base)+0x34)drivers/gpu/drm/i915/intel_engine_cs.c +24
-0@@ -123,6 +123,22 @@ static const struct engine_info intel_engines[] = { .mmio_base = GEN8_BSD2_RING_BASE, .irq_shift = GEN8_VCS2_IRQ_SHIFT, }, + [VCS3] = { + .hw_id = VCS3_HW, + .uabi_id = I915_EXEC_BSD, + .class = VIDEO_DECODE_CLASS, + .instance = 2, + .mmio_base = GEN11_BSD3_RING_BASE, + .irq_shift = 0, /* not used */ + }, + [VCS4] = { + .hw_id = VCS4_HW, + .uabi_id = I915_EXEC_BSD, + .class = VIDEO_DECODE_CLASS, + .instance = 3, + .mmio_base = GEN11_BSD4_RING_BASE, + .irq_shift = 0, /* not used */ + }, [VECS] = { .hw_id = VECS_HW, .uabi_id = I915_EXEC_VEBOX,@@ -131,6 +147,14 @@ static const struct engine_info intel_engines[] = { .mmio_base = VEBOX_RING_BASE, .irq_shift = GEN8_VECS_IRQ_SHIFT, }, + [VECS2] = { + .hw_id = VECS2_HW, + .uabi_id = I915_EXEC_VEBOX, + .class = VIDEO_ENHANCEMENT_CLASS, + .instance = 1, + .mmio_base = GEN11_VEBOX2_RING_BASE, + .irq_shift = 0, /* not used */ + }, }; /**@@ -230,7 +254,25 @@ intel_engine_setup(struct drm_i915_private *dev_priv,
class_info->name,info->instance) >=sizeof(engine->name));engine->hw_id=engine->guc_id=info->hw_id; -engine->mmio_base=info->mmio_base;
+ if (INTEL_GEN(dev_priv)>= 11) {
+ switch (engine->id) {
+ case VCS:
+engine->mmio_base=GEN11_BSD_RING_BASE; + break;
+ case VCS2:
+engine->mmio_base=GEN11_BSD2_RING_BASE; + break;Quoted 8 lines
+ case VECS:
+engine->mmio_base=GEN11_VEBOX_RING_BASE; + break;
+ default:
+ /* take the original value for all other engines */ +engine->mmio_base=info->mmio_base;
+ break;
+ }I'm slightly unconvinced by the fact that we have a static table with some values and then we use other values here. Maybe we could instead use and array of [
starting_gen,mmio_base] pairs in the table and derive the correct value here? Anyway, since this is not the only place where we don't use themmio_basevalue from the table (same happens for pre-gen6 BSD inintel_init_bsd_ring_buffer) I don't consider this a blocking issue. All the values match the specs, so:
Quoted 3 lines
Reviewed-by Daniele Ceraolo Spurio <[email protected]>I'll probably check how using the table I mentioned above looks like after this is merged and I'll send an RFC if it seems nice.
Agreed it is inelegant to diverge. Your idea sounds potentially OK. Or even just duplicate the whole table for < gen6 and >= gen11 - they are not too big.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/6 drm/i915/icl: new context descriptor support
In reply to Mika KuoppalaFrom: Daniele Ceraolo Spurio <[email protected]>
Starting from Gen11 the context descriptor format has been updated in the HW. The hw_id field has been considerably reduced in size and engine class and instance fields have been added.
There is a slight name clashing issue because the field that we call hw_id is actually called SW Context ID in the specs for Gen11+.
With the current size of the hw_id field we can have a maximum of 2k contexts at any time, but we could use the sw_counter field (which is sw defined) to increase that because the HW requirement is that engine_id + sw id + sw_counter is a unique number.
GuC uses a similar method to support more contexts but does its tracking at lrc level. To avoid doing an implementation that will need to be reworked once GuC support lands, defer it for now and mark it as TODO.
v2: rebased, add documentation, fix GEN11_ENGINE_INSTANCE_SHIFT
v3: rebased, bring back lost code from i915_gem_context.c
v4: make TODO comment more generic
v5: be consistent with bit ordering, add extra checks (Chris)
--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_gem_context.c | 11 ++++++++-- drivers/gpu/drm/i915/i915_reg.h | 6 ++++++ drivers/gpu/drm/i915/intel_engine_cs.c | 3 +++ drivers/gpu/drm/i915/intel_lrc.c | 36 +++++++++++++++++++++++++++++++-- 5 files changed, 53 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +1 -0
@@ -2103,6 +2103,7 @@ struct drm_i915_private {*/ struct ida hw_ida;#define MAX_CONTEXT_HW_ID (1<<21)/* exclusive */ +#define GEN11_MAX_CONTEXT_HW_ID (1<<11)/* exclusive */ } contexts;u32 fdi_rx_config;
drivers/gpu/drm/i915/i915_gem_context.c +9 -2
@@ -211,9 +211,15 @@ static void context_close(struct i915_gem_context *ctx)static int assign_hw_id (struct drm_i915_private *dev_priv,unsigned *out) {int ret; +unsigned int max; + +if (INTEL_GEN (dev_priv) >=11 ) + max =GEN11_MAX_CONTEXT_HW_ID ; +else + max =MAX_CONTEXT_HW_ID ; ret =ida_simple_get (&dev_priv->contexts.hw_ida, -0 ,MAX_CONTEXT_HW_ID ,GFP_KERNEL ); +0 , max,GFP_KERNEL );if (ret <0 ) {/* Contexts are only released when no longer active. * Flush any pending retires to hopefully release some
@@ -221,7 +227,7 @@ static int assign_hw_id(struct drm_i915_private *dev_priv, unsigned *out)*/ i915_retire_requests (dev_priv); ret =ida_simple_get (&dev_priv->contexts.hw_ida, -0 ,MAX_CONTEXT_HW_ID ,GFP_KERNEL ); +0 , max,GFP_KERNEL );if (ret <0 )return ret; }
@@ -463,6 +469,7 @@ int i915_gem_contexts_init(struct drm_i915_private *dev_priv)/* Using the simple ida interface, the max is limited by sizeof(int) */ BUILD_BUG_ON (MAX_CONTEXT_HW_ID >INT_MAX ); +BUILD_BUG_ON (GEN11_MAX_CONTEXT_HW_ID >INT_MAX );ida_init (&dev_priv->contexts.hw_ida);/* lowest priority; idle task */
drivers/gpu/drm/i915/i915_reg.h +6 -0
@@ -3912,6 +3912,12 @@ enum {#define GEN8_CTX_ID_SHIFT 32#define GEN8_CTX_ID_WIDTH 21 +#define GEN11_SW_CTX_ID_SHIFT 37 +#define GEN11_SW_CTX_ID_WIDTH 11 +#define GEN11_ENGINE_CLASS_SHIFT 61 +#define GEN11_ENGINE_CLASS_WIDTH 3 +#define GEN11_ENGINE_INSTANCE_SHIFT 48 +#define GEN11_ENGINE_INSTANCE_WIDTH 6#define CHV_CLK_CTL1 _MMIO(0x101100)#define VLV_CLK_CTL2 _MMIO(0x101104)
drivers/gpu/drm/i915/intel_engine_cs.c +3 -0
@@ -234,6 +234,9 @@ intel_engine_setup(struct drm_i915_private *dev_priv,GEM_BUG_ON (info->class >=ARRAY_SIZE (intel_engine_classes)); class_info = &intel_engine_classes[info->class]; +BUILD_BUG_ON (MAX_ENGINE_CLASS >=BIT (GEN11_ENGINE_CLASS_WIDTH )); +BUILD_BUG_ON (MAX_ENGINE_INSTANCE >=BIT (GEN11_ENGINE_INSTANCE_WIDTH )); +if (GEM_WARN_ON (info->class >MAX_ENGINE_CLASS ))return -EINVAL ;
drivers/gpu/drm/i915/intel_lrc.c +34 -2
@@ -204,6 +204,18 @@ static inline bool need_preempt(const struct intel_engine_cs *engine,* bits 32-52: ctx ID, a globally unique tag * bits 53-54: mbz, reserved for use by hardware * bits 55-63: group ID, currently unused and set to 0 +* +* Starting from Gen11, the upper dword of the descriptor has a new format: +* +* bits 32-36: reserved +* bits 37-47: SW context ID +* bits 48:53: engine instance +* bit 54: mbz, reserved for use by hardware +* bits 55-60: SW counter +* bits 61-63: engine class +* +* engine info, SW context ID and SW counter need to form a unique number +* (Context ID) per lrc. */ static void intel_lr_context_descriptor_update(struct i915_gem_context *ctx,
@@ -212,12 +224,32 @@ intel_lr_context_descriptor_update(struct i915_gem_context *ctx,struct intel_context *ce = &ctx->engine[engine->id];u64 desc; -BUILD_BUG_ON (MAX_CONTEXT_HW_ID > (1 <<GEN8_CTX_ID_WIDTH )); +BUILD_BUG_ON (MAX_CONTEXT_HW_ID > (BIT (GEN8_CTX_ID_WIDTH ))); +BUILD_BUG_ON (GEN11_MAX_CONTEXT_HW_ID > (BIT (GEN11_SW_CTX_ID_WIDTH ))); desc = ctx->desc_template;/* bits 0-11 */ +GEM_BUG_ON (desc &GENMASK_ULL (63 ,12 )); + desc |=i915_ggtt_offset (ce->state) +LRC_HEADER_PAGES *PAGE_SIZE ;/* bits 12-31 */ - desc |= (u64 )ctx->hw_id <<GEN8_CTX_ID_SHIFT ;/* bits 32-52 */ +GEM_BUG_ON (desc &GENMASK_ULL (63 ,32 )); + +if (INTEL_GEN (ctx->i915) >=11 ) { +GEM_BUG_ON (ctx->hw_id >=BIT (GEN11_SW_CTX_ID_WIDTH )); + desc |= (u64 )ctx->hw_id <<GEN11_SW_CTX_ID_SHIFT ; +/* bits 37-47 */ + + desc |= (u64 )engine->instance <<GEN11_ENGINE_INSTANCE_SHIFT ; +/* bits 48-53 */ + +/* TODO: decide what to do with SW counter (bits 55-60) */ + + desc |= (u64 )engine->class <<GEN11_ENGINE_CLASS_SHIFT ; +/* bits 61-63 */ + }else { +GEM_BUG_ON (ctx->hw_id >=BIT (GEN8_CTX_ID_WIDTH )); + desc |= (u64 )ctx->hw_id <<GEN8_CTX_ID_SHIFT ;/* bits 32-52 */ + } ce->lrc_desc = desc; }
Signature · 6 lines
2.14.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 3/6] drm/i915/icl: new context descriptor support
Quoted 22 lines · Mika Kuoppala
From: Daniele Ceraolo Spurio <[email protected]>
Starting from Gen11 the context descriptor format has been updated in the HW. The
hw_idfield has been considerably reduced in size and engine class and instance fields have been added.There is a slight name clashing issue because the field that we call
hw_idis actually called SW Context ID in the specs for Gen11+.With the current size of the
hw_idfield we can have a maximum of 2k contexts at any time, but we could use thesw_counterfield (which is sw defined) to increase that because the HW requirement is thatengine_id+ sw id +sw_counteris a unique number.
GuC uses a similar method to support more contexts but does its tracking at lrc level. To avoid doing an implementation that will need to be reworked once GuC support lands, defer it for now and mark it as TODO.v2: rebased, add documentation, fix
GEN11_ENGINE_INSTANCE_SHIFT
v3: rebased, bring back lost code fromi915_gem_context.c
v4: make TODO comment more generic
v5: be consistent with bit ordering, add extra checks (Chris)
Quoted 4 lines
Cc Oscar Mateo <[email protected]>Cc Chris Wilson <[email protected]>Cc Mika Kuoppala <[email protected]>Signed-off-by Daniele Ceraolo Spurio <[email protected]>
v5 still looks good to me:
Quoted 137 lines
--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_gem_context.c | 11 ++++++++-- drivers/gpu/drm/i915/i915_reg.h | 6 ++++++ drivers/gpu/drm/i915/intel_engine_cs.c | 3 +++ drivers/gpu/drm/i915/intel_lrc.c | 36 +++++++++++++++++++++++++++++++-- 5 files changed, 53 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/i915_drv.h +1
-0@@ -2103,6 +2103,7 @@ struct drm_i915_private {*/ struct ida hw_ida;#define MAX_CONTEXT_HW_ID (1<<21)/* exclusive */ +#define GEN11_MAX_CONTEXT_HW_ID (1<<11)/* exclusive */ } contexts;u32 fdi_rx_config;drivers/gpu/drm/i915/i915_gem_context.c +9
-2@@ -211,9 +211,15 @@ static void context_close(struct i915_gem_context *ctx)static int assign_hw_id (struct drm_i915_private *dev_priv,unsigned *out) {int ret; +unsigned int max; + +if (INTEL_GEN (dev_priv) >=11 ) + max =GEN11_MAX_CONTEXT_HW_ID ; +else + max =MAX_CONTEXT_HW_ID ; ret =ida_simple_get (&dev_priv->contexts.hw_ida, -0 ,MAX_CONTEXT_HW_ID ,GFP_KERNEL ); +0 , max,GFP_KERNEL );if (ret <0 ) {/* Contexts are only released when no longer active. * Flush any pending retires to hopefully release some @@ -221,7 +227,7 @@ static int assign_hw_id(struct drm_i915_private *dev_priv, unsigned *out)*/ i915_retire_requests (dev_priv); ret =ida_simple_get (&dev_priv->contexts.hw_ida, -0 ,MAX_CONTEXT_HW_ID ,GFP_KERNEL ); +0 , max,GFP_KERNEL );if (ret <0 )return ret; }@@ -463,6 +469,7 @@ int i915_gem_contexts_init(struct drm_i915_private *dev_priv)/* Using the simple ida interface, the max is limited by sizeof(int) */ BUILD_BUG_ON (MAX_CONTEXT_HW_ID >INT_MAX ); +BUILD_BUG_ON (GEN11_MAX_CONTEXT_HW_ID >INT_MAX );ida_init (&dev_priv->contexts.hw_ida);/* lowest priority; idle task */ drivers/gpu/drm/i915/i915_reg.h +6
-0@@ -3912,6 +3912,12 @@ enum {#define GEN8_CTX_ID_SHIFT 32#define GEN8_CTX_ID_WIDTH 21 +#define GEN11_SW_CTX_ID_SHIFT 37 +#define GEN11_SW_CTX_ID_WIDTH 11 +#define GEN11_ENGINE_CLASS_SHIFT 61 +#define GEN11_ENGINE_CLASS_WIDTH 3 +#define GEN11_ENGINE_INSTANCE_SHIFT 48 +#define GEN11_ENGINE_INSTANCE_WIDTH 6#define CHV_CLK_CTL1 _MMIO(0x101100)#define VLV_CLK_CTL2 _MMIO(0x101104)drivers/gpu/drm/i915/intel_engine_cs.c +3
-0@@ -234,6 +234,9 @@ intel_engine_setup(struct drm_i915_private *dev_priv,GEM_BUG_ON (info->class >=ARRAY_SIZE (intel_engine_classes)); class_info = &intel_engine_classes[info->class]; +BUILD_BUG_ON (MAX_ENGINE_CLASS >=BIT (GEN11_ENGINE_CLASS_WIDTH )); +BUILD_BUG_ON (MAX_ENGINE_INSTANCE >=BIT (GEN11_ENGINE_INSTANCE_WIDTH )); +if (GEM_WARN_ON (info->class >MAX_ENGINE_CLASS ))return -EINVAL ;drivers/gpu/drm/i915/intel_lrc.c +27
-2@@ -204,6 +204,18 @@ static inline bool need_preempt(const struct intel_engine_cs *engine,* bits 32-52: ctx ID, a globally unique tag * bits 53-54: mbz, reserved for use by hardware * bits 55-63: group ID, currently unused and set to 0 +* +* Starting from Gen11, the upper dword of the descriptor has a new format: +* +* bits 32-36: reserved +* bits 37-47: SW context ID +* bits 48:53: engine instance +* bit 54: mbz, reserved for use by hardware +* bits 55-60: SW counter +* bits 61-63: engine class +* +* engine info, SW context ID and SW counter need to form a unique number +* (Context ID) per lrc. */ static void intel_lr_context_descriptor_update(struct i915_gem_context *ctx,@@ -212,12 +224,32 @@ intel_lr_context_descriptor_update(struct i915_gem_context *ctx,struct intel_context *ce = &ctx->engine[engine->id];u64 desc; -BUILD_BUG_ON (MAX_CONTEXT_HW_ID > (1 <<GEN8_CTX_ID_WIDTH )); +BUILD_BUG_ON (MAX_CONTEXT_HW_ID > (BIT (GEN8_CTX_ID_WIDTH ))); +BUILD_BUG_ON (GEN11_MAX_CONTEXT_HW_ID > (BIT (GEN11_SW_CTX_ID_WIDTH ))); desc = ctx->desc_template;/* bits 0-11 */ +GEM_BUG_ON (desc &GENMASK_ULL (63 ,12 )); + desc |=i915_ggtt_offset (ce->state) +LRC_HEADER_PAGES *PAGE_SIZE ;/* bits 12-31 */ - desc |= (u64 )ctx->hw_id <<GEN8_CTX_ID_SHIFT ;/* bits 32-52 */ +GEM_BUG_ON (desc &GENMASK_ULL (63 ,32 )); + +if (INTEL_GEN (ctx->i915) >=11 ) { +GEM_BUG_ON (ctx->hw_id >=BIT (GEN11_SW_CTX_ID_WIDTH )); + desc |= (u64 )ctx->hw_id <<GEN11_SW_CTX_ID_SHIFT ; +/* bits 37-47 */ + + desc |= (u64 )engine->instance <<GEN11_ENGINE_INSTANCE_SHIFT ; +/* bits 48-53 */ + +/* TODO: decide what to do with SW counter (bits 55-60) */
drivers/gpu/drm/i915/intel_lrc.c intel_lr_context_descriptor_update(struct i915_gem_context *ctx, · line 255
Quoted 10 lines
drivers/gpu/drm/i915/intel_lrc.c +7
-0+ + desc |= (u64 )engine->class <<GEN11_ENGINE_CLASS_SHIFT ; +/* bits 61-63 */ + }else { +GEM_BUG_ON (ctx->hw_id >=BIT (GEN8_CTX_ID_WIDTH )); + desc |= (u64 )ctx->hw_id <<GEN8_CTX_ID_SHIFT ;/* bits 32-52 */ + } ce->lrc_desc = desc; }
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/6 drm/i915/icl: Enhanced execution list support
In reply to Mika KuoppalaFrom: Thomas Daniel <[email protected]>
Enhanced Execlists is an upgraded version of execlists which supports up to 8 ports. The lrcs to be submitted are written to a submit queue (the ExecLists Submission Queue - ELSQ), which is then loaded on the HW. When writing to the ELSP register, the lrcs are written cyclically in the queue from position 0 to position 7. Alternatively, it is possible to write directly in the individual positions of the queue using the ELSQC registers. To be able to re-use all the existing code we're using the latter method and we're currently limiting ourself to only using 2 elements.
v2: Rebase.
v3: Switch from !IS_GEN11 to GEN < 11 (Daniele Ceraolo Spurio).
v4: Use the elsq registers instead of elsp. (Daniele Ceraolo Spurio)
v5: Reword commit, rename regs to be closer to specs, turn off
preemption (Daniele), reuse engine->execlists.elsp (Chris)
v6: use has_logical_ring_elsq to differentiate the new paths
v7: add preemption support, rename els to submit_reg (Chris)
v8: save the ctrl register inside the execlists struct, drop CSB
handling updates (superseded by preempt_complete_status) (Chris)
v9: s/drm_i915_gem_request/i915_request (Mika)
v10: resolved conflict in inject_preempt_context (Mika)
--- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/i915_pci.c | 3 +- drivers/gpu/drm/i915/intel_device_info.h | 1 + drivers/gpu/drm/i915/intel_lrc.c | 58 ++++++++++++++++++++++++-------- drivers/gpu/drm/i915/intel_lrc.h | 3 ++ drivers/gpu/drm/i915/intel_ringbuffer.h | 12 +++++-- 6 files changed, 62 insertions(+), 17 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +2 -0
@@ -2772,6 +2772,8 @@ intel_info(const struct drm_i915_private *dev_priv)#define HAS_LOGICAL_RING_CONTEXTS (dev_priv) \ ((dev_priv)->info.has_logical_ring_contexts) +#define HAS_LOGICAL_RING_ELSQ (dev_priv) \ + ((dev_priv)->info.has_logical_ring_elsq)#define HAS_LOGICAL_RING_PREEMPTION (dev_priv) \ ((dev_priv)->info.has_logical_ring_preemption)
drivers/gpu/drm/i915/i915_pci.c +2 -1
@@ -594,7 +594,8 @@ static const struct intel_device_info intel_cannonlake_info = {GEN10_FEATURES , \GEN (11 ), \ .ddb_size = 2048, \ - .has_csr = 0 + .has_csr = 0, \ + .has_logical_ring_elsq = 1static const struct intel_device_info intel_icelake_11_info = {GEN11_FEATURES ,
drivers/gpu/drm/i915/intel_device_info.h +1 -0
@@ -96,6 +96,7 @@ enum intel_platform {func (has_l3_dpf); \func (has_llc); \func (has_logical_ring_contexts); \ +func (has_logical_ring_elsq); \func (has_logical_ring_preemption); \func (has_overlay); \func (has_pooled_eu); \
drivers/gpu/drm/i915/intel_lrc.c +44 -14
107 lines not on this page · raw message
drivers/gpu/drm/i915/intel_lrc.h +3 -0
@@ -42,6 +42,9 @@#define RING_CONTEXT_STATUS_BUF_LO (engine, i) _MMIO((engine)->mmio_base + 0x370 + (i) * 8)#define RING_CONTEXT_STATUS_BUF_HI (engine, i) _MMIO((engine)->mmio_base + 0x370 + (i) * 8 + 4)#define RING_CONTEXT_STATUS_PTR (engine) _MMIO((engine)->mmio_base + 0x3a0) +#define RING_EXECLIST_SQ_CONTENTS (engine) _MMIO((engine)->mmio_base + 0x510) +#define RING_EXECLIST_CONTROL (engine) _MMIO((engine)->mmio_base + 0x550) +#define EL_CTRL_LOAD (1 << 0)/* The docs specify that the write pointer wraps around after 5h, "After status * is written out to the last available status QW at offset 5h, this pointer
drivers/gpu/drm/i915/intel_ringbuffer.h +10 -2
@@ -209,9 +209,17 @@ struct intel_engine_execlists {bool no_priolist;/** -* @elsp: the ExecList Submission Port register +* @submit_reg: gen-specific execlist submission register +* set to the ExecList Submission Port (elsp) register pre-Gen11 and to +* the ExecList Submission Queue Contents register array for Gen11+ */ -u32 __iomem *elsp; +u32 __iomem *submit_reg; + +/** +* @ctrl_reg: the enhanced execlists control register, used to load the +* submit queue on the HW and to request preemptions to idle +*/ +u32 __iomem *ctrl_reg;/** * @port: execlist port states
Signature · 6 lines
2.14.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 4/6] drm/i915/icl: Enhanced execution list support
Quoting Mika Kuoppala (2018-03-02 16:14:59)
Quoted 24 lines
From: Thomas Daniel <[email protected]>
Enhanced Execlists is an upgraded version of execlists which supports up to 8 ports. The lrcs to be submitted are written to a submit queue (the ExecLists Submission Queue - ELSQ), which is then loaded on the HW. When writing to the ELSP register, the lrcs are written cyclically in the queue from position 0 to position 7. Alternatively, it is possible to write directly in the individual positions of the queue using the ELSQC registers. To be able to re-use all the existing code we're using the latter method and we're currently limiting ourself to only using 2 elements.
v2: Rebase.
v3: Switch from !IS_GEN11 to GEN < 11 (Daniele Ceraolo Spurio).
v4: Use the elsq registers instead of elsp. (Daniele Ceraolo Spurio)
v5: Reword commit, rename regs to be closer to specs, turn offpreemption (Daniele), reuse engine->execlists.elsp (Chris)v6: use
has_logical_ring_elsqto differentiate the new paths
v7: add preemption support, rename els tosubmit_reg(Chris)
v8: save the ctrl register inside the execlists struct, drop CSB
handling updates (superseded bypreempt_complete_status) (Chris)
v9: s/drm_i915_gem_request/i915_request (Mika)
v10: resolved conflict ininject_preempt_context(Mika)
Quoted 6 lines
Cc Chris Wilson <[email protected]>Cc Mika Kuoppala <[email protected]>Signed-off-by Thomas Daniel <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>Signed-off-by Daniele Ceraolo Spurio <[email protected]>Reviewed-by Chris Wilson <[email protected]> (v8)
Quoted 1 line
Signed-off-by Mika Kuoppala <[email protected]>
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 5/6 drm/i915/icl: Add Indirect Context Offset for Gen11
In reply to Mika KuoppalaFrom: Michel Thierry <[email protected]>
v2: rebased to intel_lr_indirect_ctx_offset
v3: rebase, move define to intel_lrc_reg.h
BSpec: 11740
--- drivers/gpu/drm/i915/intel_lrc.c | 4 ++++ drivers/gpu/drm/i915/intel_lrc_reg.h | 1 + 2 files changed, 5 insertions(+)
drivers/gpu/drm/i915/intel_lrc.c +4 -0
@@ -2244,6 +2244,10 @@ static u32 intel_lr_indirect_ctx_offset(struct intel_engine_cs *engine)default :MISSING_CASE (INTEL_GEN (engine->i915));/* fall through */ +case 11 : + indirect_ctx_offset = +GEN11_CTX_RCS_INDIRECT_CTX_OFFSET_DEFAULT ; +break ;case 10 : indirect_ctx_offset =GEN10_CTX_RCS_INDIRECT_CTX_OFFSET_DEFAULT ;
drivers/gpu/drm/i915/intel_lrc_reg.h +1 -0
@@ -63,5 +63,6 @@#define GEN8_CTX_RCS_INDIRECT_CTX_OFFSET_DEFAULT 0x17#define GEN9_CTX_RCS_INDIRECT_CTX_OFFSET_DEFAULT 0x26#define GEN10_CTX_RCS_INDIRECT_CTX_OFFSET_DEFAULT 0x19 +#define GEN11_CTX_RCS_INDIRECT_CTX_OFFSET_DEFAULT 0x1A#endif /* _INTEL_LRC_REG_H_ */
Signature · 6 lines
2.14.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 6/6 drm/i915/icl: Gen11 forcewake support
In reply to Mika KuoppalaFrom: Daniele Ceraolo Spurio <[email protected]>
The main difference with previous GENs is that starting from Gen11 each VCS and VECS engine has its own power well, which only exist if the related engine exists in the HW.
The fallback forcewake request workaround is only needed on gen9 according to the HSDES WA entry (1604254524), so we can go back to using the simpler fw_domains_get/put functions.
BSpec: 18331
v2: fix fwtable, use array to test shadow tables, create new
accessors to avoid check on every access (Tvrtko)
v3 (from Paulo): Rebase.
v4:
- Range 09400-097FF should be FORCEWAKE_ALL (Daniele)
- Use the BIT macro for forcewake domains (Daniele)
- Add a comment about the range ordering (Oscar)
- Updated commit message (Oscar)
v5: Rebased
v6: Use I915_MAX_VCS/VECS (Michal)
v7: translate FORCEWAKE_ALL to available domains
v8: rebase, add clarification on fallback ack in commit message.
v9: fix rebase issue, change check in fw_domains_init from IS_GEN11
to GEN >= 11
v10: Generate is_genX_shadowed with a macro (Daniele)
Include gen11_fw_ranges in the selftest (Michel)
v11: Simplify FORCEWAKE_ALL, new line between NEEDS_FORCEWAKEs (Tvrtko)
--- drivers/gpu/drm/i915/i915_reg.h | 4 + drivers/gpu/drm/i915/intel_uncore.c | 157 ++++++++++++++++++++++++-- drivers/gpu/drm/i915/intel_uncore.h | 23 +++- drivers/gpu/drm/i915/selftests/intel_uncore.c | 31 +++-- 4 files changed, 189 insertions(+), 26 deletions(-)
drivers/gpu/drm/i915/i915_reg.h +4 -0
@@ -8020,9 +8020,13 @@ enum {#define VLV_GTLC_PW_RENDER_STATUS_MASK (1 << 7)#define FORCEWAKE_MT _MMIO(0xa188)/* multi-threaded */ #define FORCEWAKE_MEDIA_GEN9 _MMIO(0xa270) +#define FORCEWAKE_MEDIA_VDBOX_GEN11 (n) _MMIO(0xa540 + (n) * 4) +#define FORCEWAKE_MEDIA_VEBOX_GEN11 (n) _MMIO(0xa560 + (n) * 4)#define FORCEWAKE_RENDER_GEN9 _MMIO(0xa278)#define FORCEWAKE_BLITTER_GEN9 _MMIO(0xa188)#define FORCEWAKE_ACK_MEDIA_GEN9 _MMIO(0x0D88) +#define FORCEWAKE_ACK_MEDIA_VDBOX_GEN11 (n) _MMIO(0x0D50 + (n) * 4) +#define FORCEWAKE_ACK_MEDIA_VEBOX_GEN11 (n) _MMIO(0x0D70 + (n) * 4)#define FORCEWAKE_ACK_RENDER_GEN9 _MMIO(0x0D84)#define FORCEWAKE_ACK_BLITTER_GEN9 _MMIO(0x130044)#define FORCEWAKE_KERNEL BIT(0)
drivers/gpu/drm/i915/intel_uncore.c +147 -10
266 lines not on this page · raw message
drivers/gpu/drm/i915/intel_uncore.h +17 -6
@@ -37,17 +37,28 @@ enum forcewake_domain_id {FW_DOMAIN_ID_RENDER =0 ,FW_DOMAIN_ID_BLITTER ,FW_DOMAIN_ID_MEDIA , +FW_DOMAIN_ID_MEDIA_VDBOX0 , +FW_DOMAIN_ID_MEDIA_VDBOX1 , +FW_DOMAIN_ID_MEDIA_VDBOX2 , +FW_DOMAIN_ID_MEDIA_VDBOX3 , +FW_DOMAIN_ID_MEDIA_VEBOX0 , +FW_DOMAIN_ID_MEDIA_VEBOX1 ,FW_DOMAIN_ID_COUNT };enum forcewake_domains { -FORCEWAKE_RENDER =BIT (FW_DOMAIN_ID_RENDER ), -FORCEWAKE_BLITTER =BIT (FW_DOMAIN_ID_BLITTER ), -FORCEWAKE_MEDIA =BIT (FW_DOMAIN_ID_MEDIA ), -FORCEWAKE_ALL = (FORCEWAKE_RENDER | -FORCEWAKE_BLITTER | -FORCEWAKE_MEDIA ) +FORCEWAKE_RENDER =BIT (FW_DOMAIN_ID_RENDER ), +FORCEWAKE_BLITTER =BIT (FW_DOMAIN_ID_BLITTER ), +FORCEWAKE_MEDIA =BIT (FW_DOMAIN_ID_MEDIA ), +FORCEWAKE_MEDIA_VDBOX0 =BIT (FW_DOMAIN_ID_MEDIA_VDBOX0 ), +FORCEWAKE_MEDIA_VDBOX1 =BIT (FW_DOMAIN_ID_MEDIA_VDBOX1 ), +FORCEWAKE_MEDIA_VDBOX2 =BIT (FW_DOMAIN_ID_MEDIA_VDBOX2 ), +FORCEWAKE_MEDIA_VDBOX3 =BIT (FW_DOMAIN_ID_MEDIA_VDBOX3 ), +FORCEWAKE_MEDIA_VEBOX0 =BIT (FW_DOMAIN_ID_MEDIA_VEBOX0 ), +FORCEWAKE_MEDIA_VEBOX1 =BIT (FW_DOMAIN_ID_MEDIA_VEBOX1 ), + +FORCEWAKE_ALL =BIT (FW_DOMAIN_ID_COUNT ) -1 }; struct intel_uncore_funcs {
drivers/gpu/drm/i915/selftests/intel_uncore.c +21 -10
@@ -61,20 +61,30 @@ static int intel_fw_table_check(const struct intel_forcewake_range *ranges,static int intel_shadow_table_check (void ) { -const i915_reg_t *reg = gen8_shadowed_regs; -unsigned int i; +struct { +const i915_reg_t *regs; +unsigned int size; + } reg_lists[] = { + { gen8_shadowed_regs,ARRAY_SIZE (gen8_shadowed_regs) }, + { gen11_shadowed_regs,ARRAY_SIZE (gen11_shadowed_regs) }, + }; +const i915_reg_t *reg; +unsigned int i, j;s32 prev; -for (i =0 , prev =-1 ; i <ARRAY_SIZE (gen8_shadowed_regs); i++, reg++) { -u32 offset =i915_mmio_reg_offset (*reg); +for (j =0 ; j <ARRAY_SIZE (reg_lists); ++j) { + reg = reg_lists[j].regs; +for (i =0 , prev =-1 ; i < reg_lists[j].size; i++, reg++) { +u32 offset =i915_mmio_reg_offset (*reg); -if (prev >= (s32 )offset) { -pr_err ("%s: entry[%d]:(%x) is before previous (%x)\n" , - __func__, i, offset, prev); -return -EINVAL ; - } +if (prev >= (s32 )offset) { +pr_err ("%s: entry[%d]:(%x) is before previous (%x)\n" , + __func__, i, offset, prev); +return -EINVAL ; + } - prev = offset; + prev = offset; + } }return 0 ;
@@ -90,6 +100,7 @@ int intel_uncore_mock_selftests(void) { __vlv_fw_ranges, ARRAY_SIZE(__vlv_fw_ranges), false }, { __chv_fw_ranges, ARRAY_SIZE(__chv_fw_ranges), false }, { __gen9_fw_ranges, ARRAY_SIZE(__gen9_fw_ranges), true }, + { __gen11_fw_ranges, ARRAY_SIZE(__gen11_fw_ranges), true }, };int err, i;
Signature · 6 lines
2.14.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915/icl: Ringbuffer interrupt handling
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: series starting with [1/6] drm/i915/icl: Ringbuffer interrupt handling
URL : https://patchwork.freedesktop.org/series/39293/
State : success
== Summary ==
Series 39293v1 series starting with [1/6] drm/i915/icl: Ringbuffer interrupt handling
https://patchwork.freedesktop.org/api/1.0/series/39293/revisions/1/mbox/
---- Known issues:
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> INCOMPLETE (fi-snb-2520m) fdo#103713
Test prime_vgem:
Subgroup basic-fence-flip:
fail -> PASS (fi-ivb-3770) fdo#104008fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:418s fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:421s fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:371s fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:486s fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:278s fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:477s fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:475s fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:472s fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:459s fi-cfl-8700k total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:392s fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:562s fi-cfl-u total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:493s fi-cnl-y3 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:574s fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:413s fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:289s fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:504s fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:388s fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:409s fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:452s fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:411s fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:457s fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:492s fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:454s fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:494s fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:587s fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:427s fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:498s fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:521s fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:483s fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:477s fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:407s fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:430s fi-snb-2520m total:245 pass:211 dwarn:0 dfail:0 fail:0 skip:33 fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:392s
75cc49c0195a217db94582fd000059e7264709b0 drm-tip: 2018y-03m-02d-15h-49m-26s UTC integration manifest 93c06d88e6cd drm/i915/icl: Gen11 forcewake support6454d9eddb6f drm/i915/icl: Add Indirect Context Offset for Gen11fbda88d78285 drm/i915/icl: Enhanced execution list supporteccd00f6e1ec drm/i915/icl: new context descriptor support30be6ea2de55 drm/i915/icl: Correctly initialize the Gen11 enginesbf0e69425895 drm/i915/icl: Ringbuffer interrupt handling
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8220/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for series starting with [1/6] drm/i915/icl: Ringbuffer interrupt handling
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: series starting with [1/6] drm/i915/icl: Ringbuffer interrupt handling
URL : https://patchwork.freedesktop.org/series/39293/
State : success
== Summary ==
---- Known issues:
Test gem_eio:
Subgroup in-flight-contexts:
incomplete -> PASS (shard-apl) fdo#104945
Test kms_chv_cursor_fail:
Subgroup pipe-b-128x128-left-edge:
pass -> DMESG-WARN (shard-snb) fdo#105185 +1
Test kms_plane:
Subgroup plane-panning-top-left-pipe-c-planes:
pass -> FAIL (shard-apl) fdo#103166
Test kms_vblank:
Subgroup pipe-a-ts-continuation-suspend:
pass -> INCOMPLETE (shard-hsw) fdo#103540fdo#104945 https://bugs.freedesktop.org/show_bug.cgi?id=104945
fdo#105185 https://bugs.freedesktop.org/show_bug.cgi?id=105185
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
shard-apl total:3463 pass:1821 dwarn:1 dfail:0 fail:8 skip:1632 time:12504s shard-hsw total:3389 pass:1721 dwarn:1 dfail:0 fail:1 skip:1664 time:11624s shard-snb total:3463 pass:1361 dwarn:2 dfail:0 fail:1 skip:2099 time:6968s
Blacklisted hosts:
shard-kbl total:3463 pass:1947 dwarn:1 dfail:0 fail:7 skip:1508 time:9901s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8220/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx