Skip to contentSkip to conversation

ARM: dts: aspeed: Add Portwell Neptune machine

PATCH Superseded Amithash Prasad 2 participants 3 messages Mar 23, 2018

Subsystems (3)
Device tree bindings Arm/Aspeed machine support Arm and arm64 SoC sub-architectures (common parts)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Amithash Prasad

author
#0 lore raw

PATCH 1/1 ARM: dts: aspeed: Add Portwell Neptune machine

Initial introduction of Portwell Neptune family equipped with Aspeed 2500 BMC SoC. Neptune is a x86 server development kit with a ASPEED ast2500 BMC manufactured by Portwell. Specifically, This adds the neptune platform device tree file including the flash layout used by the neptune machines.

Signed-off-by Amithash Prasad <[email protected]>
---
 .../devicetree/bindings/vendor-prefixes.txt        |   1 +
 arch/arm/boot/dts/Makefile                         |   3 +-
 arch/arm/boot/dts/aspeed-bmc-portwell-neptune.dts  | 158 +++++++++++++++++++++
 3 files changed, 161 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-portwell-neptune.dts
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index daf465be..ad3406d 100644
@@ -255,6 +255,7 @@ pine64	Pine64
 pixcir  PIXCIR MICROELECTRONICS Co., Ltd
 plathome	Plat'Home Co., Ltd.
 plda	PLDA
+portwell	Portwell Inc.
 poslab	Poslab Technology Co., Ltd.
 powervr	PowerVR (deprecated, use img)
 pulsedlight	PulsedLight, Inc
arch/arm/boot/dts/Makefile +2 -1
index 5cfee25..4746060 100644
@@ -1061,7 +1061,8 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-opp-romulus.dtb \
 	aspeed-bmc-opp-witherspoon.dtb \
 	aspeed-bmc-opp-zaius.dtb \
-	aspeed-bmc-quanta-q71l.dtb
+	aspeed-bmc-quanta-q71l.dtb \
+	aspeed-bmc-portwell-neptune.dtb
 endif
 
 dtstree		:= $(srctree)/$(src)
arch/arm/boot/dts/aspeed-bmc-portwell-neptune.dts new file +158 -0

158 lines not on this page · raw message

Signature · 1 line
2.9.5
maintainer
#1 lore raw
Quoted 6 lines · Amithash Prasad

+++ b/arch/arm/boot/dts/aspeed-bmc-portwell-neptune.dts

arch/arm/boot/dts/aspeed-bmc-portwell-neptune.dts new file +4 -0
@@ -0,0 +1,158 @@
+// SPDX-License-Identifier: GPL-2.0
+// Copyright (c) 2017 Facebook Inc.
+/dts-v1/;
+

arch/arm/boot/dts/aspeed-bmc-portwell-neptune.dts line 14

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-portwell-neptune.dts new file +10 -0
+#include "aspeed-g5.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h>
+
+/ {
+       model = "Portwell Neptune BMC";
+       compatible = "portwell,neptune-bmc", "aspeed,ast2500";
+       aliases {
+               serial0 = &uart1;
+               serial4 = &uart5;
+       };

These are redundant; they are included in aspeed-g5.dtsi.

arch/arm/boot/dts/aspeed-bmc-portwell-neptune.dts line 88

Quoted 12 lines
arch/arm/boot/dts/aspeed-bmc-portwell-neptune.dts new file +12 -0
+&mac0 {
+       status = "okay";
+
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_rmii1_default>;
+};
+
+&mac1 {
+       status = "okay";
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_rgmii2_default>;
+       use-ncsi;

NCSI can only be used with RMII as far as I understand.

If this is supposed to be NCSI, you need to mux pinctrl_rmii2_default.

If it's supposed to be RGMII, you need to mux pinctrl_rgmii2_default and pinctrl_mdio2_default.

Cheers,

Joel

author
#2 lore raw
Quoted 4 lines

If this is supposed to be NCSI, you need to mux pinctrl_rmii2_default.

If it's supposed to be RGMII, you need to mux pinctrl_rgmii2_default and pinctrl_mdio2_default.

V2 Coming up. Thanks for catching this.