ipc: Adding new return type vm_fault_t
PATCH v2 1/1 ipc: Adding new return type vm_fault_t
Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.
Commit 1c8f422059ae ("mm: change return type to vm_fault_t")
---
v2: Updated the change log
ipc/shm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ipc/shm.c +1 -1
@@ -378,7 +378,7 @@ void exit_shm(struct task_struct *task)up_write (&shm_ids (ns).rwsem); } -static int shm_fault (struct vm_fault *vmf) +static vm_fault_t shm_fault (struct vm_fault *vmf) {struct file *file = vmf->vma->vm_file;struct shm_file_data *sfd =shm_file_data (file);
Signature · 1 line
1.9.1
Quoted 29 lines · Souptick Joarder
Use new return type
vm_fault_tfor fault handler. For now, this is just documenting that the function returns aVM_FAULTvalue rather than an errno. Once all instances are converted,vm_fault_twill become a distinct type.Commit
1c8f422059ae("mm: change return type tovm_fault_t")Signed-off-by Souptick Joarder <[email protected]>Reviewed-by Matthew Wilcox <[email protected]>---
v2: Updated the change logipc/shm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)ipc/shm.c +1
-2@@ -378,7 +378,7 @@ void exit_shm(struct task_struct *task)up_write (&shm_ids (ns).rwsem); } -static int shm_fault (struct vm_fault *vmf) +static vm_fault_t shm_fault (struct vm_fault *vmf) {struct file *file = vmf->vma->vm_file;struct shm_file_data *sfd =shm_file_data (file); --
Quoted 2 lines
1.9.1
Any comment for this patch ?
Quoted 24 lines · Souptick Joarder
Quoted 23 lines · Souptick Joarder
Use new return type
vm_fault_tfor fault handler. For now, this is just documenting that the function returns aVM_FAULTvalue rather than an errno. Once all instances are converted,vm_fault_twill become a distinct type.Commit
1c8f422059ae("mm: change return type tovm_fault_t")Signed-off-by Souptick Joarder <[email protected]>Reviewed-by Matthew Wilcox <[email protected]>---
v2: Updated the change logipc/shm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)ipc/shm.c +0
-0@@ -378,7 +378,7 @@ void exit_shm(struct task_struct *task)up_write (&shm_ids (ns).rwsem); }
Quoted 10 lines
Quoted 8 lines
ipc/shm.c +1
-2-static int shm_fault (struct vm_fault *vmf) +static vm_fault_t shm_fault (struct vm_fault *vmf) {struct file *file = vmf->vma->vm_file;struct shm_file_data *sfd =shm_file_data (file); --1.9.1
Any comment for this patch ?
If no further comment, we would like to get this
patch in queue for 4.18.
Davidlohr Bueso
Acked-byQuoted 11 lines · Souptick Joarder
Quoted 10 lines · Souptick Joarder
Quoted 9 lines · Souptick Joarder
Use new return type
vm_fault_tfor fault handler. For now, this is just documenting that the function returns aVM_FAULTvalue rather than an errno. Once all instances are converted,vm_fault_twill become a distinct type.Commit
1c8f422059ae("mm: change return type tovm_fault_t")Signed-off-by Souptick Joarder <[email protected]>Reviewed-by Matthew Wilcox <[email protected]>