Skip to contentSkip to conversation

fs: fuse: Adding new return type vm_fault_t

PATCH Superseded Souptick Joarder 2 participants 7 messages May 12, 2018 – Jun 26, 2018

Subsystems (2)

v2 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 fs: fuse: Adding new return type vm_fault_t

Use new return type vm_fault_t for fault handler in struct vm_operations_struct. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

commit 1c8f422059ae ("mm: change return type to vm_fault_t")

---
 fs/fuse/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/fuse/file.c +1 -1
index a201fb0..67648cc 100644
@@ -2048,7 +2048,7 @@ static void fuse_vma_close(struct vm_area_struct *vma)
  * - sync(2)
  * - try_to_free_pages() with order > PAGE_ALLOC_COSTLY_ORDER
  */
-static int fuse_page_mkwrite(struct vm_fault *vmf)
+static vm_fault_t fuse_page_mkwrite(struct vm_fault *vmf)
 {
 	struct page *page = vmf->page;
 	struct inode *inode = file_inode(vmf->vma->vm_file);

--
1.9.1

#1 lore raw
Quoted 30 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler in struct vm_operations_struct. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

commit 1c8f422059ae ("mm: change return type to vm_fault_t")

---
 fs/fuse/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/fuse/file.c +1 -2
index a201fb0..67648cc 100644
@@ -2048,7 +2048,7 @@ static void fuse_vma_close(struct vm_area_struct *vma)
  * - sync(2)
  * - try_to_free_pages() with order > PAGE_ALLOC_COSTLY_ORDER
  */
-static int fuse_page_mkwrite(struct vm_fault *vmf)
+static vm_fault_t fuse_page_mkwrite(struct vm_fault *vmf)
 {
        struct page *page = vmf->page;
        struct inode *inode = file_inode(vmf->vma->vm_file);
--
Quoted 2 lines

1.9.1

Miklos, we would like to get this patch in queue
for 4.18.

maintainer
#2 lore raw
Quoted 28 lines · Souptick Joarder
Quoted 27 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler in struct vm_operations_struct. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

commit 1c8f422059ae ("mm: change return type to vm_fault_t")

---
 fs/fuse/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/fuse/file.c +1 -1
index a201fb0..67648cc 100644
@@ -2048,7 +2048,7 @@ static void fuse_vma_close(struct vm_area_struct *vma)
  * - sync(2)
  * - try_to_free_pages() with order > PAGE_ALLOC_COSTLY_ORDER
  */
-static int fuse_page_mkwrite(struct vm_fault *vmf)
+static vm_fault_t fuse_page_mkwrite(struct vm_fault *vmf)
 {
Quoted 8 lines
Quoted 5 lines
fs/fuse/file.c +0 -1
        struct page *page = vmf->page;
        struct inode *inode = file_inode(vmf->vma->vm_file);
--

1.9.1

Miklos, we would like to get this patch in queue
for 4.18.

Sure, queued up.

Thanks,
Miklos

#3 lore raw
Quoted 38 lines · Miklos Szeredi
Quoted 28 lines · Souptick Joarder
Quoted 27 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler in struct vm_operations_struct. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

commit 1c8f422059ae ("mm: change return type to vm_fault_t")

---
 fs/fuse/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/fuse/file.c +1 -1
index a201fb0..67648cc 100644
@@ -2048,7 +2048,7 @@ static void fuse_vma_close(struct vm_area_struct *vma)
  * - sync(2)
  * - try_to_free_pages() with order > PAGE_ALLOC_COSTLY_ORDER
  */
-static int fuse_page_mkwrite(struct vm_fault *vmf)
+static vm_fault_t fuse_page_mkwrite(struct vm_fault *vmf)
 {
Quoted 8 lines
Quoted 5 lines
fs/fuse/file.c +0 -1
        struct page *page = vmf->page;
        struct inode *inode = file_inode(vmf->vma->vm_file);
--

1.9.1

Miklos, we would like to get this patch in queue
for 4.18.

Quoted 2 lines

Sure, queued up.

This patch is not merged in 4.18-rc-1

#4 lore raw
Quoted 39 lines · Souptick Joarder
Quoted 38 lines · Miklos Szeredi
Quoted 36 lines · Souptick Joarder
Quoted 30 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler in struct vm_operations_struct. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

commit 1c8f422059ae ("mm: change return type to vm_fault_t")

---
 fs/fuse/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/fuse/file.c +1 -2
index a201fb0..67648cc 100644
@@ -2048,7 +2048,7 @@ static void fuse_vma_close(struct vm_area_struct *vma)
  * - sync(2)
  * - try_to_free_pages() with order > PAGE_ALLOC_COSTLY_ORDER
  */
-static int fuse_page_mkwrite(struct vm_fault *vmf)
+static vm_fault_t fuse_page_mkwrite(struct vm_fault *vmf)
 {
        struct page *page = vmf->page;
        struct inode *inode = file_inode(vmf->vma->vm_file);
--
Quoted 2 lines

1.9.1

Miklos, we would like to get this patch in queue
for 4.18.

Quoted 4 lines
Quoted 2 lines

Sure, queued up.

This patch is not merged in 4.18-rc-1

Miklos, Can we get this patch in 4.18-rc-x / 4.19 ?

maintainer
#5 lore raw
Quoted 40 lines · Souptick Joarder
Quoted 39 lines · Souptick Joarder
Quoted 38 lines · Miklos Szeredi
Quoted 36 lines · Souptick Joarder
Quoted 30 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler in struct vm_operations_struct. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

commit 1c8f422059ae ("mm: change return type to vm_fault_t")

---
 fs/fuse/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/fuse/file.c +1 -2
index a201fb0..67648cc 100644
@@ -2048,7 +2048,7 @@ static void fuse_vma_close(struct vm_area_struct *vma)
  * - sync(2)
  * - try_to_free_pages() with order > PAGE_ALLOC_COSTLY_ORDER
  */
-static int fuse_page_mkwrite(struct vm_fault *vmf)
+static vm_fault_t fuse_page_mkwrite(struct vm_fault *vmf)
 {
        struct page *page = vmf->page;
        struct inode *inode = file_inode(vmf->vma->vm_file);
--
Quoted 2 lines

1.9.1

Miklos, we would like to get this patch in queue
for 4.18.

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

Sure, queued up.

This patch is not merged in 4.18-rc-1

Miklos, Can we get this patch in 4.18-rc-x / 4.19 ?

Sure, queued up for 4.18-rc
(git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#for-next).

Sorry for the delay, somehow I left this off the 4.18 pull.

Thanks,
Miklos

#6 lore raw
Quoted 44 lines · Miklos Szeredi
Quoted 43 lines · Souptick Joarder
Quoted 42 lines · Souptick Joarder
Quoted 40 lines · Miklos Szeredi
Quoted 28 lines · Souptick Joarder
Quoted 27 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler in struct vm_operations_struct. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

commit 1c8f422059ae ("mm: change return type to vm_fault_t")

---
 fs/fuse/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/fuse/file.c +1 -1
index a201fb0..67648cc 100644
@@ -2048,7 +2048,7 @@ static void fuse_vma_close(struct vm_area_struct *vma)
  * - sync(2)
  * - try_to_free_pages() with order > PAGE_ALLOC_COSTLY_ORDER
  */
-static int fuse_page_mkwrite(struct vm_fault *vmf)
+static vm_fault_t fuse_page_mkwrite(struct vm_fault *vmf)
 {
Quoted 8 lines
Quoted 5 lines
fs/fuse/file.c +0 -1
        struct page *page = vmf->page;
        struct inode *inode = file_inode(vmf->vma->vm_file);
--

1.9.1

Miklos, we would like to get this patch in queue
for 4.18.

Sure, queued up.

Quoted 9 lines
Quoted 3 lines
Quoted 1 line

This patch is not merged in 4.18-rc-1

Miklos, Can we get this patch in 4.18-rc-x / 4.19 ?

Sure, queued up for 4.18-rc
(git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#for-next).

Sorry for the delay, somehow I left this off the 4.18 pull.

Thanks :)