mtd: nand: davinci: stop using pdev->id as chipselect

From: Bartosz Golaszewski <[email protected]>

We have the 'ti,davinci-chipselect' property in the device tree, but when using platform data the driver silently uses the id field of struct platform_device as the chipselect. This is confusing and we almost broke the nand support again recently after converting the platform to common clock framework (which changed the device id in the clock lookup - the problem is gone now that we no longer acquire the clock in the nand driver.

This series adds a new field to davinci-nand platform data, then makes all board use it and finally modifies the two drivers that make use of it.

Bartosz Golaszewski (12):
mtd: nand: davinci: store the core chipselect number in platform data

Hi Bartosz,

Quoted 10 lines · On Mon, 30 Apr 2018 10:24:41 +0200 Bartosz Golaszewski <[email protected]> wrote:

From: Bartosz Golaszewski <[email protected]>

We have the 'ti,davinci-chipselect' property in the device tree, but when using platform data the driver silently uses the id field of struct platform_device as the chipselect. This is confusing and we almost broke the nand support again recently after converting the platform to common clock framework (which changed the device id in the clock lookup - the problem is gone now that we no longer acquire the clock in the nand driver.

Quoted 6 lines

This series adds a new field to davinci-nand platform data, then makes all board use it and finally modifies the two drivers that make use of it.

Bartosz Golaszewski (12):
mtd: nand: davinci: store the core chipselect number in platform data

Raw NAND related patches (that is, everything that is not onenand or SPI NAND) should use the "mtd: rawnand: " prefix now. Other than that, I'm fine with the patch series, just let me know how you want to have it merged (through the MTD tree or the davinci tree).

Thanks,

Boris

2018-04-30 12:09 GMT+02:00 Boris Brezillon <[email protected]>:

Quoted 27 lines

Hi Bartosz,

Quoted 10 lines · On Mon, 30 Apr 2018 10:24:41 +0200 Bartosz Golaszewski <[email protected]> wrote:

From: Bartosz Golaszewski <[email protected]>

We have the 'ti,davinci-chipselect' property in the device tree, but when using platform data the driver silently uses the id field of struct platform_device as the chipselect. This is confusing and we almost broke the nand support again recently after converting the platform to common clock framework (which changed the device id in the clock lookup - the problem is gone now that we no longer acquire the clock in the nand driver.

Quoted 6 lines

This series adds a new field to davinci-nand platform data, then makes all board use it and finally modifies the two drivers that make use of it.

Bartosz Golaszewski (12):
mtd: nand: davinci: store the core chipselect number in platform data

Raw NAND related patches (that is, everything that is not onenand or SPI NAND) should use the "mtd: rawnand: " prefix now. Other than that, I'm fine with the patch series, just let me know how you want to have it merged (through the MTD tree or the davinci tree).

Quoted 3 lines

Thanks,

Boris

I think Sekhar could pick all those patches up for 4.18.

Sekhar - do you want me to resend the series with the commit message changed as requested by Boris, or can you fix it when applying the series?

Best regards,
Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

We have the 'ti,davinci-chipselect' property in the device tree, but when using platform data the driver silently uses the id field of struct platform_device as the chipselect. This is confusing and we almost broke the nand support again recently after converting the platform to common clock framework (which changed the device id in the clock lookup - the problem is gone now that we no longer acquire the clock in the nand driver.

This patch adds a new filed - core_chipsel - to the platform_data.

Subsequent patches will convert the platforms to using this new field.

Signed-off-by Bartosz Golaszewski <[email protected]>

Quoted 11 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

We have the 'ti,davinci-chipselect' property in the device tree, but when using platform data the driver silently uses the id field of struct platform_device as the chipselect. This is confusing and we almost broke the nand support again recently after converting the platform to common clock framework (which changed the device id in the clock lookup - the problem is gone now that we no longer acquire the clock in the nand driver.

This patch adds a new filed - core_chipsel - to the platform_data.

s/filed/field

Quoted 1 line

Subsequent patches will convert the platforms to using this new field.

Can you add a comment for this new field too, like how we have for most other fields?

Curious on what 'core' in core_chipsel means. Something to do with chip-select offset we have on DA850?

Quoted 28 lines · On Mon, 30 Apr 2018 18:45:06 +0200 Bartosz Golaszewski <[email protected]> wrote:

2018-04-30 12:09 GMT+02:00 Boris Brezillon <[email protected]>:

Quoted 27 lines

Hi Bartosz,

Quoted 10 lines · On Mon, 30 Apr 2018 10:24:41 +0200 Bartosz Golaszewski <[email protected]> wrote:

From: Bartosz Golaszewski <[email protected]>

We have the 'ti,davinci-chipselect' property in the device tree, but when using platform data the driver silently uses the id field of struct platform_device as the chipselect. This is confusing and we almost broke the nand support again recently after converting the platform to common clock framework (which changed the device id in the clock lookup - the problem is gone now that we no longer acquire the clock in the nand driver.

Quoted 6 lines

This series adds a new field to davinci-nand platform data, then makes all board use it and finally modifies the two drivers that make use of it.

Bartosz Golaszewski (12):
mtd: nand: davinci: store the core chipselect number in platform data

Raw NAND related patches (that is, everything that is not onenand or SPI NAND) should use the "mtd: rawnand: " prefix now. Other than that, I'm fine with the patch series, just let me know how you want to have it merged (through the MTD tree or the davinci tree).

Quoted 5 lines

Quoted 3 lines

Thanks,

Boris

I think Sekhar could pick all those patches up for 4.18.

Okay, then I'd need an immutable branch containing these changes.

Quoted 5 lines

Sekhar - do you want me to resend the series with the commit message changed as requested by Boris, or can you fix it when applying the series?

Quoted 15 lines · Sekhar Nori

Quoted 11 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

We have the 'ti,davinci-chipselect' property in the device tree, but when using platform data the driver silently uses the id field of struct platform_device as the chipselect. This is confusing and we almost broke the nand support again recently after converting the platform to common clock framework (which changed the device id in the clock lookup - the problem is gone now that we no longer acquire the clock in the nand driver.

This patch adds a new filed - core_chipsel - to the platform_data.

s/filed/field

Quoted 7 lines

Quoted 1 line

Subsequent patches will convert the platforms to using this new field.

Can you add a comment for this new field too, like how we have for most other fields?

Curious on what 'core' in core_chipsel means. Something to do with chip-select offset we have on DA850?

Looks like you may have just picked the terminology from DaVinci NAND driver (introduced back in 2009). But in this context, it means the 0-indexed chip-select number that of the asynchronous memory interface to which the NAND device is connected.

So, may be a comment here will suffice.

Hi Bartosz,

Quoted 14 lines · On Mon, 30 Apr 2018 10:24:41 +0200 Bartosz Golaszewski <[email protected]> wrote:

From: Bartosz Golaszewski <[email protected]>

We have the 'ti,davinci-chipselect' property in the device tree, but when using platform data the driver silently uses the id field of struct platform_device as the chipselect. This is confusing and we almost broke the nand support again recently after converting the platform to common clock framework (which changed the device id in the clock lookup - the problem is gone now that we no longer acquire the clock in the nand driver.

This series adds a new field to davinci-nand platform data, then makes all board use it and finally modifies the two drivers that make use of it.

Quoted 2 lines

Bartosz Golaszewski (12):
mtd: nand: davinci: store the core chipselect number in platform data

Raw NAND related patches (that is, everything that is not onenand or SPI NAND) should use the "mtd: rawnand: " prefix now. Other than that, I'm fine with the patch series, just let me know how you want to have it

Quoted 24 lines · Sekhar Nori

Quoted 15 lines · Sekhar Nori

Quoted 11 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

We have the 'ti,davinci-chipselect' property in the device tree, but when using platform data the driver silently uses the id field of struct platform_device as the chipselect. This is confusing and we almost broke the nand support again recently after converting the platform to common clock framework (which changed the device id in the clock lookup - the problem is gone now that we no longer acquire the clock in the nand driver.

This patch adds a new filed - core_chipsel - to the platform_data.

s/filed/field

Quoted 7 lines

Quoted 1 line

Subsequent patches will convert the platforms to using this new field.

Can you add a comment for this new field too, like how we have for most other fields?

Curious on what 'core' in core_chipsel means. Something to do with chip-select offset we have on DA850?

Quoted 6 lines

Looks like you may have just picked the terminology from DaVinci NAND driver (introduced back in 2009). But in this context, it means the 0-indexed chip-select number that of the asynchronous memory interface to which the NAND device is connected.

So, may be a comment here will suffice.

This is what I committed:

--8<--
commit 533d93703fa717fdf74c4fb711c868c4fdc8b475 (HEAD -> refs/heads/v4.18/nand-cs-simplification)

Author:     Bartosz Golaszewski <[email protected]>
AuthorDate: Mon Apr 30 10:24:42 2018 +0200
Commit:     Sekhar Nori <[email protected]>
CommitDate: Tue May 1 15:57:47 2018 +0530

mtd: nand: davinci: store the core chipselect number in platform data

Quoted 22 lines · Boris Brezillon

Hi Bartosz,

Quoted 16 lines · On Mon, 30 Apr 2018 10:24:41 +0200 Bartosz Golaszewski <[email protected]> wrote:

From: Bartosz Golaszewski <[email protected]>

We have the 'ti,davinci-chipselect' property in the device tree, but when using platform data the driver silently uses the id field of struct platform_device as the chipselect. This is confusing and we almost broke the nand support again recently after converting the platform to common clock framework (which changed the device id in the clock lookup - the problem is gone now that we no longer acquire the clock in the nand driver.

This series adds a new field to davinci-nand platform data, then makes all board use it and finally modifies the two drivers that make use of it.

Bartosz Golaszewski (12):
mtd: nand: davinci: store the core chipselect number in platform data

Quoted 3 lines

Raw NAND related patches (that is, everything that is not onenand or SPI NAND) should use the "mtd: rawnand: " prefix now. Other than that, I'm fine with the patch series, just let me know how you want to have it

Hi Boris, should I convert the "I'm fine" to some sort of formal tag? If yes, what is the tag and for which patches?

Quoted 24 lines · Sekhar Nori

Quoted 22 lines · Bartosz Golaszewski

Quoted 11 lines

From: Bartosz Golaszewski <[email protected]>

We have the 'ti,davinci-chipselect' property in the device tree, but when using platform data the driver silently uses the id field of struct platform_device as the chipselect. This is confusing and we almost broke the nand support again recently after converting the platform to common clock framework (which changed the device id in the clock lookup - the problem is gone now that we no longer acquire the clock in the nand driver.

This patch adds a new filed - core_chipsel - to the platform_data.

s/filed/field

Quoted 1 line

Subsequent patches will convert the platforms to using this new field.

Can you add a comment for this new field too, like how we have for most other fields?

Curious on what 'core' in core_chipsel means. Something to do with chip-select offset we have on DA850?

Quoted 6 lines

Looks like you may have just picked the terminology from DaVinci NAND driver (introduced back in 2009). But in this context, it means the 0-indexed chip-select number that of the asynchronous memory interface to which the NAND device is connected.

So, may be a comment here will suffice.

This is what I committed:

--8<--
commit 533d93703fa717fdf74c4fb711c868c4fdc8b475 (HEAD -> refs/heads/v4.18/nand-cs-simplification)

Author:     Bartosz Golaszewski <[email protected]>
AuthorDate: Mon Apr 30 10:24:42 2018 +0200
Commit:     Sekhar Nori <[email protected]>
CommitDate: Tue May 1 15:57:47 2018 +0530

mtd: nand: davinci: store the core chipselect number in platform data

We have the 'ti,davinci-chipselect' property in the device tree, but when using platform data the driver silently uses the id field of struct platform_device as the chipselect. This is confusing and we almost broke the nand support again recently after converting the platform to common clock framework (which changed the device id in the clock lookup - the problem is gone now that we no longer acquire the clock in the nand driver.

This patch adds a new field - core_chipsel - to the platform_data. Subsequent patches will convert the platforms to using this new field.

Signed-off-by Bartosz Golaszewski <[email protected]>

Signed-off-by Sekhar Nori <[email protected]>

include/linux/platform_data/mtd-davinci.h +0 -0

index f1a2cf655bdb..1bbfa27cccb4 100644
@@ -56,6 +56,16 @@ struct davinci_nand_pdata {          /* platform_data */
        uint32_t                mask_ale;

2018-05-01 12:29 GMT+02:00 Sekhar Nori <[email protected]>:

Quoted 30 lines · Sekhar Nori

Quoted 29 lines · Sekhar Nori

Quoted 15 lines · Bartosz Golaszewski

Quoted 11 lines

From: Bartosz Golaszewski <[email protected]>

We have the 'ti,davinci-chipselect' property in the device tree, but when using platform data the driver silently uses the id field of struct platform_device as the chipselect. This is confusing and we almost broke the nand support again recently after converting the platform to common clock framework (which changed the device id in the clock lookup - the problem is gone now that we no longer acquire the clock in the nand driver.

This patch adds a new filed - core_chipsel - to the platform_data.

s/filed/field

Quoted 7 lines

Quoted 1 line

Subsequent patches will convert the platforms to using this new field.

Can you add a comment for this new field too, like how we have for most other fields?

Curious on what 'core' in core_chipsel means. Something to do with chip-select offset we have on DA850?

Looks like you may have just picked the terminology from DaVinci NAND driver (introduced back in 2009). But in this context, it means the 0-indexed chip-select number that of the asynchronous memory interface to which the NAND device is connected.

Quoted 4 lines

Quoted 1 line

So, may be a comment here will suffice.

This is what I committed:

I don't see it in your tree yet.

Quoted 32 lines

--8<--
commit 533d93703fa717fdf74c4fb711c868c4fdc8b475 (HEAD -> refs/heads/v4.18/nand-cs-simplification)

Author:     Bartosz Golaszewski <[email protected]>
AuthorDate: Mon Apr 30 10:24:42 2018 +0200
Commit:     Sekhar Nori <[email protected]>
CommitDate: Tue May 1 15:57:47 2018 +0530

mtd: nand: davinci: store the core chipselect number in platform data

We have the 'ti,davinci-chipselect' property in the device tree, but when using platform data the driver silently uses the id field of struct platform_device as the chipselect. This is confusing and we almost broke the nand support again recently after converting the platform to common clock framework (which changed the device id in the clock lookup - the problem is gone now that we no longer acquire the clock in the nand driver.

This patch adds a new field - core_chipsel - to the platform_data. Subsequent patches will convert the platforms to using this new field.

Signed-off-by Bartosz Golaszewski <[email protected]>

Signed-off-by Sekhar Nori <[email protected]>

include/linux/platform_data/mtd-davinci.h +0 -0

index f1a2cf655bdb..1bbfa27cccb4 100644
@@ -56,6 +56,16 @@ struct davinci_nand_pdata {          /* platform_data */
        uint32_t                mask_ale;
        uint32_t                mask_cle;
 

include/linux/platform_data/mtd-davinci.h struct davinci_nand_pdata { /* platform_data */ · line 66

Quoted 8 lines

include/linux/platform_data/mtd-davinci.h +8 -0

+       /*
+        * 0-indexed chip-select number of the asynchronous
+        * interface to which the NAND device has been connected.
+        *
+        * So, if you have NAND connected to CS3 of DA850, you
+        * will pass '1' here. Since the asynchronous interface
+        * on DA850 starts from CS2.
+        */

Maybe we should add that on all other DaVinci SoCs the async interface starts from CS0?

Quoted 28 lines · On Mon, 30 Apr 2018 18:45:06 +0200 Bartosz Golaszewski <[email protected]> wrote:

2018-04-30 12:09 GMT+02:00 Boris Brezillon <[email protected]>:

Quoted 27 lines

Hi Bartosz,

Quoted 10 lines · On Mon, 30 Apr 2018 10:24:41 +0200 Bartosz Golaszewski <[email protected]> wrote:

From: Bartosz Golaszewski <[email protected]>

We have the 'ti,davinci-chipselect' property in the device tree, but when using platform data the driver silently uses the id field of struct platform_device as the chipselect. This is confusing and we almost broke the nand support again recently after converting the platform to common clock framework (which changed the device id in the clock lookup - the problem is gone now that we no longer acquire the clock in the nand driver.

Quoted 6 lines

This series adds a new field to davinci-nand platform data, then makes all board use it and finally modifies the two drivers that make use of it.

Bartosz Golaszewski (12):
mtd: nand: davinci: store the core chipselect number in platform data

Raw NAND related patches (that is, everything that is not onenand or SPI NAND) should use the "mtd: rawnand: " prefix now. Other than that, I'm fine with the patch series, just let me know how you want to have it merged (through the MTD tree or the davinci tree).

Quoted 5 lines

Quoted 3 lines

Thanks,

Boris

I think Sekhar could pick all those patches up for 4.18.

Okay, then I'd need an immutable branch containing these changes.