Skip to contentSkip to conversation

lib/ratelimit: Lockless ratelimiting

PATCH Superseded Dmitry Safonov 3 participants 8 messages Jun 26, 2018 – Jul 3, 2018

Subsystems (4)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 lib/ratelimit: Lockless ratelimiting

Currently ratelimit_state is protected with spin_lock. If the .lock is taken at the moment of ___ratelimit() call, the message is suppressed to make ratelimiting robust.

That results in the following issue issue:
CPU0 CPU1
------------------ ------------------
printk_ratelimit() printk_ratelimit()

        |                             |
  try_spin_lock()              try_spin_lock()
        |                             |
time_is_before_jiffies()          return 0; // suppress

So, concurrent call of ___ratelimit() results in silently suppressing one of the messages, regardless if the limit is reached or not. And rc->missed is not increased in such case so the issue is covered from user.

Convert ratelimiting to use atomic counters and drop spin_lock.

Note: That might be unexpected, but with the first interval of messages storm one can print up to burst*2 messages. So, it doesn't guarantee that in *any* interval amount of messages is lesser than burst. But, that differs lightly from previous behavior where one can start burst=5 interval and print 4 messages on the last milliseconds of interval + new 5 messages from new interval (totally 9 messages in lesser than interval value):

msg0 msg1-msg4 msg0-msg4

    |                     |       |
    |                     |       |
 |--o---------------------o-|-----o--------------------|--> (t)

<------->
Lesser than burst

Dropped dev/random patch since v1 version:
lkml.kernel.org/r/<[email protected]>

Cc Arnd Bergmann <[email protected]>
Cc David Airlie <[email protected]>
Cc Dmitry Safonov <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc Jani Nikula <[email protected]>
Cc Joonas Lahtinen <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc "Theodore Ts'o" <[email protected]>
Cc Thomas Gleixner <[email protected]>
---
 drivers/char/random.c            | 16 ++++-------
 drivers/gpu/drm/i915/i915_perf.c |  4 +--
 include/linux/ratelimit.h        | 24 +++++++++-------
 lib/ratelimit.c                  | 59 +++++++++++++++++++---------------------
 4 files changed, 50 insertions(+), 53 deletions(-)
drivers/char/random.c +6 -10
index a8fb0020ba5c..ba67ea0dc568 100644
@@ -936,24 +936,20 @@ static void crng_reseed(struct crng_state *crng, struct entropy_store *r)
 	crng->init_time = jiffies;
 	spin_unlock_irqrestore(&crng->lock, flags);
 	if (crng == &primary_crng && crng_init < 2) {
+		int unseeded_miss, urandom_miss;
+
 		invalidate_batched_entropy();
 		numa_crng_init();
 		crng_init = 2;
 		process_random_ready_list();
 		wake_up_interruptible(&crng_init_wait);
 		pr_notice("random: crng init done\n");
-		if (unseeded_warning.missed) {
+		if ((unseeded_miss = atomic_xchg(&unseeded_warning.missed, 0)))
 			pr_notice("random: %d get_random_xx warning(s) missed "
-				  "due to ratelimiting\n",
-				  unseeded_warning.missed);
-			unseeded_warning.missed = 0;
-		}
-		if (urandom_warning.missed) {
+				  "due to ratelimiting\n", unseeded_miss);
+		if ((urandom_miss = atomic_xchg(&urandom_warning.missed, 0)))
 			pr_notice("random: %d urandom warning(s) missed "
-				  "due to ratelimiting\n",
-				  urandom_warning.missed);
-			urandom_warning.missed = 0;
-		}
+				  "due to ratelimiting\n", urandom_miss);
 	}
 }
 
drivers/gpu/drm/i915/i915_perf.c +2 -2
index 019bd2d073ad..75f6203f6e8e 100644
@@ -1317,9 +1317,9 @@ static void i915_oa_stream_destroy(struct i915_perf_stream *stream)
 
 	put_oa_config(dev_priv, stream->oa_config);
 
-	if (dev_priv->perf.oa.spurious_report_rs.missed) {
+	if (atomic_read(&dev_priv->perf.oa.spurious_report_rs.missed)) {
 		DRM_NOTE("%d spurious OA report notices suppressed due to ratelimiting\n",
-			 dev_priv->perf.oa.spurious_report_rs.missed);
+			 atomic_read(&dev_priv->perf.oa.spurious_report_rs.missed));
 	}
 }
 
include/linux/ratelimit.h +14 -10
index 8ddf79e9207a..7b5914e12d5b 100644
@@ -4,7 +4,6 @@
 
 #include <linux/param.h>
 #include <linux/sched.h>
-#include <linux/spinlock.h>
 
 #define DEFAULT_RATELIMIT_INTERVAL	(5 * HZ)
 #define DEFAULT_RATELIMIT_BURST		10
@@ -13,20 +12,20 @@
 #define RATELIMIT_MSG_ON_RELEASE	BIT(0)
 
 struct ratelimit_state {
-	raw_spinlock_t	lock;		/* protect the state */
+	atomic_t	printed;
+	atomic_t	missed;
 
 	int		interval;
 	int		burst;
-	int		printed;
-	int		missed;
 	unsigned long	begin;
 	unsigned long	flags;
 };
 
 #define RATELIMIT_STATE_INIT(name, interval_init, burst_init) {		\
-		.lock		= __RAW_SPIN_LOCK_UNLOCKED(name.lock),	\
 		.interval	= interval_init,			\
 		.burst		= burst_init,				\
+		.printed	= ATOMIC_INIT(0),			\
+		.missed		= ATOMIC_INIT(0),			\
 	}
 
 #define RATELIMIT_STATE_INIT_DISABLED					\
@@ -42,9 +41,10 @@ static inline void ratelimit_state_init(struct ratelimit_state *rs,
 {
 	memset(rs, 0, sizeof(*rs));
 
-	raw_spin_lock_init(&rs->lock);
 	rs->interval	= interval;
 	rs->burst	= burst;
+	atomic_set(&rs->printed, 0);
+	atomic_set(&rs->missed, 0);
 }
 
 static inline void ratelimit_default_init(struct ratelimit_state *rs)
@@ -53,16 +53,20 @@ static inline void ratelimit_default_init(struct ratelimit_state *rs)
 					DEFAULT_RATELIMIT_BURST);
 }
 
+/*
+ * Keeping it simple: not reenterable and not safe for concurrent
+ * ___ratelimit() call as used only by devkmsg_release().
+ */
 static inline void ratelimit_state_exit(struct ratelimit_state *rs)
 {
+	int missed;
+
 	if (!(rs->flags & RATELIMIT_MSG_ON_RELEASE))
 		return;
 
-	if (rs->missed) {
+	if ((missed = atomic_xchg(&rs->missed, 0)))
 		pr_warn("%s: %d output lines suppressed due to ratelimiting\n",
-			current->comm, rs->missed);
-		rs->missed = 0;
-	}
+			current->comm, missed);
 }
 
 static inline void
lib/ratelimit.c +28 -31

79 lines not on this page · raw message

Signature · 6 lines
2.13.6

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.CHECKPATCH: warning for lib/ratelimit: Lockless ratelimiting

== Series Details ==

== Series Details ==

Series: lib/ratelimit: Lockless ratelimiting
URL : https://patchwork.freedesktop.org/series/45416/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
a8dce76165a9 lib/ratelimit: Lockless ratelimiting
-:74: ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#74: FILE: drivers/char/random.c:947:
+		if ((unseeded_miss = atomic_xchg(&unseeded_warning.missed, 0)))

-:82: ERROR:ASSIGN_IN_IF: do not use assignment in if condition #82: FILE: drivers/char/random.c:950:
+ if ((urandom_miss = atomic_xchg(&urandom_warning.missed, 0)))

-:173: ERROR:ASSIGN_IN_IF: do not use assignment in if condition #173: FILE: include/linux/ratelimit.h:67:
+ if ((missed = atomic_xchg(&rs->missed, 0)))

-:195: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #195: FILE: lib/ratelimit.c:21:
+ unsigned missed = (unsigned)atomic_xchg(&rs->missed, 0);

-:195: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #195: FILE: lib/ratelimit.c:21:
+ unsigned missed = (unsigned)atomic_xchg(&rs->missed, 0);

total: 3 errors, 2 warnings, 0 checks, 186 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✓ Fi.CI.BAT: success for lib/ratelimit: Lockless ratelimiting

In reply to Dmitry Safonov
== Series Details ==

== Series Details ==

Series: lib/ratelimit: Lockless ratelimiting
URL : https://patchwork.freedesktop.org/series/45416/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4380 -> Patchwork_9426 =

== Summary - SUCCESS ==

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/45416/revisions/1/mbox/

== Known issues ==

Here are the changes found in Patchwork_9426 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_getparams_basic@basic-subslice-total:
      fi-skl-6770hq:      PASS -> DMESG-WARN (fdo#105541)

    
    ==== Possible fixes ====

    igt@gem_basic@bad-close:
      fi-skl-6770hq:      DMESG-WARN (fdo#105541) -> PASS

fdo#105541 https://bugs.freedesktop.org/show_bug.cgi?id=105541

== Participating hosts (44 -> 39) ==

Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u

== Build changes ==

* Linux: CI_DRM_4380 -> Patchwork_9426

CI_DRM_4380: e69a5560b14d9c7377744267ffd9963f06734f38 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4530: 0e98bf69f146eb72fe3a7c3b19a049b5786f0ca3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9426: a8dce76165a9eb3723ba64d789077c655f91c47f @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

a8dce76165a9 lib/ratelimit: Lockless ratelimiting

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9426/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
In reply to Dmitry Safonov
Quoted 29 lines · Dmitry Safonov

Currently ratelimit_state is protected with spin_lock. If the .lock is taken at the moment of ___ratelimit() call, the message is suppressed to make ratelimiting robust.

That results in the following issue issue:
CPU0 CPU1
------------------ ------------------
printk_ratelimit() printk_ratelimit()

        |                             |
  try_spin_lock()              try_spin_lock()
        |                             |
time_is_before_jiffies()          return 0; // suppress

So, concurrent call of ___ratelimit() results in silently suppressing one of the messages, regardless if the limit is reached or not. And rc->missed is not increased in such case so the issue is covered from user.

Convert ratelimiting to use atomic counters and drop spin_lock.

Note: That might be unexpected, but with the first interval of messages storm one can print up to burst*2 messages. So, it doesn't guarantee that in *any* interval amount of messages is lesser than burst. But, that differs lightly from previous behavior where one can start burst=5 interval and print 4 messages on the last milliseconds of interval + new 5 messages from new interval (totally 9 messages in lesser than interval value):

msg0 msg1-msg4 msg0-msg4

Quoted 8 lines
    |                     |       |
    |                     |       |
 |--o---------------------o-|-----o--------------------|--> (t)

<------->
Lesser than burst

#define RATELIMIT_STATE_INIT(name, interval_init, burst_init) { \
- .lock = __RAW_SPIN_LOCK_UNLOCKED(name.lock), \

name is now redundant, isn't it?

Quoted 8 lines
                .interval       = interval_init,                        \
                .burst          = burst_init,                           \
include/linux/ratelimit.h +2 -0
+               .printed        = ATOMIC_INIT(0),                       \
+               .missed         = ATOMIC_INIT(0),                       \
        }
 
 #define RATELIMIT_STATE_INIT_DISABLED                                  \

include/linux/ratelimit.h static inline void ratelimit_state_init(struct ratelimit_state *rs, · line 47

Quoted 8 lines
include/linux/ratelimit.h +2 -1
@@ -42,9 +41,10 @@ static inline void ratelimit_state_init(struct ratelimit_state *rs,
 {
        memset(rs, 0, sizeof(*rs));
 
-       raw_spin_lock_init(&rs->lock);
        rs->interval    = interval;
        rs->burst       = burst;
+       atomic_set(&rs->printed, 0);
+       atomic_set(&rs->missed, 0);

Can it be

*rs = RATELIMIT_STATE_INIT(interval, burst);

?

(Yes, the '(struct ratelimit_state)' has to be added to macro to allow this)

include/linux/ratelimit.h static inline void ratelimit_default_init(struct ratelimit_state *rs) · line 67

Quoted 12 lines
(quoted diff) +0 -0
 }
 
 

static inline void ratelimit_state_exit(struct ratelimit_state *rs) {

include/linux/ratelimit.h +3 -1
+       int missed;
+
        if (!(rs->flags & RATELIMIT_MSG_ON_RELEASE))
                return;
 
-       if (rs->missed) {
+       if ((missed = atomic_xchg(&rs->missed, 0)))

Perhaps

missed = ...
if (missed)

?

Quoted 7 lines

pr_warn("%s: %d output lines suppressed due to ratelimiting\n",

lib/ratelimit.c +1 -3
-                       current->comm, rs->missed);
-               rs->missed = 0;
-       }
+                       current->comm, missed);
 }
 

lib/ratelimit.c line 24

Quoted 10 lines
lib/ratelimit.c +9 -0
+static void ratelimit_end_interval(struct ratelimit_state *rs, const char *func)
+{
+       rs->begin = jiffies;
+
+       if (!(rs->flags & RATELIMIT_MSG_ON_RELEASE)) {
 
+               unsigned missed = (unsigned)atomic_xchg(&rs->missed, 0);
+
+               if (missed)
+                       pr_warn("%s: %u callbacks suppressed\n", func, missed);

Instead of casting, perhaps

int missed = ...

I think you already has a guard against going it below zero. Or I missed something?

Quoted 2 lines
lib/ratelimit.c +2 -0
+       }
+}
Signature · 6 lines
With Best Regards,
Andy Shevchenko
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#4 lore raw

Hi Andy, thanks for the review,

On Tue, 2018-06-26 at 20:04 +0300, Andy Shevchenko wrote [..]

Quoted 6 lines
Quoted 4 lines

#define RATELIMIT_STATE_INIT(name, interval_init, burst_init)
{ \
- .lock =
__RAW_SPIN_LOCK_UNLOCKED(name.lock), \

name is now redundant, isn't it?

It is. Worth to split on the second patch or keep callers changes in this patch?

Quoted 13 lines

include/linux/ratelimit.h static inline void ratelimit_state_init(struct · line 48

Quoted 10 lines
include/linux/ratelimit.h +2 -1
@@ -42,9 +41,10 @@ static inline void ratelimit_state_init(struct
 ratelimit_state *rs,
 {
        memset(rs, 0, sizeof(*rs));
 
-       raw_spin_lock_init(&rs->lock);
        rs->interval    = interval;
        rs->burst       = burst;
+       atomic_set(&rs->printed, 0);
+       atomic_set(&rs->missed, 0);

Can it be

Quoted 6 lines

*rs = RATELIMIT_STATE_INIT(interval, burst);

?

(Yes, the '(struct ratelimit_state)' has to be added to macro to allow this)

Sure.

Quoted 11 lines

include/linux/ratelimit.h static inline void ratelimit_default_init(struct ratelimit_state *rs) · line 67

Quoted 10 lines
(quoted diff) +0 -0
 static inline void ratelimit_state_exit(struct ratelimit_state
 *rs)

{

include/linux/ratelimit.h +3 -1
+       int missed;
+
        if (!(rs->flags & RATELIMIT_MSG_ON_RELEASE))
                return;
 
-       if (rs->missed) {
+       if ((missed = atomic_xchg(&rs->missed, 0)))
Quoted 6 lines

Perhaps

missed = ...
if (missed)

?

Ok, will change - checkpatch has warned me, but I thought it's just a preference than a rule.

Quoted 21 lines
Quoted 19 lines

pr_warn("%s: %d output lines suppressed due to
ratelimiting\n",

include/linux/ratelimit.h +2 -3
-                       current->comm, rs->missed);
-               rs->missed = 0;
-       }
+                       current->comm, missed);
 }
+static void ratelimit_end_interval(struct ratelimit_state *rs,

const char *func)

lib/ratelimit.c +5 -0
+{
+       rs->begin = jiffies;
+
+       if (!(rs->flags & RATELIMIT_MSG_ON_RELEASE)) {
+               unsigned missed = (unsigned)atomic_xchg(&rs-
Quoted 1 line

missed, 0);

lib/ratelimit.c +3 -0
+
+               if (missed)
+                       pr_warn("%s: %u callbacks suppressed\n",
Quoted 1 line

func, missed);

Quoted 6 lines

Instead of casting, perhaps

int missed = ...

I think you already has a guard against going it below zero. Or I missed something?

No, I do:
atomic_add_unless(&rs->missed, 1, -1);

So, it's guard against overflow, but not against negative. That's why I do print it as unsigned.

Signature · 6 lines
Thanks,
             Dmitry
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#5 lore raw
Quoted 11 lines · Dmitry Safonov

On Tue, 2018-06-26 at 20:04 +0300, Andy Shevchenko wrote

Quoted 6 lines
Quoted 4 lines

#define RATELIMIT_STATE_INIT(name, interval_init, burst_init)
{ \
- .lock =
__RAW_SPIN_LOCK_UNLOCKED(name.lock), \

name is now redundant, isn't it?

It is. Worth to split on the second patch or keep callers changes in this patch?

For me sounds like a part of this change, though weakly tighten to the main purpose.
Otherwise in the middle of the series you introduce some bogus stuff (not sure if compiler or some static analyzers would warn about it).

Quoted 13 lines
Quoted 13 lines

include/linux/ratelimit.h static inline void ratelimit_state_init(struct · line 48

Quoted 10 lines
include/linux/ratelimit.h +2 -1
@@ -42,9 +41,10 @@ static inline void ratelimit_state_init(struct
 ratelimit_state *rs,
 {
        memset(rs, 0, sizeof(*rs));
 
-       raw_spin_lock_init(&rs->lock);
        rs->interval    = interval;
        rs->burst       = burst;
+       atomic_set(&rs->printed, 0);
+       atomic_set(&rs->missed, 0);

Can it be

Quoted 8 lines
Quoted 6 lines

*rs = RATELIMIT_STATE_INIT(interval, burst);

?

(Yes, the '(struct ratelimit_state)' has to be added to macro to allow this)

Sure.

This part, by the way, potentially can be split into preparatory patch. Please, double check if it possible to do this way.

Quoted 5 lines
Quoted 5 lines

include/linux/ratelimit.h static inline void ratelimit_default_init(struct ratelimit_state *rs) · line 67

Quoted 2 lines
include/linux/ratelimit.h +1 -1
-       if (rs->missed) {
+       if ((missed = atomic_xchg(&rs->missed, 0)))

Perhaps

Quoted 7 lines
Quoted 4 lines

missed = ...
if (missed)

?

Ok, will change - checkpatch has warned me, but I thought it's just a preference than a rule.

In general, yes and no. In this case it would increase readability and assignment inside conditionals is not the best practice.

Quoted 4 lines
Quoted 4 lines

Instead of casting, perhaps

int missed = ...

Quoted 8 lines
Quoted 2 lines

I think you already has a guard against going it below zero. Or I missed something?

No, I do:
atomic_add_unless(&rs->missed, 1, -1);

So, it's guard against overflow, but not against negative. That's why I do print it as unsigned.

Hmm...
If you increment the variable, it would become 2^n, then 2^n + 1, ... which in unsigned form quite far from -1.

So, this check is against revolving the value. Otherwise you are using atomic_t as unsigned type indeed.

But in case of use you assign signed to unsigned which would not overflow, so, the casting is superfluous.

(and I would rather go with unsigned int type instead of unsigned if it fits style of the module)

Signature · 6 lines
With Best Regards,
Andy Shevchenko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#6 lore raw
Quoted 18 lines · Andy Shevchenko
Quoted 18 lines
Quoted 18 lines

include/linux/ratelimit.h static inline void ratelimit_state_init(struct ratelimit_state *rs, · line 47

Quoted 11 lines
(quoted diff) +0 -0
@@ -42,9 +41,10 @@ static inline void

ratelimit_state_init(struct
ratelimit_state *rs,

 {
        memset(rs, 0, sizeof(*rs));
include/linux/ratelimit.h +2 -1
-       raw_spin_lock_init(&rs->lock);
        rs->interval    = interval;
        rs->burst       = burst;
+       atomic_set(&rs->printed, 0);
+       atomic_set(&rs->missed, 0);

Can it be

*rs = RATELIMIT_STATE_INIT(interval, burst);

?

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

(Yes, the '(struct ratelimit_state)' has to be added to macro to allow this)

Sure.

This part, by the way, potentially can be split into preparatory patch. Please, double check if it possible to do this way.

Hmm, I tried this way:
:#define RATELIMIT_STATE_INIT(name, interval_init, burst_init) ({ \
: struct ratelimit_state name = { \

:                       .lock = __RAW_SPIN_LOCK_UNLOCKED(name.lock), \
:                       .interval       = interval_init,          \
:                       .burst          = burst_init,             \
:               };                                                \
:               name;                                             \

: })

but the expression becomes non-constant, so it fails to compile in definitions of globals.

I think I'll change it to
struct ratelimit_state tmp = RATELIMIT_STATE_INIT(...); *rs = tmp;

Not perfect, but we did memset() and set elements after, so it's kinda the same.

Signature · 6 lines
Thanks,
             Dmitry
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#7 lore raw

✓ Fi.CI.IGT: success for lib/ratelimit: Lockless ratelimiting

In reply to Dmitry Safonov
== Series Details ==

== Series Details ==

Series: lib/ratelimit: Lockless ratelimiting
URL : https://patchwork.freedesktop.org/series/45416/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4380_full -> Patchwork_9426_full =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_9426_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_9426_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_9426_full:

=== IGT changes ===

    ==== Warnings ====

    igt@gem_exec_schedule@deep-bsd2:
      shard-kbl:          SKIP -> PASS

== Known issues ==

Here are the changes found in Patchwork_9426_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_gtt:
      shard-apl:          PASS -> FAIL (fdo#105347)

    igt@drv_suspend@shrink:
      shard-glk:          PASS -> FAIL (fdo#106886)

    igt@gem_softpin@noreloc-s3:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665)

    igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
      shard-glk:          PASS -> FAIL (fdo#105703)

    igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
      shard-hsw:          PASS -> FAIL (fdo#105767)

    igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size:
      shard-hsw:          PASS -> FAIL (fdo#103355)

    igt@kms_cursor_legacy@cursor-vs-flip-toggle:
      shard-kbl:          PASS -> FAIL (fdo#103355)

    igt@kms_flip_tiling@flip-x-tiled:
      shard-glk:          PASS -> FAIL (fdo#103822, fdo#104724)

    igt@perf@blocking:
      shard-hsw:          PASS -> FAIL (fdo#102252)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_hangcheck:
      shard-kbl:          DMESG-FAIL (fdo#106947, fdo#106560) -> PASS

    igt@kms_flip@plain-flip-ts-check-interruptible:
      shard-glk:          FAIL (fdo#100368) -> PASS

    igt@kms_flip_tiling@flip-to-x-tiled:
      shard-glk:          FAIL (fdo#103822, fdo#104724) -> PASS

fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
fdo#105703 https://bugs.freedesktop.org/show_bug.cgi?id=105703
fdo#105767 https://bugs.freedesktop.org/show_bug.cgi?id=105767
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947

== Participating hosts (5 -> 5) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_4380 -> Patchwork_9426

CI_DRM_4380: e69a5560b14d9c7377744267ffd9963f06734f38 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4530: 0e98bf69f146eb72fe3a7c3b19a049b5786f0ca3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9426: a8dce76165a9eb3723ba64d789077c655f91c47f @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9426/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx