USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected
PATCH v2 1/1 USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected
Quoted 17 lines · Fabio Estevam
Hi Shawn,
Quoted 3 lines · Shawn Guo
We can have the options in defconfig, but they can still be turned off for whatever reason and we get the hang. Really, missing a user selectable option in defconfig shouldn't result in a system hang.
Yes, 100% agree and this is exactly what this USB patch is all about :-)
The whole point of this USB patch is not to let the the system to hang when the defconfig options are turned off.
It will warn the user that
CONFIG_USB_CHIPIDEA_ULPIneeds to be selected, will propagate an error, but at least the system will not hang.
Quoted 5 lines
The user will certainly notice the big warning which says "Select
CONFIG_USB_CHIPIDEA_ULPIin order to use ULPI mode"Please check the original patch of this thread:
https://patchwork.kernel.org/patch/10486371/
I'm still not convinced this is the best way to go. But that's USB maintainer's call. I will just apply defconfig patches which shouldn't hurt anyway.
Shawn
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html