Skip to contentSkip to conversation

ASoC: add es7241 support

PATCH In review Jerome Brunet 2 participants 9 messages Jul 3, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v3 cover ASoC: add es7241 support

Add support for the es7241 which is a simple 2 channels analog to digital converter.

Changes since v1: [0]
* Add missing break as reported by smatch [1]
My device is hardwired in slave mode, which probably why this slipped through unnoticed.

Changes since v2: [2]
* Supply are now required dt properties
* Add a dt property to state the serial interface configuration

[0]: https://lkml.kernel.org/r/[email protected]
[1]: https://lkml.kernel.org/r/20180630082829.qwnhkk4f76n32omm@mwanda
[2]: https://lkml.kernel.org/r/[email protected]

Jerome Brunet (2):
ASoC: es7241: add dt-bindings documentation for the es7241 adc
ASoC: es7241: add es7241 codec support

 .../devicetree/bindings/sound/everest,es7241.txt   |  28 ++
 sound/soc/codecs/Kconfig                           |   4 +
 sound/soc/codecs/Makefile                          |   2 +
 sound/soc/codecs/es7241.c                          | 322 +++++++++++++++++++++
 4 files changed, 356 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/everest,es7241.txt
 create mode 100644 sound/soc/codecs/es7241.c
Signature · 1 line
2.14.4
#1 lore raw

PATCH v3 1/2 ASoC: es7241: add dt-bindings documentation for the es7241 adc

---
 .../devicetree/bindings/sound/everest,es7241.txt   | 28 ++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/everest,es7241.txt
Documentation/devicetree/bindings/sound/everest,es7241.txt new file +28 -0
new file mode 100644
index 000000000000..28f82cf4959f
@@ -0,0 +1,28 @@
+ES7241 i2s AD converter
+
+Required properties:
+- compatible : "everest,es7241"
+- VDDP-supply: regulator phandle for the VDDA supply
+- VDDA-supply: regulator phandle for the VDDP supply
+- VDDD-supply: regulator phandle for the VDDD supply
+
+Optional properties:
+- reset-gpios: gpio connected to the reset pin
+- m0-gpios   : gpio connected to the m0 pin
+- m1-gpios   : gpio connected to the m1 pin
+- everest,sdout-pull-down:
+   Format used by the serial interface is controlled by pulling
+   the sdout. If the sdout is pulled down, leftj format is used.
+   If this property is not provided, sdout is assumed to pulled
+   up and i2s format is used
+
+Example:
+
+linein: audio-codec@2 {
+	#sound-dai-cells = <0>;
+	compatible = "everest,es7241";
+	VDDA-supply = <&vcc_3v3>;
+	VDDP-supply = <&vcc_3v3>;
+	VDDD-supply = <&vcc_3v3>;
+	reset-gpios = <&gpio GPIOH_42>;
+};
Signature · 1 line
2.14.4
maintainer
#2 lore raw

Applied "ASoC: es7241: add dt-bindings documentation for the es7241 adc" to the asoc tree

The patch

ASoC: es7241: add dt-bindings documentation for the es7241 adc

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 1b8fc56ed514f815c4779273348c3308fb263c87 Mon Sep 17 00:00:00 2001

From: Jerome Brunet <[email protected]>
Date: Tue, 3 Jul 2018 15:28:44 +0200
Subject: [PATCH] ASoC: es7241: add dt-bindings documentation for the es7241
adc

---
 .../bindings/sound/everest,es7241.txt         | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/everest,es7241.txt
Documentation/devicetree/bindings/sound/everest,es7241.txt new file +28 -0
new file mode 100644
index 000000000000..28f82cf4959f
@@ -0,0 +1,28 @@
+ES7241 i2s AD converter
+
+Required properties:
+- compatible : "everest,es7241"
+- VDDP-supply: regulator phandle for the VDDA supply
+- VDDA-supply: regulator phandle for the VDDP supply
+- VDDD-supply: regulator phandle for the VDDD supply
+
+Optional properties:
+- reset-gpios: gpio connected to the reset pin
+- m0-gpios   : gpio connected to the m0 pin
+- m1-gpios   : gpio connected to the m1 pin
+- everest,sdout-pull-down:
+   Format used by the serial interface is controlled by pulling
+   the sdout. If the sdout is pulled down, leftj format is used.
+   If this property is not provided, sdout is assumed to pulled
+   up and i2s format is used
+
+Example:
+
+linein: audio-codec@2 {
+	#sound-dai-cells = <0>;
+	compatible = "everest,es7241";
+	VDDA-supply = <&vcc_3v3>;
+	VDDP-supply = <&vcc_3v3>;
+	VDDD-supply = <&vcc_3v3>;
+	reset-gpios = <&gpio GPIOH_42>;
+};
Signature · 1 line
2.18.0.rc2
#3 lore raw

PATCH v3 2/2 ASoC: es7241: add es7241 codec support

In reply to Jerome Brunet

Add support for the everest es7241 which is a simple 2 channels analog to digital converter.

---
 sound/soc/codecs/Kconfig  |   4 +
 sound/soc/codecs/Makefile |   2 +
 sound/soc/codecs/es7241.c | 322 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 328 insertions(+)
 create mode 100644 sound/soc/codecs/es7241.c
sound/soc/codecs/Kconfig +4 -0
index f5839eeeed5e..047ac28ba40f 100644
@@ -79,6 +79,7 @@ config SND_SOC_ALL_CODECS
 	select SND_SOC_ES8328_SPI if SPI_MASTER
 	select SND_SOC_ES8328_I2C if I2C
 	select SND_SOC_ES7134
+	select SND_SOC_ES7241
 	select SND_SOC_GTM601
 	select SND_SOC_HDAC_HDMI
 	select SND_SOC_ICS43432
@@ -584,6 +585,9 @@ config SND_SOC_HDMI_CODEC
 config SND_SOC_ES7134
        tristate "Everest Semi ES7134 CODEC"
 
+config SND_SOC_ES7241
+       tristate "Everest Semi ES7241 CODEC"
+
 config SND_SOC_ES8316
 	tristate "Everest Semi ES8316 CODEC"
 	depends on I2C
sound/soc/codecs/Makefile +2 -0
index 6cc15d1c5767..719653a4c882 100644
@@ -71,6 +71,7 @@ snd-soc-da732x-objs := da732x.o
 snd-soc-da9055-objs := da9055.o
 snd-soc-dmic-objs := dmic.o
 snd-soc-es7134-objs := es7134.o
+snd-soc-es7241-objs := es7241.o
 snd-soc-es8316-objs := es8316.o
 snd-soc-es8328-objs := es8328.o
 snd-soc-es8328-i2c-objs := es8328-i2c.o
@@ -329,6 +330,7 @@ obj-$(CONFIG_SND_SOC_DA732X)	+= snd-soc-da732x.o
 obj-$(CONFIG_SND_SOC_DA9055)	+= snd-soc-da9055.o
 obj-$(CONFIG_SND_SOC_DMIC)	+= snd-soc-dmic.o
 obj-$(CONFIG_SND_SOC_ES7134)	+= snd-soc-es7134.o
+obj-$(CONFIG_SND_SOC_ES7241)	+= snd-soc-es7241.o
 obj-$(CONFIG_SND_SOC_ES8316)    += snd-soc-es8316.o
 obj-$(CONFIG_SND_SOC_ES8328)	+= snd-soc-es8328.o
 obj-$(CONFIG_SND_SOC_ES8328_I2C)+= snd-soc-es8328-i2c.o
sound/soc/codecs/es7241.c new file +322 -0

322 lines not on this page · raw message

Signature · 1 line
2.14.4
maintainer
#4 lore raw

Applied "ASoC: es7241: add es7241 codec support" to the asoc tree

The patch

ASoC: es7241: add es7241 codec support

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 5f7bdc466c772b3af3145a71724965ecdc03e6bf Mon Sep 17 00:00:00 2001

From: Jerome Brunet <[email protected]>
Date: Tue, 3 Jul 2018 15:28:45 +0200
Subject: [PATCH] ASoC: es7241: add es7241 codec support

Add support for the everest es7241 which is a simple 2 channels analog to digital converter.

---
 sound/soc/codecs/Kconfig  |   4 +
 sound/soc/codecs/Makefile |   2 +
 sound/soc/codecs/es7241.c | 322 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 328 insertions(+)
 create mode 100644 sound/soc/codecs/es7241.c
sound/soc/codecs/Kconfig +4 -0
index 6d1674699385..efb095dbcd71 100644
@@ -79,6 +79,7 @@ config SND_SOC_ALL_CODECS
 	select SND_SOC_ES8328_SPI if SPI_MASTER
 	select SND_SOC_ES8328_I2C if I2C
 	select SND_SOC_ES7134
+	select SND_SOC_ES7241
 	select SND_SOC_GTM601
 	select SND_SOC_HDAC_HDMI
 	select SND_SOC_ICS43432
@@ -585,6 +586,9 @@ config SND_SOC_HDMI_CODEC
 config SND_SOC_ES7134
        tristate "Everest Semi ES7134 CODEC"
 
+config SND_SOC_ES7241
+       tristate "Everest Semi ES7241 CODEC"
+
 config SND_SOC_ES8316
 	tristate "Everest Semi ES8316 CODEC"
 	depends on I2C
sound/soc/codecs/Makefile +2 -0
index f26ded89a1e5..7ae7c85e8219 100644
@@ -71,6 +71,7 @@ snd-soc-da732x-objs := da732x.o
 snd-soc-da9055-objs := da9055.o
 snd-soc-dmic-objs := dmic.o
 snd-soc-es7134-objs := es7134.o
+snd-soc-es7241-objs := es7241.o
 snd-soc-es8316-objs := es8316.o
 snd-soc-es8328-objs := es8328.o
 snd-soc-es8328-i2c-objs := es8328-i2c.o
@@ -330,6 +331,7 @@ obj-$(CONFIG_SND_SOC_DA732X)	+= snd-soc-da732x.o
 obj-$(CONFIG_SND_SOC_DA9055)	+= snd-soc-da9055.o
 obj-$(CONFIG_SND_SOC_DMIC)	+= snd-soc-dmic.o
 obj-$(CONFIG_SND_SOC_ES7134)	+= snd-soc-es7134.o
+obj-$(CONFIG_SND_SOC_ES7241)	+= snd-soc-es7241.o
 obj-$(CONFIG_SND_SOC_ES8316)    += snd-soc-es8316.o
 obj-$(CONFIG_SND_SOC_ES8328)	+= snd-soc-es8328.o
 obj-$(CONFIG_SND_SOC_ES8328_I2C)+= snd-soc-es8328-i2c.o
sound/soc/codecs/es7241.c new file +322 -0

322 lines not on this page · raw message

Signature · 1 line
2.18.0.rc2
maintainer
#5 lore raw
In reply to Jerome Brunet
Quoted 2 lines · Jerome Brunet

Add support for the es7241 which is a simple 2 channels analog to digital converter.

Please don't resubmit patches that have already been applied, you should submit patches against current code in the tree you're expecting things to be applied to. If any updates are needed to a patch that's already been applied you should submit incremental patches which make those updates. This avoids having to change published git commits which could cause problems for people working against git.

#6 lore raw
Quoted 10 lines · Mark Brown
Quoted 2 lines · Jerome Brunet

Add support for the es7241 which is a simple 2 channels analog to digital converter.

Please don't resubmit patches that have already been applied, you should submit patches against current code in the tree you're expecting things to be applied to. If any updates are needed to a patch that's already been applied you should submit incremental patches which make those updates. This avoids having to change published git commits which could cause problems for people working against git.

Unless I missed something, which entirely possible, I don't think any patches of this series have been applied yet. You asked me resubmit after the v1 because of
power supply bindings and the mode selection.

I don't see anything related to the es7241 in your tree ATM.

maintainer
#7 lore raw
Quoted 5 lines · Jerome Brunet

Unless I missed something, which entirely possible, I don't think any patches of this series have been applied yet. You asked me resubmit after the v1 because of
power supply bindings and the mode selection.

I don't see anything related to the es7241 in your tree ATM.

Oh, my mistake sorry - I must have copied it into my to apply queue twice so got a reject on the second application.

#8 lore raw
Quoted 9 lines · Mark Brown
Quoted 4 lines · Jerome Brunet

Unless I missed something, which entirely possible, I don't think any patches of this series have been applied yet. You asked me resubmit after the v1 because of
power supply bindings and the mode selection.
I don't see anything related to the es7241 in your tree ATM.

Oh, my mistake sorry - I must have copied it into my to apply queue twice so got a reject on the second application.

No worries. Just wanted to make sure.
Thanks !