drm/amdgpu/vi: fix mixed up state in smu clockgating setup
Subsystems (2)
PATCH 1/1 drm/amdgpu/vi: fix mixed up state in smu clockgating setup
Use the PP_STATE_SUPPORT_* rather than AMD_CG_SUPPORT_* when communicating with the SMU.
Signed-off-by Alex Deucher <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/vi.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/amd/amdgpu/vi.c +6 -6
@@ -1363,11 +1363,11 @@ static int vi_common_set_clockgating_state_by_smu(void *handle,if (adev->cg_flags & (AMD_CG_SUPPORT_MC_LS |AMD_CG_SUPPORT_MC_MGCG )) {if (adev->cg_flags &AMD_CG_SUPPORT_MC_LS ) { - pp_support_state =AMD_CG_SUPPORT_MC_LS ; + pp_support_state =PP_STATE_SUPPORT_LS ; pp_state =PP_STATE_LS ; }if (adev->cg_flags &AMD_CG_SUPPORT_MC_MGCG ) { - pp_support_state |=AMD_CG_SUPPORT_MC_MGCG ; + pp_support_state |=PP_STATE_SUPPORT_CG ; pp_state |=PP_STATE_CG ; }if (state ==AMD_CG_STATE_UNGATE )
@@ -1382,11 +1382,11 @@ static int vi_common_set_clockgating_state_by_smu(void *handle,if (adev->cg_flags & (AMD_CG_SUPPORT_SDMA_LS |AMD_CG_SUPPORT_SDMA_MGCG )) {if (adev->cg_flags &AMD_CG_SUPPORT_SDMA_LS ) { - pp_support_state =AMD_CG_SUPPORT_SDMA_LS ; + pp_support_state =PP_STATE_SUPPORT_LS ; pp_state =PP_STATE_LS ; }if (adev->cg_flags &AMD_CG_SUPPORT_SDMA_MGCG ) { - pp_support_state |=AMD_CG_SUPPORT_SDMA_MGCG ; + pp_support_state |=PP_STATE_SUPPORT_CG ; pp_state |=PP_STATE_CG ; }if (state ==AMD_CG_STATE_UNGATE )
@@ -1401,11 +1401,11 @@ static int vi_common_set_clockgating_state_by_smu(void *handle,if (adev->cg_flags & (AMD_CG_SUPPORT_HDP_LS |AMD_CG_SUPPORT_HDP_MGCG )) {if (adev->cg_flags &AMD_CG_SUPPORT_HDP_LS ) { - pp_support_state =AMD_CG_SUPPORT_HDP_LS ; + pp_support_state =PP_STATE_SUPPORT_LS ; pp_state =PP_STATE_LS ; }if (adev->cg_flags &AMD_CG_SUPPORT_HDP_MGCG ) { - pp_support_state |=AMD_CG_SUPPORT_HDP_MGCG ; + pp_support_state |=PP_STATE_SUPPORT_CG ; pp_state |=PP_STATE_CG ; }if (state ==AMD_CG_STATE_UNGATE )
Signature · 6 lines
2.13.6 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 20180710215339.20378-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org
Huang Rui
Reviewed-byQuoted 4 lines · Alex Deucher
Use the PP_STATE_SUPPORT_* rather than AMD_CG_SUPPORT_* when communicating with the SMU.
Signed-off-by Alex Deucher <[email protected]>
Reviewed-by Huang Rui <[email protected]>
Quoted 57 lines
--- drivers/gpu/drm/amd/amdgpu/vi.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)drivers/gpu/drm/amd/amdgpu/vi.c +6
-6@@ -1363,11 +1363,11 @@ static int vi_common_set_clockgating_state_by_smu(void *handle,if (adev->cg_flags & (AMD_CG_SUPPORT_MC_LS |AMD_CG_SUPPORT_MC_MGCG )) {if (adev->cg_flags &AMD_CG_SUPPORT_MC_LS ) { - pp_support_state =AMD_CG_SUPPORT_MC_LS ; + pp_support_state =PP_STATE_SUPPORT_LS ; pp_state =PP_STATE_LS ; }if (adev->cg_flags &AMD_CG_SUPPORT_MC_MGCG ) { - pp_support_state |=AMD_CG_SUPPORT_MC_MGCG ; + pp_support_state |=PP_STATE_SUPPORT_CG ; pp_state |=PP_STATE_CG ; }if (state ==AMD_CG_STATE_UNGATE )@@ -1382,11 +1382,11 @@ static int vi_common_set_clockgating_state_by_smu(void *handle,if (adev->cg_flags & (AMD_CG_SUPPORT_SDMA_LS |AMD_CG_SUPPORT_SDMA_MGCG )) {if (adev->cg_flags &AMD_CG_SUPPORT_SDMA_LS ) { - pp_support_state =AMD_CG_SUPPORT_SDMA_LS ; + pp_support_state =PP_STATE_SUPPORT_LS ; pp_state =PP_STATE_LS ; }if (adev->cg_flags &AMD_CG_SUPPORT_SDMA_MGCG ) { - pp_support_state |=AMD_CG_SUPPORT_SDMA_MGCG ; + pp_support_state |=PP_STATE_SUPPORT_CG ; pp_state |=PP_STATE_CG ; }if (state ==AMD_CG_STATE_UNGATE )@@ -1401,11 +1401,11 @@ static int vi_common_set_clockgating_state_by_smu(void *handle,if (adev->cg_flags & (AMD_CG_SUPPORT_HDP_LS |AMD_CG_SUPPORT_HDP_MGCG )) {if (adev->cg_flags &AMD_CG_SUPPORT_HDP_LS ) { - pp_support_state =AMD_CG_SUPPORT_HDP_LS ; + pp_support_state =PP_STATE_SUPPORT_LS ; pp_state =PP_STATE_LS ; }if (adev->cg_flags &AMD_CG_SUPPORT_HDP_MGCG ) { - pp_support_state |=AMD_CG_SUPPORT_HDP_MGCG ; + pp_support_state |=PP_STATE_SUPPORT_CG ; pp_state |=PP_STATE_CG ; }if (state ==AMD_CG_STATE_UNGATE )Signature · 6 lines
2.13.6 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx