net: ethernet: freescale: Use generic CRC32 implementation
Subsystems (3)
PATCH 1/1 net: ethernet: freescale: Use generic CRC32 implementation
Use generic kernel CRC32 implementation because it:
1. Should be faster (uses lookup tables),
2. Removes duplicated CRC generation code,
3. Uses well-proven algorithm instead of coding it one more time.
Suggested-by Eric Biggers <[email protected]>
Signed-off-by Krzysztof Kozlowski <[email protected]>
--- drivers/net/ethernet/freescale/fec_main.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)
drivers/net/ethernet/freescale/fec_main.c +2 -10
@@ -2955,7 +2955,7 @@ static void set_multicast_list(struct net_device *ndev) {struct fec_enet_private *fep =netdev_priv (ndev);struct netdev_hw_addr *ha; -unsigned int i, bit, data, crc, tmp; +unsigned int crc, tmp;unsigned char hash;unsigned int hash_high =0 , hash_low =0 ;
@@ -2983,15 +2983,7 @@ static void set_multicast_list(struct net_device *ndev)/* Add the addresses in hash register */ netdev_for_each_mc_addr (ha, ndev) {/* calculate crc32 value of mac address */ - crc =0xffffffff ; - -for (i =0 ; i < ndev->addr_len; i++) { - data = ha->addr[i]; -for (bit =0 ; bit <8 ; bit++, data >>=1 ) { - crc = (crc >>1 ) ^ - (((crc ^ data) &1 ) ?CRC32_POLY :0 ); - } - } + crc =crc32_le (~0 , ha->addr, ndev->addr_len);/* only upper 6 bits (FEC_HASH_BITS) are used * which point to specific bit in the hash registers
Signature · 1 line
2.14.1