target/core: Reduce the amount of code executed with a spinlock held
PATCH 12/17 target/core: Reduce the amount of code executed with a spinlock held
Due to the "make ABORT and LUN RESET handling synchronous" patch, cmd->work is only modified from the regular command execution path and no longer asynchronously by the code that executes task management functions. Since the regular command execution code is sequential per command, no locking is required to manipulate cmd->work. Hence stop protecting cmd->work manipulations with locking.
Signed-off-by Bart Van Assche <[email protected]>
Cc Nicholas Bellinger <[email protected]>
Cc Mike Christie <[email protected]>
Cc Christoph Hellwig <[email protected]>
Cc Hannes Reinecke <[email protected]>
--- drivers/target/target_core_transport.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/target/target_core_transport.c +3 -6
@@ -844,16 +844,13 @@ void target_complete_cmd(struct se_cmd *cmd, u8 scsi_status)break ; } -if (!success) { -INIT_WORK (&cmd->work, target_complete_failure_work); - }else { -INIT_WORK (&cmd->work, target_complete_ok_work); - } - cmd->t_state =TRANSPORT_COMPLETE ; cmd->transport_state |= (CMD_T_COMPLETE |CMD_T_ACTIVE );spin_unlock_irqrestore (&cmd->t_state_lock, flags); +INIT_WORK (&cmd->work, success ? target_complete_ok_work : + target_complete_failure_work); + queue_work:if (cmd->se_cmd_flags &SCF_USE_CPUID )queue_work_on (cmd->cpuid, target_completion_wq, &cmd->work);
Signature · 1 line
2.18.0