Skip to contentSkip to conversation

f2fs: avoid infinite loop in f2fs_alloc_nid

PATCH In review Jaegeuk Kim 2 participants 2 messages Sep 19, 2018 – Sep 20, 2018 F2FS file system

lore
Share & tools
lore

Jaegeuk Kim

author maintainer
#0 lore raw

PATCH 1/1 f2fs: avoid infinite loop in f2fs_alloc_nid

If we have an error in f2fs_build_free_nids, we're able to fall into a loop to find free nids.

---
 fs/f2fs/node.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
fs/f2fs/node.c +3 -2
index 79b6fee354f7..e24f8acbea82 100644
@@ -2356,8 +2356,9 @@ bool f2fs_alloc_nid(struct f2fs_sb_info *sbi, nid_t *nid)
 	spin_unlock(&nm_i->nid_list_lock);
 
 	/* Let's scan nat pages and its caches to get free nids */
-	f2fs_build_free_nids(sbi, true, false);
-	goto retry;
+	if (!f2fs_build_free_nids(sbi, true, false))
+		goto retry;
+	return false;
 }
 
 /*
Signature · 1 line
2.17.0.441.gb46fe60e1d-goog