f2fs: avoid infinite loop in f2fs_alloc_nid
Jaegeuk Kim
maintainerPATCH 1/1 f2fs: avoid infinite loop in f2fs_alloc_nid
If we have an error in f2fs_build_free_nids, we're able to fall into a loop to find free nids.
Suggested-by Chao Yu <[email protected]>
Signed-off-by Jaegeuk Kim <[email protected]>
--- fs/f2fs/node.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
fs/f2fs/node.c +3 -2
@@ -2356,8 +2356,9 @@ bool f2fs_alloc_nid(struct f2fs_sb_info *sbi, nid_t *nid)spin_unlock (&nm_i->nid_list_lock);/* Let's scan nat pages and its caches to get free nids */ -f2fs_build_free_nids (sbi, true, false); - goto retry; +if (!f2fs_build_free_nids (sbi, true, false)) + goto retry; +return false; }/*
Signature · 1 line
2.17.0.441.gb46fe60e1d-goog
Quoted 5 lines · Jaegeuk Kim
If we have an error in
f2fs_build_free_nids, we're able to fall into a loop to find free nids.Suggested-by Chao Yu <[email protected]>Signed-off-by Jaegeuk Kim <[email protected]>
Reviewed-by Chao Yu <[email protected]>
Thanks,