drm/etnaviv: Replace drm_dev_unref with drm_dev_put
Subsystems (2)
PATCH RESEND 1/1 drm/etnaviv: Replace drm_dev_unref with drm_dev_put
This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces.
--- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/etnaviv/etnaviv_drv.c +4 -4
@@ -523,7 +523,7 @@ static int etnaviv_bind(struct device *dev)if (!priv) {dev_err (dev,"failed to allocate private data\n" ); ret = -ENOMEM ; - goto out_unref; + goto out_put; } drm->dev_private = priv;
@@ -549,8 +549,8 @@ static int etnaviv_bind(struct device *dev)component_unbind_all (dev, drm); out_bind:kfree (priv); -out_unref: -drm_dev_unref (drm); +out_put: +drm_dev_put (drm);return ret; }
@@ -567,7 +567,7 @@ static void etnaviv_unbind(struct device *dev) drm->dev_private =NULL ;kfree (priv); -drm_dev_unref (drm); +drm_dev_put (drm); }static const struct component_master_ops etnaviv_master_ops = {
--
2.19.0
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Lucas Stach
maintainerAm Mittwoch, den 26.09.2018, 13:41 +0200 schrieb Thomas Zimmermann:
Quoted 5 lines
This patch unifies the naming of DRM functions for reference counting of struct
drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces.Signed-off-by Thomas Zimmermann <[email protected]>
Thanks, now applied after slipping through the cracks a second time.
Regards,
Lucas
Quoted 36 lines
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 8 ++++----1 file changed, 4 insertions(+), 4 deletions(-)drivers/gpu/drm/etnaviv/etnaviv_drv.c +0
-0@@ -523,7 +523,7 @@ static int etnaviv_bind(struct device *dev) > if (!priv) { > dev_err(dev, "failed to allocate private data\n"); > ret = -ENOMEM; > - goto out_unref; > + goto out_put; > } > drm->dev_private = priv;@@ -549,8 +549,8 @@ static int etnaviv_bind(struct device *dev) > component_unbind_all(dev, drm);out_bind:
Quoted 1 line
kfree(priv);
-out_unref:
Review
Quoted 1 line
(quoted diff) +0
-1- drm_dev_unref(drm);+out_put:
Quoted 3 lines
(quoted diff) +1
-0+ drm_dev_put(drm);return ret;
}
drivers/gpu/drm/etnaviv/etnaviv_drv.c +0
-0@@ -567,7 +567,7 @@ static void etnaviv_unbind(struct device *dev) > drm->dev_private = NULL; > kfree(priv); > - drm_dev_unref(drm); > + drm_dev_put(drm); }
Quoted 4 lines
static const struct
component_master_opsetnaviv_master_ops= { --
2.19.0
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Am 07.11.18 um 17:37 schrieb Lucas Stach:
Quoted 8 lines
Am Mittwoch, den 26.09.2018, 13:41 +0200 schrieb Thomas Zimmermann:
Quoted 5 lines
This patch unifies the naming of DRM functions for reference counting of struct
drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces.Signed-off-by Thomas Zimmermann <[email protected]>Thanks, now applied after slipping through the cracks a second time.
Great, thanks a lot.
Quoted 44 lines
Regards,
LucasQuoted 40 lines
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 8 ++++----1 file changed, 4 insertions(+), 4 deletions(-)drivers/gpu/drm/etnaviv/etnaviv_drv.c +0
-0@@ -523,7 +523,7 @@ static int etnaviv_bind(struct device *dev) > if (!priv) { > dev_err(dev, "failed to allocate private data\n"); > ret = -ENOMEM; > - goto out_unref; > + goto out_put; > } > drm->dev_private = priv;@@ -549,8 +549,8 @@ static int etnaviv_bind(struct device *dev) > component_unbind_all(dev, drm);out_bind:
Quoted 1 line
kfree(priv);
-out_unref:
Review
Quoted 1 line
(quoted diff) +0
-1- drm_dev_unref(drm);+out_put:
Quoted 3 lines
(quoted diff) +1
-0+ drm_dev_put(drm);return ret;
}
drivers/gpu/drm/etnaviv/etnaviv_drv.c +0
-0@@ -567,7 +567,7 @@ static void etnaviv_unbind(struct device *dev) > drm->dev_private = NULL; > kfree(priv); > - drm_dev_unref(drm); > + drm_dev_put(drm); }static const struct
component_master_opsetnaviv_master_ops= { --
2.19.0
Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nürnberg Tel: +49-911-74053-0; Fax: +49-911-7417755; https://www.suse.com/ SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel