Skip to contentSkip to conversation

drm/tve200: Replace drm_dev_unref with drm_dev_put

PATCH RESEND Superseded Thomas Zimmermann 2 participants 3 messages Sep 26, 2018

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Thomas Zimmermann

author maintainer
#0 lore raw

PATCH RESEND 1/1 drm/tve200: Replace drm_dev_unref with drm_dev_put

This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces.

---
 drivers/gpu/drm/tve200/tve200_drv.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/gpu/drm/tve200/tve200_drv.c +5 -5
index 72efcecb44f7..90f24b5a95b3 100644
@@ -191,12 +191,12 @@ static int tve200_probe(struct platform_device *pdev)
 	if (IS_ERR(priv->pclk)) {
 		dev_err(dev, "unable to get PCLK\n");
 		ret = PTR_ERR(priv->pclk);
-		goto dev_unref;
+		goto dev_put;
 	}
 	ret = clk_prepare_enable(priv->pclk);
 	if (ret) {
 		dev_err(dev, "failed to enable PCLK\n");
-		goto dev_unref;
+		goto dev_put;
 	}
 
 	/* This clock is for the pixels (27MHz) */
@@ -248,8 +248,8 @@ static int tve200_probe(struct platform_device *pdev)
 
 clk_disable:
 	clk_disable_unprepare(priv->pclk);
-dev_unref:
-	drm_dev_unref(drm);
+dev_put:
+	drm_dev_put(drm);
 	return ret;
 }
 
@@ -263,7 +263,7 @@ static int tve200_remove(struct platform_device *pdev)
 		drm_panel_bridge_remove(priv->bridge);
 	drm_mode_config_cleanup(drm);
 	clk_disable_unprepare(priv->pclk);
-	drm_dev_unref(drm);
+	drm_dev_put(drm);
 
 	return 0;
 }

--
2.19.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#1 lore raw
Quoted 6 lines · Thomas Zimmermann

This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces.

Since you are resending it, do you need help to have it applied?

Yours,
Linus Walleij
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author maintainer
#2 lore raw

Hi

Am 26.09.18 um 14:14 schrieb Linus Walleij:

Quoted 10 lines · Thomas Zimmermann
Quoted 7 lines

This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces.

Since you are resending it, do you need help to have it applied?

Yes. Could you please help with merging the patch? Thanks.

Best regards
Thomas

Quoted 3 lines

Yours,
Linus Walleij

Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nürnberg
Tel: +49-911-74053-0; Fax: +49-911-7417755;  https://www.suse.com/
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard,
Graham Norton, HRB 21284 (AG Nürnberg)

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel