Skip to contentSkip to conversation

i2c: brcmstb: Allow enabling the driver on DSL SoCs

PATCH Superseded Florian Fainelli 2 participants 3 messages Sep 28, 2018 – Sep 29, 2018 I2C subsystem host drivers

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Florian Fainelli

author
#0 lore raw

PATCH 1/1 i2c: brcmstb: Allow enabling the driver on DSL SoCs

ARCH_BCM_63XX which is used by ARM-based DSL SoCs from Broadcom uses the same controller, make it possible to select the STB driver and update the Kconfig and help text a bit.

Signed-off-by Florian Fainelli <[email protected]>
---
 drivers/i2c/busses/Kconfig | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/i2c/busses/Kconfig +4 -3
index 451d4ae50e66..fc3fd987f718 100644
@@ -432,12 +432,13 @@ config I2C_BCM_KONA
 	  If you do not need KONA I2C interface, say N.
 
 config I2C_BRCMSTB
-	tristate "BRCM Settop I2C controller"
-	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
+	tristate "BRCM Settop/DSL I2C controller"
+	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST || \
+		   ARCH_BCM_63XX
 	default y
 	help
 	  If you say yes to this option, support will be included for the
-	  I2C interface on the Broadcom Settop SoCs.
+	  I2C interface on the Broadcom Settop/DSL SoCs.
 
 	  If you do not need I2C interface, say N.
Signature · 1 line
2.17.1
#1 lore raw

Hi Florian,

Quoted 5 lines · Florian Fainelli

ARCH_BCM_63XX which is used by ARM-based DSL SoCs from Broadcom uses the same controller, make it possible to select the STB driver and update the Kconfig and help text a bit.

Signed-off-by Florian Fainelli <[email protected]>

Thanks for your patch!

drivers/i2c/busses/Kconfig config I2C_BCM_KONA · line 437

Quoted 11 lines
drivers/i2c/busses/Kconfig +3 -2
@@ -432,12 +432,13 @@ config I2C_BCM_KONA
          If you do not need KONA I2C interface, say N.
 
 config I2C_BRCMSTB
-       tristate "BRCM Settop I2C controller"
-       depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
+       tristate "BRCM Settop/DSL I2C controller"
+       depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST || \
+                  ARCH_BCM_63XX

I think it would be good to keep the "|| COMPILE_TEST" as the last dependency.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
author
#2 lore raw
Quoted 18 lines · Geert Uytterhoeven

Hi Florian,

Quoted 1 line · Florian Fainelli

ARCH_BCM_63XX which is used by ARM-based DSL SoCs from Broadcom uses

the

Quoted 4 lines

same controller, make it possible to select the STB driver and update the Kconfig and help text a bit.

Signed-off-by Florian Fainelli <[email protected]>

Thanks for your patch!

Quoted 5 lines
drivers/i2c/busses/Kconfig +0 -0
@@ -432,12 +432,13 @@ config I2C_BCM_KONA
          If you do not need KONA I2C interface, say N.
Quoted 9 lines

drivers/i2c/busses/Kconfig config I2C_BCM_KONA · line 437

Quoted 6 lines
drivers/i2c/busses/Kconfig +3 -2
 config I2C_BRCMSTB
-       tristate "BRCM Settop I2C controller"
-       depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
+       tristate "BRCM Settop/DSL I2C controller"
+       depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST || \
+                  ARCH_BCM_63XX

I think it would be good to keep the "|| COMPILE_TEST" as the last dependency.

Makes sense, v2 coming, thank you!

Signature · 1 line
Florian