Skip to contentSkip to conversation

i2c: brcmstb: Allow enabling the driver on DSL SoCs

PATCH Applied Florian Fainelli 4 participants 5 messages Oct 1, 2018 – Oct 5, 2018 I2C subsystem host drivers

lore
Share & tools
lore

Florian Fainelli

author
#0 lore raw

PATCH v2 1/1 i2c: brcmstb: Allow enabling the driver on DSL SoCs

ARCH_BCM_63XX which is used by ARM-based DSL SoCs from Broadcom uses the same controller, make it possible to select the STB driver and update the Kconfig and help text a bit.

Signed-off-by Florian Fainelli <[email protected]>

---
Changes in v2:

- Make COMPILE_TEST last, as per Geert's recommendation

 drivers/i2c/busses/Kconfig | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/i2c/busses/Kconfig +4 -3
index 451d4ae50e66..56ccb1ea7da5 100644
@@ -432,12 +432,13 @@ config I2C_BCM_KONA
 	  If you do not need KONA I2C interface, say N.
 
 config I2C_BRCMSTB
-	tristate "BRCM Settop I2C controller"
-	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
+	tristate "BRCM Settop/DSL I2C controller"
+	depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_63XX || \
+		   COMPILE_TEST
 	default y
 	help
 	  If you say yes to this option, support will be included for the
-	  I2C interface on the Broadcom Settop SoCs.
+	  I2C interface on the Broadcom Settop/DSL SoCs.
 
 	  If you do not need I2C interface, say N.
Signature · 1 line
2.17.1
#1 lore raw
Quoted 19 lines · Florian Fainelli

ARCH_BCM_63XX which is used by ARM-based DSL SoCs from Broadcom uses the same controller, make it possible to select the STB driver and update the Kconfig and help text a bit.

Signed-off-by Florian Fainelli <[email protected]>

---
Changes in v2:

- Make COMPILE_TEST last, as per Geert's recommendation

 drivers/i2c/busses/Kconfig | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/i2c/busses/Kconfig +0 -0
index 451d4ae50e66..56ccb1ea7da5 100644

drivers/i2c/busses/Kconfig config I2C_BCM_KONA · line 437

Quoted 8 lines
drivers/i2c/busses/Kconfig +3 -2
@@ -432,12 +432,13 @@ config I2C_BCM_KONA
          If you do not need KONA I2C interface, say N.
 
 config I2C_BRCMSTB
-       tristate "BRCM Settop I2C controller"
-       depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
+       tristate "BRCM Settop/DSL I2C controller"
+       depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_63XX || \
+                  COMPILE_TEST

I would rather split this to two 'depends' entries, though it's cosmetic and up to you.

Quoted 11 lines
drivers/i2c/busses/Kconfig +1 -2
        default y
        help
          If you say yes to this option, support will be included for the
-         I2C interface on the Broadcom Settop SoCs.
+         I2C interface on the Broadcom Settop/DSL SoCs.
 
          If you do not need I2C interface, say N.
 
--

2.17.1

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
Quoted 11 lines · Andy Shevchenko

drivers/i2c/busses/Kconfig config I2C_BCM_KONA · line 437

Quoted 7 lines · Florian Fainelli

config I2C_BRCMSTB

drivers/i2c/busses/Kconfig +3 -2
-       tristate "BRCM Settop I2C controller"
-       depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
+       tristate "BRCM Settop/DSL I2C controller"
+       depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_63XX || \
+                  COMPILE_TEST

I would rather split this to two 'depends' entries, though it's cosmetic and up to you.

You can only split 'depends on A && B' into multiple lines, not 'depends on A || B'.

Arnd

#3 lore raw
Quoted 12 lines · Arnd Bergmann
Quoted 9 lines · Andy Shevchenko
Quoted 7 lines · Florian Fainelli

config I2C_BRCMSTB

drivers/i2c/busses/Kconfig +3 -2
-       tristate "BRCM Settop I2C controller"
-       depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
+       tristate "BRCM Settop/DSL I2C controller"
+       depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_63XX || \
+                  COMPILE_TEST
Quoted 5 lines
Quoted 2 lines

I would rather split this to two 'depends' entries, though it's cosmetic and up to you.

You can only split 'depends on A && B' into multiple lines, not 'depends on A || B'.

Indeed. What I was thinking of?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
Applied
#4 lore raw
In reply to Florian Fainelli
Quoted 10 lines · Florian Fainelli

ARCH_BCM_63XX which is used by ARM-based DSL SoCs from Broadcom uses the same controller, make it possible to select the STB driver and update the Kconfig and help text a bit.

Signed-off-by Florian Fainelli <[email protected]>

---
Changes in v2:

- Make COMPILE_TEST last, as per Geert's recommendation

Applied to for-next, thanks!