Skip to contentSkip to conversation

riscv: dts: Add ae350_32.dts for 32 bit

PATCH New Andes 3 participants 5 messages Oct 8, 2018 – Oct 25, 2018 RISC-V

lore
Share & tools
lore

Andes

author
#0 lore raw

PATCH 2/2 riscv: dts: Add ae350_32.dts for 32 bit

From: Rick Chen <[email protected]>

Add ae350_32.dts for 32 bit. And also rename
ae350.dts to ae350_64.dts for 64 bit.

Cc Greentime Hu <[email protected]>
---
 arch/riscv/dts/ae350.dts    | 229 --------------------------------------------
 arch/riscv/dts/ae350_32.dts | 229 ++++++++++++++++++++++++++++++++++++++++++++
 arch/riscv/dts/ae350_64.dts | 229 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 458 insertions(+), 229 deletions(-)
 delete mode 100644 arch/riscv/dts/ae350.dts
 create mode 100644 arch/riscv/dts/ae350_32.dts
 create mode 100644 arch/riscv/dts/ae350_64.dts
arch/riscv/dts/ae350.dts deleted +0 -229
deleted file mode 100644
index e48c298..0000000
@@ -1,229 +0,0 @@
-/dts-v1/;
-
-/ {
-	#address-cells = <2>;
-	#size-cells = <2>;
-	compatible = "andestech,ax25";
-	model = "andestech,ax25";
-
-	aliases {
-		uart0 = &serial0;
-		spi0 = &spi;
-	};
-
-	chosen {
-		bootargs = "console=ttyS0,38400n8  debug loglevel=7";
-		stdout-path = "uart0:38400n8";
-	};
-
-	cpus {
-		#address-cells = <1>;
-		#size-cells = <0>;
-		timebase-frequency = <60000000>;
-		CPU0: cpu at 0 {
-			device_type = "cpu";
-			reg = <0>;
-			status = "okay";
-			compatible = "riscv";
-			riscv,isa = "rv64imafdc";
-			mmu-type = "riscv,sv39";
-			clock-frequency = <60000000>;
-			d-cache-size = <0x8000>;
-			d-cache-line-size = <32>;
-			CPU0_intc: interrupt-controller {
-				#interrupt-cells = <1>;
-				interrupt-controller;
-				compatible = "riscv,cpu-intc";
-			};
-		};
-	};
-
-	memory at 0 {
-		device_type = "memory";
-		reg = <0x0 0x00000000 0x0 0x40000000>;
-	};
-
-	soc {
-		#address-cells = <2>;
-		#size-cells = <2>;
-		compatible = "andestech,riscv-ae350-soc";
-		ranges;
-
-	plic0: interrupt-controller at e4000000 {
-		compatible = "riscv,plic0";
-		#address-cells = <2>;
-		#interrupt-cells = <2>;
-		interrupt-controller;
-		reg = <0x0 0xe4000000 0x0 0x2000000>;
-		riscv,ndev=<71>;
-		interrupts-extended = <&CPU0_intc 11 &CPU0_intc 9>;
-	};
-
-	plic1: interrupt-controller at e6400000 {
-		compatible = "riscv,plic1";
-		#address-cells = <2>;
-		#interrupt-cells = <2>;
-		interrupt-controller;
-		reg = <0x0 0xe6400000 0x0 0x400000>;
-		riscv,ndev=<1>;
-		interrupts-extended = <&CPU0_intc 3>;
-	};
-
-	plmt0 at e6000000 {
-		compatible = "riscv,plmt0";
-			interrupts-extended = <&CPU0_intc 7>;
-			reg = <0x0 0xe6000000 0x0 0x100000>;
-		};
-	};
-
-	spiclk: virt_100mhz {
-		#clock-cells = <0>;
-		compatible = "fixed-clock";
-		clock-frequency = <100000000>;
-	};
-
-	timer0: timer at f0400000 {
-		compatible = "andestech,atcpit100";
-		reg = <0x0 0xf0400000 0x0 0x1000>;
-		clock-frequency = <60000000>;
-		interrupts = <3 4>;
-		interrupt-parent = <&plic0>;
-	};
-
-	serial0: serial at f0300000 {
-		compatible = "andestech,uart16550", "ns16550a";
-		reg = <0x0 0xf0300000 0x0 0x1000>;
-		interrupts = <9 4>;
-		clock-frequency = <19660800>;
-		reg-shift = <2>;
-		reg-offset = <32>;
-		no-loopback-test = <1>;
-		interrupt-parent = <&plic0>;
-	};
-
-	mac0: mac at e0100000 {
-		compatible = "andestech,atmac100";
-		reg = <0x0 0xe0100000 0x0 0x1000>;
-		interrupts = <19 4>;
-		interrupt-parent = <&plic0>;
-	};
-
-	mmc0: mmc at f0e00000 {
-		compatible = "andestech,atfsdc010";
-		max-frequency = <100000000>;
-		clock-freq-min-max = <400000 100000000>;
-		fifo-depth = <0x10>;
-		reg = <0x0 0xf0e00000 0x0 0x1000>;
-		interrupts = <18 4>;
-		cap-sd-highspeed;
-		interrupt-parent = <&plic0>;
-	};
-
-	dma0: dma at f0c00000 {
-		compatible = "andestech,atcdmac300";
-		reg = <0x0 0xf0c00000 0x0 0x1000>;
-		interrupts = <10 4 64 4 65 4 66 4 67 4 68 4 69 4 70 4 71 4>;
-		dma-channels = <8>;
-		interrupt-parent = <&plic0>;
-	};
-
-	lcd0: lcd at e0200000 {
-		compatible = "andestech,atflcdc100";
-		reg = <0x0 0xe0200000 0x0 0x1000>;
-		interrupts = <20 4>;
-		interrupt-parent = <&plic0>;
-	};
-
-	smc0: smc at e0400000 {
-		compatible = "andestech,atfsmc020";
-		reg = <0x0 0xe0400000 0x0 0x1000>;
-	};
-
-	snd0: snd at f0d00000 {
-		compatible = "andestech,atfac97";
-		reg = <0x0 0xf0d00000 0x0 0x1000>;
-		interrupts = <17 4>;
-		interrupt-parent = <&plic0>;
-	};
-
-	virtio_mmio at fe007000 {
-		interrupts = <0x17 0x4>;
-		interrupt-parent = <0x2>;
-		reg = <0x0 0xfe007000 0x0 0x1000>;
-		compatible = "virtio,mmio";
-	};
-
-	virtio_mmio at fe006000 {
-		interrupts = <0x16 0x4>;
-		interrupt-parent = <0x2>;
-		reg = <0x0 0xfe006000 0x0 0x1000>;
-		compatible = "virtio,mmio";
-	};
-
-	virtio_mmio at fe005000 {
-		interrupts = <0x15 0x4>;
-		interrupt-parent = <0x2>;
-		reg = <0x0 0xfe005000 0x0 0x1000>;
-		compatible = "virtio,mmio";
-	};
-
-	virtio_mmio at fe004000 {
-		interrupts = <0x14 0x4>;
-		interrupt-parent = <0x2>;
-		reg = <0x0 0xfe004000 0x0 0x1000>;
-		compatible = "virtio,mmio";
-	};
-
-	virtio_mmio at fe003000 {
-		interrupts = <0x13 0x4>;
-		interrupt-parent = <0x2>;
-		reg = <0x0 0xfe003000 0x0 0x1000>;
-		compatible = "virtio,mmio";
-	};
-
-	virtio_mmio at fe002000 {
-		interrupts = <0x12 0x4>;
-		interrupt-parent = <0x2>;
-		reg = <0x0 0xfe002000 0x0 0x1000>;
-		compatible = "virtio,mmio";
-	};
-
-	virtio_mmio at fe001000 {
-		interrupts = <0x11 0x4>;
-		interrupt-parent = <0x2>;
-		reg = <0x0 0xfe001000 0x0 0x1000>;
-		compatible = "virtio,mmio";
-	};
-
-	virtio_mmio at fe000000 {
-		interrupts = <0x10 0x4>;
-		interrupt-parent = <0x2>;
-		reg = <0x0 0xfe000000 0x0 0x1000>;
-		compatible = "virtio,mmio";
-	};
-
-	nor at 0,0 {
-		compatible = "cfi-flash";
-		reg = <0x0 0x88000000 0x0 0x1000>;
-		bank-width = <2>;
-		device-width = <1>;
-	};
-
-	spi: spi at f0b00000 {
-		compatible = "andestech,atcspi200";
-		reg = <0x0 0xf0b00000 0x0 0x1000>;
-		#address-cells = <1>;
-		#size-cells = <0>;
-		num-cs = <1>;
-		clocks = <&spiclk>;
-		interrupts = <4 4>;
-		interrupt-parent = <&plic0>;
-		flash at 0 {
-			compatible = "spi-flash";
-			spi-max-frequency = <50000000>;
-			reg = <0>;
-			spi-cpol;
-			spi-cpha;
-		};
-	};
-};
arch/riscv/dts/ae350_32.dts new file +229 -0

229 lines not on this page · raw message

arch/riscv/dts/ae350_64.dts new file +229 -0

229 lines not on this page · raw message

Signature · 1 line
2.7.4
#1 lore raw

PATCH 2/2 riscv: dts: Add ae350_32.dts for 32 bit

Hi Rick,

Quoted 8 lines · Andes

From: Rick Chen <[email protected]>

Add ae350_32.dts for 32 bit. And also rename
ae350.dts to ae350_64.dts for 64 bit.

Cc Greentime Hu <[email protected]>
Quoted 9 lines
---
 arch/riscv/dts/ae350.dts    | 229 --------------------------------------------
 arch/riscv/dts/ae350_32.dts | 229 ++++++++++++++++++++++++++++++++++++++++++++
 arch/riscv/dts/ae350_64.dts | 229 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 458 insertions(+), 229 deletions(-)
 delete mode 100644 arch/riscv/dts/ae350.dts
 create mode 100644 arch/riscv/dts/ae350_32.dts
 create mode 100644 arch/riscv/dts/ae350_64.dts

It looks to me that the only difference between these two dts files are the cpu node (rv32 vs rv64). Can we please put the common part into a dtsi file and let the main dts file include the dtsi file and override anything if needed?

Regards,
Bin

#2 lore raw

PATCH 2/2 riscv: dts: Add ae350_32.dts for 32 bit

Bin Meng <[email protected]> 於 2018年10月8日 週一 下午11:48寫道:

Quoted 22 lines

Hi Rick,

Quoted 8 lines · Andes

From: Rick Chen <[email protected]>

Add ae350_32.dts for 32 bit. And also rename
ae350.dts to ae350_64.dts for 64 bit.

Cc Greentime Hu <[email protected]>
Quoted 9 lines
---
 arch/riscv/dts/ae350.dts    | 229 --------------------------------------------
 arch/riscv/dts/ae350_32.dts | 229 ++++++++++++++++++++++++++++++++++++++++++++
 arch/riscv/dts/ae350_64.dts | 229 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 458 insertions(+), 229 deletions(-)
 delete mode 100644 arch/riscv/dts/ae350.dts
 create mode 100644 arch/riscv/dts/ae350_32.dts
 create mode 100644 arch/riscv/dts/ae350_64.dts
Quoted 5 lines

It looks to me that the only difference between these two dts files are the cpu node (rv32 vs rv64). Can we please put the common part into a dtsi file and let the main dts file include the dtsi file and override anything if needed?

Hi Bin

I will separate the common into a dtsi file. And others into dts file.

Thanks

Rick

Quoted 2 lines

Regards,
Bin

#3 lore raw

PATCH 2/2 riscv: dts: Add ae350_32.dts for 32 bit

Rick Chen <[email protected]> 於 2018年10月16日 週二 上午10:01寫道:

Quoted 30 lines

Bin Meng <[email protected]> 於 2018年10月8日 週一 下午11:48寫道:

Quoted 22 lines

Hi Rick,

Quoted 8 lines · Andes

From: Rick Chen <[email protected]>

Add ae350_32.dts for 32 bit. And also rename
ae350.dts to ae350_64.dts for 64 bit.

Cc Greentime Hu <[email protected]>
Quoted 9 lines
---
 arch/riscv/dts/ae350.dts    | 229 --------------------------------------------
 arch/riscv/dts/ae350_32.dts | 229 ++++++++++++++++++++++++++++++++++++++++++++
 arch/riscv/dts/ae350_64.dts | 229 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 458 insertions(+), 229 deletions(-)
 delete mode 100644 arch/riscv/dts/ae350.dts
 create mode 100644 arch/riscv/dts/ae350_32.dts
 create mode 100644 arch/riscv/dts/ae350_64.dts
Quoted 5 lines

It looks to me that the only difference between these two dts files are the cpu node (rv32 vs rv64). Can we please put the common part into a dtsi file and let the main dts file include the dtsi file and override anything if needed?

Quoted 4 lines

Hi Bin

I will separate the common into a dtsi file. And others into dts file.

Hi Bin

I am trying to put the common part in a ae350.dtsi from ae350_32.dts and ae350_64.dts.
But i encounter a problem as below :

smc node for 32 bit :

smc0: smc at e0400000 {
compatible = "andestech,atfsmc020";
reg = <0xe0400000 0x1000>;
};

smc node for 64 bit :

smc0: smc at e0400000 {
compatible = "andestech,atfsmc020";
reg = <0x0 0xe0400000 0x0 0x1000>;
};

Though they look like almost the same, but their reg is different. Since can not put in a dtsi file for sharing.

Do you have any idea ?

Rick

Quoted 6 lines

Thanks

Rick

Quoted 2 lines

Regards,
Bin

#4 lore raw

PATCH 2/2 riscv: dts: Add ae350_32.dts for 32 bit

Hi Rick,

Quoted 57 lines · Rick Chen

Rick Chen <[email protected]> 於 2018年10月16日 週二 上午10:01寫道:

Quoted 30 lines

Bin Meng <[email protected]> 於 2018年10月8日 週一 下午11:48寫道:

Quoted 22 lines

Hi Rick,

Quoted 8 lines · Andes

From: Rick Chen <[email protected]>

Add ae350_32.dts for 32 bit. And also rename
ae350.dts to ae350_64.dts for 64 bit.

Cc Greentime Hu <[email protected]>
Quoted 9 lines
---
 arch/riscv/dts/ae350.dts    | 229 --------------------------------------------
 arch/riscv/dts/ae350_32.dts | 229 ++++++++++++++++++++++++++++++++++++++++++++
 arch/riscv/dts/ae350_64.dts | 229 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 458 insertions(+), 229 deletions(-)
 delete mode 100644 arch/riscv/dts/ae350.dts
 create mode 100644 arch/riscv/dts/ae350_32.dts
 create mode 100644 arch/riscv/dts/ae350_64.dts
Quoted 5 lines

It looks to me that the only difference between these two dts files are the cpu node (rv32 vs rv64). Can we please put the common part into a dtsi file and let the main dts file include the dtsi file and override anything if needed?

Quoted 4 lines

Hi Bin

I will separate the common into a dtsi file. And others into dts file.

Hi Bin

I am trying to put the common part in a ae350.dtsi from ae350_32.dts and ae350_64.dts.
But i encounter a problem as below :

smc node for 32 bit :

smc0: smc at e0400000 {
compatible = "andestech,atfsmc020";
reg = <0xe0400000 0x1000>;
};

smc node for 64 bit :

smc0: smc at e0400000 {
compatible = "andestech,atfsmc020";
reg = <0x0 0xe0400000 0x0 0x1000>;
};

Quoted 5 lines

Though they look like almost the same, but their reg is different. Since can not put in a dtsi file for sharing.

Do you have any idea ?

So the register physical address and size are the same and both are below 4GB. In such case, the 64-bit DTS should have the same #address-cells and #size-cells as the 32-bit one.

Regards,
Bin