cpufreq: ia64: Remove unused header files
PATCH 1/1 cpufreq: ia64: Remove unused header files
seq_file.h does not need to be included,so remove it.Moreover deleted a line of meaningless return and move the module declaration to the end. In a function whose return type is void, returning on the last line is not required.
--- drivers/cpufreq/ia64-acpi-cpufreq.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
drivers/cpufreq/ia64-acpi-cpufreq.c +3 -7
@@ -16,7 +16,6 @@#include <linux/init.h> #include <linux/cpufreq.h> #include <linux/proc_fs.h> -#include <linux/seq_file.h> #include <asm/io.h> #include <linux/uaccess.h> #include <asm/pal.h>
@@ -24,11 +23,6 @@#include <linux/acpi.h> #include <acpi/processor.h> -MODULE_AUTHOR ("Venkatesh Pallipadi" ); -MODULE_DESCRIPTION ("ACPI Processor P-States Driver" ); -MODULE_LICENSE ("GPL" ); - -struct cpufreq_acpi_io {struct acpi_processor_performance acpi_data;unsigned int resume;
@@ -348,9 +342,11 @@ acpi_cpufreq_exit (void)pr_debug ("acpi_cpufreq_exit\n" );cpufreq_unregister_driver (&acpi_cpufreq_driver); -return ; } +MODULE_AUTHOR ("Venkatesh Pallipadi" ); +MODULE_DESCRIPTION ("ACPI Processor P-States Driver" ); +MODULE_LICENSE ("GPL" );late_initcall (acpi_cpufreq_init);module_exit (acpi_cpufreq_exit);
Signature · 1 line
2.17.0
Quoted 37 lines · Yangtao Li
seq_file.hdoes not need to be included,so remove it.Moreover deleted a line of meaningless return and move the module declaration to the end. In a function whose return type is void, returning on the last line is not required.Signed-off-by Yangtao Li <[email protected]>--- drivers/cpufreq/ia64-acpi-cpufreq.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)drivers/cpufreq/ia64-acpi-cpufreq.c +0
-6@@ -16,7 +16,6 @@#include <linux/init.h> #include <linux/cpufreq.h> #include <linux/proc_fs.h> -#include <linux/seq_file.h> #include <asm/io.h> #include <linux/uaccess.h> #include <asm/pal.h> @@ -24,11 +23,6 @@#include <linux/acpi.h> #include <acpi/processor.h> -MODULE_AUTHOR ("Venkatesh Pallipadi" ); -MODULE_DESCRIPTION ("ACPI Processor P-States Driver" ); -MODULE_LICENSE ("GPL" ); - -struct cpufreq_acpi_io {struct acpi_processor_performance acpi_data;unsigned int resume;@@ -348,9 +342,11 @@ acpi_cpufreq_exit (void)pr_debug ("acpi_cpufreq_exit\n" );
drivers/cpufreq/ia64-acpi-cpufreq.c acpi_cpufreq_exit (void) · line 352
Quoted 10 lines
drivers/cpufreq/ia64-acpi-cpufreq.c +3
-1cpufreq_unregister_driver (&acpi_cpufreq_driver); -return ; } +MODULE_AUTHOR ("Venkatesh Pallipadi" ); +MODULE_DESCRIPTION ("ACPI Processor P-States Driver" ); +MODULE_LICENSE ("GPL" );late_initcall (acpi_cpufreq_init);module_exit (acpi_cpufreq_exit);
Signature · 1 line
viresh
Viresh Kumar
maintainerQuoted 38 lines · Viresh Kumar
Quoted 37 lines · Yangtao Li
seq_file.hdoes not need to be included,so remove it.Moreover deleted a line of meaningless return and move the module declaration to the end. In a function whose return type is void, returning on the last line is not required.Signed-off-by Yangtao Li <[email protected]>--- drivers/cpufreq/ia64-acpi-cpufreq.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)drivers/cpufreq/ia64-acpi-cpufreq.c +0
-6@@ -16,7 +16,6 @@#include <linux/init.h> #include <linux/cpufreq.h> #include <linux/proc_fs.h> -#include <linux/seq_file.h> #include <asm/io.h> #include <linux/uaccess.h> #include <asm/pal.h> @@ -24,11 +23,6 @@#include <linux/acpi.h> #include <acpi/processor.h> -MODULE_AUTHOR ("Venkatesh Pallipadi" ); -MODULE_DESCRIPTION ("ACPI Processor P-States Driver" ); -MODULE_LICENSE ("GPL" ); - -struct cpufreq_acpi_io {struct acpi_processor_performance acpi_data;unsigned int resume;@@ -348,9 +342,11 @@ acpi_cpufreq_exit (void)pr_debug ("acpi_cpufreq_exit\n" );
Quoted 7 lines
drivers/cpufreq/ia64-acpi-cpufreq.c acpi_cpufreq_exit (void) · line 349
Quoted 7 lines
drivers/cpufreq/ia64-acpi-cpufreq.c +3
-1cpufreq_unregister_driver (&acpi_cpufreq_driver); -return ; } +MODULE_AUTHOR ("Venkatesh Pallipadi" ); +MODULE_DESCRIPTION ("ACPI Processor P-States Driver" ); +MODULE_LICENSE ("GPL" );
Well, why not move this to the end of file completely ?
Quoted 5 lines
drivers/cpufreq/ia64-acpi-cpufreq.c acpi_cpufreq_exit (void) · line 352
Quoted 3 lines
drivers/cpufreq/ia64-acpi-cpufreq.c +0
-0late_initcall (acpi_cpufreq_init);module_exit (acpi_cpufreq_exit);Acked-by Viresh Kumar <[email protected]>
Signature · 1 line
viresh