Skip to contentSkip to conversation

line6: add a check for snd_card_register

PATCH In review Kangjie Lu 2 participants 2 messages Dec 26, 2018 – Jan 1, 2019 Sound

lore
Share & tools
lore

Kangjie Lu

author
#0 lore raw

PATCH 1/1 line6: add a check for snd_card_register

The fix checks if snd_card_register() fails, and if so, issues a warning.

---
 sound/usb/line6/pod.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
sound/usb/line6/pod.c +2 -1
index 020c81818951..da8837bc5a5b 100644
@@ -320,7 +320,8 @@ static void pod_startup4(struct work_struct *work)
 	line6_read_serial_number(&pod->line6, &pod->serial_number);
 
 	/* ALSA audio interface: */
-	snd_card_register(line6->card);
+	if (snd_card_register(line6->card))
+		pr_warn("Failed to register ALSA card.\n");
 }
 
 /* POD special files: */
Signature · 1 line
2.17.2 (Apple Git-113)
#1 lore raw
Quoted 5 lines · Kangjie Lu

The fix checks if snd_card_register() fails, and if so, issues a warning.

Hmm, you submitted multiple patches doing the similar things but the error messages are handled completely differently in both cases. Please make them consistent.

... and above all:

sound/usb/line6/pod.c static void pod_startup4(struct work_struct *work) · line 324

Quoted 3 lines
sound/usb/line6/pod.c +2 -1
-	snd_card_register(line6->card);
+	if (snd_card_register(line6->card))
+		pr_warn("Failed to register ALSA card.\n");

This error message is almost useless. Better to use dev_*() variant.

thanks,

Takashi