drm/stm: do not reply on drmP.h from drm_gem_cma_helper.h
Subsystems (4)
PATCH v2 12/14 drm/stm: do not reply on drmP.h from drm_gem_cma_helper.h
drmP.h was the only header file in the past and a lot of files rely on that drmP.h defines everything. The goal is to one day to delete drmP.h and
as a step towards this it will no longer be included in the headers files in include/drm/
To prepare stm/ for this add dependencies that othwewise was pulled in by drmP.h from drm_gem_cma_helper.h
Sort the include list when we anyway modify it.
--- drivers/gpu/drm/stm/drv.c | 6 +++++- drivers/gpu/drm/stm/ltdc.c | 9 ++++++++- 2 files changed, 13 insertions(+), 2 deletions(-)
drivers/gpu/drm/stm/drv.c +5 -1
@@ -9,15 +9,19 @@*/ #include <linux/component.h> +#include <linux/dma-mapping.h> +#include <linux/module.h> #include <linux/of_platform.h> #include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_crtc_helper.h> #include <drm/drm_fb_helper.h> -#include <drm/drm_fb_cma_helper.h> +#include <drm/drm_drv.h> #include <drm/drm_gem_cma_helper.h> #include <drm/drm_gem_framebuffer_helper.h> +#include <drm/drm_fb_cma_helper.h> +#include <drm/drm_vblank.h> #include "ltdc.h"
drivers/gpu/drm/stm/ltdc.c +8 -1
@@ -10,17 +10,24 @@#include <linux/clk.h> #include <linux/component.h> +#include <linux/delay.h> +#include <linux/interrupt.h> +#include <linux/module.h> #include <linux/of_address.h> #include <linux/of_graph.h> +#include <linux/platform_device.h> #include <linux/reset.h> #include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> +#include <drm/drm_bridge.h> #include <drm/drm_crtc_helper.h> +#include <drm/drm_device.h> #include <drm/drm_fb_cma_helper.h> +#include <drm/drm_fourcc.h> #include <drm/drm_gem_cma_helper.h> #include <drm/drm_of.h> -#include <drm/drm_bridge.h> +#include <drm/drm_vblank.h> #include <drm/drm_plane_helper.h> #include <video/videomode.h>
Signature · 6 lines
2.12.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Den 30.12.2018 18.48, skrev Sam Ravnborg:
Quoted 11 lines
drmP.hwas the only header file in the past and a lot of files rely on thatdrmP.hdefines everything. The goal is to one day to deletedrmP.hand
as a step towards this it will no longer be included in the headers files ininclude/drm/To prepare stm/ for this add dependencies that othwewise was pulled in by
drmP.hfromdrm_gem_cma_helper.hSort the include list when we anyway modify it.
Quoted 8 lines
Signed-off-by Sam Ravnborg <[email protected]>Cc Yannick Fertre <[email protected]>Cc Philippe Cornu <[email protected]>Cc Benjamin Gaignard <[email protected]>Cc Vincent Abriou <[email protected]>Cc David Airlie <[email protected]>Cc Daniel Vetter <[email protected]>---
Benjamin Gaignard
Acked-byQuoted 24 lines · Noralf Trønnes
Den 30.12.2018 18.48, skrev Sam Ravnborg:
Quoted 11 lines
drmP.hwas the only header file in the past and a lot of files rely on thatdrmP.hdefines everything. The goal is to one day to deletedrmP.hand
as a step towards this it will no longer be included in the headers files ininclude/drm/To prepare stm/ for this add dependencies that othwewise was pulled in by
drmP.hfromdrm_gem_cma_helper.hSort the include list when we anyway modify it.
Quoted 8 lines
Signed-off-by Sam Ravnborg <[email protected]>Cc Yannick Fertre <[email protected]>Cc Philippe Cornu <[email protected]>Cc Benjamin Gaignard <[email protected]>Cc Vincent Abriou <[email protected]>Cc David Airlie <[email protected]>Cc Daniel Vetter <[email protected]>---
Quoted 1 line
Acked-by Noralf Trønnes <[email protected]>
Quoted 4 lines
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel