drm/tinydrm: do not reply on drmP.h from drm_gem_cma_helper.h
Subsystems (2)
PATCH v2 13/14 drm/tinydrm: do not reply on drmP.h from drm_gem_cma_helper.h
drmP.h was the only header file in the past and a lot of files rely on that drmP.h defines everything. The goal is to one day to delete drmP.h and
as a step towards this it will no longer be included in the headers files in include/drm/
To prepare tinydrm/ for this add dependencies that othwewise was pulled in by drmP.h from drm_gem_cma_helper.h
To avoid that tinydrm.h became "include everything", push include files to the individual drivers.
--- drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 3 +++ drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 3 +++ drivers/gpu/drm/tinydrm/hx8357d.c | 1 + drivers/gpu/drm/tinydrm/ili9225.c | 2 ++ drivers/gpu/drm/tinydrm/ili9341.c | 1 + drivers/gpu/drm/tinydrm/mi0283qt.c | 1 + drivers/gpu/drm/tinydrm/mipi-dbi.c | 3 +++ drivers/gpu/drm/tinydrm/repaper.c | 1 + drivers/gpu/drm/tinydrm/st7586.c | 1 + drivers/gpu/drm/tinydrm/st7735r.c | 1 + 10 files changed, 17 insertions(+)
drivers/gpu/drm/tinydrm/core/tinydrm-core.c +3 -0
@@ -10,11 +10,14 @@#include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_crtc_helper.h> +#include <drm/drm_drv.h> #include <drm/drm_fb_helper.h> #include <drm/drm_gem_framebuffer_helper.h> +#include <drm/drm_print.h> #include <drm/tinydrm/tinydrm.h> #include <linux/device.h> #include <linux/dma-buf.h> +#include <linux/module.h> /** * DOC: overview
drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c +3 -0
@@ -9,8 +9,11 @@#include <drm/drm_atomic_helper.h> #include <drm/drm_crtc_helper.h> +#include <drm/drm_drv.h> #include <drm/drm_gem_framebuffer_helper.h> #include <drm/drm_modes.h> +#include <drm/drm_print.h> +#include <drm/drm_vblank.h> #include <drm/tinydrm/tinydrm.h> struct tinydrm_connector {
drivers/gpu/drm/tinydrm/hx8357d.c +1 -0
@@ -16,6 +16,7 @@#include <linux/property.h> #include <linux/spi/spi.h> +#include <drm/drm_drv.h> #include <drm/drm_gem_cma_helper.h> #include <drm/drm_gem_framebuffer_helper.h> #include <drm/drm_modeset_helper.h>
drivers/gpu/drm/tinydrm/ili9225.c +2 -0
@@ -20,7 +20,9 @@#include <linux/spi/spi.h> #include <video/mipi_display.h> +#include <drm/drm_drv.h> #include <drm/drm_fb_cma_helper.h> +#include <drm/drm_fourcc.h> #include <drm/drm_gem_cma_helper.h> #include <drm/drm_gem_framebuffer_helper.h> #include <drm/tinydrm/mipi-dbi.h>
drivers/gpu/drm/tinydrm/ili9341.c +1 -0
@@ -15,6 +15,7 @@#include <linux/property.h> #include <linux/spi/spi.h> +#include <drm/drm_drv.h> #include <drm/drm_gem_cma_helper.h> #include <drm/drm_gem_framebuffer_helper.h> #include <drm/drm_modeset_helper.h>
drivers/gpu/drm/tinydrm/mi0283qt.c +1 -0
@@ -17,6 +17,7 @@#include <linux/regulator/consumer.h> #include <linux/spi/spi.h> +#include <drm/drm_drv.h> #include <drm/drm_gem_cma_helper.h> #include <drm/drm_gem_framebuffer_helper.h> #include <drm/drm_modeset_helper.h>
drivers/gpu/drm/tinydrm/mipi-dbi.c +3 -0
@@ -10,14 +10,17 @@*/ #include <linux/debugfs.h> +#include <linux/delay.h> #include <linux/dma-buf.h> #include <linux/gpio/consumer.h> #include <linux/module.h> #include <linux/regulator/consumer.h> #include <linux/spi/spi.h> +#include <drm/drm_drv.h> #include <drm/drm_fb_cma_helper.h> #include <drm/drm_gem_cma_helper.h> +#include <drm/drm_fourcc.h> #include <drm/drm_gem_framebuffer_helper.h> #include <drm/tinydrm/mipi-dbi.h> #include <drm/tinydrm/tinydrm-helpers.h>
drivers/gpu/drm/tinydrm/repaper.c +1 -0
@@ -26,6 +26,7 @@#include <linux/spi/spi.h> #include <linux/thermal.h> +#include <drm/drm_drv.h> #include <drm/drm_fb_cma_helper.h> #include <drm/drm_gem_cma_helper.h> #include <drm/drm_gem_framebuffer_helper.h>
drivers/gpu/drm/tinydrm/st7586.c +1 -0
@@ -17,6 +17,7 @@#include <linux/spi/spi.h> #include <video/mipi_display.h> +#include <drm/drm_drv.h> #include <drm/drm_fb_cma_helper.h> #include <drm/drm_gem_cma_helper.h> #include <drm/drm_gem_framebuffer_helper.h>
drivers/gpu/drm/tinydrm/st7735r.c +1 -0
@@ -14,6 +14,7 @@#include <linux/spi/spi.h> #include <video/mipi_display.h> +#include <drm/drm_drv.h> #include <drm/drm_gem_cma_helper.h> #include <drm/drm_gem_framebuffer_helper.h> #include <drm/tinydrm/mipi-dbi.h>
Signature · 1 line
2.12.0
Quoted 12 lines · Sam Ravnborg
drmP.hwas the only header file in the past and a lot of files rely on thatdrmP.hdefines everything. The goal is to one day to deletedrmP.hand
as a step towards this it will no longer be included in the headers files ininclude/drm/To prepare tinydrm/ for this add dependencies that othwewise was pulled in by
drmP.hfromdrm_gem_cma_helper.hTo avoid that
tinydrm.hbecame "include everything", push include files to the individual drivers.
Quoted 7 lines
Signed-off-by Sam Ravnborg <[email protected]>Cc "Noralf Trønnes" <[email protected]>Cc David Airlie <[email protected]>Cc Eric Anholt <[email protected]>Cc David Lechner <[email protected]>Cc Daniel Vetter <[email protected]>---
Den 30.12.2018 18.48, skrev Sam Ravnborg:
Quoted 12 lines
drmP.hwas the only header file in the past and a lot of files rely on thatdrmP.hdefines everything. The goal is to one day to deletedrmP.hand
as a step towards this it will no longer be included in the headers files ininclude/drm/To prepare tinydrm/ for this add dependencies that othwewise was pulled in by
drmP.hfromdrm_gem_cma_helper.hTo avoid that
tinydrm.hbecame "include everything", push include files to the individual drivers.
Quoted 7 lines
Signed-off-by Sam Ravnborg <[email protected]>Cc "Noralf Trønnes" <[email protected]>Cc David Airlie <[email protected]>Cc Eric Anholt <[email protected]>Cc David Lechner <[email protected]>Cc Daniel Vetter <[email protected]>---
Thanks for doing this dep fix series:
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel