Skip to contentSkip to conversation

drm: make drm_file.h self contained

PATCH Superseded Sam Ravnborg 2 participants 2 messages Dec 30, 2018 – Jan 7, 2019

Subsystems (2)

v2 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 5/14 drm: make drm_file.h self contained

drm_file.h embed struct idr, so this file need to know the full type definition.

With this change users of drm_file.h are no longer forced to include idr.h - a file they usually get from drmP.h

This makes it simpler to remove drmP.h includes

Cc Jani Nikula <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Sean Paul <[email protected]>
Cc David Airlie <[email protected]>
---
 include/drm/drm_file.h | 1 +
 1 file changed, 1 insertion(+)
include/drm/drm_file.h +1 -0
index 84ac79219e4c..bbdb74c3d7ff 100644
@@ -30,6 +30,7 @@
 #ifndef _DRM_FILE_H_
 #define _DRM_FILE_H_
 
+#include <linux/idr.h>
 #include <linux/types.h>
 #include <linux/completion.h>
 
Signature · 6 lines
2.12.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Acked-by on v2 5/14
#1 lore raw

Den 30.12.2018 18.48, skrev Sam Ravnborg:

Quoted 8 lines

drm_file.h embed struct idr, so this file need to know the full type definition.

With this change users of drm_file.h are no longer forced to include idr.h - a file they usually get from drmP.h

This makes it simpler to remove drmP.h includes

Quoted 8 lines
Cc Jani Nikula <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Sean Paul <[email protected]>
Cc David Airlie <[email protected]>

---

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel