Skip to contentSkip to conversation

fpga: altera_freeze_bridge: remove restriction to socfpga

PATCH Superseded Alan Tull 2 participants 3 messages Jan 10, 2019 – Jan 14, 2019 FPGA manager framework

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Alan Tull

author
#0 lore raw

PATCH 1/1 fpga: altera_freeze_bridge: remove restriction to socfpga

The Altera Freeze Bridge should not be restricted to ARCH_SOCFPGA since it can be used on other platforms such as Stratix10.

---
 drivers/fpga/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/fpga/Kconfig +1 -1
index 0bb7b5c..0bdbd3d 100644
@@ -104,7 +104,7 @@ config SOCFPGA_FPGA_BRIDGE
 
 config ALTERA_FREEZE_BRIDGE
 	tristate "Altera FPGA Freeze Bridge"
-	depends on ARCH_SOCFPGA && FPGA_BRIDGE
+	depends on FPGA_BRIDGE
 	help
 	  Say Y to enable drivers for Altera FPGA Freeze bridges.  A
 	  freeze bridge is a bridge that exists in the FPGA fabric to
Signature · 1 line
2.7.4
#1 lore raw

Hi Alan,

Quoted 14 lines · Alan Tull

The Altera Freeze Bridge should not be restricted to ARCH_SOCFPGA since it can be used on other platforms such as Stratix10.

---
 drivers/fpga/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/fpga/Kconfig +0 -0
index 0bb7b5c..0bdbd3d 100644

drivers/fpga/Kconfig config SOCFPGA_FPGA_BRIDGE · line 107

Quoted 5 lines
drivers/fpga/Kconfig +1 -1
@@ -104,7 +104,7 @@ config SOCFPGA_FPGA_BRIDGE
 
 config ALTERA_FREEZE_BRIDGE
        tristate "Altera FPGA Freeze Bridge"
-       depends on ARCH_SOCFPGA && FPGA_BRIDGE
+       depends on FPGA_BRIDGE

Doesn't that need a dependency on HAS_IOMEM at least, then?

Quoted 6 lines
drivers/fpga/Kconfig +0 -1
        help
          Say Y to enable drivers for Altera FPGA Freeze bridges.  A
          freeze bridge is a bridge that exists in the FPGA fabric to
--

2.7.4

Thanks,
Moritz

author
#2 lore raw

On Fri, Jan 11, 2019 at 12:42 PM Moritz Fischer
<[email protected]> wrote:

Hi Moritz,

Quoted 19 lines

Hi Alan,

Quoted 15 lines · Alan Tull

The Altera Freeze Bridge should not be restricted to ARCH_SOCFPGA since it can be used on other platforms such as Stratix10.

---
 drivers/fpga/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/fpga/Kconfig +0 -0
index 0bb7b5c..0bdbd3d 100644
@@ -104,7 +104,7 @@ config SOCFPGA_FPGA_BRIDGE
 
Quoted 6 lines

drivers/fpga/Kconfig config SOCFPGA_FPGA_BRIDGE · line 107

Quoted 4 lines
drivers/fpga/Kconfig +1 -1
 config ALTERA_FREEZE_BRIDGE
        tristate "Altera FPGA Freeze Bridge"
-       depends on ARCH_SOCFPGA && FPGA_BRIDGE
+       depends on FPGA_BRIDGE

Doesn't that need a dependency on HAS_IOMEM at least, then?

Right you are! Thanks!

Alan

Quoted 9 lines
Quoted 6 lines
drivers/fpga/Kconfig +0 -1
        help
          Say Y to enable drivers for Altera FPGA Freeze bridges.  A
          freeze bridge is a bridge that exists in the FPGA fabric to
--

2.7.4

Thanks,
Moritz