Skip to contentSkip to conversation

fpga: altera_freeze_bridge: remove restriction to socfpga

PATCH Superseded Alan Tull 2 participants 3 messages Jan 14, 2019 – Jan 15, 2019 FPGA manager framework

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Alan Tull

author
#0 lore raw

PATCH v2 1/1 fpga: altera_freeze_bridge: remove restriction to socfpga

The Altera Freeze Bridge should not be restricted to ARCH_SOCFPGA since it can be used on other platforms such as Stratix10.

---
 drivers/fpga/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/fpga/Kconfig +2 -1
index 0bb7b5c..da5786a 100644
@@ -104,7 +104,8 @@ config SOCFPGA_FPGA_BRIDGE
 
 config ALTERA_FREEZE_BRIDGE
 	tristate "Altera FPGA Freeze Bridge"
-	depends on ARCH_SOCFPGA && FPGA_BRIDGE
+	depends on FPGA_BRIDGE
+	depends on HAS_IOMEM
 	help
 	  Say Y to enable drivers for Altera FPGA Freeze bridges.  A
 	  freeze bridge is a bridge that exists in the FPGA fabric to
Signature · 1 line
2.7.4
#1 lore raw

minor nit

Quoted 13 lines · Alan Tull

The Altera Freeze Bridge should not be restricted to ARCH_SOCFPGA since it can be used on other platforms such as Stratix10.

---
 drivers/fpga/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/fpga/Kconfig +0 -0
index 0bb7b5c..da5786a 100644

drivers/fpga/Kconfig config SOCFPGA_FPGA_BRIDGE · line 108

Quoted 6 lines
drivers/fpga/Kconfig +2 -1
@@ -104,7 +104,8 @@ config SOCFPGA_FPGA_BRIDGE
 
 config ALTERA_FREEZE_BRIDGE
 	tristate "Altera FPGA Freeze Bridge"
-	depends on ARCH_SOCFPGA && FPGA_BRIDGE
+	depends on FPGA_BRIDGE
+	depends on HAS_IOMEM

can just be:

depends on FPGA_BRIDGE && HAS_IOMEM

Dinh

author
#2 lore raw
Quoted 26 lines · Dinh Nguyen

minor nit

Quoted 13 lines · Alan Tull

The Altera Freeze Bridge should not be restricted to ARCH_SOCFPGA since it can be used on other platforms such as Stratix10.

---
 drivers/fpga/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/fpga/Kconfig +0 -0
index 0bb7b5c..da5786a 100644

drivers/fpga/Kconfig config SOCFPGA_FPGA_BRIDGE · line 108

Quoted 6 lines
drivers/fpga/Kconfig +2 -1
@@ -104,7 +104,8 @@ config SOCFPGA_FPGA_BRIDGE
 
 config ALTERA_FREEZE_BRIDGE
      tristate "Altera FPGA Freeze Bridge"
-     depends on ARCH_SOCFPGA && FPGA_BRIDGE
+     depends on FPGA_BRIDGE
+     depends on HAS_IOMEM

can just be:

Quoted 1 line

depends on FPGA_BRIDGE && HAS_IOMEM

I agree.

Quoted 2 lines

Dinh