hw/i386/pc.c: remove unused function pc_acpi_init()
PATCH v2 1/3 hw/i386/pc.c: remove unused function pc_acpi_init()
Function pc_acpi_init() is now used in no place.
Remove the definition and declaration.
--- hw/i386/pc.c | 27 --------------------------- include/hw/i386/pc.h | 1 - 2 files changed, 28 deletions(-)
hw/i386/pc.c +0 -27
@@ -1280,33 +1280,6 @@ void pc_pci_as_mapping_init(Object *owner, MemoryRegion *system_memory, pci_address_space, -1); } -void pc_acpi_init (const char *default_dsdt) -{ -char *filename; - -if (acpi_tables !=NULL ) { -/* manually set via -acpitable, leave it alone */ -return ; - } - - filename =qemu_find_file (QEMU_FILE_TYPE_BIOS , default_dsdt); -if (filename ==NULL ) { -warn_report ("failed to find %s" , default_dsdt); - }else { -QemuOpts *opts =qemu_opts_create (qemu_find_opts ("acpi" ),NULL ,0 , - &error_abort); -Error *err =NULL ; - -qemu_opt_set (opts,"file" , filename, &error_abort); - -acpi_table_add_builtin (opts, &err); -if (err) { -warn_reportf_err (err,"failed to load %s: " , filename); - } -g_free (filename); - } -} -void xen_load_linux (PCMachineState *pcms) {int i;
include/hw/i386/pc.h +0 -1
@@ -187,7 +187,6 @@ void pc_acpi_smi_interrupt(void *opaque, int irq, int level);void pc_cpus_init (PCMachineState *pcms);void pc_hot_add_cpu (const int64_t id,Error **errp); -void pc_acpi_init (const char *default_dsdt);void pc_guest_info_init (PCMachineState *pcms);
Signature · 1 line
2.19.1
PATCH v2 2/3 hw/acpi: remove unused function acpi_table_add_builtin()
Function acpi_table_add_builtin() is now used in no place.
Remove the definition and declaration.
--- hw/acpi/core.c | 6 ------ include/hw/acpi/acpi.h | 1 - 2 files changed, 7 deletions(-)
hw/acpi/core.c +0 -6
@@ -305,12 +305,6 @@ out:static bool acpi_table_builtin = false; -void acpi_table_add_builtin (const QemuOpts *opts,Error **errp) -{ - acpi_table_builtin = true; -acpi_table_add (opts, errp); -} -unsigned acpi_table_len (void *current) {struct acpi_table_header *hdr = current -sizeof (hdr->_length);
include/hw/acpi/acpi.h +0 -1
@@ -190,7 +190,6 @@ uint8_t *acpi_table_first(void);uint8_t *acpi_table_next (uint8_t *current);unsigned acpi_table_len (void *current);void acpi_table_add (const QemuOpts *opts,Error **errp); -void acpi_table_add_builtin (const QemuOpts *opts,Error **errp);typedef struct AcpiSlicOem AcpiSlicOem ;struct AcpiSlicOem {
Signature · 1 line
2.19.1
PATCH v2 3/3 hw/acpi: remove unnecessary variable acpi_table_builtin
In reply to Wei Yangacpi_table_builtin is now always false, it is not necessary to check it again.
This patch just removes it.
--- hw/acpi/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
hw/acpi/core.c +1 -3
@@ -303,8 +303,6 @@ out:error_propagate (errp, err); } -static bool acpi_table_builtin = false; -unsigned acpi_table_len (void *current) {struct acpi_table_header *hdr = current -sizeof (hdr->_length);
@@ -320,7 +318,7 @@ void *acpi_table_hdr(void *h)uint8_t *acpi_table_first (void ) { -if (acpi_table_builtin || !acpi_tables) { +if (!acpi_tables) {return NULL ; }return acpi_table_hdr (acpi_tables +ACPI_TABLE_PFX_SIZE );
Signature · 1 line
2.19.1
Quoted 1 line · On Fri, 25 Jan 2019 14:01:55 +0800 Wei Yang <[email protected]>…
Function
pc_acpi_init()is now used in no place.
s/is now used in no place./in not used anymore,/
fixup the same phrase in other patches.
otherwise series looks good, so fix commit messages and resubmit series.
Also when sending multi-patch series, pls use cover letter (see help for git format-patch --cover-letter)
Quoted 58 lines
Remove the definition and declaration.
Signed-off-by Wei Yang <[email protected]>--- hw/i386/pc.c | 27 --------------------------- include/hw/i386/pc.h | 1 - 2 files changed, 28 deletions(-)hw/i386/pc.c +0
-27@@ -1280,33 +1280,6 @@ void pc_pci_as_mapping_init(Object *owner, MemoryRegion *system_memory, pci_address_space, -1); } -void pc_acpi_init (const char *default_dsdt) -{ -char *filename; - -if (acpi_tables !=NULL ) { -/* manually set via -acpitable, leave it alone */ -return ; - } - - filename =qemu_find_file (QEMU_FILE_TYPE_BIOS , default_dsdt); -if (filename ==NULL ) { -warn_report ("failed to find %s" , default_dsdt); - }else { -QemuOpts *opts =qemu_opts_create (qemu_find_opts ("acpi" ),NULL ,0 , - &error_abort); -Error *err =NULL ; - -qemu_opt_set (opts,"file" , filename, &error_abort); - -acpi_table_add_builtin (opts, &err); -if (err) { -warn_reportf_err (err,"failed to load %s: " , filename); - } -g_free (filename); - } -} -void xen_load_linux (PCMachineState *pcms) {int i;include/hw/i386/pc.h +0
-1@@ -187,7 +187,6 @@ void pc_acpi_smi_interrupt(void *opaque, int irq, int level);void pc_cpus_init (PCMachineState *pcms);void pc_hot_add_cpu (const int64_t id,Error **errp); -void pc_acpi_init (const char *default_dsdt);void pc_guest_info_init (PCMachineState *pcms);
Quoted 4 lines · Igor Mammedov
Quoted 1 line · On Fri, 25 Jan 2019 14:01:55 +0800 Wei Yang <[email protected]>…
Function
pc_acpi_init()is now used in no place.
Quoted 8 lines
s/is now used in no place./in not used anymore,/
fixup the same phrase in other patches.
otherwise series looks good, so fix commit messages and resubmit series.
Also when sending multi-patch series, pls use cover letter (see help for git format-patch --cover-letter)
Thanks :-)
Will change and re-submit.
Quoted 60 lines
Quoted 60 lines
Remove the definition and declaration.
Signed-off-by Wei Yang <[email protected]>--- hw/i386/pc.c | 27 --------------------------- include/hw/i386/pc.h | 1 - 2 files changed, 28 deletions(-)hw/i386/pc.c +0
-27@@ -1280,33 +1280,6 @@ void pc_pci_as_mapping_init(Object *owner, MemoryRegion *system_memory, pci_address_space, -1); } -void pc_acpi_init (const char *default_dsdt) -{ -char *filename; - -if (acpi_tables !=NULL ) { -/* manually set via -acpitable, leave it alone */ -return ; - } - - filename =qemu_find_file (QEMU_FILE_TYPE_BIOS , default_dsdt); -if (filename ==NULL ) { -warn_report ("failed to find %s" , default_dsdt); - }else { -QemuOpts *opts =qemu_opts_create (qemu_find_opts ("acpi" ),NULL ,0 , - &error_abort); -Error *err =NULL ; - -qemu_opt_set (opts,"file" , filename, &error_abort); - -acpi_table_add_builtin (opts, &err); -if (err) { -warn_reportf_err (err,"failed to load %s: " , filename); - } -g_free (filename); - } -} -void xen_load_linux (PCMachineState *pcms) {int i;include/hw/i386/pc.h +0
-1@@ -187,7 +187,6 @@ void pc_acpi_smi_interrupt(void *opaque, int irq, int level);void pc_cpus_init (PCMachineState *pcms);void pc_hot_add_cpu (const int64_t id,Error **errp); -void pc_acpi_init (const char *default_dsdt);void pc_guest_info_init (PCMachineState *pcms);
Signature · 2 lines
Wei Yang Help you, Help me
PATCH v2 2/3 hw/acpi: remove unused function acpi_table_add_builtin()
In reply to Wei YangFunction acpi_table_add_builtin() is not used anymore.
Remove the definition and declaration.
--- hw/acpi/core.c | 6 ------ include/hw/acpi/acpi.h | 1 - 2 files changed, 7 deletions(-)
hw/acpi/core.c +0 -6
@@ -305,12 +305,6 @@ out:static bool acpi_table_builtin = false; -void acpi_table_add_builtin (const QemuOpts *opts,Error **errp) -{ - acpi_table_builtin = true; -acpi_table_add (opts, errp); -} -unsigned acpi_table_len (void *current) {struct acpi_table_header *hdr = current -sizeof (hdr->_length);
include/hw/acpi/acpi.h +0 -1
@@ -190,7 +190,6 @@ uint8_t *acpi_table_first(void);uint8_t *acpi_table_next (uint8_t *current);unsigned acpi_table_len (void *current);void acpi_table_add (const QemuOpts *opts,Error **errp); -void acpi_table_add_builtin (const QemuOpts *opts,Error **errp);typedef struct AcpiSlicOem AcpiSlicOem ;struct AcpiSlicOem {
Signature · 1 line
2.19.1
PATCH v2 3/3 hw/acpi: remove unnecessary variable acpi_table_builtin
In reply to Wei Yangacpi_table_builtin is now always false, it is not necessary to check it again.
This patch just removes it.
--- hw/acpi/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
hw/acpi/core.c +1 -3
@@ -303,8 +303,6 @@ out:error_propagate (errp, err); } -static bool acpi_table_builtin = false; -unsigned acpi_table_len (void *current) {struct acpi_table_header *hdr = current -sizeof (hdr->_length);
@@ -320,7 +318,7 @@ void *acpi_table_hdr(void *h)uint8_t *acpi_table_first (void ) { -if (acpi_table_builtin || !acpi_tables) { +if (!acpi_tables) {return NULL ; }return acpi_table_hdr (acpi_tables +ACPI_TABLE_PFX_SIZE );
Signature · 1 line
2.19.1
PATCH v2 1/3 hw/i386/pc.c: remove unused function pc_acpi_init()
In reply to Wei YangFunction pc_acpi_init() is not used anymore.
Remove the definition and declaration.
--- hw/i386/pc.c | 27 --------------------------- include/hw/i386/pc.h | 1 - 2 files changed, 28 deletions(-)
hw/i386/pc.c +0 -27
@@ -1280,33 +1280,6 @@ void pc_pci_as_mapping_init(Object *owner, MemoryRegion *system_memory, pci_address_space, -1); } -void pc_acpi_init (const char *default_dsdt) -{ -char *filename; - -if (acpi_tables !=NULL ) { -/* manually set via -acpitable, leave it alone */ -return ; - } - - filename =qemu_find_file (QEMU_FILE_TYPE_BIOS , default_dsdt); -if (filename ==NULL ) { -warn_report ("failed to find %s" , default_dsdt); - }else { -QemuOpts *opts =qemu_opts_create (qemu_find_opts ("acpi" ),NULL ,0 , - &error_abort); -Error *err =NULL ; - -qemu_opt_set (opts,"file" , filename, &error_abort); - -acpi_table_add_builtin (opts, &err); -if (err) { -warn_reportf_err (err,"failed to load %s: " , filename); - } -g_free (filename); - } -} -void xen_load_linux (PCMachineState *pcms) {int i;
include/hw/i386/pc.h +0 -1
@@ -187,7 +187,6 @@ void pc_acpi_smi_interrupt(void *opaque, int irq, int level);void pc_cpus_init (PCMachineState *pcms);void pc_hot_add_cpu (const int64_t id,Error **errp); -void pc_acpi_init (const char *default_dsdt);void pc_guest_info_init (PCMachineState *pcms);
Signature · 1 line
2.19.1
v2 cover Trivial cleanup in hw/acpi
In reply to Wei YangThere are several functions/variable which are not used anymore.
This serials just remove those without functional change.
Wei Yang (3):
hw/i386/pc.c: remove unused function pc_acpi_init() hw/acpi: remove unused function acpi_table_add_builtin() hw/acpi: remove unnecessary variable acpi_table_builtin
hw/acpi/core.c | 10 +--------- hw/i386/pc.c | 27 --------------------------- include/hw/acpi/acpi.h | 1 - include/hw/i386/pc.h | 1 - 4 files changed, 1 insertion(+), 38 deletions(-)
Signature · 1 line
2.19.1
Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi
Hi Wei,
Quoted 9 lines · Wei Yang
There are several functions/variable which are not used anymore.
This serials just remove those without functional change.
Wei Yang (3):
hw/i386/pc.c: remove unused functionpc_acpi_init()hw/acpi: remove unused functionacpi_table_add_builtin()hw/acpi: remove unnecessary variableacpi_table_builtin
Quoted 6 lines
hw/acpi/core.c | 10 +--------- hw/i386/pc.c | 27 --------------------------- include/hw/acpi/acpi.h | 1 - include/hw/i386/pc.h | 1 - 4 files changed, 1 insertion(+), 38 deletions(-)
Please do not post iterated series in reply to previous version, but as new thread:
- patches are parsed by scripts
- some email clients can tag a thread as "reviewed, skip" and replies to this thread will be masked.
Regards,
Phil.
Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi
Quoted 19 lines · Philippe Mathieu-Daudé
Hi Wei,
Quoted 9 lines · Wei Yang
There are several functions/variable which are not used anymore.
This serials just remove those without functional change.
Wei Yang (3):
hw/i386/pc.c: remove unused functionpc_acpi_init()hw/acpi: remove unused functionacpi_table_add_builtin()hw/acpi: remove unnecessary variableacpi_table_builtinQuoted 6 lines
hw/acpi/core.c | 10 +--------- hw/i386/pc.c | 27 --------------------------- include/hw/acpi/acpi.h | 1 - include/hw/i386/pc.h | 1 - 4 files changed, 1 insertion(+), 38 deletions(-)
Quoted 6 lines
Please do not post iterated series in reply to previous version, but as new thread:
- patches are parsed by scripts
- some email clients can tag a thread as "reviewed, skip" and replies to this thread will be masked.
Well, do I need to repost it in a new thread?
Quoted 3 lines
Regards,
Phil.
Signature · 2 lines
Wei Yang Help you, Help me
Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi
Quoted 20 lines · Wei Yang
Quoted 19 lines · Philippe Mathieu-Daudé
Hi Wei,
Quoted 15 lines · Wei Yang
There are several functions/variable which are not used anymore.
This serials just remove those without functional change.
Wei Yang (3):
hw/i386/pc.c: remove unused functionpc_acpi_init()hw/acpi: remove unused functionacpi_table_add_builtin()hw/acpi: remove unnecessary variableacpi_table_builtinhw/acpi/core.c | 10 +--------- hw/i386/pc.c | 27 --------------------------- include/hw/acpi/acpi.h | 1 - include/hw/i386/pc.h | 1 - 4 files changed, 1 insertion(+), 38 deletions(-)
Quoted 8 lines
Quoted 6 lines
Please do not post iterated series in reply to previous version, but as new thread:
- patches are parsed by scripts
- some email clients can tag a thread as "reviewed, skip" and replies to this thread will be masked.Well, do I need to repost it in a new thread?
It depends who will take this patchset and his mood :) Let's wait and see.
Quoted 5 lines · Wei Yang
Function
pc_acpi_init()is not used anymore.Remove the definition and declaration.
Signed-off-by Wei Yang <[email protected]>
Quoted 56 lines
--- hw/i386/pc.c | 27 --------------------------- include/hw/i386/pc.h | 1 - 2 files changed, 28 deletions(-)hw/i386/pc.c +0
-27@@ -1280,33 +1280,6 @@ void pc_pci_as_mapping_init(Object *owner, MemoryRegion *system_memory, pci_address_space, -1); } -void pc_acpi_init (const char *default_dsdt) -{ -char *filename; - -if (acpi_tables !=NULL ) { -/* manually set via -acpitable, leave it alone */ -return ; - } - - filename =qemu_find_file (QEMU_FILE_TYPE_BIOS , default_dsdt); -if (filename ==NULL ) { -warn_report ("failed to find %s" , default_dsdt); - }else { -QemuOpts *opts =qemu_opts_create (qemu_find_opts ("acpi" ),NULL ,0 , - &error_abort); -Error *err =NULL ; - -qemu_opt_set (opts,"file" , filename, &error_abort); - -acpi_table_add_builtin (opts, &err); -if (err) { -warn_reportf_err (err,"failed to load %s: " , filename); - } -g_free (filename); - } -} -void xen_load_linux (PCMachineState *pcms) {int i;include/hw/i386/pc.h +0
-1@@ -187,7 +187,6 @@ void pc_acpi_smi_interrupt(void *opaque, int irq, int level);void pc_cpus_init (PCMachineState *pcms);void pc_hot_add_cpu (const int64_t id,Error **errp); -void pc_acpi_init (const char *default_dsdt);void pc_guest_info_init (PCMachineState *pcms);
Re: [Qemu-devel] [PATCH v2 2/3] hw/acpi: remove unused function acpi_table_add_builtin()
In reply to Wei YangQuoted 5 lines · Wei Yang
Function
acpi_table_add_builtin()is not used anymore.Remove the definition and declaration.
Signed-off-by Wei Yang <[email protected]>
Quoted 35 lines
--- hw/acpi/core.c | 6 ------ include/hw/acpi/acpi.h | 1 - 2 files changed, 7 deletions(-)hw/acpi/core.c +0
-6@@ -305,12 +305,6 @@ out:static bool acpi_table_builtin = false; -void acpi_table_add_builtin (const QemuOpts *opts,Error **errp) -{ - acpi_table_builtin = true; -acpi_table_add (opts, errp); -} -unsigned acpi_table_len (void *current) {struct acpi_table_header *hdr = current -sizeof (hdr->_length);include/hw/acpi/acpi.h +0
-1@@ -190,7 +190,6 @@ uint8_t *acpi_table_first(void);uint8_t *acpi_table_next (uint8_t *current);unsigned acpi_table_len (void *current);void acpi_table_add (const QemuOpts *opts,Error **errp); -void acpi_table_add_builtin (const QemuOpts *opts,Error **errp);typedef struct AcpiSlicOem AcpiSlicOem ;struct AcpiSlicOem {
Re: [Qemu-devel] [PATCH v2 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin
In reply to Wei YangQuoted 6 lines · Wei Yang
acpi_table_builtinis now always false, it is not necessary to check it again.This patch just removes it.
Signed-off-by Wei Yang <[email protected]>
Quoted 27 lines
--- hw/acpi/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)hw/acpi/core.c +1
-3@@ -303,8 +303,6 @@ out:error_propagate (errp, err); } -static bool acpi_table_builtin = false; -unsigned acpi_table_len (void *current) {struct acpi_table_header *hdr = current -sizeof (hdr->_length);@@ -320,7 +318,7 @@ void *acpi_table_hdr(void *h)uint8_t *acpi_table_first (void ) { -if (acpi_table_builtin || !acpi_tables) { +if (!acpi_tables) {return NULL ; }return acpi_table_hdr (acpi_tables +ACPI_TABLE_PFX_SIZE );
Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi
In reply to Philippe Mathieu-DaudéQuoted 28 lines · Philippe Mathieu-Daudé
Quoted 27 lines · Wei Yang
Quoted 25 lines · Philippe Mathieu-Daudé
Hi Wei,
Quoted 9 lines · Wei Yang
There are several functions/variable which are not used anymore.
This serials just remove those without functional change.
Wei Yang (3):
hw/i386/pc.c: remove unused functionpc_acpi_init()hw/acpi: remove unused functionacpi_table_add_builtin()hw/acpi: remove unnecessary variableacpi_table_builtinQuoted 6 lines
hw/acpi/core.c | 10 +--------- hw/i386/pc.c | 27 --------------------------- include/hw/acpi/acpi.h | 1 - include/hw/i386/pc.h | 1 - 4 files changed, 1 insertion(+), 38 deletions(-)Please do not post iterated series in reply to previous version, but as new thread:
- patches are parsed by scripts
- some email clients can tag a thread as "reviewed, skip" and replies to this thread will be masked.
Quoted 5 lines
Quoted 1 line
Well, do I need to repost it in a new thread?
It depends who will take this patchset and his mood :) Let's wait and see.
No need to repost if they go through the trivial branch.
Thanks,
Laurent
Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi
Quoted 29 lines · Laurent Vivier
Quoted 28 lines · Philippe Mathieu-Daudé
Quoted 27 lines · Wei Yang
Quoted 25 lines · Philippe Mathieu-Daudé
Hi Wei,
Quoted 9 lines · Wei Yang
There are several functions/variable which are not used anymore.
This serials just remove those without functional change.
Wei Yang (3):
hw/i386/pc.c: remove unused functionpc_acpi_init()hw/acpi: remove unused functionacpi_table_add_builtin()hw/acpi: remove unnecessary variableacpi_table_builtinQuoted 6 lines
hw/acpi/core.c | 10 +--------- hw/i386/pc.c | 27 --------------------------- include/hw/acpi/acpi.h | 1 - include/hw/i386/pc.h | 1 - 4 files changed, 1 insertion(+), 38 deletions(-)Please do not post iterated series in reply to previous version, but as new thread:
- patches are parsed by scripts
- some email clients can tag a thread as "reviewed, skip" and replies to this thread will be masked.
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Well, do I need to repost it in a new thread?
It depends who will take this patchset and his mood :) Let's wait and see.
No need to repost if they go through the trivial branch.
Thanks :-)
Quoted 3 lines
Thanks,
Laurent
Signature · 2 lines
Wei Yang Help you, Help me
Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi
Quoted 32 lines · Wei Yang
Quoted 31 lines · Laurent Vivier
Quoted 30 lines · Philippe Mathieu-Daudé
Quoted 28 lines · Wei Yang
Quoted 19 lines · Philippe Mathieu-Daudé
Hi Wei,
Quoted 9 lines · Wei Yang
There are several functions/variable which are not used anymore.
This serials just remove those without functional change.
Wei Yang (3):
hw/i386/pc.c: remove unused functionpc_acpi_init()hw/acpi: remove unused functionacpi_table_add_builtin()hw/acpi: remove unnecessary variableacpi_table_builtinQuoted 6 lines
hw/acpi/core.c | 10 +--------- hw/i386/pc.c | 27 --------------------------- include/hw/acpi/acpi.h | 1 - include/hw/i386/pc.h | 1 - 4 files changed, 1 insertion(+), 38 deletions(-)Quoted 6 lines
Please do not post iterated series in reply to previous version, but as new thread:
- patches are parsed by scripts
- some email clients can tag a thread as "reviewed, skip" and replies to this thread will be masked.Well, do I need to repost it in a new thread?
Quoted 11 lines
Quoted 5 lines
Quoted 3 lines
It depends who will take this patchset and his mood :) Let's wait and see.
No need to repost if they go through the trivial branch.
Thanks :-)
Quoted 3 lines
Thanks,
Laurent
Pls repost with all acks etc and I'll pick it up.
Quoted 3 lines
Signature · 2 lines
Wei Yang Help you, Help me
Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi
Quoted 39 lines · Michael S. Tsirkin
Quoted 38 lines · Wei Yang
Quoted 36 lines · Laurent Vivier
Quoted 28 lines · Philippe Mathieu-Daudé
Quoted 27 lines · Wei Yang
Quoted 25 lines · Philippe Mathieu-Daudé
Hi Wei,
Quoted 9 lines · Wei Yang
There are several functions/variable which are not used anymore.
This serials just remove those without functional change.
Wei Yang (3):
hw/i386/pc.c: remove unused functionpc_acpi_init()hw/acpi: remove unused functionacpi_table_add_builtin()hw/acpi: remove unnecessary variableacpi_table_builtinQuoted 6 lines
hw/acpi/core.c | 10 +--------- hw/i386/pc.c | 27 --------------------------- include/hw/acpi/acpi.h | 1 - include/hw/i386/pc.h | 1 - 4 files changed, 1 insertion(+), 38 deletions(-)Please do not post iterated series in reply to previous version, but as new thread:
- patches are parsed by scripts
- some email clients can tag a thread as "reviewed, skip" and replies to this thread will be masked.Quoted 5 lines
Quoted 1 line
Well, do I need to repost it in a new thread?
It depends who will take this patchset and his mood :) Let's wait and see.
No need to repost if they go through the trivial branch.
Quoted 8 lines
Quoted 5 lines
Thanks :-)
Quoted 3 lines
Thanks,
LaurentPls repost with all acks etc and I'll pick it up.
Got it.
Quoted 3 lines
Quoted 3 lines
Signature · 2 lines
Wei Yang Help you, Help me
Signature · 2 lines
Wei Yang Help you, Help me