Skip to contentSkip to conversation

USB: serial: option: add Telit ME910 ECM composition

PATCH Superseded Johan Hovold 1 participant 1 message Feb 20, 2019 USB

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 USB: serial: option: add Telit ME910 ECM composition

Quoted 24 lines · Daniele Palmas

Hi Johan,

Il giorno mer 20 feb 2019 alle ore 10:39 Johan Hovold <[email protected]> ha scritto:

Quoted 19 lines · Daniele Palmas

drivers/usb/serial/option.c static const struct usb_device_id option_ids[] = { · line 1152

Quoted 12 lines

This patch adds Telit ME910 family ECM composition 0x1102.

drivers/usb/serial/option.c +2 -0
index aef15497ff31..0cf943281065 100644
@@ -1148,6 +1148,8 @@ static const struct usb_device_id option_ids[] = {
        .driver_info = NCTRL(0) | RSVD(1) | RSVD(3) },
      { USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_ME910_DUAL_MODEM),
        .driver_info = NCTRL(0) | RSVD(3) },
+     { USB_DEVICE(TELIT_VENDOR_ID, 0x1102), /* TELIT ME910 (ECM) */
+       .driver_info = NCTRL(0) | RSVD(3) | RSVD(4) },

I realise this probably just reuses a pattern from the earlier Telit entries, but why not match on the interface class instead of blacklisting interface 3 and 4?

Quoted 4 lines

Yes, it was just for keeping the entry coherent with previous ME910 related ones.

I can send a V2 fixing this.

Please do, thanks. Let's try to keep the explicit blacklisting to a minimum.

Johan