Skip to contentSkip to conversation

spl: spl_nand.c: Add NAND loading message

PATCH New Stefan Roese 2 participants 3 messages Mar 26, 2019 – Apr 24, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 spl: spl_nand.c: Add NAND loading message

This patch adds a short message to the SPL NAND loader, which displays the source and destinations addresses including the size of the loaded image, like this:

U-Boot SPL 2019.04-rc3-00113-g486efd8aaf (Mar 15 2019 - 14:18:02 +0100) Trying to boot from NAND
Loading U-Boot from 0x00040000 (size 0x000a0000) to 0x22900000

I find this message quite helpful - hopefully others do so as well.

Cc Heiko Schocher <[email protected]>
Cc Tom Rini <[email protected]>

---
v2:
- Remove #idef as its not needed. With CONFIG_SPL_SERIAL_SUPPORT disabled, all printf's are removed automatically

 common/spl/spl_nand.c | 4 ++++
 1 file changed, 4 insertions(+)
common/spl/spl_nand.c +4 -0
index 6eb190f1ea..e2bcefb111 100644
@@ -17,6 +17,10 @@ static int spl_nand_load_image(struct spl_image_info *spl_image,
 {
 	nand_init();
 
+	printf("Loading U-Boot from 0x%08x (size 0x%08x) to 0x%08x\n",
+	       CONFIG_SYS_NAND_U_BOOT_OFFS, CONFIG_SYS_NAND_U_BOOT_SIZE,
+	       CONFIG_SYS_NAND_U_BOOT_DST);
+
 	nand_spl_load_image(CONFIG_SYS_NAND_U_BOOT_OFFS,
 			    CONFIG_SYS_NAND_U_BOOT_SIZE,
 			    (void *)CONFIG_SYS_NAND_U_BOOT_DST);
Signature · 1 line
2.21.0
#1 lore raw

PATCH v2 1/1 spl: spl_nand.c: Add NAND loading message

Quoted 8 lines · Stefan Roese

This patch adds a short message to the SPL NAND loader, which displays the source and destinations addresses including the size of the loaded image, like this:

U-Boot SPL 2019.04-rc3-00113-g486efd8aaf (Mar 15 2019 - 14:18:02 +0100) Trying to boot from NAND
Loading U-Boot from 0x00040000 (size 0x000a0000) to 0x22900000

Quoted 5 lines

I find this message quite helpful - hopefully others do so as well.

Cc Heiko Schocher <[email protected]>
Cc Tom Rini <[email protected]>
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190326/ab213e00/attachment.sig>
#2 lore raw

PATCH v2 1/1 spl: spl_nand.c: Add NAND loading message

In reply to Stefan Roese
Quoted 8 lines · Stefan Roese

This patch adds a short message to the SPL NAND loader, which displays the source and destinations addresses including the size of the loaded image, like this:

U-Boot SPL 2019.04-rc3-00113-g486efd8aaf (Mar 15 2019 - 14:18:02 +0100) Trying to boot from NAND
Loading U-Boot from 0x00040000 (size 0x000a0000) to 0x22900000

Quoted 6 lines

I find this message quite helpful - hopefully others do so as well.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190424/c65d6263/attachment.sig>