davinci: omapl138-lcdk: enable CONFIG_SPL_DM
cover davinci: omapl138-lcdk: enable CONFIG_SPL_DM
From: Bartosz Golaszewski <[email protected]>
This series enables the driver model in SPL on omapl138-lcdk. First two patches enable size-reducing options in defconfig. The third patch is just a cleanup of the board file. Last patch enables the driver model and defines the serial device so that we don't have to disable CONFIG_SPL_DM_SERIAL which is enabled by default when selecting CONFIG_SPL_DM.
Bartosz Golaszewski (4):
davinci: omapl138-lcdk: enable SPL_SYS_MALLOC_SIMPLE
davinci: omapl138-lcdk: enable CONFIG_USE_TINY_PRINTF
davinci: omapl138-lcdk: remove unneeded includes
davinci: omapl138-lcdk: enable driver-model in SPL
board/davinci/da8xxevm/omapl138_lcdk.c | 18 ++++++++++++++++-- configs/omapl138_lcdk_defconfig | 7 +++++++ 2 files changed, 23 insertions(+), 2 deletions(-)
Signature · 1 line
2.21.0
PATCH 1/4 davinci: omapl138-lcdk: enable SPL_SYS_MALLOC_SIMPLE
From: Bartosz Golaszewski <[email protected]>
We're working towards enabling the driver model in SPL for da850-lcdk. Enable SPL_SYS_MALLOC_SIMPLE in defconfig to reduce SPL size.
--- configs/omapl138_lcdk_defconfig | 1 + 1 file changed, 1 insertion(+)
configs/omapl138_lcdk_defconfig +1 -0
@@ -19,6 +19,7 @@ CONFIG_VERSION_VARIABLE=y CONFIG_BOARD_EARLY_INIT_F=y CONFIG_SPL_TEXT_BASE=0x80000000 CONFIG_SPL_BOARD_INIT=y +CONFIG_SPL_SYS_MALLOC_SIMPLE=y CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0xb5 CONFIG_SPL_NAND_SUPPORT=y CONFIG_HUSH_PARSER=y
Signature · 1 line
2.21.0
PATCH 2/4 davinci: omapl138-lcdk: enable CONFIG_USE_TINY_PRINTF
In reply to Bartosz GolaszewskiFrom: Bartosz Golaszewski <[email protected]>
We're working towards enabling the driver-model in SPL for da850-lcdk. Enable CONFIG_USE_TINY_PRINTF in defconfig to reduce SPL size.
--- configs/omapl138_lcdk_defconfig | 1 + 1 file changed, 1 insertion(+)
configs/omapl138_lcdk_defconfig +1 -0
@@ -57,3 +57,4 @@ CONFIG_DM_SERIAL=y CONFIG_SYS_NS16550=y CONFIG_SPI=y CONFIG_DAVINCI_SPI=y +CONFIG_USE_TINY_PRINTF=y
Signature · 1 line
2.21.0
PATCH 3/4 davinci: omapl138-lcdk: remove unneeded includes
In reply to Bartosz GolaszewskiFrom: Bartosz Golaszewski <[email protected]>
There's no SPI on da850-lcdk. Remove unnecessary includes.
--- board/davinci/da8xxevm/omapl138_lcdk.c | 2 -- 1 file changed, 2 deletions(-)
board/davinci/da8xxevm/omapl138_lcdk.c +0 -2
@@ -12,8 +12,6 @@#include <i2c.h> #include <net.h> #include <netdev.h> -#include <spi.h> -#include <spi_flash.h> #include <asm/arch/hardware.h> #include <asm/ti-common/davinci_nand.h> #include <asm/io.h>
Signature · 1 line
2.21.0
PATCH 4/4 davinci: omapl138-lcdk: enable driver-model in SPL
In reply to Bartosz GolaszewskiFrom: Bartosz Golaszewski <[email protected]>
Enable CONFIG_SPL_DM and enable the driver model for serial by defining an appropriate device in the board file for da850-lcdk.
--- board/davinci/da8xxevm/omapl138_lcdk.c | 16 ++++++++++++++++ configs/omapl138_lcdk_defconfig | 5 +++++ 2 files changed, 21 insertions(+)
board/davinci/da8xxevm/omapl138_lcdk.c +16 -0
@@ -15,6 +15,8 @@#include <asm/arch/hardware.h> #include <asm/ti-common/davinci_nand.h> #include <asm/io.h> +#include <ns16550.h> +#include <dm/platdata.h> #include <linux/errno.h> #include <asm/mach-types.h> #include <asm/arch/davinci_misc.h>
@@ -369,3 +371,17 @@ int board_mmc_init(bd_t *bis) }#endif #endif + +#ifdef CONFIG_SPL_BUILD +static const struct ns16550_platdata serial_pdata = { + .base =DAVINCI_UART2_BASE , + .reg_shift =2 , + .clock =228000000 , + .fcr =UART_FCR_DEFVAL , +}; + +U_BOOT_DEVICE (omapl138_uart) = { + .name ="ns16550_serial" , + .platdata = &serial_pdata, +}; +#endif
configs/omapl138_lcdk_defconfig +5 -0
@@ -33,10 +33,13 @@ CONFIG_CMD_MTDPARTS=y CONFIG_CMD_DIAG=y CONFIG_CMD_UBI=y CONFIG_OF_CONTROL=y +CONFIG_SPL_OF_CONTROL=y CONFIG_DEFAULT_DEVICE_TREE="da850-lcdk" +CONFIG_SPL_OF_PLATDATA=y CONFIG_ENV_IS_IN_NAND=y CONFIG_NET_RANDOM_ETHADDR=y CONFIG_DM=y +CONFIG_SPL_DM=y CONFIG_DM_I2C=y CONFIG_DM_I2C_COMPAT=y CONFIG_SYS_I2C_DAVINCI=y
@@ -53,8 +56,10 @@ CONFIG_SPI_FLASH_STMICRO=y CONFIG_SPI_FLASH_WINBOND=y CONFIG_MII=y CONFIG_DRIVER_TI_EMAC=y +CONFIG_SPECIFY_CONSOLE_INDEX=y CONFIG_DM_SERIAL=y CONFIG_SYS_NS16550=y CONFIG_SPI=y CONFIG_DAVINCI_SPI=y CONFIG_USE_TINY_PRINTF=y +# CONFIG_SPL_OF_LIBFDT is not set
Signature · 1 line
2.21.0
PATCH 4/4 davinci: omapl138-lcdk: enable driver-model in SPL
Quoted 48 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
Enable
CONFIG_SPL_DMand enable the driver model for serial by defining an appropriate device in the board file for da850-lcdk.Signed-off-by Bartosz Golaszewski <[email protected]>--- board/davinci/da8xxevm/omapl138_lcdk.c | 16 ++++++++++++++++ configs/omapl138_lcdk_defconfig | 5 +++++ 2 files changed, 21 insertions(+)board/davinci/da8xxevm/omapl138_lcdk.c +16
-0@@ -15,6 +15,8 @@#include <asm/arch/hardware.h> #include <asm/ti-common/davinci_nand.h> #include <asm/io.h> +#include <ns16550.h> +#include <dm/platdata.h> #include <linux/errno.h> #include <asm/mach-types.h> #include <asm/arch/davinci_misc.h> @@ -369,3 +371,17 @@ int board_mmc_init(bd_t *bis) }#endif #endif + +#ifdef CONFIG_SPL_BUILD +static const struct ns16550_platdata serial_pdata = { + .base =DAVINCI_UART2_BASE , + .reg_shift =2 , + .clock =228000000 , + .fcr =UART_FCR_DEFVAL , +}; + +U_BOOT_DEVICE (omapl138_uart) = { + .name ="ns16550_serial" , + .platdata = &serial_pdata, +}; +#endif configs/omapl138_lcdk_defconfig +0
-0
configs/omapl138_lcdk_defconfig CONFIG_CMD_MTDPARTS=y · line 36
Quoted 4 lines
configs/omapl138_lcdk_defconfig +1
-0@@ -33,10 +33,13 @@ CONFIG_CMD_MTDPARTS=y CONFIG_CMD_DIAG=y CONFIG_CMD_UBI=y CONFIG_OF_CONTROL=y +CONFIG_SPL_OF_CONTROL=y
If SPL_OF_CONTROL is being added, why do you need to manually add the stuff above for the serial port? Checkout the da850-evm-u-boot.dtsi file. I adds the device tree entries for the serial port to appear in the SPL DTB.
See http://git.denx.de/?p=u-boot.git;a=commit;h=f7c1d53605d9ec528abacda9ba1763c67221fc88
Quoted 23 lines
configs/omapl138_lcdk_defconfig +4
-1CONFIG_DEFAULT_DEVICE_TREE="da850-lcdk" +CONFIG_SPL_OF_PLATDATA=y CONFIG_ENV_IS_IN_NAND=y CONFIG_NET_RANDOM_ETHADDR=y CONFIG_DM=y +CONFIG_SPL_DM=y CONFIG_DM_I2C=y CONFIG_DM_I2C_COMPAT=y CONFIG_SYS_I2C_DAVINCI=y@@ -53,8 +56,10 @@ CONFIG_SPI_FLASH_STMICRO=y CONFIG_SPI_FLASH_WINBOND=y CONFIG_MII=y CONFIG_DRIVER_TI_EMAC=y +CONFIG_SPECIFY_CONSOLE_INDEX=y CONFIG_DM_SERIAL=y CONFIG_SYS_NS16550=y CONFIG_SPI=y CONFIG_DAVINCI_SPI=y CONFIG_USE_TINY_PRINTF=y +# CONFIG_SPL_OF_LIBFDT is not set --2.21.0
PATCH 4/4 davinci: omapl138-lcdk: enable driver-model in SPL
wt., 28 maj 2019 o 17:05 Adam Ford <[email protected]> napisał(a):
Quoted 60 lines · Bartosz Golaszewski
Quoted 48 lines
From: Bartosz Golaszewski <[email protected]>
Enable
CONFIG_SPL_DMand enable the driver model for serial by defining an appropriate device in the board file for da850-lcdk.Signed-off-by Bartosz Golaszewski <[email protected]>--- board/davinci/da8xxevm/omapl138_lcdk.c | 16 ++++++++++++++++ configs/omapl138_lcdk_defconfig | 5 +++++ 2 files changed, 21 insertions(+)board/davinci/da8xxevm/omapl138_lcdk.c +16
-0@@ -15,6 +15,8 @@#include <asm/arch/hardware.h> #include <asm/ti-common/davinci_nand.h> #include <asm/io.h> +#include <ns16550.h> +#include <dm/platdata.h> #include <linux/errno.h> #include <asm/mach-types.h> #include <asm/arch/davinci_misc.h> @@ -369,3 +371,17 @@ int board_mmc_init(bd_t *bis) }#endif #endif + +#ifdef CONFIG_SPL_BUILD +static const struct ns16550_platdata serial_pdata = { + .base =DAVINCI_UART2_BASE , + .reg_shift =2 , + .clock =228000000 , + .fcr =UART_FCR_DEFVAL , +}; + +U_BOOT_DEVICE (omapl138_uart) = { + .name ="ns16550_serial" , + .platdata = &serial_pdata, +}; +#endif configs/omapl138_lcdk_defconfig +0
-0configs/omapl138_lcdk_defconfig CONFIG_CMD_MTDPARTS=y · line 36
Quoted 4 lines
configs/omapl138_lcdk_defconfig +1
-0@@ -33,10 +33,13 @@ CONFIG_CMD_MTDPARTS=y CONFIG_CMD_DIAG=y CONFIG_CMD_UBI=y CONFIG_OF_CONTROL=y +CONFIG_SPL_OF_CONTROL=yIf
SPL_OF_CONTROLis being added, why do you need to manually add the stuff above for the serial port? Checkout theda850-evm-u-boot.dtsifile. I adds the device tree entries for the serial port to appear in the SPL DTB.
Quoted 2 lines
See http://git.denx.de/?p=u-boot.git;a=commit;h=f7c1d53605d9ec528abacda9ba1763c67221fc88
I tried to follow the example from this patch but for some reason adding u-boot,dm-spl; to the soc at 1c00000 node in da850-lcdk-u-boot.dtsi results in the final image being reported as corrupted by the aisimage tool:
[...]
COPY spl/u-boot-spl.dtb CC spl/common/spl/spl.o LD spl/common/spl/built-in.o CC spl/lib/display_options.o LD spl/lib/built-in.o LD spl/u-boot-spl OBJCOPY spl/u-boot-spl-nodtb.bin CAT spl/u-boot-spl-dtb.bin COPY spl/u-boot-spl.bin MKIMAGE spl/u-boot-spl.ais Error: - AIS Image corrupted CAT u-boot.ais CFGCHK u-boot.cfg
The image doen't boot (or at least there's nothing on the console).
I'm not sure what's causing it. Any idea?
Bart
Quoted 24 lines
Quoted 24 lines
configs/omapl138_lcdk_defconfig +4
-1CONFIG_DEFAULT_DEVICE_TREE="da850-lcdk" +CONFIG_SPL_OF_PLATDATA=y CONFIG_ENV_IS_IN_NAND=y CONFIG_NET_RANDOM_ETHADDR=y CONFIG_DM=y +CONFIG_SPL_DM=y CONFIG_DM_I2C=y CONFIG_DM_I2C_COMPAT=y CONFIG_SYS_I2C_DAVINCI=y@@ -53,8 +56,10 @@ CONFIG_SPI_FLASH_STMICRO=y CONFIG_SPI_FLASH_WINBOND=y CONFIG_MII=y CONFIG_DRIVER_TI_EMAC=y +CONFIG_SPECIFY_CONSOLE_INDEX=y CONFIG_DM_SERIAL=y CONFIG_SYS_NS16550=y CONFIG_SPI=y CONFIG_DAVINCI_SPI=y CONFIG_USE_TINY_PRINTF=y +# CONFIG_SPL_OF_LIBFDT is not set --2.21.0
PATCH 4/4 davinci: omapl138-lcdk: enable driver-model in SPL
Quoted 85 lines · Bartosz Golaszewski
wt., 28 maj 2019 o 17:05 Adam Ford <[email protected]> napisał(a):
Quoted 60 lines · Bartosz Golaszewski
Quoted 48 lines
From: Bartosz Golaszewski <[email protected]>
Enable
CONFIG_SPL_DMand enable the driver model for serial by defining an appropriate device in the board file for da850-lcdk.Signed-off-by Bartosz Golaszewski <[email protected]>--- board/davinci/da8xxevm/omapl138_lcdk.c | 16 ++++++++++++++++ configs/omapl138_lcdk_defconfig | 5 +++++ 2 files changed, 21 insertions(+)board/davinci/da8xxevm/omapl138_lcdk.c +16
-0@@ -15,6 +15,8 @@#include <asm/arch/hardware.h> #include <asm/ti-common/davinci_nand.h> #include <asm/io.h> +#include <ns16550.h> +#include <dm/platdata.h> #include <linux/errno.h> #include <asm/mach-types.h> #include <asm/arch/davinci_misc.h> @@ -369,3 +371,17 @@ int board_mmc_init(bd_t *bis) }#endif #endif + +#ifdef CONFIG_SPL_BUILD +static const struct ns16550_platdata serial_pdata = { + .base =DAVINCI_UART2_BASE , + .reg_shift =2 , + .clock =228000000 , + .fcr =UART_FCR_DEFVAL , +}; + +U_BOOT_DEVICE (omapl138_uart) = { + .name ="ns16550_serial" , + .platdata = &serial_pdata, +}; +#endif configs/omapl138_lcdk_defconfig +0
-0configs/omapl138_lcdk_defconfig CONFIG_CMD_MTDPARTS=y · line 36
Quoted 4 lines
configs/omapl138_lcdk_defconfig +1
-0@@ -33,10 +33,13 @@ CONFIG_CMD_MTDPARTS=y CONFIG_CMD_DIAG=y CONFIG_CMD_UBI=y CONFIG_OF_CONTROL=y +CONFIG_SPL_OF_CONTROL=yIf
SPL_OF_CONTROLis being added, why do you need to manually add the stuff above for the serial port? Checkout theda850-evm-u-boot.dtsifile. I adds the device tree entries for the serial port to appear in the SPL DTB.Quoted 2 lines
See http://git.denx.de/?p=u-boot.git;a=commit;h=f7c1d53605d9ec528abacda9ba1763c67221fc88
I tried to follow the example from this patch but for some reason adding u-boot,dm-spl; to the soc at 1c00000 node in
da850-lcdk-u-boot.dtsiresults in the final image being reported as corrupted by the aisimage tool:[...]
COPY spl/u-boot-spl.dtb CC spl/common/spl/spl.o LD spl/common/spl/built-in.o CC spl/lib/display_options.o LD spl/lib/built-in.o LD spl/u-boot-spl OBJCOPY spl/u-boot-spl-nodtb.bin CAT spl/u-boot-spl-dtb.bin COPY spl/u-boot-spl.bin MKIMAGE spl/u-boot-spl.ais Error: - AIS Image corrupted CAT u-boot.ais CFGCHK u-boot.cfg
Quoted 3 lines
The image doen't boot (or at least there's nothing on the console).
I'm not sure what's causing it. Any idea?
I got the same 'AIS Image corrupted' message if the SPL + DTB image is too large.
I enabled SPL_SYS_MALLOC_SIMPLE along with USE_TINY_PRINTF reduced my code size:
(see commit c4fa049a121457ff38b74daac32e18d7afbd4538)
Original:
text data bss dec hex filename
20760 1216 80 22056 5628 spl/u-boot-spl
Tiny Printf
text data bss dec hex filename
17947 1216 80 19243 4b2b spl/u-boot-spl
Malloc Simple + Tiny Printf
text data bss dec hex filename
15187 176 28 15391 3c1f spl/u-boot-spl
I think you can also setup CONFIG_SPL_SYS_THUMB_BUILD to also reduce size. The DA850 evm has that and CONFIG_SYS_THUMB_BUILD set to shrink U-Boot.
I just ran some checks and disabling CONFIG_SPL_SYS_THUMB_BUILD makes the u-boot-spl file overflow the space requirements. With it enabled, it builds
text data bss dec hex filename
24356 1144 24 25524 63b4 spl/u-boot-spl
For U-Boot proper, the difference between CONFIG_SYS_THUMB_BUILD and not using it is
with CONFIG_SYS_THUMB_BUILD
text data bss dec hex filename
324147 19700 58256 402103 622b7 u-boot
(not using it)
text data bss dec hex filename
423167 19700 58248 501115 7a57b u-boot
So the size is about 25% smaller with it enabled.
Unrelated to size, but something you want to consider is to increase your available malloc pool size to accommodate the device tree stuff once you've managed to shrink the code. For da850evm, SPL_SYS_MALLOC_F_LEN = 0x800
adam
Quoted 27 lines
Bart
Quoted 24 lines
Quoted 24 lines
configs/omapl138_lcdk_defconfig +4
-1CONFIG_DEFAULT_DEVICE_TREE="da850-lcdk" +CONFIG_SPL_OF_PLATDATA=y CONFIG_ENV_IS_IN_NAND=y CONFIG_NET_RANDOM_ETHADDR=y CONFIG_DM=y +CONFIG_SPL_DM=y CONFIG_DM_I2C=y CONFIG_DM_I2C_COMPAT=y CONFIG_SYS_I2C_DAVINCI=y@@ -53,8 +56,10 @@ CONFIG_SPI_FLASH_STMICRO=y CONFIG_SPI_FLASH_WINBOND=y CONFIG_MII=y CONFIG_DRIVER_TI_EMAC=y +CONFIG_SPECIFY_CONSOLE_INDEX=y CONFIG_DM_SERIAL=y CONFIG_SYS_NS16550=y CONFIG_SPI=y CONFIG_DAVINCI_SPI=y CONFIG_USE_TINY_PRINTF=y +# CONFIG_SPL_OF_LIBFDT is not set --2.21.0
PATCH 4/4 davinci: omapl138-lcdk: enable driver-model in SPL
śr., 29 maj 2019 o 15:04 Adam Ford <[email protected]> napisał(a):
Quoted 120 lines · Bartosz Golaszewski
Quoted 85 lines
wt., 28 maj 2019 o 17:05 Adam Ford <[email protected]> napisał(a):
Quoted 60 lines · Bartosz Golaszewski
Quoted 48 lines
From: Bartosz Golaszewski <[email protected]>
Enable
CONFIG_SPL_DMand enable the driver model for serial by defining an appropriate device in the board file for da850-lcdk.Signed-off-by Bartosz Golaszewski <[email protected]>--- board/davinci/da8xxevm/omapl138_lcdk.c | 16 ++++++++++++++++ configs/omapl138_lcdk_defconfig | 5 +++++ 2 files changed, 21 insertions(+)board/davinci/da8xxevm/omapl138_lcdk.c +16
-0@@ -15,6 +15,8 @@#include <asm/arch/hardware.h> #include <asm/ti-common/davinci_nand.h> #include <asm/io.h> +#include <ns16550.h> +#include <dm/platdata.h> #include <linux/errno.h> #include <asm/mach-types.h> #include <asm/arch/davinci_misc.h> @@ -369,3 +371,17 @@ int board_mmc_init(bd_t *bis) }#endif #endif + +#ifdef CONFIG_SPL_BUILD +static const struct ns16550_platdata serial_pdata = { + .base =DAVINCI_UART2_BASE , + .reg_shift =2 , + .clock =228000000 , + .fcr =UART_FCR_DEFVAL , +}; + +U_BOOT_DEVICE (omapl138_uart) = { + .name ="ns16550_serial" , + .platdata = &serial_pdata, +}; +#endif configs/omapl138_lcdk_defconfig +0
-0configs/omapl138_lcdk_defconfig CONFIG_CMD_MTDPARTS=y · line 36
Quoted 4 lines
configs/omapl138_lcdk_defconfig +1
-0@@ -33,10 +33,13 @@ CONFIG_CMD_MTDPARTS=y CONFIG_CMD_DIAG=y CONFIG_CMD_UBI=y CONFIG_OF_CONTROL=y +CONFIG_SPL_OF_CONTROL=yIf
SPL_OF_CONTROLis being added, why do you need to manually add the stuff above for the serial port? Checkout theda850-evm-u-boot.dtsifile. I adds the device tree entries for the serial port to appear in the SPL DTB.Quoted 2 lines
See http://git.denx.de/?p=u-boot.git;a=commit;h=f7c1d53605d9ec528abacda9ba1763c67221fc88
I tried to follow the example from this patch but for some reason adding u-boot,dm-spl; to the soc at 1c00000 node in
da850-lcdk-u-boot.dtsiresults in the final image being reported as corrupted by the aisimage tool:[...]
COPY spl/u-boot-spl.dtb CC spl/common/spl/spl.o LD spl/common/spl/built-in.o CC spl/lib/display_options.o LD spl/lib/built-in.o LD spl/u-boot-spl OBJCOPY spl/u-boot-spl-nodtb.bin CAT spl/u-boot-spl-dtb.bin COPY spl/u-boot-spl.bin MKIMAGE spl/u-boot-spl.ais Error: - AIS Image corrupted CAT u-boot.ais CFGCHK u-boot.cfgQuoted 3 lines
The image doen't boot (or at least there's nothing on the console).
I'm not sure what's causing it. Any idea?
I got the same 'AIS Image corrupted' message if the SPL + DTB image is too large.
I enabled
SPL_SYS_MALLOC_SIMPLEalong withUSE_TINY_PRINTFreduced my code size:
(see commitc4fa049a121457ff38b74daac32e18d7afbd4538)
Original:
text data bss dec hex filename
20760 1216 80 22056 5628 spl/u-boot-splTiny Printf
text data bss dec hex filename
17947 1216 80 19243 4b2b spl/u-boot-splMalloc Simple + Tiny Printf
text data bss dec hex filename
15187 176 28 15391 3c1f spl/u-boot-splI think you can also setup
CONFIG_SPL_SYS_THUMB_BUILDto also reduce size. The DA850 evm has that andCONFIG_SYS_THUMB_BUILDset to shrink U-Boot.
I just ran some checks and disablingCONFIG_SPL_SYS_THUMB_BUILDmakes the u-boot-spl file overflow the space requirements. With it enabled, it builds
text data bss dec hex filename
24356 1144 24 25524 63b4 spl/u-boot-splFor U-Boot proper, the difference between
CONFIG_SYS_THUMB_BUILDand not using it is
Quoted 8 lines
with
CONFIG_SYS_THUMB_BUILD
text data bss dec hex filename
324147 19700 58256 402103 622b7 u-boot(not using it)
text data bss dec hex filename
423167 19700 58248 501115 7a57b u-boot
Even with THUMB and other code shrinking options I still get the same error. In fact I even disabled MMC support in SPL just to see if it'll work and I still get the same error despite the size of the resulting SPL image being well within limit:
text data bss dec hex filename
19269 3692 1368 24329 5f09 spl/u-boot-spl
as opposed to
text data bss dec hex filename
27766 4008 1368 33142 8176 spl/u-boot-spl
with MMC in SPL.
Also this error pops up only when extending the soc node of the device tree. If I do this:
/ {
aliases {
i2c0 = &i2c0;
};
foo {
compatible = "foo";
};
bar {
compatible = "bar";
};
};It builds fine. I think the culprit is somewhere else here.
Bart
Quoted 36 lines
So the size is about 25% smaller with it enabled.
Unrelated to size, but something you want to consider is to increase your available malloc pool size to accommodate the device tree stuff once you've managed to shrink the code. For da850evm,
SPL_SYS_MALLOC_F_LEN=0x800adam
Quoted 27 lines
Bart
Quoted 24 lines
Quoted 24 lines
configs/omapl138_lcdk_defconfig +4
-1CONFIG_DEFAULT_DEVICE_TREE="da850-lcdk" +CONFIG_SPL_OF_PLATDATA=y CONFIG_ENV_IS_IN_NAND=y CONFIG_NET_RANDOM_ETHADDR=y CONFIG_DM=y +CONFIG_SPL_DM=y CONFIG_DM_I2C=y CONFIG_DM_I2C_COMPAT=y CONFIG_SYS_I2C_DAVINCI=y@@ -53,8 +56,10 @@ CONFIG_SPI_FLASH_STMICRO=y CONFIG_SPI_FLASH_WINBOND=y CONFIG_MII=y CONFIG_DRIVER_TI_EMAC=y +CONFIG_SPECIFY_CONSOLE_INDEX=y CONFIG_DM_SERIAL=y CONFIG_SYS_NS16550=y CONFIG_SPI=y CONFIG_DAVINCI_SPI=y CONFIG_USE_TINY_PRINTF=y +# CONFIG_SPL_OF_LIBFDT is not set --2.21.0
PATCH 4/4 davinci: omapl138-lcdk: enable driver-model in SPL
Quoted 163 lines · Bartosz Golaszewski
śr., 29 maj 2019 o 15:04 Adam Ford <[email protected]> napisał(a):
Quoted 120 lines · Bartosz Golaszewski
Quoted 85 lines
wt., 28 maj 2019 o 17:05 Adam Ford <[email protected]> napisał(a):
Quoted 60 lines · Bartosz Golaszewski
Quoted 48 lines
From: Bartosz Golaszewski <[email protected]>
Enable
CONFIG_SPL_DMand enable the driver model for serial by defining an appropriate device in the board file for da850-lcdk.Signed-off-by Bartosz Golaszewski <[email protected]>--- board/davinci/da8xxevm/omapl138_lcdk.c | 16 ++++++++++++++++ configs/omapl138_lcdk_defconfig | 5 +++++ 2 files changed, 21 insertions(+)board/davinci/da8xxevm/omapl138_lcdk.c +16
-0@@ -15,6 +15,8 @@#include <asm/arch/hardware.h> #include <asm/ti-common/davinci_nand.h> #include <asm/io.h> +#include <ns16550.h> +#include <dm/platdata.h> #include <linux/errno.h> #include <asm/mach-types.h> #include <asm/arch/davinci_misc.h> @@ -369,3 +371,17 @@ int board_mmc_init(bd_t *bis) }#endif #endif + +#ifdef CONFIG_SPL_BUILD +static const struct ns16550_platdata serial_pdata = { + .base =DAVINCI_UART2_BASE , + .reg_shift =2 , + .clock =228000000 , + .fcr =UART_FCR_DEFVAL , +}; + +U_BOOT_DEVICE (omapl138_uart) = { + .name ="ns16550_serial" , + .platdata = &serial_pdata, +}; +#endif configs/omapl138_lcdk_defconfig +0
-0configs/omapl138_lcdk_defconfig CONFIG_CMD_MTDPARTS=y · line 36
Quoted 4 lines
configs/omapl138_lcdk_defconfig +1
-0@@ -33,10 +33,13 @@ CONFIG_CMD_MTDPARTS=y CONFIG_CMD_DIAG=y CONFIG_CMD_UBI=y CONFIG_OF_CONTROL=y +CONFIG_SPL_OF_CONTROL=yIf
SPL_OF_CONTROLis being added, why do you need to manually add the stuff above for the serial port? Checkout theda850-evm-u-boot.dtsifile. I adds the device tree entries for the serial port to appear in the SPL DTB.Quoted 2 lines
See http://git.denx.de/?p=u-boot.git;a=commit;h=f7c1d53605d9ec528abacda9ba1763c67221fc88
I tried to follow the example from this patch but for some reason adding u-boot,dm-spl; to the soc at 1c00000 node in
da850-lcdk-u-boot.dtsiresults in the final image being reported as corrupted by the aisimage tool:[...]
COPY spl/u-boot-spl.dtb CC spl/common/spl/spl.o LD spl/common/spl/built-in.o CC spl/lib/display_options.o LD spl/lib/built-in.o LD spl/u-boot-spl OBJCOPY spl/u-boot-spl-nodtb.bin CAT spl/u-boot-spl-dtb.bin COPY spl/u-boot-spl.bin MKIMAGE spl/u-boot-spl.ais Error: - AIS Image corrupted CAT u-boot.ais CFGCHK u-boot.cfgQuoted 3 lines
The image doen't boot (or at least there's nothing on the console).
I'm not sure what's causing it. Any idea?
I got the same 'AIS Image corrupted' message if the SPL + DTB image is too large.
I enabled
SPL_SYS_MALLOC_SIMPLEalong withUSE_TINY_PRINTFreduced my code size:
(see commitc4fa049a121457ff38b74daac32e18d7afbd4538)
Original:
text data bss dec hex filename
20760 1216 80 22056 5628 spl/u-boot-splTiny Printf
text data bss dec hex filename
17947 1216 80 19243 4b2b spl/u-boot-splMalloc Simple + Tiny Printf
text data bss dec hex filename
15187 176 28 15391 3c1f spl/u-boot-splI think you can also setup
CONFIG_SPL_SYS_THUMB_BUILDto also reduce size. The DA850 evm has that andCONFIG_SYS_THUMB_BUILDset to shrink U-Boot.
I just ran some checks and disablingCONFIG_SPL_SYS_THUMB_BUILDmakes the u-boot-spl file overflow the space requirements. With it enabled, it builds
text data bss dec hex filename
24356 1144 24 25524 63b4 spl/u-boot-splFor U-Boot proper, the difference between
CONFIG_SYS_THUMB_BUILDand not using it isQuoted 8 lines
with
CONFIG_SYS_THUMB_BUILD
text data bss dec hex filename
324147 19700 58256 402103 622b7 u-boot(not using it)
text data bss dec hex filename
423167 19700 58248 501115 7a57b u-bootEven with THUMB and other code shrinking options I still get the same error. In fact I even disabled MMC support in SPL just to see if it'll work and I still get the same error despite the size of the resulting SPL image being well within limit:
text data bss dec hex filename
19269 3692 1368 24329 5f09 spl/u-boot-splas opposed to
text data bss dec hex filename
27766 4008 1368 33142 8176 spl/u-boot-splwith MMC in SPL.
Also this error pops up only when extending the soc node of the device tree. If I do this:
/ { aliases { i2c0 = &i2c0; }; foo { compatible = "foo"; }; bar { compatible = "bar"; }; };
Quoted 1 line
It builds fine. I think the culprit is somewhere else here.
Maybe keeping the DM chunks of C code as starting point is better. Once it's all merged, it can always be improved later. I threw out the idea as a suggestion, but it's clearly not as simple as I original thought.
adam
Quoted 39 lines
Bart
Quoted 36 lines
So the size is about 25% smaller with it enabled.
Unrelated to size, but something you want to consider is to increase your available malloc pool size to accommodate the device tree stuff once you've managed to shrink the code. For da850evm,
SPL_SYS_MALLOC_F_LEN=0x800adam
Quoted 27 lines
Bart
Quoted 24 lines
Quoted 24 lines
configs/omapl138_lcdk_defconfig +4
-1CONFIG_DEFAULT_DEVICE_TREE="da850-lcdk" +CONFIG_SPL_OF_PLATDATA=y CONFIG_ENV_IS_IN_NAND=y CONFIG_NET_RANDOM_ETHADDR=y CONFIG_DM=y +CONFIG_SPL_DM=y CONFIG_DM_I2C=y CONFIG_DM_I2C_COMPAT=y CONFIG_SYS_I2C_DAVINCI=y@@ -53,8 +56,10 @@ CONFIG_SPI_FLASH_STMICRO=y CONFIG_SPI_FLASH_WINBOND=y CONFIG_MII=y CONFIG_DRIVER_TI_EMAC=y +CONFIG_SPECIFY_CONSOLE_INDEX=y CONFIG_DM_SERIAL=y CONFIG_SYS_NS16550=y CONFIG_SPI=y CONFIG_DAVINCI_SPI=y CONFIG_USE_TINY_PRINTF=y +# CONFIG_SPL_OF_LIBFDT is not set --2.21.0
PATCH 4/4 davinci: omapl138-lcdk: enable driver-model in SPL
śr., 29 maj 2019 o 15:47 Adam Ford <[email protected]> napisał(a):
Quoted 165 lines · Bartosz Golaszewski
Quoted 163 lines
śr., 29 maj 2019 o 15:04 Adam Ford <[email protected]> napisał(a):
Quoted 120 lines · Bartosz Golaszewski
Quoted 85 lines
wt., 28 maj 2019 o 17:05 Adam Ford <[email protected]> napisał(a):
Quoted 60 lines · Bartosz Golaszewski
Quoted 48 lines
From: Bartosz Golaszewski <[email protected]>
Enable
CONFIG_SPL_DMand enable the driver model for serial by defining an appropriate device in the board file for da850-lcdk.Signed-off-by Bartosz Golaszewski <[email protected]>--- board/davinci/da8xxevm/omapl138_lcdk.c | 16 ++++++++++++++++ configs/omapl138_lcdk_defconfig | 5 +++++ 2 files changed, 21 insertions(+)board/davinci/da8xxevm/omapl138_lcdk.c +16
-0@@ -15,6 +15,8 @@#include <asm/arch/hardware.h> #include <asm/ti-common/davinci_nand.h> #include <asm/io.h> +#include <ns16550.h> +#include <dm/platdata.h> #include <linux/errno.h> #include <asm/mach-types.h> #include <asm/arch/davinci_misc.h> @@ -369,3 +371,17 @@ int board_mmc_init(bd_t *bis) }#endif #endif + +#ifdef CONFIG_SPL_BUILD +static const struct ns16550_platdata serial_pdata = { + .base =DAVINCI_UART2_BASE , + .reg_shift =2 , + .clock =228000000 , + .fcr =UART_FCR_DEFVAL , +}; + +U_BOOT_DEVICE (omapl138_uart) = { + .name ="ns16550_serial" , + .platdata = &serial_pdata, +}; +#endif configs/omapl138_lcdk_defconfig +0
-0configs/omapl138_lcdk_defconfig CONFIG_CMD_MTDPARTS=y · line 36
Quoted 4 lines
configs/omapl138_lcdk_defconfig +1
-0@@ -33,10 +33,13 @@ CONFIG_CMD_MTDPARTS=y CONFIG_CMD_DIAG=y CONFIG_CMD_UBI=y CONFIG_OF_CONTROL=y +CONFIG_SPL_OF_CONTROL=yIf
SPL_OF_CONTROLis being added, why do you need to manually add the stuff above for the serial port? Checkout theda850-evm-u-boot.dtsifile. I adds the device tree entries for the serial port to appear in the SPL DTB.Quoted 2 lines
See http://git.denx.de/?p=u-boot.git;a=commit;h=f7c1d53605d9ec528abacda9ba1763c67221fc88
I tried to follow the example from this patch but for some reason adding u-boot,dm-spl; to the soc at 1c00000 node in
da850-lcdk-u-boot.dtsiresults in the final image being reported as corrupted by the aisimage tool:[...]
COPY spl/u-boot-spl.dtb CC spl/common/spl/spl.o LD spl/common/spl/built-in.o CC spl/lib/display_options.o LD spl/lib/built-in.o LD spl/u-boot-spl OBJCOPY spl/u-boot-spl-nodtb.bin CAT spl/u-boot-spl-dtb.bin COPY spl/u-boot-spl.bin MKIMAGE spl/u-boot-spl.ais Error: - AIS Image corrupted CAT u-boot.ais CFGCHK u-boot.cfgQuoted 3 lines
The image doen't boot (or at least there's nothing on the console).
I'm not sure what's causing it. Any idea?
I got the same 'AIS Image corrupted' message if the SPL + DTB image is too large.
I enabled
SPL_SYS_MALLOC_SIMPLEalong withUSE_TINY_PRINTFreduced my code size:
(see commitc4fa049a121457ff38b74daac32e18d7afbd4538)
Original:
text data bss dec hex filename
20760 1216 80 22056 5628 spl/u-boot-splTiny Printf
text data bss dec hex filename
17947 1216 80 19243 4b2b spl/u-boot-splMalloc Simple + Tiny Printf
text data bss dec hex filename
15187 176 28 15391 3c1f spl/u-boot-splI think you can also setup
CONFIG_SPL_SYS_THUMB_BUILDto also reduce size. The DA850 evm has that andCONFIG_SYS_THUMB_BUILDset to shrink U-Boot.
I just ran some checks and disablingCONFIG_SPL_SYS_THUMB_BUILDmakes the u-boot-spl file overflow the space requirements. With it enabled, it builds
text data bss dec hex filename
24356 1144 24 25524 63b4 spl/u-boot-splFor U-Boot proper, the difference between
CONFIG_SYS_THUMB_BUILDand not using it isQuoted 8 lines
with
CONFIG_SYS_THUMB_BUILD
text data bss dec hex filename
324147 19700 58256 402103 622b7 u-boot(not using it)
text data bss dec hex filename
423167 19700 58248 501115 7a57b u-bootEven with THUMB and other code shrinking options I still get the same error. In fact I even disabled MMC support in SPL just to see if it'll work and I still get the same error despite the size of the resulting SPL image being well within limit:
text data bss dec hex filename
19269 3692 1368 24329 5f09 spl/u-boot-splas opposed to
text data bss dec hex filename
27766 4008 1368 33142 8176 spl/u-boot-splwith MMC in SPL.
Also this error pops up only when extending the soc node of the device tree. If I do this:
/ { aliases { i2c0 = &i2c0; }; foo { compatible = "foo"; }; bar { compatible = "bar"; }; };
Quoted 7 lines
Quoted 1 line
It builds fine. I think the culprit is somewhere else here.
Maybe keeping the DM chunks of C code as starting point is better. Once it's all merged, it can always be improved later. I threw out the idea as a suggestion, but it's clearly not as simple as I original thought.
Thanks, I take it as an Ack. I'll try to get back to it once I convert the nand driver to using DM which won't be easy either as the nand node on the device-tree is a sub-node of the aemif device. On linux there's an actual aemif driver that populates its child nodes, but on u-boot I'll have to come up with some workaround.
Bart
Quoted 40 lines
adam
Quoted 39 lines
Bart
Quoted 36 lines
So the size is about 25% smaller with it enabled.
Unrelated to size, but something you want to consider is to increase your available malloc pool size to accommodate the device tree stuff once you've managed to shrink the code. For da850evm,
SPL_SYS_MALLOC_F_LEN=0x800adam
Quoted 27 lines
Bart
Quoted 24 lines
Quoted 24 lines
configs/omapl138_lcdk_defconfig +4
-1CONFIG_DEFAULT_DEVICE_TREE="da850-lcdk" +CONFIG_SPL_OF_PLATDATA=y CONFIG_ENV_IS_IN_NAND=y CONFIG_NET_RANDOM_ETHADDR=y CONFIG_DM=y +CONFIG_SPL_DM=y CONFIG_DM_I2C=y CONFIG_DM_I2C_COMPAT=y CONFIG_SYS_I2C_DAVINCI=y@@ -53,8 +56,10 @@ CONFIG_SPI_FLASH_STMICRO=y CONFIG_SPI_FLASH_WINBOND=y CONFIG_MII=y CONFIG_DRIVER_TI_EMAC=y +CONFIG_SPECIFY_CONSOLE_INDEX=y CONFIG_DM_SERIAL=y CONFIG_SYS_NS16550=y CONFIG_SPI=y CONFIG_DAVINCI_SPI=y CONFIG_USE_TINY_PRINTF=y +# CONFIG_SPL_OF_LIBFDT is not set --2.21.0
cover davinci: omapl138-lcdk: enable CONFIG_SPL_DM
In reply to Bartosz Golaszewskiwt., 28 maj 2019 o 11:58 Bartosz Golaszewski <[email protected]> napisał(a):
Quoted 16 lines
From: Bartosz Golaszewski <[email protected]>
This series enables the driver model in SPL on omapl138-lcdk. First two patches enable size-reducing options in defconfig. The third patch is just a cleanup of the board file. Last patch enables the driver model and defines the serial device so that we don't have to disable
CONFIG_SPL_DM_SERIALwhich is enabled by default when selectingCONFIG_SPL_DM.Bartosz Golaszewski (4):
davinci: omapl138-lcdk: enableSPL_SYS_MALLOC_SIMPLE
davinci: omapl138-lcdk: enableCONFIG_USE_TINY_PRINTF
davinci: omapl138-lcdk: remove unneeded includes
davinci: omapl138-lcdk: enable driver-model in SPL
Quoted 7 lines
board/davinci/da8xxevm/omapl138_lcdk.c | 18 ++++++++++++++++-- configs/omapl138_lcdk_defconfig | 7 +++++++ 2 files changed, 23 insertions(+), 2 deletions(-)--
2.21.0
Gentle ping
Bart
cover davinci: omapl138-lcdk: enable CONFIG_SPL_DM
pon., 24 cze 2019 o 10:18 Bartosz Golaszewski <[email protected]> napisał(a):
Quoted 22 lines
wt., 28 maj 2019 o 11:58 Bartosz Golaszewski <[email protected]> napisał(a):
Quoted 20 lines
From: Bartosz Golaszewski <[email protected]>
This series enables the driver model in SPL on omapl138-lcdk. First two patches enable size-reducing options in defconfig. The third patch is just a cleanup of the board file. Last patch enables the driver model and defines the serial device so that we don't have to disable
CONFIG_SPL_DM_SERIALwhich is enabled by default when selectingCONFIG_SPL_DM.Bartosz Golaszewski (4):
davinci: omapl138-lcdk: enableSPL_SYS_MALLOC_SIMPLE
davinci: omapl138-lcdk: enableCONFIG_USE_TINY_PRINTF
davinci: omapl138-lcdk: remove unneeded includes
davinci: omapl138-lcdk: enable driver-model in SPLboard/davinci/da8xxevm/omapl138_lcdk.c | 18 ++++++++++++++++-- configs/omapl138_lcdk_defconfig | 7 +++++++ 2 files changed, 23 insertions(+), 2 deletions(-)
Quoted 7 lines
Quoted 3 lines
--
2.21.0Gentle ping
Bart
Ping again. Any objections to this series?
Bart
cover davinci: omapl138-lcdk: enable CONFIG_SPL_DM
Quoted 27 lines · Bartosz Golaszewski
pon., 24 cze 2019 o 10:18 Bartosz Golaszewski <[email protected]> napisał(a):
Quoted 26 lines
wt., 28 maj 2019 o 11:58 Bartosz Golaszewski <[email protected]> napisał(a):
Quoted 23 lines
From: Bartosz Golaszewski <[email protected]>
This series enables the driver model in SPL on omapl138-lcdk. First two patches enable size-reducing options in defconfig. The third patch is just a cleanup of the board file. Last patch enables the driver model and defines the serial device so that we don't have to disable
CONFIG_SPL_DM_SERIALwhich is enabled by default when selectingCONFIG_SPL_DM.Bartosz Golaszewski (4):
davinci: omapl138-lcdk: enableSPL_SYS_MALLOC_SIMPLE
davinci: omapl138-lcdk: enableCONFIG_USE_TINY_PRINTF
davinci: omapl138-lcdk: remove unneeded includes
davinci: omapl138-lcdk: enable driver-model in SPLboard/davinci/da8xxevm/omapl138_lcdk.c | 18 ++++++++++++++++-- configs/omapl138_lcdk_defconfig | 7 +++++++ 2 files changed, 23 insertions(+), 2 deletions(-)--
2.21.0
Quoted 5 lines
Quoted 3 lines
Gentle ping
Bart
Ping again. Any objections to this series?
Seems fine, I'll pick it up post release, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190703/2e0ba1f4/attachment.sig>